21831 2008-10-23 11:10:03 -0700 Fix create_hash_table for Perl 5.10 2008-10-23 13:31:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED https://lists.webkit.org/pipermail/webkit-dev/2008-October/005489.html P2 Normal --- 1 ddkilzer ddkilzer oldest_to_newest 96349 0 ddkilzer 2008-10-23 11:10:03 -0700 Square brackets need to be escaped in a print() statement to make Perl 5.10 happy when running create_hash_table. Patch forthcoming. 96351 1 24603 ddkilzer 2008-10-23 11:16:23 -0700 Created attachment 24603 Patch v1 Just fix it. 96353 2 24603 sam 2008-10-23 11:18:16 -0700 Comment on attachment 24603 Patch v1 > commit 9ad34c84b18ab388ac50ad70fe7aac879ad74f6d > Author: David Kilzer <ddkilzer@apple.com> > Date: Thu Oct 23 11:16:14 2008 -0700 > > Bug 21831: Fix create_hash_table for Perl 5.10 > > <https://bugs.webkit.org/show_bug.cgi?id=21831> > > Reviewed by NOBODY (OOPS!). > > * kjs/create_hash_table: Escaped square brackets so that Perl 5.10 > doesn't try to use @nameEntries. > > diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog > index 3fbfd0c..50742fd 100644 > --- a/JavaScriptCore/ChangeLog > +++ b/JavaScriptCore/ChangeLog > @@ -1,3 +1,14 @@ > +2008-10-23 David Kilzer <ddkilzer@apple.com> > + > + Bug 21831: Fix create_hash_table for Perl 5.10 > + > + <https://bugs.webkit.org/show_bug.cgi?id=21831> > + > + Reviewed by NOBODY (OOPS!). > + > + * kjs/create_hash_table: Escaped square brackets so that Perl 5.10 > + doesn't try to use @nameEntries. > + > 2008-10-22 Darin Adler <darin@apple.com> > > Reviewed by Sam Weinig. > diff --git a/JavaScriptCore/kjs/create_hash_table b/JavaScriptCore/kjs/create_hash_table > index d98cc30..829a024 100755 > --- a/JavaScriptCore/kjs/create_hash_table > +++ b/JavaScriptCore/kjs/create_hash_table > @@ -215,7 +215,7 @@ sub output() { > print "\nnamespace JSC {\n"; > } > my $count = scalar @keys + 1; > - print "\nstatic const struct HashTableValue ${nameEntries}[$count] = {\n"; > + print "\nstatic const struct HashTableValue ${nameEntries}\[$count\] = {\n"; > my $i = 0; > foreach my $key (@keys) { > my $firstValue = ""; 96394 3 ddkilzer 2008-10-23 13:31:26 -0700 Committed r37819 http://trac.webkit.org/changeset/37819 24603 2008-10-23 11:16:23 -0700 2008-10-23 11:18:16 -0700 Patch v1 bug-21831-v1.diff text/plain 1567 ddkilzer Y29tbWl0IDlhZDM0Yzg0YjE4YWIzODhhYzUwYWQ3MGZlN2FhYzg3OWFkNzRmNmQKQXV0aG9yOiBE YXZpZCBLaWx6ZXIgPGRka2lsemVyQGFwcGxlLmNvbT4KRGF0ZTogICBUaHUgT2N0IDIzIDExOjE2 OjE0IDIwMDggLTA3MDAKCiAgICAgICAgICAgIEJ1ZyAyMTgzMTogRml4IGNyZWF0ZV9oYXNoX3Rh YmxlIGZvciBQZXJsIDUuMTAKICAgIAogICAgICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxODMxPgogICAgCiAgICAgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgogICAgCiAgICAgICAgICAgICoga2pzL2NyZWF0ZV9oYXNoX3RhYmxlOiBF c2NhcGVkIHNxdWFyZSBicmFja2V0cyBzbyB0aGF0IFBlcmwgNS4xMAogICAgICAgICAgICBkb2Vz bid0IHRyeSB0byB1c2UgQG5hbWVFbnRyaWVzLgoKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAzZmJmZDBjLi41MDc0 MmZkIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTAtMjMgIERhdmlkIEtpbHpl ciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBCdWcgMjE4MzE6IEZpeCBjcmVhdGVf aGFzaF90YWJsZSBmb3IgUGVybCA1LjEwCisKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTgzMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGtqcy9jcmVhdGVfaGFzaF90YWJsZTogRXNjYXBlZCBzcXVh cmUgYnJhY2tldHMgc28gdGhhdCBQZXJsIDUuMTAKKyAgICAgICAgZG9lc24ndCB0cnkgdG8gdXNl IEBuYW1lRW50cmllcy4KKwogMjAwOC0xMC0yMiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KZGlmZiAtLWdpdCBhL0phdmFT Y3JpcHRDb3JlL2tqcy9jcmVhdGVfaGFzaF90YWJsZSBiL0phdmFTY3JpcHRDb3JlL2tqcy9jcmVh dGVfaGFzaF90YWJsZQppbmRleCBkOThjYzMwLi44MjlhMDI0IDEwMDc1NQotLS0gYS9KYXZhU2Ny aXB0Q29yZS9ranMvY3JlYXRlX2hhc2hfdGFibGUKKysrIGIvSmF2YVNjcmlwdENvcmUva2pzL2Ny ZWF0ZV9oYXNoX3RhYmxlCkBAIC0yMTUsNyArMjE1LDcgQEAgc3ViIG91dHB1dCgpIHsKICAgICAg ICAgcHJpbnQgIlxubmFtZXNwYWNlIEpTQyB7XG4iOwogICAgIH0KICAgICBteSAkY291bnQgPSBz Y2FsYXIgQGtleXMgKyAxOwotICAgIHByaW50ICJcbnN0YXRpYyBjb25zdCBzdHJ1Y3QgSGFzaFRh YmxlVmFsdWUgJHtuYW1lRW50cmllc31bJGNvdW50XSA9IHtcbiI7CisgICAgcHJpbnQgIlxuc3Rh dGljIGNvbnN0IHN0cnVjdCBIYXNoVGFibGVWYWx1ZSAke25hbWVFbnRyaWVzfVxbJGNvdW50XF0g PSB7XG4iOwogICAgIG15ICRpID0gMDsKICAgICBmb3JlYWNoIG15ICRrZXkgKEBrZXlzKSB7CiAg ICAgICAgIG15ICRmaXJzdFZhbHVlID0gIiI7Cg==