<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>218306</bug_id>
          
          <creation_ts>2020-10-28 13:42:37 -0700</creation_ts>
          <short_desc>Make run-webkit-test support filter attached devices by udid</short_desc>
          <delta_ts>2025-01-16 13:43:04 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>282198</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Zhifei Fang">zhifei_fang</reporter>
          <assigned_to name="Zhifei Fang">zhifei_fang</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>glenn</cc>
    
    <cc>jbedard</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zhifei_fang</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1702474</commentid>
    <comment_count>0</comment_count>
    <who name="Zhifei Fang">zhifei_fang</who>
    <bug_when>2020-10-28 13:42:37 -0700</bug_when>
    <thetext>Make run-webkit-test support filter attached devices by udid</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1702476</commentid>
    <comment_count>1</comment_count>
      <attachid>412570</attachid>
    <who name="Zhifei Fang">zhifei_fang</who>
    <bug_when>2020-10-28 13:46:39 -0700</bug_when>
    <thetext>Created attachment 412570
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1702477</commentid>
    <comment_count>2</comment_count>
    <who name="Zhifei Fang">zhifei_fang</who>
    <bug_when>2020-10-28 13:48:16 -0700</bug_when>
    <thetext>&lt;rdar://34412623&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1702480</commentid>
    <comment_count>3</comment_count>
    <who name="Zhifei Fang">zhifei_fang</who>
    <bug_when>2020-10-28 13:56:14 -0700</bug_when>
    <thetext>This is also need an internal part</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1702531</commentid>
    <comment_count>4</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2020-10-28 15:50:09 -0700</bug_when>
    <thetext>Please check if it breaks layout tests on ios: https://ews-build.webkit.org/#/builders/51/builds/672

File &quot;Tools/Scripts/webkitpy/port/device_port.py&quot;, line 47, in __init__
    self.udids = options.udid.split(&apos;,&apos;) if options and options.udid else None
AttributeError: Values instance has no attribute &apos;udid&apos;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1704564</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-11-04 12:43:17 -0800</bug_when>
    <thetext>&lt;rdar://problem/71047801&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1705002</commentid>
    <comment_count>6</comment_count>
      <attachid>413350</attachid>
    <who name="Zhifei Fang">zhifei_fang</who>
    <bug_when>2020-11-05 13:35:26 -0800</bug_when>
    <thetext>Created attachment 413350
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1705012</commentid>
    <comment_count>7</comment_count>
      <attachid>413352</attachid>
    <who name="Zhifei Fang">zhifei_fang</who>
    <bug_when>2020-11-05 14:24:46 -0800</bug_when>
    <thetext>Created attachment 413352
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1705052</commentid>
    <comment_count>8</comment_count>
      <attachid>413352</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2020-11-05 16:30:54 -0800</bug_when>
    <thetext>Comment on attachment 413352
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413352&amp;action=review

&gt; Tools/Scripts/webkitpy/xcode/simulated_device.py:162
&gt; +    def available_devices(host=None, udids=None):

Wanted to check before this landed, and it turns out that simulated devices do indeed have udidis, if we&apos;re passing this in, seems that we should use it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2087837</commentid>
    <comment_count>9</comment_count>
    <who name="Sam Sneddon [:gsnedders]">gsnedders</who>
    <bug_when>2025-01-16 13:43:04 -0800</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 282198 ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>412570</attachid>
            <date>2020-10-28 13:46:39 -0700</date>
            <delta_ts>2020-11-05 13:35:25 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-218306-20201028134638.patch</filename>
            <type>text/plain</type>
            <size>3805</size>
            <attacher name="Zhifei Fang">zhifei_fang</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MTE1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDg5OWQyOTA3NTJjNDUzMTg1NmZiZjMyNTJjN2E1NWMy
NjczNjRlYi4uNDkzMmQ3OTBhYmM4NWI5N2FjMWQ0NzdlMjBmNjZmZTRkNTA3MDgwOCAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2
IEBACisyMDIwLTEwLTI4ICBaaGlmZWkgRmFuZyAgPHpoaWZlaV9mYW5nQGFwcGxlLmNvbT4KKwor
ICAgICAgICBNYWtlIHJ1bi13ZWJraXQtdGVzdCBzdXBwb3J0IGZpbHRlciBhdHRhY2hlZCBkZXZp
Y2VzIGJ5IHVkaWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTIxODMwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2RldmljZV9wb3J0LnB5OgorICAgICAgICAoRGV2
aWNlUG9ydC5fX2luaXRfXyk6CisgICAgICAgIChEZXZpY2VQb3J0LnN1cHBvcnRlZF9kZXZpY2Vf
dHlwZXMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHk6CisgICAgICAg
IChJT1NQb3J0Ll9faW5pdF9fKToKKwogMjAyMC0xMC0yOCAgSm9uYXRoYW4gQmVkYXJkICA8amJl
ZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgW3dlYmtpdGZsYXNrcHldIENyZWF0ZSBzaGFyZWQg
bGlicmFyeSBmb3IgV2ViS2l0J3MgZmxhc2sgdG9vbGluZwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny
aXB0cy93ZWJraXRweS9wb3J0L2RldmljZV9wb3J0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw
eS9wb3J0L2RldmljZV9wb3J0LnB5CmluZGV4IGRhZjg2ZmYwM2EzNzFjZDg5ZmJiZTkxNjI5M2Uz
MDc2NDk3Njg3MzAuLjFmMjRiY2JmMWUwNDg5MTM3ZjRkNWU0NWY1ODA2YTM4MzBkNzc1NTEgMTAw
NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kZXZpY2VfcG9ydC5weQorKysg
Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZGV2aWNlX3BvcnQucHkKQEAgLTQwLDEwICs0
MCwxMSBAQCBjbGFzcyBEZXZpY2VQb3J0KERhcndpblBvcnQpOgogICAgIERFVklDRV9NQU5BR0VS
ID0gTm9uZQogICAgIE5PX0RFVklDRV9NQU5BR0VSID0gJ05vIGRldmljZSBtYW5hZ2VyIGZvdW5k
IGZvciBwb3J0JwogCi0gICAgZGVmIF9faW5pdF9fKHNlbGYsICphcmdzLCAqKmt3YXJncyk6Ci0g
ICAgICAgIHN1cGVyKERldmljZVBvcnQsIHNlbGYpLl9faW5pdF9fKCphcmdzLCAqKmt3YXJncykK
KyAgICBkZWYgX19pbml0X18oc2VsZiwgaG9zdCwgcG9ydF9uYW1lLCBvcHRpb25zLCAqYXJncywg
Kiprd2FyZ3MpOgorICAgICAgICBzdXBlcihEZXZpY2VQb3J0LCBzZWxmKS5fX2luaXRfXyhob3N0
LCBwb3J0X25hbWUsICphcmdzLCAqKmt3YXJncykKICAgICAgICAgc2VsZi5fdGVzdF9ydW5uZXJf
cHJvY2Vzc19jb25zdHJ1Y3RvciA9IFNpbXVsYXRvclByb2Nlc3MKICAgICAgICAgc2VsZi5fcHJp
bnRpbmdfY21kX2xpbmUgPSBGYWxzZQorICAgICAgICBzZWxmLnVkaWRzID0gb3B0aW9ucy51ZGlk
LnNwbGl0KCcsJykgaWYgb3B0aW9ucyBhbmQgb3B0aW9ucy51ZGlkIGVsc2UgTm9uZQogCiAgICAg
ZGVmIGRyaXZlcl9jbWRfbGluZV9mb3JfbG9nZ2luZyhzZWxmKToKICAgICAgICAgIyBBdm9pZCBj
cmVhdGluZy9jb25uZWN0aW5nIHRvIGRldmljZXMganVzdCBmb3IgY29tbWFuZCBsaW5lIGxvZ2dp
bmcuCkBAIC0xNDAsNyArMTQxLDcgQEAgY2xhc3MgRGV2aWNlUG9ydChEYXJ3aW5Qb3J0KToKIAog
ICAgIGRlZiBzdXBwb3J0ZWRfZGV2aWNlX3R5cGVzKHNlbGYpOgogICAgICAgICB0eXBlcyA9IHNl
dCgpCi0gICAgICAgIGZvciBkZXZpY2UgaW4gc2VsZi5ERVZJQ0VfTUFOQUdFUi5hdmFpbGFibGVf
ZGV2aWNlcyhob3N0PXNlbGYuaG9zdCk6CisgICAgICAgIGZvciBkZXZpY2UgaW4gc2VsZi5ERVZJ
Q0VfTUFOQUdFUi5hdmFpbGFibGVfZGV2aWNlcyhob3N0PXNlbGYuaG9zdCwgdWRpZHM9c2VsZi51
ZGlkcyk6CiAgICAgICAgICAgICBpZiBzZWxmLkRFVklDRV9NQU5BR0VSID09IFNpbXVsYXRlZERl
dmljZU1hbmFnZXIgYW5kIG5vdCBkZXZpY2UucGxhdGZvcm1fZGV2aWNlLmlzX2Jvb3RlZF9vcl9i
b290aW5nKCk6CiAgICAgICAgICAgICAgICAgY29udGludWUKICAgICAgICAgICAgIGlmIGRldmlj
ZS5kZXZpY2VfdHlwZSBpbiBzZWxmLkRFVklDRV9UWVBFOgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny
aXB0cy93ZWJraXRweS9wb3J0L2lvcy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9p
b3MucHkKaW5kZXggMzZjY2NmZTA0ZTczNDU0MTgxNGFhZGFhNmY4ZGNjY2ExZjNjY2YwZC4uZGU3
MTg1NDcxYjdiMDZhODdiYjQwMTJiM2EzY2Y5OGRiMjUzZmU0MSAxMDA2NDQKLS0tIGEvVG9vbHMv
U2NyaXB0cy93ZWJraXRweS9wb3J0L2lvcy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5
L3BvcnQvaW9zLnB5CkBAIC0zOSw4ICszOSw4IEBAIGNsYXNzIElPU1BvcnQoRGV2aWNlUG9ydCk6
CiAgICAgQ1VSUkVOVF9WRVJTSU9OID0gVmVyc2lvbigxNCkKICAgICBERVZJQ0VfVFlQRSA9IERl
dmljZVR5cGUoc29mdHdhcmVfdmFyaWFudD0naU9TJykKIAotICAgIGRlZiBfX2luaXRfXyhzZWxm
LCBob3N0LCBwb3J0X25hbWUsICoqa3dhcmdzKToKLSAgICAgICAgc3VwZXIoSU9TUG9ydCwgc2Vs
ZikuX19pbml0X18oaG9zdCwgcG9ydF9uYW1lLCAqKmt3YXJncykKKyAgICBkZWYgX19pbml0X18o
c2VsZiwgaG9zdCwgcG9ydF9uYW1lLCBvcHRpb25zLCAqKmt3YXJncyk6CisgICAgICAgIHN1cGVy
KElPU1BvcnQsIHNlbGYpLl9faW5pdF9fKGhvc3QsIHBvcnRfbmFtZSwgb3B0aW9ucywgKiprd2Fy
Z3MpCiAgICAgICAgIHNlbGYuX3Rlc3RfcnVubmVyX3Byb2Nlc3NfY29uc3RydWN0b3IgPSBTaW11
bGF0b3JQcm9jZXNzCiAgICAgICAgIHNlbGYuX3ByaW50aW5nX2NtZF9saW5lID0gRmFsc2UKIApk
aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3dhdGNoX2RldmljZS5weSBi
L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93YXRjaF9kZXZpY2UucHkKaW5kZXggYWQ4Mjg5
NTNkYzI3MDI5N2ZiODRiY2UyN2QxYmRhOGZkYzZmNmU5NC4uYThmYzk1MTk0YjMyNGVhOTMzY2Nm
YmM4MTM4OWQ0NjJmMWNmNTZiNCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9w
b3J0L3dhdGNoX2RldmljZS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2F0
Y2hfZGV2aWNlLnB5CkBAIC05NCw3ICs5NCw3IEBAIGNsYXNzIFdhdGNoRGV2aWNlUG9ydChXYXRj
aFBvcnQpOgogICAgICAgICBpZiBub3Qgc2VsZi5ERVZJQ0VfTUFOQUdFUi5hdmFpbGFibGVfZGV2
aWNlcyhob3N0PXNlbGYuaG9zdCk6CiAgICAgICAgICAgICByYWlzZSBSdW50aW1lRXJyb3IoJ05v
IGRldmljZXMgYXJlIGF2YWlsYWJsZScpCiAgICAgICAgIHZlcnNpb24gPSBOb25lCi0gICAgICAg
IGZvciBkZXZpY2UgaW4gc2VsZi5ERVZJQ0VfTUFOQUdFUi5hdmFpbGFibGVfZGV2aWNlcyhob3N0
PXNlbGYuaG9zdCk6CisgICAgICAgIGZvciBkZXZpY2UgaW4gc2VsZi5ERVZJQ0VfTUFOQUdFUi5h
dmFpbGFibGVfZGV2aWNlcyhob3N0PXNlbGYuaG9zdCwgdWRpZHM9c2VsZi51ZGlkcyk6CiAgICAg
ICAgICAgICBpZiBub3QgZGV2aWNlLnBsYXRmb3JtLmlzX3dhdGNob3MoKToKICAgICAgICAgICAg
ICAgICBjb250aW51ZQogICAgICAgICAgICAgaWYgbm90IHZlcnNpb246Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>413350</attachid>
            <date>2020-11-05 13:35:26 -0800</date>
            <delta_ts>2020-11-05 14:24:44 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-218306-20201105133526.patch</filename>
            <type>text/plain</type>
            <size>4504</size>
            <attacher name="Zhifei Fang">zhifei_fang</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MTE1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDg5OWQyOTA3NTJjNDUzMTg1NmZiZjMyNTJjN2E1NWMy
NjczNjRlYi4uNDkzMmQ3OTBhYmM4NWI5N2FjMWQ0NzdlMjBmNjZmZTRkNTA3MDgwOCAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2
IEBACisyMDIwLTEwLTI4ICBaaGlmZWkgRmFuZyAgPHpoaWZlaV9mYW5nQGFwcGxlLmNvbT4KKwor
ICAgICAgICBNYWtlIHJ1bi13ZWJraXQtdGVzdCBzdXBwb3J0IGZpbHRlciBhdHRhY2hlZCBkZXZp
Y2VzIGJ5IHVkaWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTIxODMwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2RldmljZV9wb3J0LnB5OgorICAgICAgICAoRGV2
aWNlUG9ydC5fX2luaXRfXyk6CisgICAgICAgIChEZXZpY2VQb3J0LnN1cHBvcnRlZF9kZXZpY2Vf
dHlwZXMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHk6CisgICAgICAg
IChJT1NQb3J0Ll9faW5pdF9fKToKKwogMjAyMC0xMC0yOCAgSm9uYXRoYW4gQmVkYXJkICA8amJl
ZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgW3dlYmtpdGZsYXNrcHldIENyZWF0ZSBzaGFyZWQg
bGlicmFyeSBmb3IgV2ViS2l0J3MgZmxhc2sgdG9vbGluZwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny
aXB0cy93ZWJraXRweS9wb3J0L2RldmljZV9wb3J0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw
eS9wb3J0L2RldmljZV9wb3J0LnB5CmluZGV4IGRhZjg2ZmYwM2EzNzFjZDg5ZmJiZTkxNjI5M2Uz
MDc2NDk3Njg3MzAuLjJhZjk3YzIyN2Y0YTY5MjU2MGMxOWIwYzUzNjJiODUwY2FkOGFmNDUgMTAw
NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kZXZpY2VfcG9ydC5weQorKysg
Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZGV2aWNlX3BvcnQucHkKQEAgLTQwLDEwICs0
MCwxMSBAQCBjbGFzcyBEZXZpY2VQb3J0KERhcndpblBvcnQpOgogICAgIERFVklDRV9NQU5BR0VS
ID0gTm9uZQogICAgIE5PX0RFVklDRV9NQU5BR0VSID0gJ05vIGRldmljZSBtYW5hZ2VyIGZvdW5k
IGZvciBwb3J0JwogCi0gICAgZGVmIF9faW5pdF9fKHNlbGYsICphcmdzLCAqKmt3YXJncyk6Ci0g
ICAgICAgIHN1cGVyKERldmljZVBvcnQsIHNlbGYpLl9faW5pdF9fKCphcmdzLCAqKmt3YXJncykK
KyAgICBkZWYgX19pbml0X18oc2VsZiwgaG9zdCwgcG9ydF9uYW1lLCBvcHRpb25zLCAqYXJncywg
Kiprd2FyZ3MpOgorICAgICAgICBzdXBlcihEZXZpY2VQb3J0LCBzZWxmKS5fX2luaXRfXyhob3N0
LCBwb3J0X25hbWUsICphcmdzLCAqKmt3YXJncykKICAgICAgICAgc2VsZi5fdGVzdF9ydW5uZXJf
cHJvY2Vzc19jb25zdHJ1Y3RvciA9IFNpbXVsYXRvclByb2Nlc3MKICAgICAgICAgc2VsZi5fcHJp
bnRpbmdfY21kX2xpbmUgPSBGYWxzZQorICAgICAgICBzZWxmLnVkaWRzID0gb3B0aW9ucy51ZGlk
LnNwbGl0KCcsJykgaWYgb3B0aW9ucyBhbmQgaGFzYXR0cihvcHRpb25zLCAndWRpZCcpIGFuZCBv
cHRpb25zLnVkaWQgZWxzZSBOb25lCiAKICAgICBkZWYgZHJpdmVyX2NtZF9saW5lX2Zvcl9sb2dn
aW5nKHNlbGYpOgogICAgICAgICAjIEF2b2lkIGNyZWF0aW5nL2Nvbm5lY3RpbmcgdG8gZGV2aWNl
cyBqdXN0IGZvciBjb21tYW5kIGxpbmUgbG9nZ2luZy4KQEAgLTE0MCw3ICsxNDEsNyBAQCBjbGFz
cyBEZXZpY2VQb3J0KERhcndpblBvcnQpOgogCiAgICAgZGVmIHN1cHBvcnRlZF9kZXZpY2VfdHlw
ZXMoc2VsZik6CiAgICAgICAgIHR5cGVzID0gc2V0KCkKLSAgICAgICAgZm9yIGRldmljZSBpbiBz
ZWxmLkRFVklDRV9NQU5BR0VSLmF2YWlsYWJsZV9kZXZpY2VzKGhvc3Q9c2VsZi5ob3N0KToKKyAg
ICAgICAgZm9yIGRldmljZSBpbiBzZWxmLkRFVklDRV9NQU5BR0VSLmF2YWlsYWJsZV9kZXZpY2Vz
KGhvc3Q9c2VsZi5ob3N0LCB1ZGlkcz1zZWxmLnVkaWRzKToKICAgICAgICAgICAgIGlmIHNlbGYu
REVWSUNFX01BTkFHRVIgPT0gU2ltdWxhdGVkRGV2aWNlTWFuYWdlciBhbmQgbm90IGRldmljZS5w
bGF0Zm9ybV9kZXZpY2UuaXNfYm9vdGVkX29yX2Jvb3RpbmcoKToKICAgICAgICAgICAgICAgICBj
b250aW51ZQogICAgICAgICAgICAgaWYgZGV2aWNlLmRldmljZV90eXBlIGluIHNlbGYuREVWSUNF
X1RZUEU6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zLnB5IGIv
VG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvcy5weQppbmRleCAzNmNjY2ZlMDRlNzM0NTQx
ODE0YWFkYWE2ZjhkY2NjYTFmM2NjZjBkLi5kZTcxODU0NzFiN2IwNmE4N2JiNDAxMmIzYTNjZjk4
ZGIyNTNmZTQxIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zLnB5
CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHkKQEAgLTM5LDggKzM5LDgg
QEAgY2xhc3MgSU9TUG9ydChEZXZpY2VQb3J0KToKICAgICBDVVJSRU5UX1ZFUlNJT04gPSBWZXJz
aW9uKDE0KQogICAgIERFVklDRV9UWVBFID0gRGV2aWNlVHlwZShzb2Z0d2FyZV92YXJpYW50PSdp
T1MnKQogCi0gICAgZGVmIF9faW5pdF9fKHNlbGYsIGhvc3QsIHBvcnRfbmFtZSwgKiprd2FyZ3Mp
OgotICAgICAgICBzdXBlcihJT1NQb3J0LCBzZWxmKS5fX2luaXRfXyhob3N0LCBwb3J0X25hbWUs
ICoqa3dhcmdzKQorICAgIGRlZiBfX2luaXRfXyhzZWxmLCBob3N0LCBwb3J0X25hbWUsIG9wdGlv
bnMsICoqa3dhcmdzKToKKyAgICAgICAgc3VwZXIoSU9TUG9ydCwgc2VsZikuX19pbml0X18oaG9z
dCwgcG9ydF9uYW1lLCBvcHRpb25zLCAqKmt3YXJncykKICAgICAgICAgc2VsZi5fdGVzdF9ydW5u
ZXJfcHJvY2Vzc19jb25zdHJ1Y3RvciA9IFNpbXVsYXRvclByb2Nlc3MKICAgICAgICAgc2VsZi5f
cHJpbnRpbmdfY21kX2xpbmUgPSBGYWxzZQogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl
YmtpdHB5L3BvcnQvd2F0Y2hfZGV2aWNlLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0
L3dhdGNoX2RldmljZS5weQppbmRleCBhZDgyODk1M2RjMjcwMjk3ZmI4NGJjZTI3ZDFiZGE4ZmRj
NmY2ZTk0Li5hOGZjOTUxOTRiMzI0ZWE5MzNjY2ZiYzgxMzg5ZDQ2MmYxY2Y1NmI0IDEwMDY0NAot
LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2F0Y2hfZGV2aWNlLnB5CisrKyBiL1Rv
b2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93YXRjaF9kZXZpY2UucHkKQEAgLTk0LDcgKzk0LDcg
QEAgY2xhc3MgV2F0Y2hEZXZpY2VQb3J0KFdhdGNoUG9ydCk6CiAgICAgICAgIGlmIG5vdCBzZWxm
LkRFVklDRV9NQU5BR0VSLmF2YWlsYWJsZV9kZXZpY2VzKGhvc3Q9c2VsZi5ob3N0KToKICAgICAg
ICAgICAgIHJhaXNlIFJ1bnRpbWVFcnJvcignTm8gZGV2aWNlcyBhcmUgYXZhaWxhYmxlJykKICAg
ICAgICAgdmVyc2lvbiA9IE5vbmUKLSAgICAgICAgZm9yIGRldmljZSBpbiBzZWxmLkRFVklDRV9N
QU5BR0VSLmF2YWlsYWJsZV9kZXZpY2VzKGhvc3Q9c2VsZi5ob3N0KToKKyAgICAgICAgZm9yIGRl
dmljZSBpbiBzZWxmLkRFVklDRV9NQU5BR0VSLmF2YWlsYWJsZV9kZXZpY2VzKGhvc3Q9c2VsZi5o
b3N0LCB1ZGlkcz1zZWxmLnVkaWRzKToKICAgICAgICAgICAgIGlmIG5vdCBkZXZpY2UucGxhdGZv
cm0uaXNfd2F0Y2hvcygpOgogICAgICAgICAgICAgICAgIGNvbnRpbnVlCiAgICAgICAgICAgICBp
ZiBub3QgdmVyc2lvbjoKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUv
c2ltdWxhdGVkX2RldmljZS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxh
dGVkX2RldmljZS5weQppbmRleCBmZjIyZTExMDlmNzAzODdmNzZkYjBhZjc3OWEzOGEyZGIwOTZh
NjU0Li4wMmM3MzdhYTBiOTM3YzA0Y2E0NTMxMGQ3ZGEyYTlmN2Q2Y2NiM2E3IDEwMDY0NAotLS0g
YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkKKysrIGIv
VG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5CkBAIC0xNTks
NyArMTU5LDcgQEAgY2xhc3MgU2ltdWxhdGVkRGV2aWNlTWFuYWdlcihvYmplY3QpOgogICAgICAg
ICByZXR1cm4KIAogICAgIEBzdGF0aWNtZXRob2QKLSAgICBkZWYgYXZhaWxhYmxlX2RldmljZXMo
aG9zdD1Ob25lKToKKyAgICBkZWYgYXZhaWxhYmxlX2RldmljZXMoaG9zdD1Ob25lLCB1ZGlkcz1O
b25lKToKICAgICAgICAgaG9zdCA9IGhvc3Qgb3IgU3lzdGVtSG9zdCgpCiAgICAgICAgIGlmIFNp
bXVsYXRlZERldmljZU1hbmFnZXIuQVZBSUxBQkxFX0RFVklDRVMgPT0gW106CiAgICAgICAgICAg
ICBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLnBvcHVsYXRlX2F2YWlsYWJsZV9kZXZpY2VzKGhvc3Qp
Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>413352</attachid>
            <date>2020-11-05 14:24:46 -0800</date>
            <delta_ts>2020-11-05 14:24:46 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-218306-20201105142445.patch</filename>
            <type>text/plain</type>
            <size>4539</size>
            <attacher name="Zhifei Fang">zhifei_fang</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5NDc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTAxZTYyZjE5NzdkOTA3MzY1NzYwYTFlOGI0YWFjMTg3
OTBiN2VhYy4uNjllYTg5OWQ2M2I1YjAxM2ZmYjdlZjMxZDQyZmJmMGYyMDRjODRjMiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2
IEBACisyMDIwLTExLTA1ICBaaGlmZWkgRmFuZyAgPHpoaWZlaV9mYW5nQGFwcGxlLmNvbT4KKwor
ICAgICAgICBNYWtlIHJ1bi13ZWJraXQtdGVzdCBzdXBwb3J0IGZpbHRlciBhdHRhY2hlZCBkZXZp
Y2VzIGJ5IHVkaWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTIxODMwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2RldmljZV9wb3J0LnB5OgorICAgICAgICAoRGV2
aWNlUG9ydC5fX2luaXRfXyk6CisgICAgICAgIChEZXZpY2VQb3J0LnN1cHBvcnRlZF9kZXZpY2Vf
dHlwZXMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHk6CisgICAgICAg
IChJT1NQb3J0Ll9faW5pdF9fKToKKwogMjAyMC0xMS0wNSAgQWFrYXNoIEphaW4gIDxhYWthc2hf
amFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2J1aWxkLndlYmtpdC5vcmddIFJlbmFtZSBCVUlM
RF9XRUJLSVRfVVJMIHRvIENVUlJFTlRfSE9TVE5BTUUKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw
dHMvd2Via2l0cHkvcG9ydC9kZXZpY2VfcG9ydC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv
cG9ydC9kZXZpY2VfcG9ydC5weQppbmRleCBkYWY4NmZmMDNhMzcxY2Q4OWZiYmU5MTYyOTNlMzA3
NjQ5NzY4NzMwLi4xMTJkYjVhNzA3YTUxMWViMDY5NTU5OTYxMTg2Mjg3MzJkMWFkYjRkIDEwMDY0
NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZGV2aWNlX3BvcnQucHkKKysrIGIv
VG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2RldmljZV9wb3J0LnB5CkBAIC00MCwxMCArNDAs
MTIgQEAgY2xhc3MgRGV2aWNlUG9ydChEYXJ3aW5Qb3J0KToKICAgICBERVZJQ0VfTUFOQUdFUiA9
IE5vbmUKICAgICBOT19ERVZJQ0VfTUFOQUdFUiA9ICdObyBkZXZpY2UgbWFuYWdlciBmb3VuZCBm
b3IgcG9ydCcKIAotICAgIGRlZiBfX2luaXRfXyhzZWxmLCAqYXJncywgKiprd2FyZ3MpOgotICAg
ICAgICBzdXBlcihEZXZpY2VQb3J0LCBzZWxmKS5fX2luaXRfXygqYXJncywgKiprd2FyZ3MpCisg
ICAgZGVmIF9faW5pdF9fKHNlbGYsIGhvc3QsIHBvcnRfbmFtZSwgb3B0aW9ucywgKmFyZ3MsICoq
a3dhcmdzKToKKyAgICAgICAga3dhcmdzWydvcHRpb25zJ10gPSBvcHRpb25zCisgICAgICAgIHN1
cGVyKERldmljZVBvcnQsIHNlbGYpLl9faW5pdF9fKGhvc3QsIHBvcnRfbmFtZSwgKmFyZ3MsICoq
a3dhcmdzKQogICAgICAgICBzZWxmLl90ZXN0X3J1bm5lcl9wcm9jZXNzX2NvbnN0cnVjdG9yID0g
U2ltdWxhdG9yUHJvY2VzcwogICAgICAgICBzZWxmLl9wcmludGluZ19jbWRfbGluZSA9IEZhbHNl
CisgICAgICAgIHNlbGYudWRpZHMgPSBvcHRpb25zLnVkaWQuc3BsaXQoJywnKSBpZiBvcHRpb25z
IGFuZCBoYXNhdHRyKG9wdGlvbnMsICd1ZGlkJykgYW5kIG9wdGlvbnMudWRpZCBlbHNlIE5vbmUK
IAogICAgIGRlZiBkcml2ZXJfY21kX2xpbmVfZm9yX2xvZ2dpbmcoc2VsZik6CiAgICAgICAgICMg
QXZvaWQgY3JlYXRpbmcvY29ubmVjdGluZyB0byBkZXZpY2VzIGp1c3QgZm9yIGNvbW1hbmQgbGlu
ZSBsb2dnaW5nLgpAQCAtMTQwLDcgKzE0Miw3IEBAIGNsYXNzIERldmljZVBvcnQoRGFyd2luUG9y
dCk6CiAKICAgICBkZWYgc3VwcG9ydGVkX2RldmljZV90eXBlcyhzZWxmKToKICAgICAgICAgdHlw
ZXMgPSBzZXQoKQotICAgICAgICBmb3IgZGV2aWNlIGluIHNlbGYuREVWSUNFX01BTkFHRVIuYXZh
aWxhYmxlX2RldmljZXMoaG9zdD1zZWxmLmhvc3QpOgorICAgICAgICBmb3IgZGV2aWNlIGluIHNl
bGYuREVWSUNFX01BTkFHRVIuYXZhaWxhYmxlX2RldmljZXMoaG9zdD1zZWxmLmhvc3QsIHVkaWRz
PXNlbGYudWRpZHMpOgogICAgICAgICAgICAgaWYgc2VsZi5ERVZJQ0VfTUFOQUdFUiA9PSBTaW11
bGF0ZWREZXZpY2VNYW5hZ2VyIGFuZCBub3QgZGV2aWNlLnBsYXRmb3JtX2RldmljZS5pc19ib290
ZWRfb3JfYm9vdGluZygpOgogICAgICAgICAgICAgICAgIGNvbnRpbnVlCiAgICAgICAgICAgICBp
ZiBkZXZpY2UuZGV2aWNlX3R5cGUgaW4gc2VsZi5ERVZJQ0VfVFlQRToKZGlmZiAtLWdpdCBhL1Rv
b2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5
L3BvcnQvaW9zLnB5CmluZGV4IDM2Y2NjZmUwNGU3MzQ1NDE4MTRhYWRhYTZmOGRjY2NhMWYzY2Nm
MGQuLmRlNzE4NTQ3MWI3YjA2YTg3YmI0MDEyYjNhM2NmOThkYjI1M2ZlNDEgMTAwNjQ0Ci0tLSBh
L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93
ZWJraXRweS9wb3J0L2lvcy5weQpAQCAtMzksOCArMzksOCBAQCBjbGFzcyBJT1NQb3J0KERldmlj
ZVBvcnQpOgogICAgIENVUlJFTlRfVkVSU0lPTiA9IFZlcnNpb24oMTQpCiAgICAgREVWSUNFX1RZ
UEUgPSBEZXZpY2VUeXBlKHNvZnR3YXJlX3ZhcmlhbnQ9J2lPUycpCiAKLSAgICBkZWYgX19pbml0
X18oc2VsZiwgaG9zdCwgcG9ydF9uYW1lLCAqKmt3YXJncyk6Ci0gICAgICAgIHN1cGVyKElPU1Bv
cnQsIHNlbGYpLl9faW5pdF9fKGhvc3QsIHBvcnRfbmFtZSwgKiprd2FyZ3MpCisgICAgZGVmIF9f
aW5pdF9fKHNlbGYsIGhvc3QsIHBvcnRfbmFtZSwgb3B0aW9ucywgKiprd2FyZ3MpOgorICAgICAg
ICBzdXBlcihJT1NQb3J0LCBzZWxmKS5fX2luaXRfXyhob3N0LCBwb3J0X25hbWUsIG9wdGlvbnMs
ICoqa3dhcmdzKQogICAgICAgICBzZWxmLl90ZXN0X3J1bm5lcl9wcm9jZXNzX2NvbnN0cnVjdG9y
ID0gU2ltdWxhdG9yUHJvY2VzcwogICAgICAgICBzZWxmLl9wcmludGluZ19jbWRfbGluZSA9IEZh
bHNlCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93YXRjaF9kZXZp
Y2UucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2F0Y2hfZGV2aWNlLnB5CmluZGV4
IGFkODI4OTUzZGMyNzAyOTdmYjg0YmNlMjdkMWJkYThmZGM2ZjZlOTQuLmE4ZmM5NTE5NGIzMjRl
YTkzM2NjZmJjODEzODlkNDYyZjFjZjU2YjQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi
a2l0cHkvcG9ydC93YXRjaF9kZXZpY2UucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9w
b3J0L3dhdGNoX2RldmljZS5weQpAQCAtOTQsNyArOTQsNyBAQCBjbGFzcyBXYXRjaERldmljZVBv
cnQoV2F0Y2hQb3J0KToKICAgICAgICAgaWYgbm90IHNlbGYuREVWSUNFX01BTkFHRVIuYXZhaWxh
YmxlX2RldmljZXMoaG9zdD1zZWxmLmhvc3QpOgogICAgICAgICAgICAgcmFpc2UgUnVudGltZUVy
cm9yKCdObyBkZXZpY2VzIGFyZSBhdmFpbGFibGUnKQogICAgICAgICB2ZXJzaW9uID0gTm9uZQot
ICAgICAgICBmb3IgZGV2aWNlIGluIHNlbGYuREVWSUNFX01BTkFHRVIuYXZhaWxhYmxlX2Rldmlj
ZXMoaG9zdD1zZWxmLmhvc3QpOgorICAgICAgICBmb3IgZGV2aWNlIGluIHNlbGYuREVWSUNFX01B
TkFHRVIuYXZhaWxhYmxlX2RldmljZXMoaG9zdD1zZWxmLmhvc3QsIHVkaWRzPXNlbGYudWRpZHMp
OgogICAgICAgICAgICAgaWYgbm90IGRldmljZS5wbGF0Zm9ybS5pc193YXRjaG9zKCk6CiAgICAg
ICAgICAgICAgICAgY29udGludWUKICAgICAgICAgICAgIGlmIG5vdCB2ZXJzaW9uOgpkaWZmIC0t
Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5IGIv
VG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5CmluZGV4IGZm
MjJlMTEwOWY3MDM4N2Y3NmRiMGFmNzc5YTM4YTJkYjA5NmE2NTQuLjAyYzczN2FhMGI5MzdjMDRj
YTQ1MzEwZDdkYTJhOWY3ZDZjY2IzYTcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0
cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5
L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkKQEAgLTE1OSw3ICsxNTksNyBAQCBjbGFzcyBTaW11
bGF0ZWREZXZpY2VNYW5hZ2VyKG9iamVjdCk6CiAgICAgICAgIHJldHVybgogCiAgICAgQHN0YXRp
Y21ldGhvZAotICAgIGRlZiBhdmFpbGFibGVfZGV2aWNlcyhob3N0PU5vbmUpOgorICAgIGRlZiBh
dmFpbGFibGVfZGV2aWNlcyhob3N0PU5vbmUsIHVkaWRzPU5vbmUpOgogICAgICAgICBob3N0ID0g
aG9zdCBvciBTeXN0ZW1Ib3N0KCkKICAgICAgICAgaWYgU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5B
VkFJTEFCTEVfREVWSUNFUyA9PSBbXToKICAgICAgICAgICAgIFNpbXVsYXRlZERldmljZU1hbmFn
ZXIucG9wdWxhdGVfYXZhaWxhYmxlX2RldmljZXMoaG9zdCkK
</data>
<flag name="review"
          id="429929"
          type_id="1"
          status="?"
          setter="zhifei_fang"
    />
          </attachment>
      

    </bug>

</bugzilla>