218279 2020-10-28 04:51:54 -0700 WebDriver: handle surrogate pairs in keyboard actions 2020-11-05 00:47:50 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 166679 1 cgarcia webkit-unassigned bburg webkit-bug-importer oldest_to_newest 1702273 0 cgarcia 2020-10-28 04:51:54 -0700 And fail with invalid argument if the string can be represented as a single code point. 1702274 1 412518 cgarcia 2020-10-28 04:55:18 -0700 Created attachment 412518 Patch 1704368 2 webkit-bug-importer 2020-11-04 03:52:16 -0800 <rdar://problem/71031565> 1704506 3 412518 bburg 2020-11-04 10:53:03 -0800 Comment on attachment 412518 Patch r=me, thanks! 1704770 4 cgarcia 2020-11-05 00:47:50 -0800 Committed r269421: <https://trac.webkit.org/changeset/269421> 412518 2020-10-28 04:55:18 -0700 2020-11-04 10:53:03 -0800 Patch wd-surrogate.diff text/plain 5270 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZGRiNWMzNjIyZjQ0Li45ZThiMzk5N2I3MDggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjMgQEAKKzIwMjAtMTAtMjggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFdlYkRyaXZlcjogaGFuZGxlIHN1cnJvZ2F0ZSBwYWlycyBpbiBr ZXlib2FyZCBhY3Rpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMTgyNzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBbmQgZmFpbCB3aXRoIGludmFsaWQgYXJndW1lbnQgaWYgdGhlIHN0cmluZyBjYW4g YmUgcmVwcmVzZW50ZWQgYXMgYSBzaW5nbGUgY29kZSBwb2ludC4KKworICAgICAgICBGaXhlczog aW1wb3J0ZWQvdzNjL3dlYmRyaXZlci90ZXN0cy9wZXJmb3JtX2FjdGlvbnMva2V5X3NwZWNpYWxf a2V5cy5weTo6dGVzdF9jb2RlcG9pbnRfa2V5c19iZWhhdmVfY29ycmVjdGx5W1xVMDAwMWY2MDRd CisgICAgICAgICAgICAgICBpbXBvcnRlZC93M2Mvd2ViZHJpdmVyL3Rlc3RzL3BlcmZvcm1fYWN0 aW9ucy9rZXlfc3BlY2lhbF9rZXlzLnB5Ojp0ZXN0X2NvZGVwb2ludF9rZXlzX2JlaGF2ZV9jb3Jy ZWN0bHlbXFUwMDAxZjYwZF0KKyAgICAgICAgICAgICAgIGltcG9ydGVkL3czYy93ZWJkcml2ZXIv dGVzdHMvcGVyZm9ybV9hY3Rpb25zL2tleV9zcGVjaWFsX2tleXMucHk6OnRlc3RfaW52YWxpZF9t dWx0aXBsZV9jb2RlcG9pbnRfa2V5c19mYWlsW2ZhXQorICAgICAgICAgICAgICAgaW1wb3J0ZWQv dzNjL3dlYmRyaXZlci90ZXN0cy9wZXJmb3JtX2FjdGlvbnMva2V5X3NwZWNpYWxfa2V5cy5weTo6 dGVzdF9pbnZhbGlkX211bHRpcGxlX2NvZGVwb2ludF9rZXlzX2ZhaWxbXHUwYmE4XHUwYmJmYl0K KyAgICAgICAgICAgICAgIGltcG9ydGVkL3czYy93ZWJkcml2ZXIvdGVzdHMvcGVyZm9ybV9hY3Rp b25zL2tleV9zcGVjaWFsX2tleXMucHk6OnRlc3RfaW52YWxpZF9tdWx0aXBsZV9jb2RlcG9pbnRf a2V5c19mYWlsW1x1MGJhOFx1MGJiZlx1MGJhOF0KKyAgICAgICAgICAgICAgIGltcG9ydGVkL3cz Yy93ZWJkcml2ZXIvdGVzdHMvcGVyZm9ybV9hY3Rpb25zL2tleV9zcGVjaWFsX2tleXMucHk6OnRl c3RfaW52YWxpZF9tdWx0aXBsZV9jb2RlcG9pbnRfa2V5c19mYWlsW1x1MTEwMFx1MTE2MVx1MTFh OGNdCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lv bi5jcHA6CisgICAgICAgIChXZWJLaXQ6OnByZXNzZWRDaGFyS2V5KToKKyAgICAgICAgKFdlYktp dDo6V2ViQXV0b21hdGlvblNlc3Npb246OnBlcmZvcm1JbnRlcmFjdGlvblNlcXVlbmNlKToKKwog MjAyMC0xMC0yNyAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgog CiAgICAgICAgIFVzZSBfQ0ZVUkxDb25uZWN0aW9uU2V0RnJhbWV3b3JrU3R1YnMgZm9yIFNlY0l0 ZW1TaGltIGluc3RlYWQgb2YgRFlMRF9JTlRFUlBPU0Ugb24gQXBwbGUgU2lsaWNvbiBNYWNzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRp b25TZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0 b21hdGlvblNlc3Npb24uY3BwCmluZGV4IDYzYWQzMmM1MmEwYy4uZjVhYjM3MzA1ODFkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25T ZXNzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1 dG9tYXRpb25TZXNzaW9uLmNwcApAQCAtMTk3MSw2ICsxOTcxLDIyIEBAIHN0YXRpYyBWaXJ0dWFs S2V5IG5vcm1hbGl6ZWRWaXJ0dWFsS2V5KFZpcnR1YWxLZXkga2V5KQogICAgICAgICByZXR1cm4g a2V5OwogICAgIH0KIH0KKworc3RhdGljIE9wdGlvbmFsPFVDaGFyMzI+IHByZXNzZWRDaGFyS2V5 KGNvbnN0IFN0cmluZyYgcHJlc3NlZENoYXJLZXlTdHJpbmcpCit7CisgICAgc3dpdGNoIChwcmVz c2VkQ2hhcktleVN0cmluZy5sZW5ndGgoKSkgeworICAgIGNhc2UgMToKKyAgICAgICAgcmV0dXJu IHByZXNzZWRDaGFyS2V5U3RyaW5nLmNoYXJhY3RlckF0KDApOworICAgIGNhc2UgMjogeworICAg ICAgICBhdXRvIGxlYWQgPSBwcmVzc2VkQ2hhcktleVN0cmluZy5jaGFyYWN0ZXJBdCgwKTsKKyAg ICAgICAgYXV0byB0cmFpbCA9IHByZXNzZWRDaGFyS2V5U3RyaW5nLmNoYXJhY3RlckF0KDEpOwor ICAgICAgICBpZiAoVTE2X0lTX0xFQUQobGVhZCkgJiYgVTE2X0lTX1RSQUlMKHRyYWlsKSkKKyAg ICAgICAgICAgIHJldHVybiBVMTZfR0VUX1NVUFBMRU1FTlRBUlkobGVhZCwgdHJhaWwpOworICAg IH0KKyAgICB9CisKKyAgICByZXR1cm4gV1RGOjpudWxsb3B0OworfQogI2VuZGlmIC8vIEVOQUJM RShXRUJEUklWRVJfQUNUSU9OU19BUEkpCiAKIHZvaWQgV2ViQXV0b21hdGlvblNlc3Npb246OnBl cmZvcm1JbnRlcmFjdGlvblNlcXVlbmNlKGNvbnN0IEluc3BlY3Rvcjo6UHJvdG9jb2w6OkF1dG9t YXRpb246OkJyb3dzaW5nQ29udGV4dEhhbmRsZSYgaGFuZGxlLCBjb25zdCBJbnNwZWN0b3I6OlBy b3RvY29sOjpBdXRvbWF0aW9uOjpGcmFtZUhhbmRsZSYgZnJhbWVIYW5kbGUsIFJlZjxKU09OOjpB cnJheT4mJiBpbnB1dFNvdXJjZXMsIFJlZjxKU09OOjpBcnJheT4mJiBzdGVwcywgUmVmPFdlYkF1 dG9tYXRpb25TZXNzaW9uOjpQZXJmb3JtSW50ZXJhY3Rpb25TZXF1ZW5jZUNhbGxiYWNrPiYmIGNh bGxiYWNrKQpAQCAtMjA4NCw4ICsyMTAwLDEyIEBAIHZvaWQgV2ViQXV0b21hdGlvblNlc3Npb246 OnBlcmZvcm1JbnRlcmFjdGlvblNlcXVlbmNlKGNvbnN0IEluc3BlY3Rvcjo6UHJvdG9jb2w6CiAg ICAgICAgICAgICBTaW11bGF0ZWRJbnB1dFNvdXJjZVN0YXRlIHNvdXJjZVN0YXRlIHsgfTsKIAog ICAgICAgICAgICAgYXV0byBwcmVzc2VkQ2hhcktleVN0cmluZyA9IHN0YXRlT2JqZWN0LT5nZXRT dHJpbmcoInByZXNzZWRDaGFyS2V5Il9zKTsKLSAgICAgICAgICAgIGlmICghIXByZXNzZWRDaGFy S2V5U3RyaW5nKQotICAgICAgICAgICAgICAgIHNvdXJjZVN0YXRlLnByZXNzZWRDaGFyS2V5cy5h ZGQocHJlc3NlZENoYXJLZXlTdHJpbmcuY2hhcmFjdGVyQXQoMCkpOworICAgICAgICAgICAgaWYg KCEhcHJlc3NlZENoYXJLZXlTdHJpbmcpIHsKKyAgICAgICAgICAgICAgICBhdXRvIGNoYXJLZXkg PSBwcmVzc2VkQ2hhcktleShwcmVzc2VkQ2hhcktleVN0cmluZyk7CisgICAgICAgICAgICAgICAg aWYgKCFjaGFyS2V5KQorICAgICAgICAgICAgICAgICAgICBBU1lOQ19GQUlMX1dJVEhfUFJFREVG SU5FRF9FUlJPUl9BTkRfREVUQUlMUyhJbnZhbGlkUGFyYW1ldGVyLCAiSW52YWxpZCAncHJlc3Nl ZENoYXJLZXknLiIpOworICAgICAgICAgICAgICAgIHNvdXJjZVN0YXRlLnByZXNzZWRDaGFyS2V5 cy5hZGQoKmNoYXJLZXkpOworICAgICAgICAgICAgfQogCiAgICAgICAgICAgICBpZiAoYXV0byBw cmVzc2VkVmlydHVhbEtleXNBcnJheSA9IHN0YXRlT2JqZWN0LT5nZXRBcnJheSgicHJlc3NlZFZp cnR1YWxLZXlzIl9zKSkgewogICAgICAgICAgICAgICAgIFZpcnR1YWxLZXlNYXAgcHJlc3NlZFZp cnR1YWxLZXlzOwpkaWZmIC0tZ2l0IGEvV2ViRHJpdmVyVGVzdHMvQ2hhbmdlTG9nIGIvV2ViRHJp dmVyVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDc5ZjE5YjQ5ZTMzNi4uN2YxMTczNGE1ZmU1IDEwMDY0 NAotLS0gYS9XZWJEcml2ZXJUZXN0cy9DaGFuZ2VMb2cKKysrIGIvV2ViRHJpdmVyVGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMTAtMjggIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFdlYkRyaXZlcjogaGFuZGxlIHN1cnJv Z2F0ZSBwYWlycyBpbiBrZXlib2FyZCBhY3Rpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTgyNzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgZXhwZWN0YXRpb25zIGZvciB0ZXN0cyB0aGF0 IGFyZSBub3cgcGFzc2luZy4KKworICAgICAgICAqIFRlc3RFeHBlY3RhdGlvbnMuanNvbjoKKwog MjAyMC0xMC0yNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAK ICAgICAgICAgV2ViRHJpdmVyOiBzZXF1ZW5jZSBvZiBjaGFyIGtleSBwcmVzcyBpcyBub3Qgc3Vw cG9ydGVkCmRpZmYgLS1naXQgYS9XZWJEcml2ZXJUZXN0cy9UZXN0RXhwZWN0YXRpb25zLmpzb24g Yi9XZWJEcml2ZXJUZXN0cy9UZXN0RXhwZWN0YXRpb25zLmpzb24KaW5kZXggYWNhMjdmMTJmM2Nl Li5jOWRlNTVhM2QwMmIgMTAwNjQ0Ci0tLSBhL1dlYkRyaXZlclRlc3RzL1Rlc3RFeHBlY3RhdGlv bnMuanNvbgorKysgYi9XZWJEcml2ZXJUZXN0cy9UZXN0RXhwZWN0YXRpb25zLmpzb24KQEAgLTQ0 Nyw3ICs0NDcsMTQgQEAKICAgICAgICAgfQogICAgIH0sCiAgICAgImltcG9ydGVkL3czYy93ZWJk cml2ZXIvdGVzdHMvcGVyZm9ybV9hY3Rpb25zL2tleV9zcGVjaWFsX2tleXMucHkiOiB7Ci0gICAg ICAgICJleHBlY3RlZCI6IHsiYWxsIjogeyJzdGF0dXMiOiBbIkZBSUwiXSwgImJ1ZyI6ICJ3ZWJr aXQub3JnL2IvMTg0OTY3In19CisgICAgICAgICJzdWJ0ZXN0cyI6IHsKKyAgICAgICAgICAgICJ0 ZXN0X2NvZGVwb2ludF9rZXlzX2JlaGF2ZV9jb3JyZWN0bHlbXFx1MGJhOFxcdTBiYmZdIjogewor ICAgICAgICAgICAgICAgICJleHBlY3RlZCI6IHsiYWxsIjogeyJzdGF0dXMiOiBbIkZBSUwiXSwg ImJ1ZyI6ICJ3ZWJraXQub3JnL2IvMTg0OTY3In19CisgICAgICAgICAgICB9LAorICAgICAgICAg ICAgInRlc3RfY29kZXBvaW50X2tleXNfYmVoYXZlX2NvcnJlY3RseVtcXHUxMTAwXFx1MTE2MVxc dTExYThdIjogeworICAgICAgICAgICAgICAgICJleHBlY3RlZCI6IHsiYWxsIjogeyJzdGF0dXMi OiBbIkZBSUwiXSwgImJ1ZyI6ICJ3ZWJraXQub3JnL2IvMTg0OTY3In19CisgICAgICAgICAgICB9 CisgICAgICAgIH0KICAgICB9LAogCiAgICAgImltcG9ydGVkL3czYy93ZWJkcml2ZXIvdGVzdHMv Y2xvc2Vfd2luZG93L2Nsb3NlLnB5Ijogewo=