21827 2008-10-23 03:12:36 -0700 Memory leak in webkit_web_view_load_string 2008-10-27 14:46:33 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 michael webkit-unassigned mrowe oldest_to_newest 96310 0 michael 2008-10-23 03:12:36 -0700 The Gtk method webkit_web_view_load_string() takes a string as gchar* argument to set the page content. This string is passed down to a SharedBuffer, but duplicated before with strdup(), this memory is lost (verified with valgrind). void webkit_web_view_load_string(WebKitWebView* webView, const gchar* content, const gchar* contentMimeType, const gchar* contentEncoding, const { .... RefPtr<SharedBuffer> sharedBuffer = SharedBuffer::create(strdup(content), strlen(content)); SubstituteData substituteData(sharedBuffer.release(), contentMimeType ? String(contentMimeType) : "text/html", contentEncoding ? String(conte .... } 96311 1 24595 michael 2008-10-23 03:13:42 -0700 Created attachment 24595 Patch to fix memory leak in webkit_web_view_load_string() 96400 2 mrowe 2008-10-23 13:34:58 -0700 This looks fine, but the patch needs a ChangeLog entry. Can you please add one, and upload the new patch? Be sure to set the "review" flag on the attachment to "?" when you upload the patch to indicate that you'd like it reviewed! 96499 3 24638 michael 2008-10-24 04:44:01 -0700 Created attachment 24638 Patch to fix memory leak in webkit_web_view_load_string() added ChangeLog entry and requested review 96511 4 24638 alp 2008-10-24 09:28:28 -0700 Comment on attachment 24638 Patch to fix memory leak in webkit_web_view_load_string() r=me 96786 5 jmalonzo 2008-10-27 14:46:33 -0700 Landed in r37903. Cheers. 24595 2008-10-23 03:13:42 -0700 2008-10-24 04:44:01 -0700 Patch to fix memory leak in webkit_web_view_load_string() webview-leak.patch text/plain 740 michael LS0tIC4vV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAub3JpZwkyMDA4LTEwLTA1 IDAxOjUxOjE4LjAwMDAwMDAwMCArMDIwMAorKysgLi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3 ZWJ2aWV3LmNwcAkyMDA4LTEwLTIzIDA5OjM1OjE4LjAwMDAwMDAwMCArMDIwMApAQCAtMTY1Niw3 ICsxNjU2LDcgQEAKICAgICBGcmFtZSogZnJhbWUgPSBjb3JlKHdlYlZpZXcpLT5tYWluRnJhbWUo KTsKIAogICAgIEtVUkwgdXJsKGJhc2VVcmkgPyBTdHJpbmc6OmZyb21VVEY4KGJhc2VVcmkpIDog IiIpOwotICAgIFJlZlB0cjxTaGFyZWRCdWZmZXI+IHNoYXJlZEJ1ZmZlciA9IFNoYXJlZEJ1ZmZl cjo6Y3JlYXRlKHN0cmR1cChjb250ZW50KSwgc3RybGVuKGNvbnRlbnQpKTsKKyAgICBSZWZQdHI8 U2hhcmVkQnVmZmVyPiBzaGFyZWRCdWZmZXIgPSBTaGFyZWRCdWZmZXI6OmNyZWF0ZShjb250ZW50 LCBzdHJsZW4oY29udGVudCkpOwogICAgIFN1YnN0aXR1dGVEYXRhIHN1YnN0aXR1dGVEYXRhKHNo YXJlZEJ1ZmZlci5yZWxlYXNlKCksIGNvbnRlbnRNaW1lVHlwZSA/IFN0cmluZyhjb250ZW50TWlt ZVR5cGUpIDogInRleHQvaHRtbCIsIGNvbnRlbnRFbmNvZGluZyA/IFN0cmluZyhjb250ZW50RW5j b2RpbmcpIDogIlVURi04IiwgS1VSTCgiYWJvdXQ6YmxhbmsiKSwgdXJsKTsKIAogICAgIGZyYW1l LT5sb2FkZXIoKS0+bG9hZChSZXNvdXJjZVJlcXVlc3QodXJsKSwgc3Vic3RpdHV0ZURhdGEpOwo= 24638 2008-10-24 04:44:01 -0700 2008-10-24 09:28:28 -0700 Patch to fix memory leak in webkit_web_view_load_string() webkit-webview-load-string-leak.patch text/plain 1385 michael ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggNTQ4ZTljZS4uYTBhYjM3OSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAwOC0xMC0yNCAg TWljaGFlbCBUcm9zcyAgPG1pY2hhZWxAdHJvc3Mub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTgyNworICAgICAgICBbR1RLXSBGaXggbWVtb3J5IGxlYWsgaW4gd2Via2l0 X3dlYl92aWV3X2xvYWRfc3RyaW5nCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5j cHA6CisKIDIwMDgtMTAtMjIgIEFscCBUb2tlciAgPGFscEBudWFudGkuY29tPgogCiAgICAgICAg IEJ1aWxkIGZpeCBmb3Igb2xkZXIgR1RLKyB2ZXJzaW9ucyB3aGVyZSBHVEtfVFlQRV9UQVJHRVRf TElTVCBpc24ndApkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5j cHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAppbmRleCAzYWMwOGMyLi41 OWYxMmY4IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAor KysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtMTcxMSw3ICsxNzEx LDcgQEAgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfbG9hZF9zdHJpbmcoV2ViS2l0V2ViVmlldyogd2Vi VmlldywgY29uc3QgZ2NoYXIqIGNvbnRlbnQsIGMKICAgICBGcmFtZSogZnJhbWUgPSBjb3JlKHdl YlZpZXcpLT5tYWluRnJhbWUoKTsKIAogICAgIEtVUkwgdXJsKGJhc2VVcmkgPyBTdHJpbmc6OmZy b21VVEY4KGJhc2VVcmkpIDogIiIpOwotICAgIFJlZlB0cjxTaGFyZWRCdWZmZXI+IHNoYXJlZEJ1 ZmZlciA9IFNoYXJlZEJ1ZmZlcjo6Y3JlYXRlKHN0cmR1cChjb250ZW50KSwgc3RybGVuKGNvbnRl bnQpKTsKKyAgICBSZWZQdHI8U2hhcmVkQnVmZmVyPiBzaGFyZWRCdWZmZXIgPSBTaGFyZWRCdWZm ZXI6OmNyZWF0ZShjb250ZW50LCBzdHJsZW4oY29udGVudCkpOwogICAgIFN1YnN0aXR1dGVEYXRh IHN1YnN0aXR1dGVEYXRhKHNoYXJlZEJ1ZmZlci5yZWxlYXNlKCksIGNvbnRlbnRNaW1lVHlwZSA/ IFN0cmluZyhjb250ZW50TWltZVR5cGUpIDogInRleHQvaHRtbCIsIGNvbnRlbnRFbmNvZGluZyA/ IFN0cmluZyhjb250ZW50RW5jb2RpbmcpIDogIlVURi04IiwgS1VSTCgiYWJvdXQ6YmxhbmsiKSwg dXJsKTsKIAogICAgIGZyYW1lLT5sb2FkZXIoKS0+bG9hZChSZXNvdXJjZVJlcXVlc3QodXJsKSwg c3Vic3RpdHV0ZURhdGEpOwo=