218268 2020-10-27 17:55:15 -0700 Unexpected txt file: .../WebKitLegacy.framework/.../Sources.txt 2020-10-27 19:26:02 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin achristensen bburg joepeck keith_miller simon.fraser thorton webkit-bug-importer oldest_to_newest 1702170 0 krollin 2020-10-27 17:55:15 -0700 Sources.txt and SourcesCocoa.txt were added to the WebKitLegacy project in https://trac.webkit.org/changeset/247401 as targets of the WebKitLegacy target. This caused them to be treated as resources and so were copied to the framework's Resources directory on a build. These files don't need to be included in the build, and so need to be removed from that target. 1702171 1 krollin 2020-10-27 17:56:14 -0700 <rdar://problem/70742539> 1702175 2 412489 krollin 2020-10-27 18:07:52 -0700 Created attachment 412489 Patch 1702177 3 thorton 2020-10-27 18:12:46 -0700 Does this leave them in the project? I think they should be in the project, just not a part of any target 1702178 4 krollin 2020-10-27 18:13:36 -0700 Yes, they're still in the project, so you can select and open them. They were merely removed from the target. 1702180 5 keith_miller 2020-10-27 18:19:22 -0700 Seems reasonable to me. 1702181 6 simon.fraser 2020-10-27 18:20:47 -0700 Don't we have a script that checks for files added to frameworks by mistake? Why didn't it catch this? 1702182 7 simon.fraser 2020-10-27 18:22:48 -0700 "Check For Inappropriate Files In Framework" 1702185 8 krollin 2020-10-27 18:28:41 -0700 check-for-inappropriate-files-in-framework needs to be attached to WebKitLegacy (and JavaScriptCore) and updated to scan for *.txt files. 1702204 9 ews-feeder 2020-10-27 19:26:01 -0700 Committed r269093: <https://trac.webkit.org/changeset/269093> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412489. 412489 2020-10-27 18:07:52 -0700 2020-10-27 19:26:02 -0700 Patch bug-218268-20201027180752.patch text/plain 3411 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCmluZGV4IGZiNjcy N2FkZjYyODMyMzczZDNiYzI0MWJiMDhhZTMwMDQxYjUyM2QuLmI5NzMzYzJhZWJiNGE3YmUxYzY3 NzY4MGZmY2I3NTBlY2Q0MjRkYjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMjAtMTAtMjcgIEtlaXRoIFJvbGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgorCisgICAg ICAgIFVuZXhwZWN0ZWQgdHh0IGZpbGU6IC4uLi9XZWJLaXRMZWdhY3kuZnJhbWV3b3JrLy4uLi9T b3VyY2VzLnR4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjE4MjY4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MDc0MjUzOT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTb3VyY2VzLnR4dCBhbmQgU291 cmNlc0NvY29hLnR4dCB3ZXJlIGFkZGVkIHRvIHRoZSBXZWJLaXRMZWdhY3kKKyAgICAgICAgcHJv amVjdCBpbiBodHRwczovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjQ3NDAxIGFzIHRhcmdl dHMgb2YgdGhlCisgICAgICAgIFdlYktpdExlZ2FjeSB0YXJnZXQuIFRoaXMgY2F1c2VkIHRoZW0g dG8gYmUgdHJlYXRlZCBhcyByZXNvdXJjZXMgYW5kCisgICAgICAgIHNvIHdlcmUgY29waWVkIHRv IHRoZSBmcmFtZXdvcmsncyBSZXNvdXJjZXMgZGlyZWN0b3J5IG9uIGEgYnVpbGQuCisgICAgICAg IFRoZXNlIGZpbGVzIGRvbid0IG5lZWQgdG8gYmUgaW5jbHVkZWQgaW4gdGhlIGJ1aWxkLCBhbmQg c28gYXJlIHJlbW92ZWQKKyAgICAgICAgZnJvbSB0aGF0IHRhcmdldC4KKworICAgICAgICAqIFdl YktpdExlZ2FjeS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOgorCiAyMDIwLTEwLTE3ICBTYW0g V2VpbmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBbUHJlZmVyZW5jZXNdIEFkZCBp bmZyYXN0cnVjdHVyZSBmb3IgZ2VuZXJhdGluZyBwcmVmZXJlbmNlcyBmb3IgV2luZG93cyBXZWJL aXRMZWdhY3kKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvV2ViS2l0TGVnYWN5Lnhj b2RlcHJvai9wcm9qZWN0LnBieHByb2ogYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L1dlYktpdExlZ2Fj eS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IDQ3OGQ1ZGI4MTZhOGY2YjAxNjcyNmMz NDVkYzE4NDM1ZjFjZWRkZjIuLjExYmE0NGNlYzA5N2RlMzMzNmYzZjk1MThlZjM3ZGJlOGI4OTFk OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvV2ViS2l0TGVnYWN5Lnhjb2RlcHJv ai9wcm9qZWN0LnBieHByb2oKKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9XZWJLaXRMZWdhY3ku eGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagpAQCAtMTcxLDggKzE3MSw2IEBACiAJCTU5OEFEQTQ2 MTIwMjI3NTAwMEFCQUU0RSAvKiBXZWJEZXZpY2VPcmllbnRhdGlvblByb3ZpZGVyLmggaW4gSGVh ZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA1OThBREE0NTEyMDIyNzUw MDBBQkFFNEUgLyogV2ViRGV2aWNlT3JpZW50YXRpb25Qcm92aWRlci5oICovOyBzZXR0aW5ncyA9 IHtBVFRSSUJVVEVTID0gKFByaXZhdGUsICk7IH07IH07CiAJCTVDNDBDRDIxMjJEOEY5QzAwMEU5 REFENSAvKiBQb3B1cE1lbnVNYWMubW0gaW4gU291cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZp bGU7IGZpbGVSZWYgPSA3QzAxQ0I4MjE3MzQzNUM5MDBDNUQ4MDcgLyogUG9wdXBNZW51TWFjLm1t ICovOyB9OwogCQk1QzQwQ0QyMjIyRDhGOUMzMDBFOURBRDUgLyogU2VhcmNoUG9wdXBNZW51TWFj Lm1tIGluIFNvdXJjZXMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gN0MwMUNC ODQxNzM0MzVDOTAwQzVEODA3IC8qIFNlYXJjaFBvcHVwTWVudU1hYy5tbSAqLzsgfTsKLQkJNUM5 RDkyNUEyMkQ3RThBRDAwOEU5MjY2IC8qIFNvdXJjZXMudHh0IGluIFJlc291cmNlcyAqLyA9IHtp c2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA1QzlEOTI1ODIyRDdFOEFEMDA4RTkyNjYgLyog U291cmNlcy50eHQgKi87IH07Ci0JCTVDOUQ5MjVCMjJEN0U4QUQwMDhFOTI2NiAvKiBTb3VyY2Vz Q29jb2EudHh0IGluIFJlc291cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYg PSA1QzlEOTI1OTIyRDdFOEFEMDA4RTkyNjYgLyogU291cmNlc0NvY29hLnR4dCAqLzsgfTsKIAkJ NUM5RUYyRjUyMUYwNjFCRTAwM0JEQzU2IC8qIFBhZ2VTdG9yYWdlU2Vzc2lvblByb3ZpZGVyLmgg aW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA1QzlFRjJGNDIx RjA2MUJFMDAzQkRDNTYgLyogUGFnZVN0b3JhZ2VTZXNzaW9uUHJvdmlkZXIuaCAqLzsgfTsKIAkJ NUNBNDZFNzgyMUYxNDUxRDAwQ0U4NkI0IC8qIE5ldHdvcmtTdG9yYWdlU2Vzc2lvbk1hcC5oIGlu IEhlYWRlcnMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gNUNBNDZFNzYyMUYx NDUxRDAwQ0U4NkI0IC8qIE5ldHdvcmtTdG9yYWdlU2Vzc2lvbk1hcC5oICovOyB9OwogCQk1Q0U0 NEY0QTIwNkQ3MEVBMDAzRUZEMDEgLyogUGluZ0hhbmRsZS5oIGluIEhlYWRlcnMgKi8gPSB7aXNh ID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gNUNFNDRGNDkyMDZENzBFOTAwM0VGRDAxIC8qIFBp bmdIYW5kbGUuaCAqLzsgfTsKQEAgLTMyNzcsOCArMzI3NSw2IEBACiAJCQkJN0NDRTc2NkIyNTIy M0JDODAwM0M3QkQyIC8qIGdlbmVyYXRlLXByZWZlcmVuY2VzLnNoIGluIFJlc291cmNlcyAqLywK IAkJCQlBMTM4MkNERjI0QjE1QTUxMDAxNjQ1QjAgLyogTGFCYW5xdWVQb3N0YWxlUXVpcmtzLmpz IGluIFJlc291cmNlcyAqLywKIAkJCQkyOUFFRjk2MDEzNEM3NkZCMDBGRTUwOTYgLyogT3V0bG9v a1F1aXJrc1VzZXJTY3JpcHQuanMgaW4gUmVzb3VyY2VzICovLAotCQkJCTVDOUQ5MjVBMjJEN0U4 QUQwMDhFOTI2NiAvKiBTb3VyY2VzLnR4dCBpbiBSZXNvdXJjZXMgKi8sCi0JCQkJNUM5RDkyNUIy MkQ3RThBRDAwOEU5MjY2IC8qIFNvdXJjZXNDb2NvYS50eHQgaW4gUmVzb3VyY2VzICovLAogCQkJ CTkzOTgxMEI3MDgyNEJGMDEwMDhERjAzOCAvKiB1cmxfaWNvbi50aWZmIGluIFJlc291cmNlcyAq LywKIAkJCQk5Mzk4MTBCNTA4MjRCRjAxMDA4REYwMzggLyogV2ViQXV0aGVudGljYXRpb25QYW5l bC54aWIgaW4gUmVzb3VyY2VzICovLAogCQkJCTVERTgzQTdBMEQwRjdGOTQwMENBRDEyQSAvKiBX ZWJKYXZhU2NyaXB0VGV4dElucHV0UGFuZWwueGliIGluIFJlc291cmNlcyAqLywK