218263 2020-10-27 14:25:04 -0700 Remove leftover DiagnosticLoggingKey after r268458 2020-10-27 15:22:06 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham darin oldest_to_newest 1702086 0 bfulgham 2020-10-27 14:25:04 -0700 When we removed the old ITP telemetry in Bug 217665, we didn't remove the DiagnosticLoggingKey for this content. To avoid future confusion, let's remove it. 1702088 1 bfulgham 2020-10-27 14:26:05 -0700 <rdar://problem/70738034> 1702091 2 412465 bfulgham 2020-10-27 14:28:40 -0700 Created attachment 412465 Patch 1702092 3 412465 darin 2020-10-27 14:31:34 -0700 Comment on attachment 412465 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412465&action=review > Source/WebCore/ChangeLog:3 > + REGRESSION(r268458): Remove leftover DiagnosticLoggingKey Seems really strange to call this REGRESSION. An unused function has no effect other than making the binary a little bigger. 1702095 4 bfulgham 2020-10-27 14:34:26 -0700 (In reply to Darin Adler from comment #3) > Comment on attachment 412465 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=412465&action=review > > > Source/WebCore/ChangeLog:3 > > + REGRESSION(r268458): Remove leftover DiagnosticLoggingKey > > Seems really strange to call this REGRESSION. > > An unused function has no effect other than making the binary a little > bigger. Fair point -- I'll just reference the change where we forgot to remove this. 1702096 5 412466 bfulgham 2020-10-27 14:36:34 -0700 Created attachment 412466 Patch for landing 1702126 6 ews-feeder 2020-10-27 15:22:05 -0700 Committed r269078: <https://trac.webkit.org/changeset/269078> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412466. 412465 2020-10-27 14:28:40 -0700 2020-10-27 14:36:33 -0700 Patch bug-218263-20201027142839.patch text/plain 2558 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDY4MmJmZGY5YjBhMzhi MmFjNWYzNmJlY2IzMThjNzU2YmJjZTBkMy4uMDBmZTg0OTkzM2FjZWViYzBkYTRiZjQ4Y2QyZDBk M2RhMTU1YjdmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTEwLTI3ICBCcmVu dCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI2 ODQ1OCk6IFJlbW92ZSBsZWZ0b3ZlciBEaWFnbm9zdGljTG9nZ2luZ0tleQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4MjYzCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS83MDczODAzND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZW1vdmUgdGhlIGxlZnRvdmVyIERpYWdub3N0aWNLZXkgZm9yIFJlc291 cmNlTG9hZFN0YXRpc3RpY3MgdGVsZW1ldHJ5IG5vdyB0aGF0IHRoZQorICAgICAgICBhY3R1YWwg ZGF0YSBpcyBubyBsb25nZXIgZ2VuZXJhdGVkLgorCisgICAgICAgICogcGFnZS9EaWFnbm9zdGlj TG9nZ2luZ0tleXMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGlhZ25vc3RpY0xvZ2dpbmdLZXlz OjpyZXNvdXJjZUxvYWRTdGF0aXN0aWNzVGVsZW1ldHJ5S2V5KTogRGVsZXRlZC4KKyAgICAgICAg KiBwYWdlL0RpYWdub3N0aWNMb2dnaW5nS2V5cy5oOgorCiAyMDIwLTEwLTI3ICBNYXJ0aW4gUm9i aW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBPdmVyZmxvdyBzY3JvbGxJ bnRvVmlldyB3cm9uZyB3aXRoIGJvcmRlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRGlhZ25vc3RpY0xvZ2dpbmdLZXlzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRGlhZ25v c3RpY0xvZ2dpbmdLZXlzLmNwcAppbmRleCBjNzgyMmFjZDE5NDdhOWI0YTIzMDljOTNhMzc4MzMw YzhkYWQ2YzgxLi4wYWYwN2NmOGJhNDgxMzBmNDM3OGQ4MjdmMTZjMGMwOTY4MmViZTQyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RpYWdub3N0aWNMb2dnaW5nS2V5cy5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGFnZS9EaWFnbm9zdGljTG9nZ2luZ0tleXMuY3BwCkBAIC0xLDUg KzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAxMi0yMDE4IEFwcGxlIEluYy4gQWxsIHJp Z2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMi0yMDIwIEFwcGxlIEluYy4gQWxs IHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJj ZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJl IHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtODY4 LDExICs4NjgsNiBAQCBTdHJpbmcgRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpiYWNrZ3JvdW5kQ1BV VXNhZ2VUb0RpYWdub3N0aWNMb2dnaW5nS2V5KGRvdWJsZSBjcAogICAgICAgICByZXR1cm4gIjUw dG83MCJfczsKICAgICByZXR1cm4gIm92ZXI3MCJfczsKIH0KLQotU3RyaW5nIERpYWdub3N0aWNM b2dnaW5nS2V5czo6cmVzb3VyY2VMb2FkU3RhdGlzdGljc1RlbGVtZXRyeUtleSgpCi17Ci0gICAg cmV0dXJuICJyZXNvdXJjZUxvYWRTdGF0aXN0aWNzVGVsZW1ldHJ5Il9zOwotfQogICAgIAogfSAv LyBuYW1lc3BhY2UgV2ViQ29yZQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Rp YWdub3N0aWNMb2dnaW5nS2V5cy5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9EaWFnbm9zdGljTG9n Z2luZ0tleXMuaAppbmRleCA4NTJmOWE1YWU1ZWJkZGQ2NTM2ODVlOTc5YjgzZjE0Mjc0YTA5NjBm Li42MjhhNjI3NjZkMWY1YmViMGJiYTMxM2NjNmZiOTMzMTlmYjU0NDE1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wYWdlL0RpYWdub3N0aWNMb2dnaW5nS2V5cy5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRGlhZ25vc3RpY0xvZ2dpbmdLZXlzLmgKQEAgLTE5Myw4ICsxOTMsNiBAQCBw dWJsaWM6CiAgICAgV0VCQ09SRV9FWFBPUlQgc3RhdGljIFN0cmluZyBtZW1vcnlVc2FnZVRvRGlh Z25vc3RpY0xvZ2dpbmdLZXkodWludDY0X3QgbWVtb3J5VXNhZ2UpOwogICAgIFdFQkNPUkVfRVhQ T1JUIHN0YXRpYyBTdHJpbmcgZm9yZWdyb3VuZENQVVVzYWdlVG9EaWFnbm9zdGljTG9nZ2luZ0tl eShkb3VibGUgY3B1VXNhZ2UpOwogICAgIFdFQkNPUkVfRVhQT1JUIHN0YXRpYyBTdHJpbmcgYmFj a2dyb3VuZENQVVVzYWdlVG9EaWFnbm9zdGljTG9nZ2luZ0tleShkb3VibGUgY3B1VXNhZ2UpOwot ICAgIAotICAgIFdFQkNPUkVfRVhQT1JUIHN0YXRpYyBTdHJpbmcgcmVzb3VyY2VMb2FkU3RhdGlz dGljc1RlbGVtZXRyeUtleSgpOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo= 412466 2020-10-27 14:36:34 -0700 2020-10-27 15:22:06 -0700 Patch for landing bug-218263-20201027143634.patch text/plain 2548 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDY4MmJmZGY5YjBhMzhi MmFjNWYzNmJlY2IzMThjNzU2YmJjZTBkMy4uOGZlNGE3MjM2YWMzNWYwZjQzYzkzMGRjNzRiNWFk MDFlZDQ2YjhjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTEwLTI3ICBCcmVu dCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBsZWZ0b3Zl ciBEaWFnbm9zdGljTG9nZ2luZ0tleSBhZnRlciByMjY4NDU4CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTgyNjMKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzcwNzM4MDM0PgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAg ICAgIFJlbW92ZSB0aGUgbGVmdG92ZXIgRGlhZ25vc3RpY0tleSBmb3IgUmVzb3VyY2VMb2FkU3Rh dGlzdGljcyB0ZWxlbWV0cnkgbm93IHRoYXQgdGhlCisgICAgICAgIGFjdHVhbCBkYXRhIGlzIG5v IGxvbmdlciBnZW5lcmF0ZWQuCisKKyAgICAgICAgKiBwYWdlL0RpYWdub3N0aWNMb2dnaW5nS2V5 cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEaWFnbm9zdGljTG9nZ2luZ0tleXM6OnJlc291cmNl TG9hZFN0YXRpc3RpY3NUZWxlbWV0cnlLZXkpOiBEZWxldGVkLgorICAgICAgICAqIHBhZ2UvRGlh Z25vc3RpY0xvZ2dpbmdLZXlzLmg6CisKIDIwMjAtMTAtMjcgIE1hcnRpbiBSb2JpbnNvbiAgPG1y b2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIE92ZXJmbG93IHNjcm9sbEludG9WaWV3IHdy b25nIHdpdGggYm9yZGVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9EaWFnbm9z dGljTG9nZ2luZ0tleXMuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9EaWFnbm9zdGljTG9nZ2lu Z0tleXMuY3BwCmluZGV4IGM3ODIyYWNkMTk0N2E5YjRhMjMwOWM5M2EzNzgzMzBjOGRhZDZjODEu LjBhZjA3Y2Y4YmE0ODEzMGY0Mzc4ZDgyN2YxNmMwYzA5NjgyZWJlNDIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRGlhZ25vc3RpY0xvZ2dpbmdLZXlzLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0RpYWdub3N0aWNMb2dnaW5nS2V5cy5jcHAKQEAgLTEsNSArMSw1IEBACiAv KgotICogQ29weXJpZ2h0IChDKSAyMDEyLTIwMTggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2Vy dmVkLgorICogQ29weXJpZ2h0IChDKSAyMDEyLTIwMjAgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJl c2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5h cnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVk IHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC04NjgsMTEgKzg2OCw2 IEBAIFN0cmluZyBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OmJhY2tncm91bmRDUFVVc2FnZVRvRGlh Z25vc3RpY0xvZ2dpbmdLZXkoZG91YmxlIGNwCiAgICAgICAgIHJldHVybiAiNTB0bzcwIl9zOwog ICAgIHJldHVybiAib3ZlcjcwIl9zOwogfQotCi1TdHJpbmcgRGlhZ25vc3RpY0xvZ2dpbmdLZXlz OjpyZXNvdXJjZUxvYWRTdGF0aXN0aWNzVGVsZW1ldHJ5S2V5KCkKLXsKLSAgICByZXR1cm4gInJl c291cmNlTG9hZFN0YXRpc3RpY3NUZWxlbWV0cnkiX3M7Ci19CiAgICAgCiB9IC8vIG5hbWVzcGFj ZSBXZWJDb3JlCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRGlhZ25vc3RpY0xv Z2dpbmdLZXlzLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RpYWdub3N0aWNMb2dnaW5nS2V5cy5o CmluZGV4IDg1MmY5YTVhZTVlYmRkZDY1MzY4NWU5NzliODNmMTQyNzRhMDk2MGYuLjYyOGE2Mjc2 NmQxZjViZWIwYmJhMzEzY2M2ZmI5MzMxOWZiNTQ0MTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRGlhZ25vc3RpY0xvZ2dpbmdLZXlzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9EaWFnbm9zdGljTG9nZ2luZ0tleXMuaApAQCAtMTkzLDggKzE5Myw2IEBAIHB1YmxpYzoKICAg ICBXRUJDT1JFX0VYUE9SVCBzdGF0aWMgU3RyaW5nIG1lbW9yeVVzYWdlVG9EaWFnbm9zdGljTG9n Z2luZ0tleSh1aW50NjRfdCBtZW1vcnlVc2FnZSk7CiAgICAgV0VCQ09SRV9FWFBPUlQgc3RhdGlj IFN0cmluZyBmb3JlZ3JvdW5kQ1BVVXNhZ2VUb0RpYWdub3N0aWNMb2dnaW5nS2V5KGRvdWJsZSBj cHVVc2FnZSk7CiAgICAgV0VCQ09SRV9FWFBPUlQgc3RhdGljIFN0cmluZyBiYWNrZ3JvdW5kQ1BV VXNhZ2VUb0RpYWdub3N0aWNMb2dnaW5nS2V5KGRvdWJsZSBjcHVVc2FnZSk7Ci0gICAgCi0gICAg V0VCQ09SRV9FWFBPUlQgc3RhdGljIFN0cmluZyByZXNvdXJjZUxvYWRTdGF0aXN0aWNzVGVsZW1l dHJ5S2V5KCk7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==