218260 2020-10-27 14:01:34 -0700 Web Inspector: Search: don't steal focus from the search field when shown 2020-10-27 14:49:23 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=167073 InRadar P2 Normal --- 1 hi hi bburg hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1702068 0 hi 2020-10-27 14:01:34 -0700 # STEPS TO REPRODUCE 1. inspect any page 2. ⇧⌘F to show the Search Tab 3. search for "div" 4. close Web Inspector 5. open Web Inspector 6. ⇧⌘F to show the Search Tab # EXPECTED search field should stay focused even after search results populate # ACTUAL first search result steals focus from the search field 1702070 1 412462 hi 2020-10-27 14:02:58 -0700 Created attachment 412462 Patch 1702079 2 412462 bburg 2020-10-27 14:17:38 -0700 Comment on attachment 412462 Patch r=me 1702108 3 ews-feeder 2020-10-27 14:48:40 -0700 Committed r269074: <https://trac.webkit.org/changeset/269074> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412462. 1702112 4 webkit-bug-importer 2020-10-27 14:49:23 -0700 <rdar://problem/70739363> 412462 2020-10-27 14:02:58 -0700 2020-10-27 14:48:41 -0700 Patch bug-218260-20201027140257.patch text/plain 2750 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDdjNGVjZmRjYTAwZWE0ZDFhNzA3ZDMzODZhMDBl MTNiOWY1YzhmYzYuLjBjZWM2ZjdhZGIxNzkzODMxOTYzNDlkNjhmYmZhNjdhM2U4NTQ1MDggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTEwLTI3ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBT ZWFyY2g6IGRvbid0IHN0ZWFsIGZvY3VzIGZyb20gdGhlIHNlYXJjaCBmaWVsZCB3aGVuIHNob3du CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTgyNjAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvVmlld3MvU2VhcmNoU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV0kuU2VhcmNo U2lkZWJhclBhbmVsLnByb3RvdHlwZS5mb2N1c1NlYXJjaEZpZWxkKToKKyAgICAgICAgKFdJLlNl YXJjaFNpZGViYXJQYW5lbC5wcm90b3R5cGUucGVyZm9ybVNlYXJjaC5jcmVhdGVUcmVlRWxlbWVu dEZvck1hdGNoT2JqZWN0KToKKwogMjAyMC0xMC0yNiAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0Bh cHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogY29uc29sZSBjb21tYW5kIGxpbmUg QVBJIHNob3VsZCBiZSBleHBvc2VkIHRvIGJyZWFrcG9pbnQgY29uZGl0aW9ucy9hY3Rpb25zCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZWFy Y2hTaWRlYmFyUGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9TZWFyY2hTaWRlYmFyUGFuZWwuanMKaW5kZXggNGI5ZDM3YjVmMWZkYjgzNTQ5YmI4MGJi N2E2YmZhZjZlZmI1NTVlNC4uMGFhMTU2NjYzMDY5YzVjMTFhYzE3ODkyZDY5ZmZhMmE0ODIxOGI2 NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv U2VhcmNoU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1NlYXJjaFNpZGViYXJQYW5lbC5qcwpAQCAtOTMsMTAgKzkzLDEwIEBAIFdJ LlNlYXJjaFNpZGViYXJQYW5lbCA9IGNsYXNzIFNlYXJjaFNpZGViYXJQYW5lbCBleHRlbmRzIFdJ Lk5hdmlnYXRpb25TaWRlYmFyUGFuCiAgICAgICAgIHRoaXMuX2lucHV0RWxlbWVudC5zZWxlY3Qo KTsKIAogICAgICAgICBpZiAocGVyZm9ybVNlYXJjaCkKLSAgICAgICAgICAgIHRoaXMucGVyZm9y bVNlYXJjaCh0aGlzLl9pbnB1dEVsZW1lbnQudmFsdWUpOworICAgICAgICAgICAgdGhpcy5wZXJm b3JtU2VhcmNoKHRoaXMuX2lucHV0RWxlbWVudC52YWx1ZSwge29taXRGb2N1czogdHJ1ZX0pOwog ICAgIH0KIAotICAgIHBlcmZvcm1TZWFyY2goc2VhcmNoUXVlcnkpCisgICAgcGVyZm9ybVNlYXJj aChzZWFyY2hRdWVyeSwge29taXRGb2N1c30gPSB7fSkKICAgICB7CiAgICAgICAgIHRoaXMuX2lu cHV0RWxlbWVudC52YWx1ZSA9IHNlYXJjaFF1ZXJ5OwogICAgICAgICB0aGlzLl9zZWFyY2hRdWVy eVNldHRpbmcudmFsdWUgPSBzZWFyY2hRdWVyeTsKQEAgLTE0MSw3ICsxNDEsNyBAQCBXSS5TZWFy Y2hTaWRlYmFyUGFuZWwgPSBjbGFzcyBTZWFyY2hTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXSS5OYXZp Z2F0aW9uU2lkZWJhclBhbgogICAgICAgICAgICAgY3JlYXRlU2VhcmNoaW5nUGxhY2Vob2xkZXIo KTsKICAgICAgICAgICAgIFdJLndoZW5UYXJnZXRzQXZhaWxhYmxlKCkudGhlbigoKSA9PiB7CiAg ICAgICAgICAgICAgICAgaWYgKHRoaXMuX3NlYXJjaFF1ZXJ5U2V0dGluZy52YWx1ZSA9PT0gc2Vh cmNoUXVlcnkpCi0gICAgICAgICAgICAgICAgICAgIHRoaXMucGVyZm9ybVNlYXJjaChzZWFyY2hR dWVyeSk7CisgICAgICAgICAgICAgICAgICAgIHRoaXMucGVyZm9ybVNlYXJjaChzZWFyY2hRdWVy eSwge29taXRGb2N1c30pOwogICAgICAgICAgICAgfSk7CiAgICAgICAgICAgICByZXR1cm47CiAg ICAgICAgIH0KQEAgLTE3Niw4ICsxNzYsMTAgQEAgV0kuU2VhcmNoU2lkZWJhclBhbmVsID0gY2xh c3MgU2VhcmNoU2lkZWJhclBhbmVsIGV4dGVuZHMgV0kuTmF2aWdhdGlvblNpZGViYXJQYW4KIAog ICAgICAgICAgICAgcGFyZW50VHJlZUVsZW1lbnQuYXBwZW5kQ2hpbGQobWF0Y2hUcmVlRWxlbWVu dCk7CiAKLSAgICAgICAgICAgIGlmICghdGhpcy5jb250ZW50VHJlZU91dGxpbmUuc2VsZWN0ZWRU cmVlRWxlbWVudCkKLSAgICAgICAgICAgICAgICBtYXRjaFRyZWVFbGVtZW50LnJldmVhbEFuZFNl bGVjdChmYWxzZSwgdHJ1ZSk7CisgICAgICAgICAgICBpZiAoIXRoaXMuY29udGVudFRyZWVPdXRs aW5lLnNlbGVjdGVkVHJlZUVsZW1lbnQpIHsKKyAgICAgICAgICAgICAgICBjb25zdCBzZWxlY3Rl ZEJ5VXNlciA9IHRydWU7CisgICAgICAgICAgICAgICAgbWF0Y2hUcmVlRWxlbWVudC5yZXZlYWxB bmRTZWxlY3Qob21pdEZvY3VzID8/IGZhbHNlLCBzZWxlY3RlZEJ5VXNlcik7CisgICAgICAgICAg ICB9CiAgICAgICAgIH0KIAogICAgICAgICBmdW5jdGlvbiBmb3JFYWNoTWF0Y2gobGluZUNvbnRl bnQsIGNhbGxiYWNrKQo=