21826 2008-10-23 01:53:11 -0700 Add accessor for SecurityOrigin::m_domainWasSetInDOM 2008-10-23 10:20:51 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned abarth sam oldest_to_newest 96305 0 abarth 2008-10-23 01:53:11 -0700 It will help Chromium unfork SecurityOrigin.cpp if we add an accessor for SecurityOrigin::m_domainWasSetInDOM. If this flag is false, Chromium can do a same-origin check in one pointer comparison by atomizing the toString() of the SecurityOrigin (with some other caveats). Currently they have YASOTSF (Yet Another SecurityOrigin toString Function) called SecurityOrigin::securityToken that knows about m_domainWasSetInDOM. Adding an accessor for m_domainWasSetInDOM seems better than adding this function to our tree. Now, if only I can get rid of the YASOTSF called SecurityOrigin::databaseIdentifier, my plans for grand unification of the SecurityOrigin toString methods will be complete! Patch forthcoming. 96309 1 24594 abarth 2008-10-23 03:02:25 -0700 Created attachment 24594 le patch 96328 2 24594 sam 2008-10-23 06:46:50 -0700 Comment on attachment 24594 le patch + * Copyright (C) 2007-2008 Apple Inc. All rights reserved. We like to use comma delineated years. void setDomainFromDOM(const String& newDomain); + bool domainWasSetInDOM() const { return m_domainWasSetInDOM; } These should be paragraphed together. I am a little unclear about why this is necessary, the SecurityOrigin it self should be sufficient for a fast compare. Perhaps we can remove this later. 96344 3 abarth 2008-10-23 10:20:51 -0700 Fixed in http://trac.webkit.org/changeset/37814 > I am a little unclear about why this is necessary, the SecurityOrigin it self > should be sufficient for a fast compare. Perhaps we can remove this later. Yeah, maybe there is a better long term solution here. I think the fast path for comparing SecurityOrigins in V8 gets inlined into the JITed code and they want to avoid the function call overhead. (I might be wrong about this, V8 is pretty mysterious to me.) It's similar to how JavaScriptCore doesn't bother calling SecurityOrigin::canAccess if a frame is accessing itself (the most common case) but taken to a little further extreme. 24594 2008-10-23 03:02:25 -0700 2008-10-23 06:46:50 -0700 le patch was-set-in-dom.patch text/plain 2052 abarth RnJvbSBmZDE3NWVkYzlkZmJmOGE2NzVjOWI2ZDJiNTAyYjJjMWUxNDY2N2JlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIEJhcnRoIDxhYmFydGhAYXJjdGljYS5sb2NhbD4KRGF0 ZTogVGh1LCAyMyBPY3QgMjAwOCAwMzowMToyNiAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMDgt MTAtMjMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KCiAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTgyNgoKICAgICAgICBBZGQgYWNjZXNzb3IgZm9yIFNlY3VyaXR5T3JpZ2lu OjptX2RvbWFpbldhc1NldEluRE9NLgoKICAgICAgICAqIHBhZ2UvU2VjdXJpdHlPcmlnaW4uaDoK ICAgICAgICAoV2ViQ29yZTo6U2VjdXJpdHlPcmlnaW46OmRvbWFpbldhc1NldEluRE9NKToKLS0t CiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICB8ICAgMTEgKysrKysrKysrKysKIFdlYkNv cmUvcGFnZS9TZWN1cml0eU9yaWdpbi5oIHwgICAgMyArKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTMg aW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGNjMmQ1NmUuLjZmZmRmMDMgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEs MTYgQEAKIDIwMDgtMTAtMjMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4MjYKKworICAgICAgICBBZGQgYWNjZXNzb3Ig Zm9yIFNlY3VyaXR5T3JpZ2luOjptX2RvbWFpbldhc1NldEluRE9NLgorCisgICAgICAgICogcGFn ZS9TZWN1cml0eU9yaWdpbi5oOgorICAgICAgICAoV2ViQ29yZTo6U2VjdXJpdHlPcmlnaW46OmRv bWFpbldhc1NldEluRE9NKToKKworMjAwOC0xMC0yMyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJr aXQub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCiAKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzg3CmRpZmYgLS1naXQgYS9X ZWJDb3JlL3BhZ2UvU2VjdXJpdHlPcmlnaW4uaCBiL1dlYkNvcmUvcGFnZS9TZWN1cml0eU9yaWdp bi5oCmluZGV4IGRmOGVhZDguLmFlNDE1OTIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9TZWN1 cml0eU9yaWdpbi5oCisrKyBiL1dlYkNvcmUvcGFnZS9TZWN1cml0eU9yaWdpbi5oCkBAIC0xLDUg KzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAwNyBBcHBsZSBJbmMuIEFsbCByaWdodHMg cmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMDctMjAwOCBBcHBsZSBJbmMuIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5k IGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJt aXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTU1LDYgKzU1 LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAvLyBkb21haW4uICBUaGUgY2FsbGVy IGlzIHJlc3BvbnNpYmxlIGZvciB2YWxpZGF0aW5nIG5ld0RvbWFpbi4KICAgICAgICAgdm9pZCBz ZXREb21haW5Gcm9tRE9NKGNvbnN0IFN0cmluZyYgbmV3RG9tYWluKTsKIAorICAgICAgICBib29s IGRvbWFpbldhc1NldEluRE9NKCkgY29uc3QgeyByZXR1cm4gbV9kb21haW5XYXNTZXRJbkRPTTsg fQogICAgICAgICBTdHJpbmcgcHJvdG9jb2woKSBjb25zdCB7IHJldHVybiBtX3Byb3RvY29sOyB9 CiAgICAgICAgIFN0cmluZyBob3N0KCkgY29uc3QgeyByZXR1cm4gbV9ob3N0OyB9CiAgICAgICAg IFN0cmluZyBkb21haW4oKSBjb25zdCB7IHJldHVybiBtX2RvbWFpbjsgfQotLSAKMS42LjAuMQoK