218255 2020-10-27 13:16:31 -0700 Fix "usage" message when invoking `ar -V` 2020-10-27 16:51:59 -0700 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin achristensen annulen don.olmstead ews-watchlist fujii gyuyoung.kim ryuan.choi sergio webkit-bug-importer oldest_to_newest 1702043 0 krollin 2020-10-27 13:16:31 -0700 The Mac/BSD version of `ar` does not support the -V flag. This flag is used unconditionally in OptionsCommon.cmake when trying to determine if the installed `ar` supports the thinning of archives, leading to a "usage" message being emitted on macOS. Avoid this message by capturing the error-output. Examine the output to see if it's a "usage" message. If so, then treat the `ar` as one that does not support thinning. Any other error-output is printed as a warning. If there is no error-output, continue processing as normal. 1702044 1 webkit-bug-importer 2020-10-27 13:16:43 -0700 <rdar://problem/70735674> 1702045 2 412455 krollin 2020-10-27 13:18:53 -0700 Created attachment 412455 Patch 1702118 3 ews-feeder 2020-10-27 14:54:30 -0700 Committed r269076: <https://trac.webkit.org/changeset/269076> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412455. 412455 2020-10-27 13:18:53 -0700 2020-10-27 14:54:30 -0700 Patch bug-218255-20201027131852.patch text/plain 2443 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4OTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IDllZjQ5ZGI5NzkzZDc5Zjc0M2I4M2MyZmE0NjlkN2YxMzZmZWJjMmEuLjJmNDFlYjIxYmI1MzY4 YWQyOGRlZjVlMGY4ZDdmNWNjZTk3YzRjNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC03LDggKzcsMTMgQEAgYWRkX2RlZmluaXRpb25zKC1ESEFWRV9DT05GSUdfSD0xKQogCiBvcHRp b24oVVNFX1RISU5fQVJDSElWRVMgIlByb2R1Y2UgYWxsIHN0YXRpYyBsaWJyYXJpZXMgYXMgdGhp biBhcmNoaXZlcyIgT04pCiBpZiAoVVNFX1RISU5fQVJDSElWRVMpCi0gICAgZXhlY3V0ZV9wcm9j ZXNzKENPTU1BTkQgJHtDTUFLRV9BUn0gLVYgT1VUUFVUX1ZBUklBQkxFIEFSX1ZFUlNJT04pCi0g ICAgaWYgKCIke0FSX1ZFUlNJT059IiBNQVRDSEVTICJeR05VIGFyIikKKyAgICBleGVjdXRlX3By b2Nlc3MoQ09NTUFORCAke0NNQUtFX0FSfSAtViBPVVRQVVRfVkFSSUFCTEUgQVJfVkVSU0lPTiBF UlJPUl9WQVJJQUJMRSBBUl9FUlJPUikKKyAgICBpZiAoIiR7QVJfRVJST1J9IiBNQVRDSEVTICJe dXNhZ2U6IikKKyAgICAgICAgIyBUaGlzIGBhcmAgZG9lc24ndCB1bmRlcnN0YW5kICItViIuIEln bm9yZSB0aGUgZXJyb3IgYW5kIHRyZWF0IHRoaXMgYXMKKyAgICAgICAgIyBhbiB1bnN1cHBvcnRl ZCBgYXJgLiBUT0RPOiBEZXRlcm1pbmUgQlNEIG9yIFhjb2RlIGVxdWl2YWxlbnQuCisgICAgZWxz ZWlmICgiJHtBUl9FUlJPUn0iKQorICAgICAgICBtZXNzYWdlKFdBUk5JTkcgIkVycm9yIGZyb20g YGFyYDogJHtBUl9FUlJPUn0iKQorICAgIGVsc2VpZiAoIiR7QVJfVkVSU0lPTn0iIE1BVENIRVMg Il5HTlUgYXIiKQogICAgICAgICBzZXQoQ01BS0VfQ1hYX0FSQ0hJVkVfQ1JFQVRFICI8Q01BS0Vf QVI+IGNyVCA8VEFSR0VUPiA8TElOS19GTEFHUz4gPE9CSkVDVFM+IikKICAgICAgICAgc2V0KENN QUtFX0NfQVJDSElWRV9DUkVBVEUgIjxDTUFLRV9BUj4gY3JUIDxUQVJHRVQ+IDxMSU5LX0ZMQUdT PiA8T0JKRUNUUz4iKQogICAgICAgICBzZXQoQ01BS0VfQ1hYX0FSQ0hJVkVfQVBQRU5EICI8Q01B S0VfQVI+IHJUIDxUQVJHRVQ+IDxMSU5LX0ZMQUdTPiA8T0JKRUNUUz4iKQpkaWZmIC0tZ2l0IGEv Q2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDgwMzA3ZjYzMmUxM2E1ZDU1MzNlNzA4NzM3NGYw OWEyMDJlNmRjOGUuLjBhOTA0YjJiYjc3M2MxMmM0MjY3ZGEzMTYwNDI3OTU0OGMwZmI0ZDMgMTAw NjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAy MC0xMC0yNyAgS2VpdGggUm9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+CisKKyAgICAgICAgRml4 ICJ1c2FnZSIgbWVzc2FnZSB3aGVuIGludm9raW5nIGBhciAtVmAKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODI1NQorICAgICAgICA8cmRhcjovL3By b2JsZW0vNzA3MzU2NzQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhlIE1hYy9CU0QgdmVyc2lvbiBvZiBgYXJgIGRvZXMgbm90IHN1cHBvcnQgdGhl IC1WIGZsYWcuIFRoaXMgZmxhZyBpcworICAgICAgICB1c2VkIHVuY29uZGl0aW9uYWxseSBpbiBP cHRpb25zQ29tbW9uLmNtYWtlIHdoZW4gdHJ5aW5nIHRvIGRldGVybWluZQorICAgICAgICBpZiB0 aGUgaW5zdGFsbGVkIGBhcmAgc3VwcG9ydHMgdGhlIHRoaW5uaW5nIG9mIGFyY2hpdmVzLCBsZWFk aW5nIHRvIGEKKyAgICAgICAgInVzYWdlIiBtZXNzYWdlIGJlaW5nIGVtaXR0ZWQgb24gbWFjT1Mu CisKKyAgICAgICAgQXZvaWQgdGhpcyBtZXNzYWdlIGJ5IGNhcHR1cmluZyB0aGUgZXJyb3Itb3V0 cHV0LiBFeGFtaW5lIHRoZSBvdXRwdXQKKyAgICAgICAgdG8gc2VlIGlmIGl0J3MgYSAidXNhZ2Ui IG1lc3NhZ2UuIElmIHNvLCB0aGVuIHRyZWF0IHRoZSBgYXJgIGFzIG9uZQorICAgICAgICB0aGF0 IGRvZXMgbm90IHN1cHBvcnQgdGhpbm5pbmcuIEFueSBvdGhlciBlcnJvci1vdXRwdXQgaXMgcHJp bnRlZCBhcyBhCisgICAgICAgIHdhcm5pbmcuIElmIHRoZXJlIGlzIG5vIGVycm9yLW91dHB1dCwg Y29udGludWUgcHJvY2Vzc2luZyBhcyBub3JtYWwuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2Uv T3B0aW9uc0NvbW1vbi5jbWFrZToKKwogMjAyMC0xMC0yNiAgS2VpdGggUm9sbGluICA8a3JvbGxp bkBhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBzb21lIGluaXRpYWxpemF0aW9uIGNvZGUgZnJv bSB0b3AtbGV2ZWwgQ01ha2VMaXN0cy50eHQgdG8gV2ViS2l0Q29tbW9uLmNtYWtlCg==