218248 2020-10-27 11:03:36 -0700 [GStreamer] Mock video source doesn't set framerate on its caps 2020-10-28 06:14:42 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand calvaris cgarcia eric.carlson ews-watchlist glenn gustavo hta jer.noble menard philipj sergio tommyw vjaquez webkit-bug-importer oldest_to_newest 1701987 0 pnormand 2020-10-27 11:03:36 -0700 . 1701991 1 412447 pnormand 2020-10-27 11:05:51 -0700 Created attachment 412447 Patch 1702005 2 412447 pnormand 2020-10-27 11:39:09 -0700 Comment on attachment 412447 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412447&action=review > Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp:-73 > - auto buffer = adoptGRef(gst_buffer_new_wrapped(g_memdup(data.releaseBuffer().get(), size), size)); A memcpy is avoided as well 1702286 3 ews-feeder 2020-10-28 06:13:41 -0700 Committed r269101: <https://trac.webkit.org/changeset/269101> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412447. 1702288 4 webkit-bug-importer 2020-10-28 06:14:42 -0700 <rdar://problem/70762061> 412447 2020-10-27 11:05:51 -0700 2020-10-28 06:13:42 -0700 Patch bug-218248-20201027110549.patch text/plain 5500 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzg0MWY1N2FlMTQ3OGRi MDE4NmIzNGEzYWU4OTZiYmI4N2QxYzRmOS4uODkwMzI5MGY4MjM0MjkzOGE4ZmU3NTQ1ZjhlODlj YjE1MzRmMGFjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTEwLTI3ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBNb2NrIHZpZGVvIHNvdXJjZSBkb2Vzbid0IHNldCBmcmFtZXJhdGUgb24gaXRzIGNhcHMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODI0OAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNldCBmcmFtZXJh dGUgb24gdGhlIHNhbXBsZSBjYXBzIGFuZCByZWR1Y2UgY29kZSBkdXBsaWNhdGlvbi4KKyAgICAg ICAgCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhU2FtcGxlR1N0 cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU2FtcGxlR1N0cmVhbWVyOjpjcmVh dGVJbWFnZVNhbXBsZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01l ZGlhU2FtcGxlR1N0cmVhbWVyLmg6CisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vZ3N0 cmVhbWVyL01vY2tSZWFsdGltZVZpZGVvU291cmNlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6Ok1vY2tSZWFsdGltZVZpZGVvU291cmNlR1N0cmVhbWVyOjp1cGRhdGVTYW1wbGVCdWZm ZXIpOgorCiAyMDIwLTEwLTI3ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBp Z2FsaWEuY29tPgogCiAgICAgICAgIEZpeCBidWlsZCBmb3Igbm9uLXVuaWZpZWQgYnVpbGRzIGFm dGVyIHIyNjkwNDEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvTWVkaWFTYW1wbGVHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhU2FtcGxlR1N0cmVhbWVyLmNwcAppbmRleCA4 MjAyYjUxMzZkODA1MTg5MzFhZDhjNDY3YzUzZDIyY2FkMWJjM2ZkLi45NmNkOTgwZmY4MmM4NTNj ZGU1NmU4NjQxMWFkY2MwYTcxNzEyNmVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFTYW1wbGVHU3RyZWFtZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVNhbXBsZUdTdHJl YW1lci5jcHAKQEAgLTk3LDcgKzk3LDcgQEAgUmVmPE1lZGlhU2FtcGxlR1N0cmVhbWVyPiBNZWRp YVNhbXBsZUdTdHJlYW1lcjo6Y3JlYXRlRmFrZVNhbXBsZShHc3RDYXBzKiwgTWVkaWEKICAgICBy ZXR1cm4gYWRvcHRSZWYoKmdzdHJlYW1lck1lZGlhU2FtcGxlKTsKIH0KIAotUmVmPE1lZGlhU2Ft cGxlR1N0cmVhbWVyPiBNZWRpYVNhbXBsZUdTdHJlYW1lcjo6Y3JlYXRlSW1hZ2VTYW1wbGUoVmVj dG9yPHVpbnQ4X3Q+JiYgYmdyYURhdGEsIHVuc2lnbmVkIHdpZHRoLCB1bnNpZ25lZCBoZWlnaHQp CitSZWY8TWVkaWFTYW1wbGVHU3RyZWFtZXI+IE1lZGlhU2FtcGxlR1N0cmVhbWVyOjpjcmVhdGVJ bWFnZVNhbXBsZShWZWN0b3I8dWludDhfdD4mJiBiZ3JhRGF0YSwgdW5zaWduZWQgd2lkdGgsIHVu c2lnbmVkIGhlaWdodCwgZG91YmxlIGZyYW1lUmF0ZSkKIHsKICAgICBzaXplX3Qgc2l6ZSA9IGJn cmFEYXRhLnNpemVJbkJ5dGVzKCk7CiAgICAgYXV0byogZGF0YSA9IGJncmFEYXRhLnJlbGVhc2VC dWZmZXIoKS5sZWFrUHRyKCk7CkBAIC0xMDUsNyArMTA1LDEyIEBAIFJlZjxNZWRpYVNhbXBsZUdT dHJlYW1lcj4gTWVkaWFTYW1wbGVHU3RyZWFtZXI6OmNyZWF0ZUltYWdlU2FtcGxlKFZlY3Rvcjx1 aW50OF90CiAgICAgICAgIFdURjo6VmVjdG9yTWFsbG9jOjpmcmVlKGRhdGEpOwogICAgIH0pKTsK ICAgICBnc3RfYnVmZmVyX2FkZF92aWRlb19tZXRhKGJ1ZmZlci5nZXQoKSwgR1NUX1ZJREVPX0ZS QU1FX0ZMQUdfTk9ORSwgR1NUX1ZJREVPX0ZPUk1BVF9CR1JBLCB3aWR0aCwgaGVpZ2h0KTsKLSAg ICBhdXRvIGNhcHMgPSBhZG9wdEdSZWYoZ3N0X2NhcHNfbmV3X3NpbXBsZSgidmlkZW8veC1yYXci LCAiZm9ybWF0IiwgR19UWVBFX1NUUklORywgIkJHUkEiLCAid2lkdGgiLCBHX1RZUEVfSU5ULCB3 aWR0aCwgImhlaWdodCIsIEdfVFlQRV9JTlQsIGhlaWdodCwgImZyYW1lcmF0ZSIsIEdTVF9UWVBF X0ZSQUNUSU9OLCAxLCAxLCBudWxscHRyKSk7CisKKyAgICBpbnQgZnJhbWVSYXRlTnVtZXJhdG9y LCBmcmFtZVJhdGVEZW5vbWluYXRvcjsKKyAgICBnc3RfdXRpbF9kb3VibGVfdG9fZnJhY3Rpb24o ZnJhbWVSYXRlLCAmZnJhbWVSYXRlTnVtZXJhdG9yLCAmZnJhbWVSYXRlRGVub21pbmF0b3IpOwor CisgICAgYXV0byBjYXBzID0gYWRvcHRHUmVmKGdzdF9jYXBzX25ld19zaW1wbGUoInZpZGVvL3gt cmF3IiwgImZvcm1hdCIsIEdfVFlQRV9TVFJJTkcsICJCR1JBIiwgIndpZHRoIiwgR19UWVBFX0lO VCwgd2lkdGgsCisgICAgICAgICJoZWlnaHQiLCBHX1RZUEVfSU5ULCBoZWlnaHQsICJmcmFtZXJh dGUiLCBHU1RfVFlQRV9GUkFDVElPTiwgZnJhbWVSYXRlTnVtZXJhdG9yLCBmcmFtZVJhdGVEZW5v bWluYXRvciwgbnVsbHB0cikpOwogICAgIGF1dG8gc2FtcGxlID0gYWRvcHRHUmVmKGdzdF9zYW1w bGVfbmV3KGJ1ZmZlci5nZXQoKSwgY2Fwcy5nZXQoKSwgbnVsbHB0ciwgbnVsbHB0cikpOwogICAg IHJldHVybiBjcmVhdGUoV1RGTW92ZShzYW1wbGUpLCBGbG9hdFNpemUod2lkdGgsIGhlaWdodCks IHsgfSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvTWVkaWFTYW1wbGVHU3RyZWFtZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVNhbXBsZUdTdHJlYW1lci5oCmluZGV4IDM5YmMzYWE4 YjEwMjRjMzE4ZTc3NjZhOTI1MDMzYTI1NGNlN2E3NzEuLjJkNDEzN2IzYzlkNzlmOWFmMzU1MTY4 Mjc1MmQ1NTI1NzM1NTRkNmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9NZWRpYVNhbXBsZUdTdHJlYW1lci5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVNhbXBsZUdTdHJlYW1lci5oCkBA IC0zNyw3ICszNyw3IEBAIHB1YmxpYzoKICAgICB9CiAKICAgICBzdGF0aWMgUmVmPE1lZGlhU2Ft cGxlR1N0cmVhbWVyPiBjcmVhdGVGYWtlU2FtcGxlKEdzdENhcHMqLCBNZWRpYVRpbWUgcHRzLCBN ZWRpYVRpbWUgZHRzLCBNZWRpYVRpbWUgZHVyYXRpb24sIGNvbnN0IEZsb2F0U2l6ZSYgcHJlc2Vu dGF0aW9uU2l6ZSwgY29uc3QgQXRvbVN0cmluZyYgdHJhY2tJZCk7Ci0gICAgc3RhdGljIFJlZjxN ZWRpYVNhbXBsZUdTdHJlYW1lcj4gY3JlYXRlSW1hZ2VTYW1wbGUoVmVjdG9yPHVpbnQ4X3Q+JiYs IHVuc2lnbmVkIHdpZHRoLCB1bnNpZ25lZCBoZWlnaHQpOworICAgIHN0YXRpYyBSZWY8TWVkaWFT YW1wbGVHU3RyZWFtZXI+IGNyZWF0ZUltYWdlU2FtcGxlKFZlY3Rvcjx1aW50OF90PiYmLCB1bnNp Z25lZCB3aWR0aCwgdW5zaWduZWQgaGVpZ2h0LCBkb3VibGUgZnJhbWVSYXRlID0gMSk7CiAKICAg ICB2b2lkIGV4dGVuZFRvVGhlQmVnaW5uaW5nKCk7CiAgICAgTWVkaWFUaW1lIHByZXNlbnRhdGlv blRpbWUoKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiBtX3B0czsgfQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vZ3N0cmVhbWVyL01vY2tSZWFsdGltZVZp ZGVvU291cmNlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3Ry ZWFtL2dzdHJlYW1lci9Nb2NrUmVhbHRpbWVWaWRlb1NvdXJjZUdTdHJlYW1lci5jcHAKaW5kZXgg ZDU0MDA2ODRjMmMwNDdlYjUzMWE0ZDA0YWE3ZWUyZjExMTY1NWIxOS4uZmFhZDBhNjBkZDkxNGU2 ODlmYzdjYjg0YTM3Y2MwYjA2NjM2ZjE0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWVkaWFzdHJlYW0vZ3N0cmVhbWVyL01vY2tSZWFsdGltZVZpZGVvU291cmNlR1N0cmVh bWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9nc3RyZWFt ZXIvTW9ja1JlYWx0aW1lVmlkZW9Tb3VyY2VHU3RyZWFtZXIuY3BwCkBAIC02NSwxNiArNjUsOCBA QCB2b2lkIE1vY2tSZWFsdGltZVZpZGVvU291cmNlR1N0cmVhbWVyOjp1cGRhdGVTYW1wbGVCdWZm ZXIoKQogICAgICAgICByZXR1cm47CiAKICAgICBhdXRvIGltYWdlU2l6ZSA9IHNpemUoKTsKLSAg ICBhdXRvIGNhcHMgPSBhZG9wdEdSZWYoZ3N0X2NhcHNfbmV3X3NpbXBsZSgidmlkZW8veC1yYXci LCAiZm9ybWF0IiwgR19UWVBFX1NUUklORywgIkJHUkEiLAotICAgICAgICAid2lkdGgiLCBHX1RZ UEVfSU5ULCBpbWFnZVNpemUud2lkdGgoKSwgImhlaWdodCIsIEdfVFlQRV9JTlQsIGltYWdlU2l6 ZS5oZWlnaHQoKSwgbnVsbHB0cikpOwotCi0gICAgYXV0byBkYXRhID0gaW1hZ2VCdWZmZXItPnRv QkdSQURhdGEoKTsKLSAgICBhdXRvIHNpemUgPSBkYXRhLnNpemUoKTsKLSAgICBhdXRvIGJ1ZmZl ciA9IGFkb3B0R1JlZihnc3RfYnVmZmVyX25ld193cmFwcGVkKGdfbWVtZHVwKGRhdGEucmVsZWFz ZUJ1ZmZlcigpLmdldCgpLCBzaXplKSwgc2l6ZSkpOwotICAgIGF1dG8gc2FtcGxlVGltZSA9IE1l ZGlhVGltZTo6Y3JlYXRlV2l0aERvdWJsZSgoZWxhcHNlZFRpbWUoKSArIDEwMF9tcykuc2Vjb25k cygpKTsKLSAgICBHU1RfQlVGRkVSX1BUUyhidWZmZXIuZ2V0KCkpID0gdG9Hc3RDbG9ja1RpbWUo c2FtcGxlVGltZSk7Ci0gICAgYXV0byBnc3RTYW1wbGUgPSBhZG9wdEdSZWYoZ3N0X3NhbXBsZV9u ZXcoYnVmZmVyLmdldCgpLCBjYXBzLmdldCgpLCBudWxscHRyLCBudWxscHRyKSk7Ci0gICAgYXV0 byBzYW1wbGUgPSBNZWRpYVNhbXBsZUdTdHJlYW1lcjo6Y3JlYXRlKFdURk1vdmUoZ3N0U2FtcGxl KSwgaW1hZ2VTaXplLCB7IH0pOworICAgIGF1dG8gc2FtcGxlID0gTWVkaWFTYW1wbGVHU3RyZWFt ZXI6OmNyZWF0ZUltYWdlU2FtcGxlKGltYWdlQnVmZmVyLT50b0JHUkFEYXRhKCksIGltYWdlU2l6 ZS53aWR0aCgpLCBpbWFnZVNpemUuaGVpZ2h0KCksIGZyYW1lUmF0ZSgpKTsKKyAgICBzYW1wbGUt Pm9mZnNldFRpbWVzdGFtcHNCeShNZWRpYVRpbWU6OmNyZWF0ZVdpdGhEb3VibGUoKGVsYXBzZWRU aW1lKCkgKyAxMDBfbXMpLnNlY29uZHMoKSkpOwogICAgIGRpc3BhdGNoTWVkaWFTYW1wbGVUb09i c2VydmVycyhzYW1wbGUuZ2V0KCkpOwogfQogCg==