218246 2020-10-27 10:43:03 -0700 [GStreamer] Switch the ImageDecoder to decodebin3 2020-11-16 01:29:17 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218245 InRadar P2 Normal --- 1 pnormand pnormand calvaris cgarcia ews-watchlist gustavo menard tsaunier vjaquez webkit-bug-importer oldest_to_newest 1701971 0 pnormand 2020-10-27 10:43:03 -0700 See https://bugs.webkit.org/show_bug.cgi?id=218245 1703033 1 412734 pnormand 2020-10-30 06:04:13 -0700 Created attachment 412734 Patch 1703036 2 412734 tsaunier 2020-10-30 06:19:08 -0700 Comment on attachment 412734 Patch lgtm 1703485 3 412734 calvaris 2020-11-02 05:07:04 -0800 Comment on attachment 412734 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412734&action=review > Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:229 > +int ImageDecoderGStreamer::InnerDecoder::decodebinSelectStreamCallback(GstElement*, GstStreamCollection*, GstStream* stream, ImageDecoderGStreamer::InnerDecoder* decoder) > +{ > + return decoder->selectStream(stream); > +} I would use a lambda instead of this. > Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:244 > + int result = (gst_stream_get_stream_type(stream) & GST_STREAM_TYPE_VIDEO) ? 1 : 0; You don't need the () around gst_stream_get_stream_type(stream) & GST_STREAM_TYPE_VIDEO 1707717 4 pnormand 2020-11-16 01:28:22 -0800 Committed r269839: <https://trac.webkit.org/changeset/269839> 1707718 5 webkit-bug-importer 2020-11-16 01:29:17 -0800 <rdar://problem/71431266> 412734 2020-10-30 06:04:13 -0700 2020-11-02 05:07:04 -0800 Patch bug-218246-20201030060411.patch text/plain 5971 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjI5ZmE3YzhkNzIwNjQz OWMzNzg5Y2E2ZGNmYjVjMzg5ODc2YTkxNi4uNGYwMjU0NzRiZTkyNGMwMDY1ZTAzM2JlNDIzMjNi ZDZkNTFlNTMyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTEwLTMwICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBTd2l0Y2ggdGhlIEltYWdlRGVjb2RlciB0byBkZWNvZGViaW4zCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTgyNDYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWx5IG9uIHRoZSBkZWNvZGViaW4zIHNl bGVjdC1zdHJlYW0gdG8gZW5zdXJlIHRoYXQgYXQgbW9zdCBvbmUgdmlkZW8gc3RyZWFtIGlzIHNl bGVjdGVkIGZvcgorICAgICAgICBkZWNvZGluZy4gVGh1cyB3ZSBkb24ndCBuZWVkIHRvIHBsdWcg YSBmYWtlc2luayB0byBzdHJlYW1zIHdlIGRvbid0IG5lZWQgYW55bW9yZS4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9JbWFnZURlY29kZXJHU3RyZWFtZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6SW1hZ2VEZWNvZGVyR1N0cmVhbWVyOjpJbm5lckRlY29kZXI6OmRl Y29kZWJpblNlbGVjdFN0cmVhbUNhbGxiYWNrKToKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlRGVj b2RlckdTdHJlYW1lcjo6SW5uZXJEZWNvZGVyOjpzZWxlY3RTdHJlYW0pOgorICAgICAgICAoV2Vi Q29yZTo6SW1hZ2VEZWNvZGVyR1N0cmVhbWVyOjpJbm5lckRlY29kZXI6OmNvbm5lY3REZWNvZGVy UGFkKToKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlRGVjb2RlckdTdHJlYW1lcjo6SW5uZXJEZWNv ZGVyOjpwcmVwYXJlUGlwZWxpbmUpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9JbWFnZURlY29kZXJHU3RyZWFtZXIuaDoKKwogMjAyMC0xMC0zMCAgQWxlamFuZHJvIEcu IENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KIAogICAgICAgICBGaXggYnVpbGQgZXJyb3Igd2l0 aCByZWxlYXNlIGJ1aWxkIHdpdGggLURMT0dfRElTQUJMRUQ9MApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0ltYWdlRGVjb2RlckdTdHJlYW1l ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvSW1hZ2VE ZWNvZGVyR1N0cmVhbWVyLmNwcAppbmRleCBkYzk5NGI3MzFmYTg5NTRlZjg4MDNhZGMyOGY0ZjI3 MWVmZjU4OWI3Li4xNTgwMGY2OWM0ZmU2MzZlNzhlNjk2MzU3MGE5Y2I3NjAxOTg1ZTZmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvSW1hZ2VE ZWNvZGVyR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvSW1hZ2VEZWNvZGVyR1N0cmVhbWVyLmNwcApAQCAtMjIzLDYgKzIyMywyOSBA QCBjb25zdCBJbWFnZURlY29kZXJHU3RyZWFtZXJTYW1wbGUqIEltYWdlRGVjb2RlckdTdHJlYW1l cjo6c2FtcGxlQXRJbmRleChzaXplX3QgaQogICAgIHJldHVybiB0b1NhbXBsZShpdGVyKTsKIH0K IAoraW50IEltYWdlRGVjb2RlckdTdHJlYW1lcjo6SW5uZXJEZWNvZGVyOjpkZWNvZGViaW5TZWxl Y3RTdHJlYW1DYWxsYmFjayhHc3RFbGVtZW50KiwgR3N0U3RyZWFtQ29sbGVjdGlvbiosIEdzdFN0 cmVhbSogc3RyZWFtLCBJbWFnZURlY29kZXJHU3RyZWFtZXI6OklubmVyRGVjb2RlciogZGVjb2Rl cikKK3sKKyAgICByZXR1cm4gZGVjb2Rlci0+c2VsZWN0U3RyZWFtKHN0cmVhbSk7Cit9CisKK2lu dCBJbWFnZURlY29kZXJHU3RyZWFtZXI6OklubmVyRGVjb2Rlcjo6c2VsZWN0U3RyZWFtKEdzdFN0 cmVhbSogc3RyZWFtKQoreworICAgIC8vIFNlbGVjdCBvbmx5IHRoZSBmaXJzdCB2aWRlbyBzdHJl YW0uCisgICAgYXV0byogb2JqZWN0ID0gR1NUX09CSkVDVF9DQVNUKG1fZGVjb2RlYmluLmdldCgp KTsKKyAgICBHU1RfT0JKRUNUX0xPQ0sob2JqZWN0KTsKKyAgICBhdXRvIG51bWJlck9mU291cmNl UGFkcyA9IG1fZGVjb2RlYmluLT5udW1zcmNwYWRzOworICAgIEdTVF9PQkpFQ1RfVU5MT0NLKG9i amVjdCk7CisKKyAgICBpZiAobnVtYmVyT2ZTb3VyY2VQYWRzKSB7CisgICAgICAgIEdTVF9ERUJV R19PQkpFQ1QobV9waXBlbGluZS5nZXQoKSwgIkRpc2NhcmRpbmcgYWRkaXRpb25hbCAlIiBHU1Rf UFRSX0ZPUk1BVCwgc3RyZWFtKTsKKyAgICAgICAgcmV0dXJuIDA7CisgICAgfQorCisgICAgaW50 IHJlc3VsdCA9IChnc3Rfc3RyZWFtX2dldF9zdHJlYW1fdHlwZShzdHJlYW0pICYgR1NUX1NUUkVB TV9UWVBFX1ZJREVPKSA/IDEgOiAwOworICAgIEdTVF9ERUJVR19PQkpFQ1QobV9waXBlbGluZS5n ZXQoKSwgIiUiIEdTVF9QVFJfRk9STUFUICIgc2VsZWN0ZWQ6ICVzIiwgc3RyZWFtLCBib29sRm9y UHJpbnRpbmcocmVzdWx0KSk7CisgICAgcmV0dXJuIHJlc3VsdDsKK30KKwogdm9pZCBJbWFnZURl Y29kZXJHU3RyZWFtZXI6OklubmVyRGVjb2Rlcjo6ZGVjb2RlYmluUGFkQWRkZWRDYWxsYmFjayhJ bWFnZURlY29kZXJHU3RyZWFtZXI6OklubmVyRGVjb2RlciogZGVjb2RlciwgR3N0UGFkKiBwYWQp CiB7CiAgICAgZGVjb2Rlci0+Y29ubmVjdERlY29kZXJQYWQocGFkKTsKQEAgLTIzMCwxOCArMjUz LDkgQEAgdm9pZCBJbWFnZURlY29kZXJHU3RyZWFtZXI6OklubmVyRGVjb2Rlcjo6ZGVjb2RlYmlu UGFkQWRkZWRDYWxsYmFjayhJbWFnZURlY29kZXIKIAogdm9pZCBJbWFnZURlY29kZXJHU3RyZWFt ZXI6OklubmVyRGVjb2Rlcjo6Y29ubmVjdERlY29kZXJQYWQoR3N0UGFkKiBwYWQpCiB7Ci0gICAg YXV0byBwYWRDYXBzID0gYWRvcHRHUmVmKGdzdF9wYWRfZ2V0X2N1cnJlbnRfY2FwcyhwYWQpKTsK KyAgICBhdXRvIHBhZENhcHMgPSBhZG9wdEdSZWYoZ3N0X3BhZF9xdWVyeV9jYXBzKHBhZCwgbnVs bHB0cikpOwogICAgIEdTVF9ERUJVR19PQkpFQ1QobV9waXBlbGluZS5nZXQoKSwgIk5ldyBkZWNv ZGViaW4gcGFkICUiIEdTVF9QVFJfRk9STUFUICIgY2FwczogJSIgR1NUX1BUUl9GT1JNQVQsIHBh ZCwgcGFkQ2Fwcy5nZXQoKSk7Ci0KLSAgICBpZiAoIWRvQ2Fwc0hhdmVUeXBlKHBhZENhcHMuZ2V0 KCksICJ2aWRlbyIpKSB7Ci0gICAgICAgIEdTVF9ERUJVR19PQkpFQ1QobV9waXBlbGluZS5nZXQo KSwgIk5vbi12aWRlbyBwYWQsIHBsdWdnaW5nIHRvIGEgZmFrZXNpbmsiKTsKLSAgICAgICAgYXV0 byogc2luayA9IGdzdF9lbGVtZW50X2ZhY3RvcnlfbWFrZSgiZmFrZXNpbmsiLCBudWxscHRyKTsK LSAgICAgICAgZ3N0X2Jpbl9hZGQoR1NUX0JJTl9DQVNUKG1fcGlwZWxpbmUuZ2V0KCkpLCBzaW5r KTsKLSAgICAgICAgYXV0byBzaW5rUGFkID0gYWRvcHRHUmVmKGdzdF9lbGVtZW50X2dldF9zdGF0 aWNfcGFkKHNpbmssICJzaW5rIikpOwotICAgICAgICBnc3RfcGFkX2xpbmsocGFkLCBzaW5rUGFk LmdldCgpKTsKLSAgICAgICAgZ3N0X2VsZW1lbnRfc3luY19zdGF0ZV93aXRoX3BhcmVudChzaW5r KTsKLSAgICAgICAgcmV0dXJuOwotICAgIH0KKyAgICBSRUxFQVNFX0FTU0VSVChkb0NhcHNIYXZl VHlwZShwYWRDYXBzLmdldCgpLCAidmlkZW8iKSk7CiAKICAgICBHc3RFbGVtZW50KiBzaW5rID0g Z3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJhcHBzaW5rIiwgbnVsbHB0cik7CiAgICAgc3RhdGlj IEdzdEFwcFNpbmtDYWxsYmFja3MgY2FsbGJhY2tzID0gewpAQCAtMzUyLDExICszNjYsMTIgQEAg dm9pZCBJbWFnZURlY29kZXJHU3RyZWFtZXI6OklubmVyRGVjb2Rlcjo6cHJlcGFyZVBpcGVsaW5l KCkKICAgICBHc3RFbGVtZW50KiBzb3VyY2UgPSBnc3RfZWxlbWVudF9mYWN0b3J5X21ha2UoImdp b3N0cmVhbXNyYyIsIG51bGxwdHIpOwogICAgIGdfb2JqZWN0X3NldChzb3VyY2UsICJzdHJlYW0i LCBtX21lbW9yeVN0cmVhbS5nZXQoKSwgbnVsbHB0cik7CiAKLSAgICBHc3RFbGVtZW50KiBkZWNv ZGVyID0gZ3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJkZWNvZGViaW4iLCBudWxscHRyKTsKLSAg ICBnX3NpZ25hbF9jb25uZWN0X3N3YXBwZWQoZGVjb2RlciwgInBhZC1hZGRlZCIsIEdfQ0FMTEJB Q0soZGVjb2RlYmluUGFkQWRkZWRDYWxsYmFjayksIHRoaXMpOworICAgIG1fZGVjb2RlYmluID0g Z3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJkZWNvZGViaW4zIiwgbnVsbHB0cik7CisgICAgZ19z aWduYWxfY29ubmVjdChtX2RlY29kZWJpbi5nZXQoKSwgInNlbGVjdC1zdHJlYW0iLCBHX0NBTExC QUNLKGRlY29kZWJpblNlbGVjdFN0cmVhbUNhbGxiYWNrKSwgdGhpcyk7CisgICAgZ19zaWduYWxf Y29ubmVjdF9zd2FwcGVkKG1fZGVjb2RlYmluLmdldCgpLCAicGFkLWFkZGVkIiwgR19DQUxMQkFD SyhkZWNvZGViaW5QYWRBZGRlZENhbGxiYWNrKSwgdGhpcyk7CiAKLSAgICBnc3RfYmluX2FkZF9t YW55KEdTVF9CSU5fQ0FTVChtX3BpcGVsaW5lLmdldCgpKSwgc291cmNlLCBkZWNvZGVyLCBudWxs cHRyKTsKLSAgICBnc3RfZWxlbWVudF9saW5rKHNvdXJjZSwgZGVjb2Rlcik7CisgICAgZ3N0X2Jp bl9hZGRfbWFueShHU1RfQklOX0NBU1QobV9waXBlbGluZS5nZXQoKSksIHNvdXJjZSwgbV9kZWNv ZGViaW4uZ2V0KCksIG51bGxwdHIpOworICAgIGdzdF9lbGVtZW50X2xpbmsoc291cmNlLCBtX2Rl Y29kZWJpbi5nZXQoKSk7CiAgICAgZ3N0X2VsZW1lbnRfc2V0X3N0YXRlKG1fcGlwZWxpbmUuZ2V0 KCksIEdTVF9TVEFURV9QTEFZSU5HKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0ltYWdlRGVjb2RlckdTdHJlYW1lci5oIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0ltYWdlRGVjb2RlckdTdHJl YW1lci5oCmluZGV4IDZlMmVhMDc5N2JkM2NmZDNlOWQ0NTAwODQ5NjhlOGQzMzM5NTlhN2QuLjc3 MjVlMGQxMjU0MzI4ZmE3ZGJkYTRmY2I3YTAyMzIxYTE5NjM3YzMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9JbWFnZURlY29kZXJHU3RyZWFt ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvSW1h Z2VEZWNvZGVyR1N0cmVhbWVyLmgKQEAgLTEwNCwxMyArMTA0LDE2IEBAIHByaXZhdGU6CiAKICAg ICBwcml2YXRlIDoKICAgICAgICAgc3RhdGljIHZvaWQgZGVjb2RlYmluUGFkQWRkZWRDYWxsYmFj ayhJbWFnZURlY29kZXJHU3RyZWFtZXI6OklubmVyRGVjb2RlciosIEdzdFBhZCopOworICAgICAg ICBzdGF0aWMgaW50IGRlY29kZWJpblNlbGVjdFN0cmVhbUNhbGxiYWNrKEdzdEVsZW1lbnQqLCBH c3RTdHJlYW1Db2xsZWN0aW9uKiwgR3N0U3RyZWFtKiwgSW1hZ2VEZWNvZGVyR1N0cmVhbWVyOjpJ bm5lckRlY29kZXIqKTsKICAgICAgICAgdm9pZCBoYW5kbGVNZXNzYWdlKEdzdE1lc3NhZ2UqKTsK ICAgICAgICAgdm9pZCBwcmVwYXJlUGlwZWxpbmUoKTsKKyAgICAgICAgaW50IHNlbGVjdFN0cmVh bShHc3RTdHJlYW0qKTsKICAgICAgICAgdm9pZCBjb25uZWN0RGVjb2RlclBhZChHc3RQYWQqKTsK IAogICAgICAgICBJbWFnZURlY29kZXJHU3RyZWFtZXImIG1fZGVjb2RlcjsKICAgICAgICAgR1Jl ZlB0cjxHc3RFbGVtZW50PiBtX3BpcGVsaW5lOwogICAgICAgICBHUmVmUHRyPEdJbnB1dFN0cmVh bT4gbV9tZW1vcnlTdHJlYW07CisgICAgICAgIEdSZWZQdHI8R3N0RWxlbWVudD4gbV9kZWNvZGVi aW47CiAgICAgICAgIFJ1bkxvb3AmIG1fcnVuTG9vcDsKICAgICB9OwogCg==