218245 2020-10-27 10:36:13 -0700 [GStreamer] Using audio files for the <img> tag triggers warnings 2020-10-28 05:48:21 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218246 InRadar P2 Normal --- 1 pnormand pnormand aperez calvaris cgarcia ews-watchlist gustavo menard vjaquez webkit-bug-importer oldest_to_newest 1701965 0 pnormand 2020-10-27 10:36:13 -0700 ** (WebKitWebProcess:67): WARNING **: 10:23:50.597: Error: 1, Internal data stream error.. Debug output: ../gst-libs/gst/tag/gsttagdemux.c(1512): gst_tag_demux_element_loop (): /GstPipeline:image-decoder-2/GstDe codeBin:decodebin2/GstID3Demux:id3demux2: streaming stopped, reason not-linked (-1) ** (WebKitWebProcess:67): WARNING **: 10:23:50.599: Error: 12, Your GStreamer installation is missing a plug-in.. Debug output: ../gst/playback/gstdecodebin2.c(4719): gst_decode_bin_expose (): /GstPipeline:image -decoder-3/GstDecodeBin:decodebin3: no suitable plugins found: Missing decoder: MPEG-1 Layer 3 (MP3) (audio/mpeg, mpegversion=(int)1, layer=(int)3, parsed=(boolean)false) 1701970 1 412443 pnormand 2020-10-27 10:40:52 -0700 Created attachment 412443 Patch 1702028 2 412443 aperez 2020-10-27 12:31:21 -0700 Comment on attachment 412443 Patch I've tested a build with this patch and works here. The patch looks reasonable on my eyes, but you may want a formal review by someone who knows better the GStreamer multimedia code :) 1702282 3 pnormand 2020-10-28 05:47:56 -0700 Committed r269099: <https://trac.webkit.org/changeset/269099> 1702283 4 webkit-bug-importer 2020-10-28 05:48:21 -0700 <rdar://problem/70761592> 412443 2020-10-27 10:40:52 -0700 2020-10-28 05:26:01 -0700 Patch bug-218245-20201027104051.patch text/plain 2911 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzBhNGJkMGU3MjliYThj OWU4ZThlOWJiYjljZDdmYWM2YjUwNTE2MC4uNjcwZTkzNzQ1ZTYwOTkzNDBlZDM1ODdhNjViM2Yx ZjAyMzk3MjJjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTEwLTI3ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBVc2luZyBhdWRpbyBmaWxlcyBmb3IgdGhlIDxpbWc+IHRhZyB0cmlnZ2VycyB3YXJuaW5ncwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4MjQ1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGx1ZyBub24t dmlkZW8gcGFkcyB0byBhIGZha2Ugc2luayBpbiBvcmRlciB0byBtYWludGFpbiBhIHZhbGlkIHBp cGVsaW5lLiBMYXRlciB3ZSBzaG91bGQKKyAgICAgICAgc3dpdGNoIHRvIGRlY29kZWJpbjMgYW5k IHJlbHkgb24gdGhlIHN0cmVhbSBzZWxlY3Rpb24gZmFjaWxpdGllcy4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9JbWFnZURlY29kZXJHU3RyZWFtZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SW1hZ2VEZWNvZGVyR1N0cmVhbWVyOjpJbm5lckRlY29kZXI6OmNvbm5l Y3REZWNvZGVyUGFkKToKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlRGVjb2RlckdTdHJlYW1lcjo6 SW5uZXJEZWNvZGVyOjpwcmVwYXJlUGlwZWxpbmUpOgorCiAyMDIwLTEwLTI3ICBBbnR0aSBLb2l2 aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJbnRlZ3JhdGlvbl0gVXNl IGl0ZXJhdG9yIGZvciBuZXh0L3ByZXZpb3VzTGluZVBvc2l0aW9uCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvSW1hZ2VEZWNvZGVyR1N0cmVh bWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9JbWFn ZURlY29kZXJHU3RyZWFtZXIuY3BwCmluZGV4IDkwN2MyYzU5MjA2MjkwY2U0YjkzMWU1ZjAwZjVi MmI2M2I5NDRkZTMuLjc1Y2ZkYmIyNjhmYTdkZWM5ZjIwM2YxMTgxYjJlMTdlZDA3MzVjNWQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9JbWFn ZURlY29kZXJHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9JbWFnZURlY29kZXJHU3RyZWFtZXIuY3BwCkBAIC0yMzIsNyArMjMyLDE2 IEBAIHZvaWQgSW1hZ2VEZWNvZGVyR1N0cmVhbWVyOjpJbm5lckRlY29kZXI6OmNvbm5lY3REZWNv ZGVyUGFkKEdzdFBhZCogcGFkKQogewogICAgIGF1dG8gcGFkQ2FwcyA9IGFkb3B0R1JlZihnc3Rf cGFkX2dldF9jdXJyZW50X2NhcHMocGFkKSk7CiAgICAgR1NUX0RFQlVHX09CSkVDVChtX3BpcGVs aW5lLmdldCgpLCAiTmV3IGRlY29kZWJpbiBwYWQgJSIgR1NUX1BUUl9GT1JNQVQgIiBjYXBzOiAl IiBHU1RfUFRSX0ZPUk1BVCwgcGFkLCBwYWRDYXBzLmdldCgpKTsKLSAgICBSRUxFQVNFX0FTU0VS VChkb0NhcHNIYXZlVHlwZShwYWRDYXBzLmdldCgpLCAidmlkZW8iKSk7CisKKyAgICBpZiAoIWRv Q2Fwc0hhdmVUeXBlKHBhZENhcHMuZ2V0KCksICJ2aWRlbyIpKSB7CisgICAgICAgIEdTVF9ERUJV R19PQkpFQ1QobV9waXBlbGluZS5nZXQoKSwgIk5vbi12aWRlbyBwYWQsIHBsdWdnaW5nIHRvIGEg ZmFrZXNpbmsiKTsKKyAgICAgICAgYXV0byogc2luayA9IGdzdF9lbGVtZW50X2ZhY3RvcnlfbWFr ZSgiZmFrZXNpbmsiLCBudWxscHRyKTsKKyAgICAgICAgZ3N0X2Jpbl9hZGQoR1NUX0JJTl9DQVNU KG1fcGlwZWxpbmUuZ2V0KCkpLCBzaW5rKTsKKyAgICAgICAgYXV0byBzaW5rUGFkID0gYWRvcHRH UmVmKGdzdF9lbGVtZW50X2dldF9zdGF0aWNfcGFkKHNpbmssICJzaW5rIikpOworICAgICAgICBn c3RfcGFkX2xpbmsocGFkLCBzaW5rUGFkLmdldCgpKTsKKyAgICAgICAgZ3N0X2VsZW1lbnRfc3lu Y19zdGF0ZV93aXRoX3BhcmVudChzaW5rKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KIAogICAg IEdzdEVsZW1lbnQqIHNpbmsgPSBnc3RfZWxlbWVudF9mYWN0b3J5X21ha2UoImFwcHNpbmsiLCBu dWxscHRyKTsKICAgICBzdGF0aWMgR3N0QXBwU2lua0NhbGxiYWNrcyBjYWxsYmFja3MgPSB7CkBA IC0zNDQsOCArMzUzLDYgQEAgdm9pZCBJbWFnZURlY29kZXJHU3RyZWFtZXI6OklubmVyRGVjb2Rl cjo6cHJlcGFyZVBpcGVsaW5lKCkKICAgICBnX29iamVjdF9zZXQoc291cmNlLCAic3RyZWFtIiwg bV9tZW1vcnlTdHJlYW0uZ2V0KCksIG51bGxwdHIpOwogCiAgICAgR3N0RWxlbWVudCogZGVjb2Rl ciA9IGdzdF9lbGVtZW50X2ZhY3RvcnlfbWFrZSgiZGVjb2RlYmluIiwgbnVsbHB0cik7Ci0gICAg YXV0byBhbGxvd2VkQ2FwcyA9IGFkb3B0R1JlZihnc3RfY2Fwc19uZXdfZW1wdHlfc2ltcGxlKCJ2 aWRlby94LXJhdyIpKTsKLSAgICBnX29iamVjdF9zZXQoZGVjb2RlciwgImNhcHMiLCBhbGxvd2Vk Q2Fwcy5nZXQoKSwgImV4cG9zZS1hbGwtc3RyZWFtcyIsIGZhbHNlLCBudWxscHRyKTsKICAgICBn X3NpZ25hbF9jb25uZWN0X3N3YXBwZWQoZGVjb2RlciwgInBhZC1hZGRlZCIsIEdfQ0FMTEJBQ0so ZGVjb2RlYmluUGFkQWRkZWRDYWxsYmFjayksIHRoaXMpOwogCiAgICAgZ3N0X2Jpbl9hZGRfbWFu eShHU1RfQklOX0NBU1QobV9waXBlbGluZS5nZXQoKSksIHNvdXJjZSwgZGVjb2RlciwgbnVsbHB0 cik7Cg==