218242 2020-10-27 09:55:12 -0700 -Wparentheses warning in OptionsList.h 2020-10-27 10:55:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build PC All RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro ews-watchlist keith_miller mark.lam mcatanzaro msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1701922 0 mcatanzaro 2020-10-27 09:55:12 -0700 In file included from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-f2e18ffc-30.cpp:6: ../../Source/JavaScriptCore/runtime/Options.cpp: In static member function ‘static void JSC::Options::recomputeDependentOptions()’: ../../Source/JavaScriptCore/runtime/Options.cpp:539:25: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses] 539 | if (!(flags & SupportsDFG)) \ ../../Source/JavaScriptCore/runtime/OptionsList.h:574:5: note: in expansion of macro ‘DISABLE_TIERS’ 574 | v(usePrivateClassFields, SupportsFTL | SupportsDFG, "https://bugs.webkit.org/show_bug.cgi?id=212781", "https://bugs.webkit.org/show_bug.cgi?id=212784") | ^ ../../Source/JavaScriptCore/runtime/Options.cpp:545:9: note: in expansion of macro ‘FOR_EACH_JSC_EXPERIMENTAL_OPTION’ 545 | FOR_EACH_JSC_EXPERIMENTAL_OPTION(DISABLE_TIERS); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/JavaScriptCore/runtime/Options.cpp:541:25: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses] 541 | if (!(flags & SupportsFTL)) \ ../../Source/JavaScriptCore/runtime/OptionsList.h:574:5: note: in expansion of macro ‘DISABLE_TIERS’ 574 | v(usePrivateClassFields, SupportsFTL | SupportsDFG, "https://bugs.webkit.org/show_bug.cgi?id=212781", "https://bugs.webkit.org/show_bug.cgi?id=212784") | ^ ../../Source/JavaScriptCore/runtime/Options.cpp:545:9: note: in expansion of macro ‘FOR_EACH_JSC_EXPERIMENTAL_OPTION’ 545 | FOR_EACH_JSC_EXPERIMENTAL_OPTION(DISABLE_TIERS); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1701924 1 412434 mcatanzaro 2020-10-27 09:56:26 -0700 Created attachment 412434 Patch 1701976 2 ews-feeder 2020-10-27 10:54:49 -0700 Committed r269054: <https://trac.webkit.org/changeset/269054> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412434. 1701977 3 webkit-bug-importer 2020-10-27 10:55:23 -0700 <rdar://problem/70729394> 412434 2020-10-27 09:56:26 -0700 2020-10-27 10:54:49 -0700 Patch bug-218242-20201027115629.patch text/plain 1476 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MDQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 Mjk4YjVkYWI3NzI1NzE0MjkxNWM4NDU1ZDdiYmIzYTBjYThhZTg2Li40N2JjZjhiZGE2MGZlYzZl ZDFjMDQ3NzA3ZjhjNTZiM2QyZGJjODIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAyMC0xMC0yNyAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdu b21lLm9yZz4KKworICAgICAgICAtV3BhcmVudGhlc2VzIHdhcm5pbmcgaW4gT3B0aW9uc0xpc3Qu aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4MjQy CisKKyAgICAgICAgVW5yZXZpZXdlZCwgZml4IHdhcm5pbmcgYnkgYWRkaW5nIGV4dHJhIHBhcmVu dGhlc2VzLgorCisgICAgICAgICogcnVudGltZS9PcHRpb25zTGlzdC5oOgorCiAyMDIwLTEwLTI2 ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVj dG9yOiBjb25zb2xlIGNvbW1hbmQgbGluZSBBUEkgc2hvdWxkIGJlIGV4cG9zZWQgdG8gYnJlYWtw b2ludCBjb25kaXRpb25zL2FjdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL09wdGlvbnNMaXN0LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9P cHRpb25zTGlzdC5oCmluZGV4IDhkMGZmMGVjNjgzMjliMDRkMDkzY2UzOGQ0ZWNhNDZhYTI4OGYz ZWEuLmJlODU5ZWE5MWRjYWU4YzIyNzE5MDNlYTNiMDFmNmNkMGQ1MWY1OTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnNMaXN0LmgKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9uc0xpc3QuaApAQCAtNTcxLDcgKzU3MSw3IEBA IGVudW0gRXhwZXJpbWVudGFsT3B0aW9uRmxhZ3MgewogfTsKIAogI2RlZmluZSBGT1JfRUFDSF9K U0NfRVhQRVJJTUVOVEFMX09QVElPTih2KSBcCi0gICAgdih1c2VQcml2YXRlQ2xhc3NGaWVsZHMs IFN1cHBvcnRzRlRMIHwgU3VwcG9ydHNERkcsICJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjEyNzgxIiwgImh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTI3ODQiKQorICAgIHYodXNlUHJpdmF0ZUNsYXNzRmllbGRzLCAoU3VwcG9ydHNGVEwg fCBTdXBwb3J0c0RGRyksICJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjEyNzgxIiwgImh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTI3ODQi KQogCiBjb25zdGV4cHIgc2l6ZV90IGNvdW50TnVtYmVyT2ZKU0NPcHRpb25zKCkKIHsK