218227 2020-10-27 05:18:09 -0700 [ews] Ensure that uat instance doesn't send emails 2022-01-24 18:14:00 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=222035 https://bugs.webkit.org/show_bug.cgi?id=235552 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain darin jbedard krollin webkit-bug-importer oldest_to_newest 1701830 0 aakash_jain 2020-10-27 05:18:09 -0700 uat instance (ews-buidl.webkit-uat.org) is for testing purposes and various times it runs queues/configurations which aren't ready for production yet. We should ensure that uat instance doesn't send emails to users. 1701834 1 412414 aakash_jain 2020-10-27 05:26:55 -0700 Created attachment 412414 Patch 1702089 2 412414 darin 2020-10-27 14:26:23 -0700 Comment on attachment 412414 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412414&action=review > Tools/BuildSlaveSupport/ews-build/send_email.py:52 > + if 'uat' in HOSTNAME: This seems like an imprecise check. Is there no chance that a host might have "uat" as a substring of its name? It’s in words like "graduate". 1702093 3 krollin 2020-10-27 14:32:35 -0700 Heh. The word that came to my mind was "squat". The domain in question was "https://ews-build.webkit-uat.org". Would it cause problems to look for "ews-build.webkit-uat.org"? Or "webkit-uat.org"? Or "webkit-uat"? or "-uat.org"? 1702097 4 darin 2020-10-27 14:36:56 -0700 (In reply to Keith Rollin from comment #3) > The domain in question was "https://ews-build.webkit-uat.org". Would it > cause problems to look for "ews-build.webkit-uat.org"? Or "webkit-uat.org"? > Or "webkit-uat"? or "-uat.org"? or "-uat." or /\buat\b/ 1702295 5 aakash_jain 2020-10-28 06:35:43 -0700 (In reply to Keith Rollin from comment #3) > Would it cause problems to look for "ews-build.webkit-uat.org"? Or "webkit-uat.org"? Or "webkit-uat"? or "-uat.org"? Not really. This particular check is specifically for this host. In fact any other host matching this check isn't much of a concern, since almost all other hosts will fail the previous check of is_test_mode_enabled. is_test_mode_enabled is disabled only when BUILDBOT_PRODUCTION env variable is set, which is not set by default. We need to set this variable on uat instance since we need it to mimic production environment (e.g.: reading passwords.json file so that we can easily connect bots to it). Also, no other instance (like local testing instance) should send emails. Instead of disallowing this particular host, I have reverted the check in updated patch to allow only one host: production EWS instance. 1702297 6 412525 aakash_jain 2020-10-28 06:38:46 -0700 Created attachment 412525 Patch 1702313 7 412529 aakash_jain 2020-10-28 08:21:13 -0700 Created attachment 412529 Patch 1702332 8 ews-feeder 2020-10-28 09:17:14 -0700 Committed r269106: <https://trac.webkit.org/changeset/269106> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412529. 1702333 9 webkit-bug-importer 2020-10-28 09:18:20 -0700 <rdar://problem/70766615> 412414 2020-10-27 05:26:55 -0700 2020-10-28 06:38:43 -0700 Patch bug-218227-20201027082653.patch text/plain 1487 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2OTAzMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDIwLTEwLTI3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBFbnN1cmUgdGhhdCB1YXQgaW5zdGFuY2UgZG9lc24ndCBzZW5k IGVtYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjE4MjI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc2VuZF9lbWFpbC5weToKKwogMjAyMC0xMC0y NiAgRmVkZXJpY28gQnVjY2hpICA8ZmJ1Y2NoaUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIEZl ZGVyaWNvIEJ1Y2NoaSB0byBsaXN0IG9mIFdlYktpdCBjb250cmlidXRvcnMKSW5kZXg6IFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zZW5kX2VtYWlsLnB5Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zZW5kX2VtYWlsLnB5CShyZXZpc2lv biAyNjkwMzEpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc2VuZF9lbWFp bC5weQkod29ya2luZyBjb3B5KQpAQCAtMjMsNiArMjMsNyBAQAogaW1wb3J0IGpzb24KIGltcG9y dCBvcwogaW1wb3J0IHNtdHBsaWIKK2ltcG9ydCBzb2NrZXQKIAogZnJvbSBlbWFpbC5taW1lLnRl eHQgaW1wb3J0IE1JTUVUZXh0CiAKQEAgLTMyLDYgKzMzLDcgQEAgRlJPTV9FTUFJTCA9ICdld3NA d2Via2l0Lm9yZycKIElHQUxJQV9KU0NfUVVFVUVTX1BBVFRFUk5TID0gWydhcm12NycsICdtaXBz JywgJ2kzODYnXQogSUdBTElBX0dUS19XUEVfUVVFVUVTX1BBVFRFUk5TID0gWydndGsnLCAnd3Bl J10KIFNFUlZFUiA9ICdsb2NhbGhvc3QnCitIT1NUTkFNRSA9IHNvY2tldC5nZXRob3N0bmFtZSgp LnN0cmlwKCkKIAogCiBkZWYgZ2V0X2VtYWlsX2lkcyhjYXRlZ29yeSk6CkBAIC00Nyw2ICs0OSw4 IEBAIGRlZiBnZXRfZW1haWxfaWRzKGNhdGVnb3J5KToKIGRlZiBzZW5kX2VtYWlsKHRvX2VtYWls cywgc3ViamVjdCwgdGV4dCwgcmVmZXJlbmNlPScnKToKICAgICBpZiBpc190ZXN0X21vZGVfZW5h YmxlZDoKICAgICAgICAgcmV0dXJuCisgICAgaWYgJ3VhdCcgaW4gSE9TVE5BTUU6CisgICAgICAg IHJldHVybgogICAgIGlmIG5vdCB0b19lbWFpbHM6CiAgICAgICAgIHByaW50KCdFcnJvcjogc2tp cHBpbmcgZW1haWwgc2luY2Ugbm8gcmVjaXBpZW50IGlzIHNwZWNpZmllZCcpCiAgICAgICAgIHJl dHVybgo= 412525 2020-10-28 06:38:46 -0700 2020-10-28 08:21:10 -0700 Patch bug-218227-20201028093845.patch text/plain 1534 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2OTEwMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDIwLTEwLTI4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBFbnN1cmUgdGhhdCB1YXQgaW5zdGFuY2UgZG9lc24ndCBzZW5k IGVtYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjE4MjI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBDSVN1cHBvcnQvZXdzLWJ1aWxkL3NlbmRfZW1haWwucHk6CisKIDIwMjAtMTAtMjggIFBoaWxp cHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtGbGF0cGFrIFNE S10gVXBkYXRlIE1lc2EgYW5kIEdUSzQgZGVwZW5kZW5jaWVzCkluZGV4OiBUb29scy9DSVN1cHBv cnQvZXdzLWJ1aWxkL3NlbmRfZW1haWwucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ0lTdXBwb3J0 L2V3cy1idWlsZC9zZW5kX2VtYWlsLnB5CShyZXZpc2lvbiAyNjkxMDIpCisrKyBUb29scy9DSVN1 cHBvcnQvZXdzLWJ1aWxkL3NlbmRfZW1haWwucHkJKHdvcmtpbmcgY29weSkKQEAgLTIzLDYgKzIz LDcgQEAKIGltcG9ydCBqc29uCiBpbXBvcnQgb3MKIGltcG9ydCBzbXRwbGliCitpbXBvcnQgc29j a2V0CiAKIGZyb20gZW1haWwubWltZS50ZXh0IGltcG9ydCBNSU1FVGV4dAogCkBAIC0zMiw2ICsz Myw3IEBAIEZST01fRU1BSUwgPSAnZXdzQHdlYmtpdC5vcmcnCiBJR0FMSUFfSlNDX1FVRVVFU19Q QVRURVJOUyA9IFsnYXJtdjcnLCAnbWlwcycsICdpMzg2J10KIElHQUxJQV9HVEtfV1BFX1FVRVVF U19QQVRURVJOUyA9IFsnZ3RrJywgJ3dwZSddCiBTRVJWRVIgPSAnbG9jYWxob3N0JworSE9TVE5B TUUgPSBzb2NrZXQuZ2V0aG9zdG5hbWUoKS5zdHJpcCgpCiAKIAogZGVmIGdldF9lbWFpbF9pZHMo Y2F0ZWdvcnkpOgpAQCAtNDcsNiArNDksOSBAQCBkZWYgZ2V0X2VtYWlsX2lkcyhjYXRlZ29yeSk6 CiBkZWYgc2VuZF9lbWFpbCh0b19lbWFpbHMsIHN1YmplY3QsIHRleHQsIHJlZmVyZW5jZT0nJyk6 CiAgICAgaWYgaXNfdGVzdF9tb2RlX2VuYWJsZWQ6CiAgICAgICAgIHJldHVybgorICAgIGlmIEhP U1ROQU1FICE9ICdld3MtYnVpbGQud2Via2l0Lm9yZyc6CisgICAgICAgICMgT25seSBhbGxvdyBF V1MgcHJvZHVjdGlvbiBpbnN0YW5jZSB0byBzZW5kIGVtYWlscy4KKyAgICAgICAgcmV0dXJuCiAg ICAgaWYgbm90IHRvX2VtYWlsczoKICAgICAgICAgcHJpbnQoJ0Vycm9yOiBza2lwcGluZyBlbWFp bCBzaW5jZSBubyByZWNpcGllbnQgaXMgc3BlY2lmaWVkJykKICAgICAgICAgcmV0dXJuCg== 412529 2020-10-28 08:21:13 -0700 2020-10-28 09:17:14 -0700 Patch bug-218227-20201028112112.patch text/plain 1588 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2OTEwMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDIwLTEwLTI4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBFbnN1cmUgdGhhdCB1YXQgaW5zdGFuY2UgZG9lc24ndCBzZW5k IGVtYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjE4MjI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSm9uYXRoYW4gQmVkYXJkLgorCisgICAgICAg ICogQ0lTdXBwb3J0L2V3cy1idWlsZC9zZW5kX2VtYWlsLnB5OgorCiAyMDIwLTEwLTI4ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbRmxhdHBhayBT REtdIFVwZGF0ZSBNZXNhIGFuZCBHVEs0IGRlcGVuZGVuY2llcwpJbmRleDogVG9vbHMvQ0lTdXBw b3J0L2V3cy1idWlsZC9zZW5kX2VtYWlsLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NJU3VwcG9y dC9ld3MtYnVpbGQvc2VuZF9lbWFpbC5weQkocmV2aXNpb24gMjY5MTAyKQorKysgVG9vbHMvQ0lT dXBwb3J0L2V3cy1idWlsZC9zZW5kX2VtYWlsLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yMywxMSAr MjMsMTQgQEAKIGltcG9ydCBqc29uCiBpbXBvcnQgb3MKIGltcG9ydCBzbXRwbGliCitpbXBvcnQg c29ja2V0CiAKIGZyb20gZW1haWwubWltZS50ZXh0IGltcG9ydCBNSU1FVGV4dAogCiBpc190ZXN0 X21vZGVfZW5hYmxlZCA9IG9zLmdldGVudignQlVJTERCT1RfUFJPRFVDVElPTicpIGlzIE5vbmUK IAorQ1VSUkVOVF9IT1NUTkFNRSA9IHNvY2tldC5nZXRob3N0bmFtZSgpLnN0cmlwKCkKK0VXU19C VUlMRF9IT1NUTkFNRSA9ICdld3MtYnVpbGQud2Via2l0Lm9yZycKIEZST01fRU1BSUwgPSAnZXdz QHdlYmtpdC5vcmcnCiBJR0FMSUFfSlNDX1FVRVVFU19QQVRURVJOUyA9IFsnYXJtdjcnLCAnbWlw cycsICdpMzg2J10KIElHQUxJQV9HVEtfV1BFX1FVRVVFU19QQVRURVJOUyA9IFsnZ3RrJywgJ3dw ZSddCkBAIC00Nyw2ICs1MCw5IEBAIGRlZiBnZXRfZW1haWxfaWRzKGNhdGVnb3J5KToKIGRlZiBz ZW5kX2VtYWlsKHRvX2VtYWlscywgc3ViamVjdCwgdGV4dCwgcmVmZXJlbmNlPScnKToKICAgICBp ZiBpc190ZXN0X21vZGVfZW5hYmxlZDoKICAgICAgICAgcmV0dXJuCisgICAgaWYgQ1VSUkVOVF9I T1NUTkFNRSAhPSBFV1NfQlVJTERfSE9TVE5BTUU6CisgICAgICAgICMgT25seSBhbGxvdyBFV1Mg cHJvZHVjdGlvbiBpbnN0YW5jZSB0byBzZW5kIGVtYWlscy4KKyAgICAgICAgcmV0dXJuCiAgICAg aWYgbm90IHRvX2VtYWlsczoKICAgICAgICAgcHJpbnQoJ0Vycm9yOiBza2lwcGluZyBlbWFpbCBz aW5jZSBubyByZWNpcGllbnQgaXMgc3BlY2lmaWVkJykKICAgICAgICAgcmV0dXJuCg==