21822 2008-10-22 19:48:44 -0700 Correct Windows (Cairo) Build 2008-10-23 13:36:59 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 bfulgham webkit-unassigned oldest_to_newest 96285 0 bfulgham 2008-10-22 19:48:44 -0700 I had mistakenly changed the stub ResourceRequest.h for Curl-based WebKit from my original dummy structure to a void*, believing that this worked just as well. Unfortunately, I had not properly rebuilt, so my original structure-based implementation was still being used in the WebKit.dll build. When I retrieved the updated sources with my 'new' change and rebuild, I found that WebKit.dll would not compile due to conflict between the definition in WebKit.h. The attached patch returns to my original dummy structure, which satisfies the compiler dependencies set by the WebKit.idl interface. 96289 1 24587 bfulgham 2008-10-22 20:04:42 -0700 Created attachment 24587 Patch to correct Cairo build (Windows) 96291 2 24589 bfulgham 2008-10-22 21:11:02 -0700 Created attachment 24589 Patch to correct build issues in WebKit. 96403 3 sam 2008-10-23 13:36:59 -0700 Landed in r37823. 24587 2008-10-22 20:04:42 -0700 2008-10-22 21:11:35 -0700 Patch to correct Cairo build (Windows) struct.patch text/plain 1580 bfulgham SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNzgwMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMTAtMjIgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V0FSTklORzogTk8gVEVTVCBDQVNFUyBBRERFRCBPUiBDSEFOR0VECisKKyAgICAgICAgKiBwbGF0 Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VSZXF1ZXN0Lmg6ICBIYW5kbGUgQ0ZVUkxSZXF1ZXN0 IGFzIGEKKyAgICAgICAgICBzdHJ1Y3R1cmUsIHJhdGhlciB0aGFuIGEgdm9pZCogdG8gaGF2ZSBi ZXR0ZXIgY29tcGF0aWJpbGl0eSB3aXRoIHRoZQorICAgICAgICAgIFdlYktpdC5pZGwgaW50ZXJm YWNlLgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0OjpjZlVSTFJlcXVlc3QpOgor CiAyMDA4LTEwLTIyICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAg ICAgQnVnIDIxNzgxOiBXZWJDb3JlOjpTZXR0aW5ncyBzaG91bGQgaGF2ZSBhIG1heGltdW0gZGVj b2RlZCBpbWFnZSBzaXplIHNldHRpbmcKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9j dXJsL1Jlc291cmNlUmVxdWVzdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9jdXJsL1Jlc291cmNlUmVxdWVzdC5oCShyZXZpc2lvbiAzNzc5OCkKKysrIFdlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlUmVxdWVzdC5oCSh3b3JraW5nIGNvcHkpCkBA IC0yOSw3ICsyOSwxMiBAQAogCiAjaW5jbHVkZSAiUmVzb3VyY2VSZXF1ZXN0QmFzZS5oIgogCi10 eXBlZGVmIGNvbnN0IHZvaWQqIENGVVJMUmVxdWVzdFJlZjsKK3N0cnVjdCBfQ0ZVUkxSZXF1ZXN0 Cit7CisgICBpbnQgaWdub3JlTWU7Cit9OworCit0eXBlZGVmIGNvbnN0IHN0cnVjdCBfQ0ZVUkxS ZXF1ZXN0KiBDRlVSTFJlcXVlc3RSZWY7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtNTcs NyArNjIsMTIgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB9CiAKICAgICAgICAgLy8g TmVlZGVkIGZvciBjb21wYXRpYmlsaXR5LgotICAgICAgICBDRlVSTFJlcXVlc3RSZWYgY2ZVUkxS ZXF1ZXN0KCkgY29uc3QgeyByZXR1cm4gMDsgfQorICAgICAgICAvLyBOZWVkZWQgZm9yIGNvbXBh dGliaWxpdHkuCisgICAgICAgIENGVVJMUmVxdWVzdFJlZiBjZlVSTFJlcXVlc3QoKSBjb25zdCAK KyAgICAgICAgeworICAgICAgICAgICBzdGF0aWMgX0NGVVJMUmVxdWVzdCBpZ25vcmVNZTsKKyAg ICAgICAgICAgcmV0dXJuICZpZ25vcmVNZTsgCisgICAgICAgIH0KIAogICAgIHByaXZhdGU6CiAg ICAgICAgIGZyaWVuZCBjbGFzcyBSZXNvdXJjZVJlcXVlc3RCYXNlOwo= 24589 2008-10-22 21:11:02 -0700 2008-10-22 21:17:07 -0700 Patch to correct build issues in WebKit. struct.patch text/plain 1149 bfulgham SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNzgwMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMTAtMjIgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V0FSTklORzogTk8gVEVTVCBDQVNFUyBBRERFRCBPUiBDSEFOR0VECisKKyAgICAgICAgKiBwbGF0 Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VSZXF1ZXN0Lmg6ICBBIGJldHRlciBpbXBsZW1lbnRh dGlvbgorICAgICAgICAgIG9mIENGVVJMUmVxdWVzdCwgcmF0aGVyIHRoYW4gdm9pZCouICBUaGlz IGdpdmVzIGJldHRlciBjb21wYXRpYmlsaXR5IAorICAgICAgICAgIHdpdGggdGhlIFdlYktpdC5p ZGwgaW50ZXJmYWNlLgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0OjpjZlVSTFJl cXVlc3QpOgorCiAyMDA4LTEwLTIyICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+ CiAKICAgICAgICAgQnVnIDIxNzgxOiBXZWJDb3JlOjpTZXR0aW5ncyBzaG91bGQgaGF2ZSBhIG1h eGltdW0gZGVjb2RlZCBpbWFnZSBzaXplIHNldHRpbmcKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9jdXJsL1Jlc291cmNlUmVxdWVzdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlUmVxdWVzdC5oCShyZXZpc2lvbiAzNzc5OCkKKysr IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlUmVxdWVzdC5oCSh3b3JraW5n IGNvcHkpCkBAIC0yOSw3ICsyOSw3IEBACiAKICNpbmNsdWRlICJSZXNvdXJjZVJlcXVlc3RCYXNl LmgiCiAKLXR5cGVkZWYgY29uc3Qgdm9pZCogQ0ZVUkxSZXF1ZXN0UmVmOwordHlwZWRlZiBjb25z dCBzdHJ1Y3QgX0NGVVJMUmVxdWVzdCogQ0ZVUkxSZXF1ZXN0UmVmOwogCiBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAK