218203 2020-10-26 13:57:51 -0700 evictCodedFrames does extra work if RELEASE_LOG_DISABLED is set 2020-10-26 16:48:18 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo webkit-unassigned calvaris eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1701606 0 stephan.szabo 2020-10-26 13:57:51 -0700 We found on our port where we have RELEASE_LOG_DISABLED set that evictCodedFrames would sometimes evict after the current position even if it freed up enough space during the first part of the eviction. It looks like a log change from a while ago changed the block that checked whether the buffer was still full and to log and return to only happen if logging was not disabled which changed the behavior since the return no longer happened either. 1701643 1 412356 stephan.szabo 2020-10-26 14:44:27 -0700 Created attachment 412356 Patch 1701681 2 ews-feeder 2020-10-26 16:47:23 -0700 Committed r269001: <https://trac.webkit.org/changeset/269001> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412356. 1701682 3 webkit-bug-importer 2020-10-26 16:48:18 -0700 <rdar://problem/70701318> 412356 2020-10-26 14:44:27 -0700 2020-10-26 16:47:24 -0700 Patch 218203.1.diff text/plain 1636 stephan.szabo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkYzE3OTVmYzhjMTIuLmEyNGJjNTAyMjhkNSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE2IEBACisyMDIwLTEwLTI2ICBTdGVwaGFuIFN6YWJvICA8c3RlcGhhbi5zemFib0Bz b255LmNvbT4KKworICAgICAgICBldmljdENvZGVkRnJhbWVzIGRvZXMgZXh0cmEgd29yayBpZiBS RUxFQVNFX0xPR19ESVNBQkxFRCBpcyBzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxODIwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFVuZG8gcGFydCBvZiBwcmV2aW91cyBsb2dnaW5nIGNoYW5nZSB0 aGF0IHByZXZlbnRzIGNoZWNraW5nCisgICAgICAgIGlmIHRoZSBidWZmZXIgaXMgc3RpbGwgZnVs bCBhZnRlciB0aGUgZmlyc3QgcGFydCBvZiBldmljdGlvbgorICAgICAgICBpZiBSRUxFQVNFX0xP R19ESVNBQkxFRCBpcyBzZXQuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc291cmNlL1NvdXJj ZUJ1ZmZlci5jcHA6CisKIDIwMjAtMTAtMjYgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUu Y29tPgogCiAgICAgICAgIFVzZSBhIFdlYWtIYXNoU2V0IGZvciBEb2N1bWVudDo6bV9jYXB0aW9u UHJlZmVyZW5jZXNDaGFuZ2VkRWxlbWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvbWVkaWFzb3VyY2UvU291cmNlQnVmZmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvbWVkaWFzb3VyY2UvU291cmNlQnVmZmVyLmNwcAppbmRleCA3ZmViN2M2NjhmNTIuLjllZTg1 YjExNDM2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNvdXJjZS9T b3VyY2VCdWZmZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2Uv U291cmNlQnVmZmVyLmNwcApAQCAtOTc0LDEyICs5NzQsMTIgQEAgdm9pZCBTb3VyY2VCdWZmZXI6 OmV2aWN0Q29kZWRGcmFtZXMoc2l6ZV90IG5ld0RhdGFTaXplKQogICAgICAgICByYW5nZUVuZCAr PSB0aGlydHlTZWNvbmRzOwogICAgIH0KIAotI2lmICFSRUxFQVNFX0xPR19ESVNBQkxFRAogICAg IGlmICghbV9idWZmZXJGdWxsKSB7CisjaWYgIVJFTEVBU0VfTE9HX0RJU0FCTEVECiAgICAgICAg IERFQlVHX0xPRyhMT0dJREVOVElGSUVSLCAiZXZpY3RlZCAiLCBpbml0aWFsQnVmZmVyZWRTaXpl IC0gZXh0cmFNZW1vcnlDb3N0KCkpOworI2VuZGlmCiAgICAgICAgIHJldHVybjsKICAgICB9Ci0j ZW5kaWYKIAogICAgIC8vIElmIHRoZXJlIHN0aWxsIGlzbid0IGVub3VnaCBmcmVlIHNwYWNlIGFu ZCB0aGVyZSBidWZmZXJzIGluIHRpbWUgcmFuZ2VzIGFmdGVyIHRoZSBjdXJyZW50IHJhbmdlIChp ZS4gdGhlcmUgaXMgYSBnYXAgYWZ0ZXIKICAgICAvLyB0aGUgY3VycmVudCBidWZmZXJlZCByYW5n ZSksIGRlbGV0ZSAzMCBzZWNvbmRzIGF0IGEgdGltZSBmcm9tIGR1cmF0aW9uIGJhY2sgdG8gdGhl IGN1cnJlbnQgdGltZSByYW5nZSBvciAzMCBzZWNvbmRzIGFmdGVyCg==