218175 2020-10-26 04:13:10 -0700 [EME][GStreamer] Decode base64 init data if needed 2020-10-28 04:48:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 218174 218238 1 calvaris calvaris cgarcia ews-watchlist gustavo menard pnormand vjaquez webkit-bug-importer oldest_to_newest 1701388 0 calvaris 2020-10-26 04:13:10 -0700 [EME][GStreamer] Decode base64 init data if needed 1701389 1 412304 calvaris 2020-10-26 04:14:55 -0700 Created attachment 412304 Patch 1701393 2 412304 pnormand 2020-10-26 04:40:15 -0700 Comment on attachment 412304 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412304&action=review > Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:81 > + GST_CAT_LEVEL_LOG(webkit_media_common_encryption_decrypt_debug_category, GST_LEVEL_TRACE, nullptr, "payload size %zu", m_payload->size()); Seems like this would work only because of unified builds? Can you declare a dedicated log category for this module and make it default? It would reduce macro verbosity and also be useful for the GST_ERROR call in this file. 1701469 3 calvaris 2020-10-26 09:26:15 -0700 (In reply to Philippe Normand from comment #2) > Comment on attachment 412304 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=412304&action=review > > > Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:81 > > + GST_CAT_LEVEL_LOG(webkit_media_common_encryption_decrypt_debug_category, GST_LEVEL_TRACE, nullptr, "payload size %zu", m_payload->size()); > > Seems like this would work only because of unified builds? Can you declare a > dedicated log category for this module and make it default? It would reduce > macro verbosity and also be useful for the GST_ERROR call in this file. This is a header file. Declaring a default category seems a bad idea, right? 1701472 4 calvaris 2020-10-26 09:28:15 -0700 The build problem should be solved by landing patch for bug 218174 first. 1701489 5 412304 pnormand 2020-10-26 09:57:38 -0700 Comment on attachment 412304 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412304&action=review >>> Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:81 >>> + GST_CAT_LEVEL_LOG(webkit_media_common_encryption_decrypt_debug_category, GST_LEVEL_TRACE, nullptr, "payload size %zu", m_payload->size()); >> >> Seems like this would work only because of unified builds? Can you declare a dedicated log category for this module and make it default? It would reduce macro verbosity and also be useful for the GST_ERROR call in this file. > > This is a header file. Declaring a default category seems a bad idea, right? Not if you use GST_DEBUG_CATEGORY_EXTERN. 1701828 6 412411 calvaris 2020-10-27 05:05:39 -0700 Created attachment 412411 Patch 1701840 7 ews-feeder 2020-10-27 06:00:46 -0700 Committed r269033: <https://trac.webkit.org/changeset/269033> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412411. 1701842 8 webkit-bug-importer 2020-10-27 06:01:22 -0700 <rdar://problem/70719469> 1701895 9 calvaris 2020-10-27 09:02:10 -0700 It looks this patch makes media/encrypted-media/clearKey/clearKey-webm-video-playback-mse.html timeout. I'm on it. 1702269 10 calvaris 2020-10-28 04:40:39 -0700 Reverted r269033 for reason: 269043 Committed r269097: <https://trac.webkit.org/changeset/269097> 1702271 11 calvaris 2020-10-28 04:48:14 -0700 This solution ain't good, I need to find another one. Reverted and closing. 412304 2020-10-26 04:14:55 -0700 2020-10-27 05:05:34 -0700 Patch bug-218175-20201026121453.patch text/plain 3026 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4OTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDVkNTc1ZDNiMDc5MDc2 MDRhY2RjM2ExNDRhMTkxOTg2ZmQwMDg0Yy4uMTA1OGUxZTI4MmZiYWM1OThkZjEyZmI2YTlmNjdl ZmU5ZjVkNjZhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTEwLTI2ICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0VN RV1bR1N0cmVhbWVyXSBEZWNvZGUgYmFzZTY0IGluaXQgZGF0YSBpZiBuZWVkZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODE3NQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGFyZSBjZXJ0YWlu IHN0cmluZ3Mgd2l0aCBjZXJ0YWluIGtleSBzeXN0ZW1zIHRoYXQgZGVsaXZlcgorICAgICAgICBp bml0aWFsaXphdGlvbiBkYXRhIGVuY29kZWQgYXMgYmFzZTY0IHNvIHdlIG5lZWQgdG8gZGVjb2Rl IGl0CisgICAgICAgIGZpcnN0LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVh bWVyL2VtZS9HU3RyZWFtZXJFTUVVdGlsaXRpZXMuaDoKKyAgICAgICAgKFdlYkNvcmU6OkluaXRE YXRhOjpJbml0RGF0YSk6CisgICAgICAgIChXZWJDb3JlOjpJbml0RGF0YTo6ZGVjb2RlQmFzZTY0 SWZOZWVkZWQpOgorCiAyMDIwLTEwLTI0ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBw bGUuY29tPgogCiAgICAgICAgIFtMRkMgRGlzcGxheV0gSW1wbGVtZW50IGJhY2tncm91bmQgaW1h Z2UgcGFpbnRpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9lbWUvR1N0cmVhbWVyRU1FVXRpbGl0aWVzLmggYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvZW1lL0dTdHJlYW1lckVNRVV0aWxpdGllcy5oCmlu ZGV4IDQ0ZGM4MjhmNDA3YTk5NjM5MDdjYjFmOTg1MjdkZmRlYjg1NDEzNzEuLjNiM2NhYzFkZjUx ZGY2Zjc0OWJmNmM3NmE0ZWFhOTM5YjM3M2Y4ZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9lbWUvR1N0cmVhbWVyRU1FVXRpbGl0aWVzLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL2VtZS9HU3Ry ZWFtZXJFTUVVdGlsaXRpZXMuaApAQCAtMjYsNiArMjYsNyBAQAogI2luY2x1ZGUgIkdTdHJlYW1l ckNvbW1vbi5oIgogI2luY2x1ZGUgIlNoYXJlZEJ1ZmZlci5oIgogI2luY2x1ZGUgPGdzdC9nc3Qu aD4KKyNpbmNsdWRlIDx3dGYvdGV4dC9CYXNlNjQuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZT dHJpbmcuaD4KIAogI2RlZmluZSBXRUJDT1JFX0dTVFJFQU1FUl9FTUVfVVRJTElUSUVTX0NMRUFS S0VZX1VVSUQgIjEwNzdlZmVjLWMwYjItNGQwMi1hY2UzLTNjMWU1MmUyZmI0YiIKQEAgLTQ5LDEy ICs1MCwxNCBAQCBwdWJsaWM6CiAgICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAg ICAgICAgfQogICAgICAgICBtX3BheWxvYWQgPSBtYXBwZWRJbml0RGF0YS0+Y3JlYXRlU2hhcmVk QnVmZmVyKCk7CisgICAgICAgIGRlY29kZUJhc2U2NElmTmVlZGVkKCk7CiAgICAgfQogCiAgICAg SW5pdERhdGEoY29uc3QgU3RyaW5nJiBzeXN0ZW1JZCwgUmVmUHRyPFNoYXJlZEJ1ZmZlcj4mJiBw YXlsb2FkKQogICAgICAgICA6IG1fc3lzdGVtSWQoc3lzdGVtSWQpCiAgICAgICAgICwgbV9wYXls b2FkKFdURk1vdmUocGF5bG9hZCkpCiAgICAgeworICAgICAgICBkZWNvZGVCYXNlNjRJZk5lZWRl ZCgpOwogICAgIH0KIAogICAgIHZvaWQgYXBwZW5kKEluaXREYXRhJiYgaW5pdERhdGEpCkBAIC03 Myw2ICs3NiwyMiBAQCBwdWJsaWM6CiAgICAgICAgIG1fcGF5bG9hZC0+YXBwZW5kKCppbml0RGF0 YS5wYXlsb2FkKCkpOwogICAgIH0KIAorICAgIHZvaWQgZGVjb2RlQmFzZTY0SWZOZWVkZWQoKQor ICAgIHsKKyAgICAgICAgR1NUX0NBVF9MRVZFTF9MT0cod2Via2l0X21lZGlhX2NvbW1vbl9lbmNy eXB0aW9uX2RlY3J5cHRfZGVidWdfY2F0ZWdvcnksIEdTVF9MRVZFTF9UUkFDRSwgbnVsbHB0ciwg InBheWxvYWQgc2l6ZSAlenUiLCBtX3BheWxvYWQtPnNpemUoKSk7CisgICAgICAgIGlmICghbV9w YXlsb2FkLT5zaXplKCkpCisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgVmVjdG9yPGNo YXI+IG91dDsKKyAgICAgICAgaWYgKCFiYXNlNjREZWNvZGUobV9wYXlsb2FkLT5kYXRhKCksIG1f cGF5bG9hZC0+c2l6ZSgpLCBvdXQpKSB7CisgICAgICAgICAgICBHU1RfQ0FUX0xFVkVMX0xPRyh3 ZWJraXRfbWVkaWFfY29tbW9uX2VuY3J5cHRpb25fZGVjcnlwdF9kZWJ1Z19jYXRlZ29yeSwgR1NU X0xFVkVMX1RSQUNFLCBudWxscHRyLCAicGF5bG9hZCBkaWQgbm90IGRlY29kZSBiYXNlNjQsIGNv bnNpZGVyaW5nIG9rIik7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKworICAgICAg ICBHU1RfQ0FUX0xFVkVMX0xPRyh3ZWJraXRfbWVkaWFfY29tbW9uX2VuY3J5cHRpb25fZGVjcnlw dF9kZWJ1Z19jYXRlZ29yeSwgR1NUX0xFVkVMX1RSQUNFLCBudWxscHRyLCAicGF5bG9hZCBkZWNv ZGVkIHRvIGJhc2U2NCwgbmV3IHNpemUgJXp1Iiwgb3V0LnNpemUoKSk7CisgICAgICAgIG1fcGF5 bG9hZCA9IFNoYXJlZEJ1ZmZlcjo6Y3JlYXRlKG91dC5kYXRhKCksIG91dC5zaXplKCkpOworICAg IH0KKwogICAgIGNvbnN0IFJlZlB0cjxTaGFyZWRCdWZmZXI+JiBwYXlsb2FkKCkgY29uc3QgeyBy ZXR1cm4gbV9wYXlsb2FkOyB9CiAgICAgY29uc3QgU3RyaW5nJiBzeXN0ZW1JZCgpIGNvbnN0IHsg cmV0dXJuIG1fc3lzdGVtSWQ7IH0KICAgICBTdHJpbmcgcGF5bG9hZENvbnRhaW5lclR5cGUoKSBj b25zdAo= 412411 2020-10-27 05:05:39 -0700 2020-10-27 06:00:46 -0700 Patch bug-218175-20201027130538.patch text/plain 3028 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MDMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjlmODAwMjNiMTUyOWQ3 ZjM0OTk5MGEwZTEyMzg1Zjk5Yzc2ZDZlZC4uMmRmZmRiZTY1NzdmZWI5OTU3NWM0MmZjZTQ4YzE5 OGM1OWZkZWUyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTEwLTI3ICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0VN RV1bR1N0cmVhbWVyXSBEZWNvZGUgYmFzZTY0IGluaXQgZGF0YSBpZiBuZWVkZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODE3NQorCisgICAgICAg IFJldmlld2VkIGJ5IFBoaWxpcHBlIE5vcm1hbmQuCisKKyAgICAgICAgVGhlcmUgYXJlIGNlcnRh aW4gc3RyaW5ncyB3aXRoIGNlcnRhaW4ga2V5IHN5c3RlbXMgdGhhdCBkZWxpdmVyCisgICAgICAg IGluaXRpYWxpemF0aW9uIGRhdGEgZW5jb2RlZCBhcyBiYXNlNjQgc28gd2UgbmVlZCB0byBkZWNv ZGUgaXQKKyAgICAgICAgZmlyc3QuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvZW1lL0dTdHJlYW1lckVNRVV0aWxpdGllcy5oOgorICAgICAgICAoV2ViQ29yZTo6SW5p dERhdGE6OkluaXREYXRhKToKKyAgICAgICAgKFdlYkNvcmU6OkluaXREYXRhOjpkZWNvZGVCYXNl NjRJZk5lZWRlZCk6CisKIDIwMjAtMTAtMjcgIFhhYmllciBSb2RyaWd1ZXogQ2FsdmFyICA8Y2Fs dmFyaXNAaWdhbGlhLmNvbT4KIAogICAgICAgICBbRU1FXVtHU3RyZWFtZXJdIEZpeCBsb2dnaW5n IGluIHV0aWxpdGllcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL2VtZS9HU3RyZWFtZXJFTUVVdGlsaXRpZXMuaCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9lbWUvR1N0cmVhbWVyRU1FVXRpbGl0aWVzLmgK aW5kZXggODk5M2EzYjA2YTQ1ZGM0OWIxMzBlNDUzMzIwOTY3NjZkZDE3NTI1OC4uMTdlZjAxODU1 MDE1NWI3YzFkYzBhMzVmNjY3MWE1YjVmMzBiYWNmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL2VtZS9HU3RyZWFtZXJFTUVVdGlsaXRpZXMu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvZW1lL0dT dHJlYW1lckVNRVV0aWxpdGllcy5oCkBAIC0yNiw2ICsyNiw3IEBACiAjaW5jbHVkZSAiR1N0cmVh bWVyQ29tbW9uLmgiCiAjaW5jbHVkZSAiU2hhcmVkQnVmZmVyLmgiCiAjaW5jbHVkZSA8Z3N0L2dz dC5oPgorI2luY2x1ZGUgPHd0Zi90ZXh0L0Jhc2U2NC5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dU RlN0cmluZy5oPgogCiAjZGVmaW5lIFdFQkNPUkVfR1NUUkVBTUVSX0VNRV9VVElMSVRJRVNfQ0xF QVJLRVlfVVVJRCAiMTA3N2VmZWMtYzBiMi00ZDAyLWFjZTMtM2MxZTUyZTJmYjRiIgpAQCAtNTEs MTIgKzUyLDE0IEBAIHB1YmxpYzoKICAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwog ICAgICAgICB9CiAgICAgICAgIG1fcGF5bG9hZCA9IG1hcHBlZEluaXREYXRhLT5jcmVhdGVTaGFy ZWRCdWZmZXIoKTsKKyAgICAgICAgZGVjb2RlQmFzZTY0SWZOZWVkZWQoKTsKICAgICB9CiAKICAg ICBJbml0RGF0YShjb25zdCBTdHJpbmcmIHN5c3RlbUlkLCBSZWZQdHI8U2hhcmVkQnVmZmVyPiYm IHBheWxvYWQpCiAgICAgICAgIDogbV9zeXN0ZW1JZChzeXN0ZW1JZCkKICAgICAgICAgLCBtX3Bh eWxvYWQoV1RGTW92ZShwYXlsb2FkKSkKICAgICB7CisgICAgICAgIGRlY29kZUJhc2U2NElmTmVl ZGVkKCk7CiAgICAgfQogCiAgICAgdm9pZCBhcHBlbmQoSW5pdERhdGEmJiBpbml0RGF0YSkKQEAg LTc1LDYgKzc4LDIyIEBAIHB1YmxpYzoKICAgICAgICAgbV9wYXlsb2FkLT5hcHBlbmQoKmluaXRE YXRhLnBheWxvYWQoKSk7CiAgICAgfQogCisgICAgdm9pZCBkZWNvZGVCYXNlNjRJZk5lZWRlZCgp CisgICAgeworICAgICAgICBHU1RfQ0FUX0xFVkVMX0xPRyh3ZWJraXRfbWVkaWFfY29tbW9uX2Vu Y3J5cHRpb25fZGVjcnlwdF9kZWJ1Z19jYXRlZ29yeSwgR1NUX0xFVkVMX1RSQUNFLCBudWxscHRy LCAicGF5bG9hZCBzaXplICV6dSIsIG1fcGF5bG9hZC0+c2l6ZSgpKTsKKyAgICAgICAgaWYgKCFt X3BheWxvYWQtPnNpemUoKSkKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICBWZWN0b3I8 Y2hhcj4gb3V0OworICAgICAgICBpZiAoIWJhc2U2NERlY29kZShtX3BheWxvYWQtPmRhdGEoKSwg bV9wYXlsb2FkLT5zaXplKCksIG91dCkpIHsKKyAgICAgICAgICAgIEdTVF9DQVRfTEVWRUxfTE9H KHdlYmtpdF9tZWRpYV9jb21tb25fZW5jcnlwdGlvbl9kZWNyeXB0X2RlYnVnX2NhdGVnb3J5LCBH U1RfTEVWRUxfVFJBQ0UsIG51bGxwdHIsICJwYXlsb2FkIGRpZCBub3QgZGVjb2RlIGJhc2U2NCwg Y29uc2lkZXJpbmcgb2siKTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorCisgICAg ICAgIEdTVF9DQVRfTEVWRUxfTE9HKHdlYmtpdF9tZWRpYV9jb21tb25fZW5jcnlwdGlvbl9kZWNy eXB0X2RlYnVnX2NhdGVnb3J5LCBHU1RfTEVWRUxfVFJBQ0UsIG51bGxwdHIsICJwYXlsb2FkIGRl Y29kZWQgdG8gYmFzZTY0LCBuZXcgc2l6ZSAlenUiLCBvdXQuc2l6ZSgpKTsKKyAgICAgICAgbV9w YXlsb2FkID0gU2hhcmVkQnVmZmVyOjpjcmVhdGUob3V0LmRhdGEoKSwgb3V0LnNpemUoKSk7Cisg ICAgfQorCiAgICAgY29uc3QgUmVmUHRyPFNoYXJlZEJ1ZmZlcj4mIHBheWxvYWQoKSBjb25zdCB7 IHJldHVybiBtX3BheWxvYWQ7IH0KICAgICBjb25zdCBTdHJpbmcmIHN5c3RlbUlkKCkgY29uc3Qg eyByZXR1cm4gbV9zeXN0ZW1JZDsgfQogICAgIFN0cmluZyBwYXlsb2FkQ29udGFpbmVyVHlwZSgp IGNvbnN0Cg==