218174 2020-10-26 04:09:01 -0700 [EME][GStreamer] Fix logging in utilities 2020-10-27 04:42:23 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 218175 1 calvaris calvaris cgarcia ews-watchlist gustavo menard pnormand vjaquez webkit-bug-importer oldest_to_newest 1701386 0 calvaris 2020-10-26 04:09:01 -0700 [EME][GStreamer] Fix logging in utilities 1701387 1 412303 calvaris 2020-10-26 04:11:22 -0700 Created attachment 412303 Patch 1701394 2 412303 pnormand 2020-10-26 04:42:15 -0700 Comment on attachment 412303 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412303&action=review > Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:36 > +GST_DEBUG_CATEGORY_EXTERN(webkit_media_common_encryption_decrypt_debug_category); OK I am lost in all the bugs you opened :) Why not handle everything in a single patch? 1701456 3 calvaris 2020-10-26 08:01:36 -0700 (In reply to Philippe Normand from comment #2) > Comment on attachment 412303 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=412303&action=review > > > Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:36 > > +GST_DEBUG_CATEGORY_EXTERN(webkit_media_common_encryption_decrypt_debug_category); > > OK I am lost in all the bugs you opened :) Why not handle everything in a > single patch? Don't get lost, they just have consecutive numbers almost all of them! Now speaking more serious, they tackled different things, at least most of them 1701825 4 ews-feeder 2020-10-27 04:41:01 -0700 Committed r269031: <https://trac.webkit.org/changeset/269031> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412303. 1701826 5 webkit-bug-importer 2020-10-27 04:42:23 -0700 <rdar://problem/70717707> 412303 2020-10-26 04:11:22 -0700 2020-10-27 04:41:02 -0700 Patch bug-218174-20201026121121.patch text/plain 3087 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4OTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDVkNTc1ZDNiMDc5MDc2 MDRhY2RjM2ExNDRhMTkxOTg2ZmQwMDg0Yy4uM2EwNmJlM2RiNGU1NTMzNTJlNWVjOTU5ZDc0Y2Nm ODUzMzFiNTkxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTEwLTI2ICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0VN RV1bR1N0cmVhbWVyXSBGaXggbG9nZ2luZyBpbiB1dGlsaXRpZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODE3NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGlzIHNvbWUgbG9nZ2luZyBpbiBH U3RyZWFtZXJFTUVVdGlsaXRpZXMuaCB0aGF0IHdhcyBub3QKKyAgICAgICAgdXNpbmcgZGVidWdn aW5nIGNhdGVnb3JpZXMgcHJvcGVybHkuIEl0IGRvZXMgbm93LgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL2VtZS9HU3RyZWFtZXJFTUVVdGlsaXRpZXMuaDoKKyAgICAg ICAgKFdlYkNvcmU6OkluaXREYXRhOjpJbml0RGF0YSk6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL2VtZS9XZWJLaXRDb21tb25FbmNyeXB0aW9uRGVjcnlwdG9yR1N0cmVh bWVyLmNwcDoKKwogMjAyMC0xMC0yNCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxl LmNvbT4KIAogICAgICAgICBbTEZDIERpc3BsYXldIEltcGxlbWVudCBiYWNrZ3JvdW5kIGltYWdl IHBhaW50aW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvZW1lL0dTdHJlYW1lckVNRVV0aWxpdGllcy5oIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL2VtZS9HU3RyZWFtZXJFTUVVdGlsaXRpZXMuaAppbmRl eCA0NGRjODI4ZjQwN2E5OTYzOTA3Y2IxZjk4NTI3ZGZkZWI4NTQxMzcxLi44OTkzYTNiMDZhNDVk YzQ5YjEzMGU0NTMzMjA5Njc2NmRkMTc1MjU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvZW1lL0dTdHJlYW1lckVNRVV0aWxpdGllcy5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9lbWUvR1N0cmVh bWVyRU1FVXRpbGl0aWVzLmgKQEAgLTMzLDYgKzMzLDggQEAKICNkZWZpbmUgV0VCQ09SRV9HU1RS RUFNRVJfRU1FX1VUSUxJVElFU19XSURFVklORV9VVUlEICJlZGVmOGJhOS03OWQ2LTRhY2UtYTNj OC0yN2RjZDUxZDIxZWQiCiAjZW5kaWYKIAorR1NUX0RFQlVHX0NBVEVHT1JZX0VYVEVSTih3ZWJr aXRfbWVkaWFfY29tbW9uX2VuY3J5cHRpb25fZGVjcnlwdF9kZWJ1Z19jYXRlZ29yeSk7CisKIG5h bWVzcGFjZSBXZWJDb3JlIHsKIGNsYXNzIEluaXREYXRhIHsKIHB1YmxpYzoKQEAgLTQ1LDcgKzQ3 LDcgQEAgcHVibGljOgogICAgIHsKICAgICAgICAgYXV0byBtYXBwZWRJbml0RGF0YSA9IEdzdE1h cHBlZE93bmVkQnVmZmVyOjpjcmVhdGUoaW5pdERhdGEpOwogICAgICAgICBpZiAoIW1hcHBlZElu aXREYXRhKSB7Ci0gICAgICAgICAgICBHU1RfRVJST1IoImNhbm5vdCBtYXAgJXMgcHJvdGVjdGlv biBkYXRhIiwgc3lzdGVtSWQudXRmOCgpLmRhdGEoKSk7CisgICAgICAgICAgICBHU1RfQ0FUX0xF VkVMX0xPRyh3ZWJraXRfbWVkaWFfY29tbW9uX2VuY3J5cHRpb25fZGVjcnlwdF9kZWJ1Z19jYXRl Z29yeSwgR1NUX0xFVkVMX0VSUk9SLCBudWxscHRyLCAiY2Fubm90IG1hcCAlcyBwcm90ZWN0aW9u IGRhdGEiLCBzeXN0ZW1JZC51dGY4KCkuZGF0YSgpKTsKICAgICAgICAgICAgIEFTU0VSVF9OT1Rf UkVBQ0hFRCgpOwogICAgICAgICB9CiAgICAgICAgIG1fcGF5bG9hZCA9IG1hcHBlZEluaXREYXRh LT5jcmVhdGVTaGFyZWRCdWZmZXIoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9lbWUvV2ViS2l0Q29tbW9uRW5jcnlwdGlvbkRlY3J5cHRv ckdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt ZXIvZW1lL1dlYktpdENvbW1vbkVuY3J5cHRpb25EZWNyeXB0b3JHU3RyZWFtZXIuY3BwCmluZGV4 IGJlMjY1MWMwYzEzYzhlYmJlYzgzZDVkYzdhMzVhZmY4YjQzNWNhNzcuLmNmOWRlNjE5NmVkMDBk ZGRmMzgyMzNlMDAzNjE2NzUyMzdlMjdkMGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9lbWUvV2ViS2l0Q29tbW9uRW5jcnlwdGlvbkRlY3J5 cHRvckdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL2VtZS9XZWJLaXRDb21tb25FbmNyeXB0aW9uRGVjcnlwdG9yR1N0cmVhbWVyLmNw cApAQCAtNTQsNyArNTQsNyBAQCBzdGF0aWMgR3N0Rmxvd1JldHVybiB0cmFuc2Zvcm1JblBsYWNl KEdzdEJhc2VUcmFuc2Zvcm0qLCBHc3RCdWZmZXIqKTsKIHN0YXRpYyBnYm9vbGVhbiBzaW5rRXZl bnRIYW5kbGVyKEdzdEJhc2VUcmFuc2Zvcm0qLCBHc3RFdmVudCopOwogc3RhdGljIHZvaWQgc2V0 Q29udGV4dChHc3RFbGVtZW50KiwgR3N0Q29udGV4dCopOwogCi1HU1RfREVCVUdfQ0FURUdPUllf U1RBVElDKHdlYmtpdF9tZWRpYV9jb21tb25fZW5jcnlwdGlvbl9kZWNyeXB0X2RlYnVnX2NhdGVn b3J5KTsKK0dTVF9ERUJVR19DQVRFR09SWSh3ZWJraXRfbWVkaWFfY29tbW9uX2VuY3J5cHRpb25f ZGVjcnlwdF9kZWJ1Z19jYXRlZ29yeSk7CiAjZGVmaW5lIEdTVF9DQVRfREVGQVVMVCB3ZWJraXRf bWVkaWFfY29tbW9uX2VuY3J5cHRpb25fZGVjcnlwdF9kZWJ1Z19jYXRlZ29yeQogCiAjZGVmaW5l IHdlYmtpdF9tZWRpYV9jb21tb25fZW5jcnlwdGlvbl9kZWNyeXB0X3BhcmVudF9jbGFzcyBwYXJl bnRfY2xhc3MK