21813 2008-10-22 15:42:36 -0700 Enable custom properties for runtime objects in QtWebKit 2008-10-25 08:24:27 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 jade.han webkit-unassigned andersca hausmann vestbo oldest_to_newest 96246 0 jade.han 2008-10-22 15:42:36 -0700 Enabling custom properties for runtime objects allows us to do myNativeRuntimeObject.foo = "bar", which can be useful. 96247 1 24576 jade.han 2008-10-22 15:44:17 -0700 Created attachment 24576 This patch implements the feature 96269 2 24576 andersca 2008-10-22 17:48:29 -0700 Comment on attachment 24576 This patch implements the feature Are you sure you want to do this for all runtime objects and not just QtInstances? Neither WebKit nor Firefox support setting custom properties on NPObjects for example. 96329 3 jade.han 2008-10-23 06:57:01 -0700 You're right Anders, I will make a new patch that limits this behavior to QtInstance. 96330 4 24597 jade.han 2008-10-23 06:59:27 -0700 Created attachment 24597 patch that limits behavior to QtInstance, and also expands the autotest for custom properties 96331 5 24598 jade.han 2008-10-23 07:01:44 -0700 Created attachment 24598 similar to previous patch (limits to QtInstance), but removes debug statement 96337 6 24598 andersca 2008-10-23 09:04:50 -0700 Comment on attachment 24598 similar to previous patch (limits to QtInstance), but removes debug statement Looks great! r=me 96673 7 vestbo 2008-10-25 08:24:13 -0700 Thanks for the review Anders! Landed in r37889 24576 2008-10-22 15:44:17 -0700 2008-10-23 06:59:27 -0700 This patch implements the feature 0001-allowDynamicProperties.patch text/plain 1977 jade.han SW5kZXg6IFdlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcAkocmV2 aXNpb24gMzc3ODYpCisrKyBXZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC03ODMsNyArNzgzLDYgQEAKICAgICAvLyBub24tc2NyaXB0 YWJsZSBwcm9wZXJ0eQogICAgIFFDT01QQVJFKG1fbXlPYmplY3QtPmhpZGRlblByb3BlcnR5KCks IDQ1Ni4wKTsKICAgICBRQ09NUEFSRShldmFsSlMoIm15T2JqZWN0LmhpZGRlblByb3BlcnR5Iiks IHNVbmRlZmluZWQpOwotICAgIFFFWFBFQ1RfRkFJTCgiIiwgInVuZGVmaW5lZCBwcm9wZXJ0aWVz IG5vdCBzdXBwb3J0ZWQiLCBDb250aW51ZSk7CiAgICAgUUNPTVBBUkUoZXZhbEpTKCJteU9iamVj dC5oaWRkZW5Qcm9wZXJ0eSA9IDEyMzsiCiAgICAgICAgICAgICAgICAgICAgICJteU9iamVjdC5o aWRkZW5Qcm9wZXJ0eSA9PSAxMjMiKSwgc1RydWUpOwogICAgIFFDT01QQVJFKG1fbXlPYmplY3Qt PmhpZGRlblByb3BlcnR5KCksIDQ1Ni4wKTsKSW5kZXg6IFdlYkNvcmUvYnJpZGdlL3J1bnRpbWVf b2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JyaWRnZS9ydW50aW1lX29iamVjdC5j cHAJKHJldmlzaW9uIDM3Nzg2KQorKysgV2ViQ29yZS9icmlkZ2UvcnVudGltZV9vYmplY3QuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xNjIsMTEgKzE2MiwxNyBAQAogICAgICAgICAKICAgICBpbnN0 YW5jZS0+ZW5kKCk7CiAKLSAgICAvLyBkb24ndCBjYWxsIHN1cGVyY2xhc3MsIGJlY2F1c2UgcnVu dGltZSBvYmplY3RzIGNhbid0IGhhdmUgY3VzdG9tIHByb3BlcnRpZXMgb3IgYSBwcm90b3R5cGUK KyNpZiBQTEFURk9STShRVCkKKyAgICAvLyBGb3IgUXQgd2UgY2FsbCB0aGUgYmFzZWNsYXNzIGlt cGxlbWVudGF0aW9uIHRvIGFsbG93IHJ1bnRpbWUKKyAgICAvLyBvYmplY3RzIHRvIGhhdmUgY3Vz dG9tIHByb3BlcnRpZXMgb3IgYSBwcm90b3R5cGUKKyAgICByZXR1cm4gSlNPYmplY3Q6OmdldE93 blByb3BlcnR5U2xvdChleGVjLCBwcm9wZXJ0eU5hbWUsIHNsb3QpOworI2Vsc2UKKyAgICAvLyBG b3Igb3RoZXIgcGxhdGZvcm1zIHdlIGRvbid0IGFsbG93IHJ1bnRpbWUgcHJvcGVydGllcy9wcm90 b3R5cGVzCiAgICAgcmV0dXJuIGZhbHNlOworI2VuZGlmCiB9CiAKLXZvaWQgUnVudGltZU9iamVj dEltcDo6cHV0KEV4ZWNTdGF0ZSogZXhlYywgY29uc3QgSWRlbnRpZmllciYgcHJvcGVydHlOYW1l LCBKU1ZhbHVlUHRyIHZhbHVlLCBQdXRQcm9wZXJ0eVNsb3QmKQordm9pZCBSdW50aW1lT2JqZWN0 SW1wOjpwdXQoRXhlY1N0YXRlKiBleGVjLCBjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5hbWUs IEpTVmFsdWVQdHIgdmFsdWUsIFB1dFByb3BlcnR5U2xvdCYgc2xvdCkKIHsKICAgICBpZiAoIWlu c3RhbmNlKSB7CiAgICAgICAgIHRocm93SW52YWxpZEFjY2Vzc0Vycm9yKGV4ZWMpOwpAQCAtMTgy LDYgKzE4OCwxMCBAQAogICAgICAgICBpbnN0YW5jZS0+c2V0VmFsdWVPZkZpZWxkKGV4ZWMsIGFG aWVsZCwgdmFsdWUpOwogICAgIGVsc2UgaWYgKGluc3RhbmNlLT5zdXBwb3J0c1NldFZhbHVlT2ZV bmRlZmluZWRGaWVsZCgpKQogICAgICAgICBpbnN0YW5jZS0+c2V0VmFsdWVPZlVuZGVmaW5lZEZp ZWxkKGV4ZWMsIHByb3BlcnR5TmFtZSwgdmFsdWUpOworI2lmIFBMQVRGT1JNKFFUKQorICAgIGVs c2UKKyAgICAgICAgSlNPYmplY3Q6OnB1dChleGVjLCAgcHJvcGVydHlOYW1lLCB2YWx1ZSwgc2xv dCk7CisjZW5kaWYKIAogICAgIGluc3RhbmNlLT5lbmQoKTsKIH0K 24597 2008-10-23 06:59:27 -0700 2008-10-23 07:01:44 -0700 patch that limits behavior to QtInstance, and also expands the autotest for custom properties 0002-allowDynamicProperties.patch text/plain 2672 jade.han SW5kZXg6IFdlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcAkocmV2 aXNpb24gMzc3ODYpCisrKyBXZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC03ODAsMTAgKzc4MCwxOCBAQAogICAgIFFDT01QQVJFKGV2 YWxKUygiZGVsZXRlIG15T2JqZWN0LnZhcmlhbnRQcm9wZXJ0eSIpLCBzRmFsc2UpOwogICAgIFFD T01QQVJFKGV2YWxKUygibXlPYmplY3QudmFyaWFudFByb3BlcnR5IikudG9Eb3VibGUoKSwgNDIu MCk7CiAKKyAgICAvLyBjdXN0b20gcHJvcGVydHkKKyAgICBRQ09NUEFSRShldmFsSlMoIm15T2Jq ZWN0LmN1c3RvbVByb3BlcnR5IiksIHNVbmRlZmluZWQpOworICAgIFFDT01QQVJFKGV2YWxKUygi bXlPYmplY3QuY3VzdG9tUHJvcGVydHkgPSAxMjM7IgorICAgICAgICAgICAgICAgICAgICAibXlP YmplY3QuY3VzdG9tUHJvcGVydHkgPT0gMTIzIiksIHNUcnVlKTsKKyAgICBRVmFyaWFudCB2ID0g bV9wYWdlLT5tYWluRnJhbWUoKS0+ZXZhbHVhdGVKYXZhU2NyaXB0KCJteU9iamVjdC5jdXN0b21Q cm9wZXJ0eSIpOworICAgIFFDT01QQVJFKHYudHlwZSgpLCBRVmFyaWFudDo6RG91YmxlKTsKKyAg ICBRQ09NUEFSRSh2LnRvSW50KCksIDEyMyk7CisgICAgcURlYnVnKCkgPDwgImZvbyI7CisKICAg ICAvLyBub24tc2NyaXB0YWJsZSBwcm9wZXJ0eQogICAgIFFDT01QQVJFKG1fbXlPYmplY3QtPmhp ZGRlblByb3BlcnR5KCksIDQ1Ni4wKTsKICAgICBRQ09NUEFSRShldmFsSlMoIm15T2JqZWN0Lmhp ZGRlblByb3BlcnR5IiksIHNVbmRlZmluZWQpOwotICAgIFFFWFBFQ1RfRkFJTCgiIiwgInVuZGVm aW5lZCBwcm9wZXJ0aWVzIG5vdCBzdXBwb3J0ZWQiLCBDb250aW51ZSk7CiAgICAgUUNPTVBBUkUo ZXZhbEpTKCJteU9iamVjdC5oaWRkZW5Qcm9wZXJ0eSA9IDEyMzsiCiAgICAgICAgICAgICAgICAg ICAgICJteU9iamVjdC5oaWRkZW5Qcm9wZXJ0eSA9PSAxMjMiKSwgc1RydWUpOwogICAgIFFDT01Q QVJFKG1fbXlPYmplY3QtPmhpZGRlblByb3BlcnR5KCksIDQ1Ni4wKTsKSW5kZXg6IFdlYkNvcmUv YnJpZGdlL3J1bnRpbWVfb2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JyaWRnZS9y dW50aW1lX29iamVjdC5jcHAJKHJldmlzaW9uIDM3Nzg2KQorKysgV2ViQ29yZS9icmlkZ2UvcnVu dGltZV9vYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjIsMTEgKzE2MiwxOSBAQAogICAg ICAgICAKICAgICBpbnN0YW5jZS0+ZW5kKCk7CiAKLSAgICAvLyBkb24ndCBjYWxsIHN1cGVyY2xh c3MsIGJlY2F1c2UgcnVudGltZSBvYmplY3RzIGNhbid0IGhhdmUgY3VzdG9tIHByb3BlcnRpZXMg b3IgYSBwcm90b3R5cGUKKyNpZiBQTEFURk9STShRVCkKKyAgICAvLyBGb3IgUXQgaW5zdGFuY2Vz IHdlIGNhbGwgdGhlIGJhc2VjbGFzcyBpbXBsZW1lbnRhdGlvbiB0byBhbGxvdworICAgIC8vIHJ1 bnRpbWUgb2JqZWN0cyB0byBoYXZlIGN1c3RvbSBwcm9wZXJ0aWVzIG9yIGEgcHJvdG90eXBlCisg ICAgaWYgKGluc3RhbmNlLT5nZXRCaW5kaW5nTGFuZ3VhZ2UoKSA9PSBJbnN0YW5jZTo6UXRMYW5n dWFnZSkKKyAgICAgICAgcmV0dXJuIEpTT2JqZWN0OjpnZXRPd25Qcm9wZXJ0eVNsb3QoZXhlYywg cHJvcGVydHlOYW1lLCBzbG90KTsKKyNlbmRpZgorCisgICAgLy8gRm9yIG90aGVyIHBsYXRmb3Jt cyBhbmQvb3IgYmluZGluZyBsYW5ndWFnZXMgd2UgZG9uJ3QgYWxsb3cKKyAgICAvLyBydW50aW1l IHByb3BlcnRpZXMvcHJvdG90eXBlcwogICAgIHJldHVybiBmYWxzZTsKIH0KIAotdm9pZCBSdW50 aW1lT2JqZWN0SW1wOjpwdXQoRXhlY1N0YXRlKiBleGVjLCBjb25zdCBJZGVudGlmaWVyJiBwcm9w ZXJ0eU5hbWUsIEpTVmFsdWVQdHIgdmFsdWUsIFB1dFByb3BlcnR5U2xvdCYpCit2b2lkIFJ1bnRp bWVPYmplY3RJbXA6OnB1dChFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IElkZW50aWZpZXImIHByb3Bl cnR5TmFtZSwgSlNWYWx1ZVB0ciB2YWx1ZSwgUHV0UHJvcGVydHlTbG90JiBzbG90KQogewogICAg IGlmICghaW5zdGFuY2UpIHsKICAgICAgICAgdGhyb3dJbnZhbGlkQWNjZXNzRXJyb3IoZXhlYyk7 CkBAIC0xODIsNiArMTkwLDEwIEBACiAgICAgICAgIGluc3RhbmNlLT5zZXRWYWx1ZU9mRmllbGQo ZXhlYywgYUZpZWxkLCB2YWx1ZSk7CiAgICAgZWxzZSBpZiAoaW5zdGFuY2UtPnN1cHBvcnRzU2V0 VmFsdWVPZlVuZGVmaW5lZEZpZWxkKCkpCiAgICAgICAgIGluc3RhbmNlLT5zZXRWYWx1ZU9mVW5k ZWZpbmVkRmllbGQoZXhlYywgcHJvcGVydHlOYW1lLCB2YWx1ZSk7CisjaWYgUExBVEZPUk0oUVQp CisgICAgZWxzZSBpZiAoaW5zdGFuY2UtPmdldEJpbmRpbmdMYW5ndWFnZSgpID09IEluc3RhbmNl OjpRdExhbmd1YWdlKQorICAgICAgICBKU09iamVjdDo6cHV0KGV4ZWMsICBwcm9wZXJ0eU5hbWUs IHZhbHVlLCBzbG90KTsKKyNlbmRpZgogCiAgICAgaW5zdGFuY2UtPmVuZCgpOwogfQo= 24598 2008-10-23 07:01:44 -0700 2008-10-23 09:04:50 -0700 similar to previous patch (limits to QtInstance), but removes debug statement 0003-allowDynamicProperties.patch text/plain 2648 jade.han SW5kZXg6IFdlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcAkocmV2 aXNpb24gMzc3ODYpCisrKyBXZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC03ODAsMTAgKzc4MCwxNyBAQAogICAgIFFDT01QQVJFKGV2 YWxKUygiZGVsZXRlIG15T2JqZWN0LnZhcmlhbnRQcm9wZXJ0eSIpLCBzRmFsc2UpOwogICAgIFFD T01QQVJFKGV2YWxKUygibXlPYmplY3QudmFyaWFudFByb3BlcnR5IikudG9Eb3VibGUoKSwgNDIu MCk7CiAKKyAgICAvLyBjdXN0b20gcHJvcGVydHkKKyAgICBRQ09NUEFSRShldmFsSlMoIm15T2Jq ZWN0LmN1c3RvbVByb3BlcnR5IiksIHNVbmRlZmluZWQpOworICAgIFFDT01QQVJFKGV2YWxKUygi bXlPYmplY3QuY3VzdG9tUHJvcGVydHkgPSAxMjM7IgorICAgICAgICAgICAgICAgICAgICAibXlP YmplY3QuY3VzdG9tUHJvcGVydHkgPT0gMTIzIiksIHNUcnVlKTsKKyAgICBRVmFyaWFudCB2ID0g bV9wYWdlLT5tYWluRnJhbWUoKS0+ZXZhbHVhdGVKYXZhU2NyaXB0KCJteU9iamVjdC5jdXN0b21Q cm9wZXJ0eSIpOworICAgIFFDT01QQVJFKHYudHlwZSgpLCBRVmFyaWFudDo6RG91YmxlKTsKKyAg ICBRQ09NUEFSRSh2LnRvSW50KCksIDEyMyk7CisKICAgICAvLyBub24tc2NyaXB0YWJsZSBwcm9w ZXJ0eQogICAgIFFDT01QQVJFKG1fbXlPYmplY3QtPmhpZGRlblByb3BlcnR5KCksIDQ1Ni4wKTsK ICAgICBRQ09NUEFSRShldmFsSlMoIm15T2JqZWN0LmhpZGRlblByb3BlcnR5IiksIHNVbmRlZmlu ZWQpOwotICAgIFFFWFBFQ1RfRkFJTCgiIiwgInVuZGVmaW5lZCBwcm9wZXJ0aWVzIG5vdCBzdXBw b3J0ZWQiLCBDb250aW51ZSk7CiAgICAgUUNPTVBBUkUoZXZhbEpTKCJteU9iamVjdC5oaWRkZW5Q cm9wZXJ0eSA9IDEyMzsiCiAgICAgICAgICAgICAgICAgICAgICJteU9iamVjdC5oaWRkZW5Qcm9w ZXJ0eSA9PSAxMjMiKSwgc1RydWUpOwogICAgIFFDT01QQVJFKG1fbXlPYmplY3QtPmhpZGRlblBy b3BlcnR5KCksIDQ1Ni4wKTsKSW5kZXg6IFdlYkNvcmUvYnJpZGdlL3J1bnRpbWVfb2JqZWN0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JyaWRnZS9ydW50aW1lX29iamVjdC5jcHAJKHJldmlz aW9uIDM3Nzg2KQorKysgV2ViQ29yZS9icmlkZ2UvcnVudGltZV9vYmplY3QuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xNjIsMTEgKzE2MiwxOSBAQAogICAgICAgICAKICAgICBpbnN0YW5jZS0+ZW5k KCk7CiAKLSAgICAvLyBkb24ndCBjYWxsIHN1cGVyY2xhc3MsIGJlY2F1c2UgcnVudGltZSBvYmpl Y3RzIGNhbid0IGhhdmUgY3VzdG9tIHByb3BlcnRpZXMgb3IgYSBwcm90b3R5cGUKKyNpZiBQTEFU Rk9STShRVCkKKyAgICAvLyBGb3IgUXQgaW5zdGFuY2VzIHdlIGNhbGwgdGhlIGJhc2VjbGFzcyBp bXBsZW1lbnRhdGlvbiB0byBhbGxvdworICAgIC8vIHJ1bnRpbWUgb2JqZWN0cyB0byBoYXZlIGN1 c3RvbSBwcm9wZXJ0aWVzIG9yIGEgcHJvdG90eXBlCisgICAgaWYgKGluc3RhbmNlLT5nZXRCaW5k aW5nTGFuZ3VhZ2UoKSA9PSBJbnN0YW5jZTo6UXRMYW5ndWFnZSkKKyAgICAgICAgcmV0dXJuIEpT T2JqZWN0OjpnZXRPd25Qcm9wZXJ0eVNsb3QoZXhlYywgcHJvcGVydHlOYW1lLCBzbG90KTsKKyNl bmRpZgorCisgICAgLy8gRm9yIG90aGVyIHBsYXRmb3JtcyBhbmQvb3IgYmluZGluZyBsYW5ndWFn ZXMgd2UgZG9uJ3QgYWxsb3cKKyAgICAvLyBydW50aW1lIHByb3BlcnRpZXMvcHJvdG90eXBlcwog ICAgIHJldHVybiBmYWxzZTsKIH0KIAotdm9pZCBSdW50aW1lT2JqZWN0SW1wOjpwdXQoRXhlY1N0 YXRlKiBleGVjLCBjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5hbWUsIEpTVmFsdWVQdHIgdmFs dWUsIFB1dFByb3BlcnR5U2xvdCYpCit2b2lkIFJ1bnRpbWVPYmplY3RJbXA6OnB1dChFeGVjU3Rh dGUqIGV4ZWMsIGNvbnN0IElkZW50aWZpZXImIHByb3BlcnR5TmFtZSwgSlNWYWx1ZVB0ciB2YWx1 ZSwgUHV0UHJvcGVydHlTbG90JiBzbG90KQogewogICAgIGlmICghaW5zdGFuY2UpIHsKICAgICAg ICAgdGhyb3dJbnZhbGlkQWNjZXNzRXJyb3IoZXhlYyk7CkBAIC0xODIsNiArMTkwLDEwIEBACiAg ICAgICAgIGluc3RhbmNlLT5zZXRWYWx1ZU9mRmllbGQoZXhlYywgYUZpZWxkLCB2YWx1ZSk7CiAg ICAgZWxzZSBpZiAoaW5zdGFuY2UtPnN1cHBvcnRzU2V0VmFsdWVPZlVuZGVmaW5lZEZpZWxkKCkp CiAgICAgICAgIGluc3RhbmNlLT5zZXRWYWx1ZU9mVW5kZWZpbmVkRmllbGQoZXhlYywgcHJvcGVy dHlOYW1lLCB2YWx1ZSk7CisjaWYgUExBVEZPUk0oUVQpCisgICAgZWxzZSBpZiAoaW5zdGFuY2Ut PmdldEJpbmRpbmdMYW5ndWFnZSgpID09IEluc3RhbmNlOjpRdExhbmd1YWdlKQorICAgICAgICBK U09iamVjdDo6cHV0KGV4ZWMsICBwcm9wZXJ0eU5hbWUsIHZhbHVlLCBzbG90KTsKKyNlbmRpZgog CiAgICAgaW5zdGFuY2UtPmVuZCgpOwogfQo=