21811 2008-10-22 15:32:08 -0700 REGRESSION: Windows Build Not Selecting Proper Font 2009-03-02 13:57:43 -0800 1 1 1 Unclassified WebKit Layout and Rendering 523.x (Safari 3) PC OS X 10.5 RESOLVED FIXED HasReduction, PlatformOnly, Regression P1 Normal --- 1 bfulgham mitz mitz oldest_to_newest 96242 0 bfulgham 2008-10-22 15:32:08 -0700 The attached HTML file illustrates a regression in WebKit (Windows) that affects both Cairo and CG builds. There are two code sections in the HTML page that should render using Courier (or a suitable fixed-width alternate, such as "Courier New"). Instead, Arial is selected, resulting in an incorrect rendering. 96243 1 24575 bfulgham 2008-10-22 15:32:54 -0700 Created attachment 24575 Simple test showing the problem 96244 2 mitz 2008-10-22 15:38:44 -0700 This was presumably broken by <http://trac.webkit.org/changeset/31620/trunk/WebCore/platform/graphics/win/FontCacheWin.cpp>. 96249 3 hyatt 2008-10-22 15:58:50 -0700 The old code I wrote had this: 346 HFONT hfont = CreateFontIndirect(&winfont); 347 // Windows will always give us a valid pointer here, even if the face name is non-existent. We have to double-check 348 // and see if the family name was really used. 349 HDC dc = GetDC(0); 350 SaveDC(dc); 351 SelectObject(dc, hfont); 352 WCHAR name[LF_FACESIZE]; 353 GetTextFace(dc, LF_FACESIZE, name); 354 RestoreDC(dc, -1); 355 ReleaseDC(0, dc); 356 That's missing now I think. 111895 4 28195 mitz 2009-03-02 13:43:48 -0800 Created attachment 28195 Add back the code to verify the face name 111898 5 28195 aroben 2009-03-02 13:49:31 -0800 Comment on attachment 28195 Add back the code to verify the face name r=me 111899 6 mitz 2009-03-02 13:57:43 -0800 Fixed in <http://trac.webkit.org/projects/webkit/changeset/41366>. 24575 2008-10-22 15:32:54 -0700 2008-10-22 15:32:54 -0700 Simple test showing the problem fixed_font_test.html text/html 1511 bfulgham PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEvL0VOIiAiaHR0cDov L3d3dy53My5vcmcvVFIvaHRtbDQvc3RyaWN0LmR0ZCI+DQo8aHRtbD4NCiAgICA8bWV0YSBodHRw LWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9InRleHQvaHRtbDtjaGFyc2V0PXV0Zi04Ij4N CiAgICA8dGl0bGU+U3VyZmluJiM4MjE3OyBTYWZhcmkgLSBUaGUgV2ViS2l0IEJsb2cgPC90aXRs ZT4NCiAgICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiPg0KICAgICAgICBib2R5IHsNCiAgICAgICAg ICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsgYmFja2dyb3VuZC1yZXBlYXQ6IHJlcGVhdC14OyBiYWNr Z3JvdW5kLWNvbG9yOiAjZmZmOyBjb2xvcjogIzMzMzsNCiAgICAgICAgICAgIGZvbnQtc2l6ZTog MTJweDsgbGluZS1oZWlnaHQ6IDEuNWVtOyBmb250LWZhbWlseTogIkx1Y2lkYSBHcmFuZGUiLCBW ZXJkYW5hLCBBcmlhbDsNCiAgICAgICAgICAgIG1hcmdpbjogMHB4OyBwYWRkaW5nOiAwcHg7IG1h eC13aWR0aDogODUwcHg7DQogICAgICAgIH0NCg0KICAgICAgICAuY29kZSwgcHJlLCB0dCwgY29k ZSB7DQogICAgICAgICAgICBmb250LWZhbWlseTogQ291cmllciwgRml4ZWQ7IGZvbnQtc2l6ZTog MTEwJTsNCiAgICAgICAgfQ0KICAgIDwvc3R5bGU+DQo8aGVhZD4NCjwvaGVhZD4NCjxib2R5Pg0K PGgzPlNlYXJjaDwvaDM+DQo8cD5BY2NvbXBhbnlpbmcgdGhlIHRhc2stb3JpZW50ZWQgcmVvcmdh bml6YXRpb24sIHRoZSBzZWFyY2ggZmllbGQgaW4gdGhlIHRvb2xiYXIgbm93IHNlYXJjaGVzIHRo ZSBjdXJyZW50IHBhbmVsIHdpdGggcmVzdWx0cyBiZWluZyBoaWdobGlnaHRlZCBpbiB0aGUgY29u dGV4dCBvZiB0aGUgcGFuZWwuIFRhcmdldGluZyB0aGUgc2VhcmNoIHRvIHRoZSBjdXJyZW50IHBh bmVsIGFsbG93cyBlYWNoIHBhbmVsIHRvIHN1cHBvcnQgc3BlY2lhbGl6ZWQgcXVlcmllcyB0aGF0 IGFyZSBzdWl0ZWQgZm9yIHRoZSB0eXBlIG9mIGluZm9ybWF0aW9uIGJlaW5nIHNob3duLiBUaGUg cGFuZWxzIHRoYXQgc3VwcG9ydCBzcGVjaWFsaXplZCBxdWVyaWVzIGFyZSBFbGVtZW50cyBhbmQg UHJvZmlsZXMuPC9wPg0KPHA+VGhlIEVsZW1lbnRzIHBhbmVsIHN1cHBvcnRzIFhQYXRoIGFuZCBD U1Mgc2VsZWN0b3JzIGFzIHF1ZXJpZXMgaW4gYWRkaXRpb24gdG8gcGxhaW4gdGV4dC4gQW55IHNl YXJjaCB5b3UgcGVyZm9ybSB3aWxsIGJlIGF0dGVtcHRlZCBhcyBhIHBsYWluIHRleHQgc2VhcmNo LCBhIFhQYXRoIHF1ZXJ5IHVzaW5nIDxjb2RlPmRvY3VtZW50LmV2YWx1YXRlKCk8L2NvZGU+IGFu ZCBhIENTUyBzZWxlY3RvciB1c2luZyA8Y29kZT5kb2N1bWVudC5xdWVyeVNlbGVjdG9yQWxsKCk8 L2NvZGU+LiBBbGwgdGhlIHNlYXJjaCByZXN1bHRzIHdpbGwgYmUgaGlnaGxpZ2h0ZWQgaW4gdGhl IERPTSB0cmVlLCB3aXRoIHRoZSBmaXJzdCBtYXRjaCBiZWluZyByZXZlYWxlZCBhbmQgc2VsZWN0 ZWQuPC9wPg0KPC9ib2R5Pg0KPC9odG1sPg0KDQo= 28195 2009-03-02 13:43:48 -0800 2009-03-02 13:49:31 -0800 Add back the code to verify the face name 21811_r1.diff text/plain 1699 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTM2NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDMtMDIgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIGZp eCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4MTEKKyAgICAgICAg ICBSRUdSRVNTSU9OOiBXaW5kb3dzIEJ1aWxkIE5vdCBTZWxlY3RpbmcgUHJvcGVyIEZvbnQKKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3dpbi9Gb250Q2FjaGVXaW4uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Y3JlYXRlR0RJRm9udCk6IEFkZGVkIGJhY2sgY29kZSB0byB2ZXJpZnkgdGhh dCB0aGUgY3JlYXRlZAorICAgICAgICBIRk9OVCBoYXMgdGhlIHJlcXVlc3RlZCBmYWNlIG5hbWUu CisKIDIwMDktMDMtMDIgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAg ICAgICAgIEZpeGVzIGEgcmVncmVzc2lvbiBjYXVzZWQgYnkgc3BsaXR0aW5nIHRoZSBpbnB1dCBh bmQgb3V0cHV0IG9mIGNvbnNvbGUgY29tbWFuZHMuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3dpbi9Gb250Q2FjaGVXaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvd2luL0ZvbnRDYWNoZVdpbi5jcHAJKHJldmlzaW9uIDQxMzYxKQorKysgV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vRm9udENhY2hlV2luLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNDIyLDcgKzQyMiwyNCBAQCBzdGF0aWMgSEZPTlQgY3JlYXRlR0RJRm9udChjb25zdCBB dG9taWNTCiAgICAgbWF0Y2hEYXRhLm1fY2hvc2VuLmxmUXVhbGl0eSA9IERFRkFVTFRfUVVBTElU WTsKICAgICBtYXRjaERhdGEubV9jaG9zZW4ubGZQaXRjaEFuZEZhbWlseSA9IERFRkFVTFRfUElU Q0ggfCBGRl9ET05UQ0FSRTsKIAotICAgIHJldHVybiBDcmVhdGVGb250SW5kaXJlY3QoJm1hdGNo RGF0YS5tX2Nob3Nlbik7CisgICAgSEZPTlQgcmVzdWx0ID0gQ3JlYXRlRm9udEluZGlyZWN0KCZt YXRjaERhdGEubV9jaG9zZW4pOworICAgIGlmICghcmVzdWx0KQorICAgICAgICByZXR1cm4gMDsK KworICAgIEhEQyBkYyA9IEdldERDKDApOworICAgIFNhdmVEQyhkYyk7CisgICAgU2VsZWN0T2Jq ZWN0KGRjLCByZXN1bHQpOworICAgIFdDSEFSIGFjdHVhbE5hbWVbTEZfRkFDRVNJWkVdOworICAg IEdldFRleHRGYWNlKGRjLCBMRl9GQUNFU0laRSwgYWN0dWFsTmFtZSk7CisgICAgUmVzdG9yZURD KGRjLCAtMSk7CisgICAgUmVsZWFzZURDKDAsIGRjKTsKKworICAgIGlmICh3Y3NpY21wKG1hdGNo RGF0YS5tX2Nob3Nlbi5sZkZhY2VOYW1lLCBhY3R1YWxOYW1lKSkgeworICAgICAgICBEZWxldGVP YmplY3QocmVzdWx0KTsKKyAgICAgICAgcmVzdWx0ID0gMDsKKyAgICB9CisKKyAgICByZXR1cm4g cmVzdWx0OwogfQogCiBzdHJ1Y3QgVHJhaXRzSW5GYW1pbHlQcm9jRGF0YSB7Cg==