21809 2008-10-22 13:38:55 -0700 Remove PLATFORM(MAC) wrapper from USE(ATSUI) 2008-10-22 18:43:58 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 0 pinkerton webkit-unassigned oldest_to_newest 96220 0 pinkerton 2008-10-22 13:38:55 -0700 The PLATFORM(MAC) wrapping USE(ATSUI) is redundant, since right now it's only defined for Mac. This also makes it impossible moving forward for us to use it in PLATFORM(CHROMIUM) on Mac OS, since we don't define PLATFORM(MAC). Another solution would be to change these lines to PLATFORM(MAC) || PLATFORM(CHROMIUM) but that seems excessive. Just let the platforms that want to use ATSUI define ATSUI and avoid the extraneous ifdef cruft. patch upcoming 96221 1 24569 pinkerton 2008-10-22 13:39:59 -0700 Created attachment 24569 patch 96235 2 24569 mitz 2008-10-22 14:46:29 -0700 Comment on attachment 24569 patch r=me 96277 3 darin 2008-10-22 18:43:58 -0700 http://trac.webkit.org/changeset/37801 24569 2008-10-22 13:39:59 -0700 2008-10-22 14:46:29 -0700 patch atsui.patch text/plain 1830 pinkerton SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNzc4OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDgtMTAtMjIgIE1pa2UgUGlua2VydG9uICA8c2V0IEVNQUlMX0FE RFJFU1MgZW52aXJvbm1lbnQgdmFyaWFibGU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIFBMQVRGT1JNKE1BQykgd3JhcHBpbmcgVVNFKEFU U1VJKS4gSXQncyByZWR1bmRhbnQgYW5kIGluaGliaXRzIAorCWl0cyB1c2UgZm9yIFBMQVRGT1JN KENIUk9NSVVNKSBpbiB0aGUgZnV0dXJlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv U2ltcGxlRm9udERhdGEuaDoKKwogMjAwOC0xMC0yMiAgQ2hyaXMgTWFycmluICA8Y21hcnJpbkBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dApJbmRleDogV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9TaW1wbGVGb250RGF0YS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvU2ltcGxlRm9udERhdGEuaAkocmV2aXNpb24gMzc3ODQpCisr KyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NpbXBsZUZvbnREYXRhLmgJKHdvcmtpbmcgY29w eSkKQEAgLTI5LDExICsyOSw5IEBACiAjaW5jbHVkZSAiR2x5cGhXaWR0aE1hcC5oIgogI2luY2x1 ZGUgPHd0Zi9Pd25QdHIuaD4KIAotI2lmIFBMQVRGT1JNKE1BQykKICNpZiBVU0UoQVRTVUkpCiB0 eXBlZGVmIHN0cnVjdCBPcGFxdWVBVFNVU3R5bGUqIEFUU1VTdHlsZTsKICNlbmRpZgotI2VuZGlm CiAKICNpZiBQTEFURk9STShXSU4pCiAjaW5jbHVkZSA8dXNwMTAuaD4KQEAgLTk4LDYgKzk2LDcg QEAgcHVibGljOgogICAgIENURm9udFJlZiBnZXRDVEZvbnQoKSBjb25zdDsKICAgICBDRkRpY3Rp b25hcnlSZWYgZ2V0Q0ZTdHJpbmdBdHRyaWJ1dGVzKCkgY29uc3Q7CiAjZW5kaWYKKyNlbmRpZgog I2lmIFVTRShBVFNVSSkKICAgICB2b2lkIGNoZWNrU2hhcGVzQXJhYmljKCkgY29uc3Q7CiAgICAg Ym9vbCBzaGFwZXNBcmFiaWMoKSBjb25zdApAQCAtMTA3LDcgKzEwNiw2IEBAIHB1YmxpYzoKICAg ICAgICAgcmV0dXJuIG1fc2hhcGVzQXJhYmljOwogICAgIH0KICNlbmRpZgotI2VuZGlmCiAKICNp ZiBQTEFURk9STShXSU4pCiAgICAgYm9vbCBpc1N5c3RlbUZvbnQoKSBjb25zdCB7IHJldHVybiBt X2lzU3lzdGVtRm9udDsgfQpAQCAtMTc1LDYgKzE3Myw3IEBAIHB1YmxpYzoKICNpZmRlZiBCVUlM RElOR19PTl9USUdFUgogICAgIHZvaWQqIG1fc3R5bGVHcm91cDsKICNlbmRpZgorI2VuZGlmCiAj aWYgVVNFKEFUU1VJKQogICAgIG11dGFibGUgQVRTVVN0eWxlIG1fQVRTVVN0eWxlOwogICAgIG11 dGFibGUgYm9vbCBtX0FUU1VTdHlsZUluaXRpYWxpemVkOwpAQCAtMTgyLDYgKzE4MSw3IEBAIHB1 YmxpYzoKICAgICBtdXRhYmxlIGJvb2wgbV9jaGVja2VkU2hhcGVzQXJhYmljOwogICAgIG11dGFi bGUgYm9vbCBtX3NoYXBlc0FyYWJpYzsKICNlbmRpZgorI2lmIFBMQVRGT1JNKE1BQykKICNpZiBV U0UoQ09SRV9URVhUKQogICAgIG11dGFibGUgUmV0YWluUHRyPENURm9udFJlZj4gbV9DVEZvbnQ7 CiAgICAgbXV0YWJsZSBSZXRhaW5QdHI8Q0ZEaWN0aW9uYXJ5UmVmPiBtX0NGU3RyaW5nQXR0cmli dXRlczsK