218079 2020-10-22 07:43:46 -0700 Few webkitpy tests fail for machines in non-PST timezones 2021-10-23 06:57:15 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=216404 https://bugs.webkit.org/show_bug.cgi?id=225741 https://bugs.webkit.org/show_bug.cgi?id=232197 InRadar P2 Normal --- 1 aakash_jain jbedard aakash_jain webkit-bug-importer oldest_to_newest 1700632 0 aakash_jain 2020-10-22 07:43:46 -0700 Few webkitpy tests fail for machines in non-PST timezones. They pass when I manually change the timezone to PST in my system preferences. Especially 'Last Changed Date' in the testcases seems to vary by timezone. ====================================================================================================== [1543/1960] webkitscmpy.test.git_unittest.TestGit.test_info failed: Traceback (most recent call last): File "/Volumes/Data/aakash_jain/code5/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py", line 101, in test_info }, local.Git(self.path).info(), AssertionError: {'Last Changed Date': '2020-10-02 11:56:40', 'Node Kind': 'directory', 'Last Cha [truncated]... != {u'Node Kind': u'directory', u'Schedule': u'normal', u'URL': u'git@webkit.org:/m [truncated]... Diff is 908 characters long. Set self.maxDiff to None to see it. [1593/1960] webkitscmpy.test.find_unittest.TestFind.test_standard failed: Traceback (most recent call last): File "/Volumes/Data/aakash_jain/code5/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/find_unittest.py", line 128, in test_standard ''', AssertionError: 'Title: 4th commit\nAuthor: Jonathan Bedard <jbedard@apple.com>\nIdentifier: 3@main\nDate: Fri Oct 02 14:23:20 2020\nRevision: 4\nHash: 1abe25b443e9\n' != 'Title: 4th commit\nAuthor: Jonathan Bedard <jbedard@apple.com>\nIdentifier: 3@main\nDate: Fri Oct 02 11:23:20 2020\nRevision: 4\nHash: 1abe25b443e9\n' [1706/1960] webkitscmpy.test.find_unittest.TestFind.test_verbose failed: Traceback (most recent call last): File "/Volumes/Data/aakash_jain/code5/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/find_unittest.py", line 147, in test_verbose ''', AssertionError: 'Title: 4th commit\nAuthor: Jonathan Bedard <jbedard@apple.com>\nIdentifier: 3@main\nDate: Fri Oct 02 14:23:20 2020\nRevision: 4\nHash: 1abe25b443e9\n 4th commit\n svn-id: https://svn.webkit.orgrepository/repository/trunk@4 268f45cc-cd09-0410-ab3c-d52691b4dbfc\n' != 'Title: 4th commit\nAuthor: Jonathan Bedard <jbedard@apple.com>\nIdentifier: 3@main\nDate: Fri Oct 02 11:23:20 2020\nRevision: 4\nHash: 1abe25b443e9\n 4th commit\n svn-id: https://svn.webkit.orgrepository/repository/trunk@4 268f45cc-cd09-0410-ab3c-d52691b4dbfc\n' [1748/1960] webkitscmpy.test.svn_unittest.TestSvn.test_info failed: Traceback (most recent call last): File "/Volumes/Data/aakash_jain/code5/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py", line 93, in test_info }, local.Svn(self.path).info(), AssertionError: {u'NodeKind': u'directory', u'URL': u'https://svn.mock.org/repository/repository [truncated]... != {u'NodeKind': u'directory', u'Last Changed Rev': u'6', u'Schedule': u'normal', u [truncated]... {u'Last Changed Author': u'jbedard@apple.com', - u'Last Changed Date': u'2020-10-02 11:58:20 -0100 (Fri, 02 Oct 2020)', ? ^ + u'Last Changed Date': u'2020-10-02 14:58:20 -0100 (Fri, 02 Oct 2020)', ? ^ u'Last Changed Rev': u'6', u'NodeKind': u'directory', u'Path': u'.', u'Relative URL': u'^/trunk', u'Repository Root': u'https://svn.mock.org/repository/repository', u'Revision': u'6', u'Schedule': u'normal', u'URL': u'https://svn.mock.org/repository/repository/trunk', u'Working Copy Root Path': u'/mock/repository'} ====================================================================================================== 1700643 1 jbedard 2020-10-22 08:23:40 -0700 I was hoping to avoid this, but this does make a certain amount of sense....I will have to change my timezone and fix these tests. Shouldn't be particularly difficult. 1700725 2 webkit-bug-importer 2020-10-22 10:39:32 -0700 <rdar://problem/70579517> 1700729 3 412114 jbedard 2020-10-22 10:42:38 -0700 Created attachment 412114 Patch 1700762 4 ews-feeder 2020-10-22 11:48:01 -0700 Committed r268879: <https://trac.webkit.org/changeset/268879> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412114. 412114 2020-10-22 10:42:38 -0700 2020-10-22 11:48:02 -0700 Patch bug-218079-20201022104237.patch text/plain 4934 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2ODg3MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDIwLTEwLTIyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBGZXcgd2Via2l0cHkgdGVzdHMgZmFpbCBmb3IgbWFjaGluZXMgaW4gbm9u LVBTVCB0aW1lem9uZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIxODA3OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzA1Nzk1MTc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2xpYnJh cmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9fX2luaXRfXy5weTogQnVtcCB2ZXJzaW9uLgor ICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L3Rlc3Qv ZmluZF91bml0dGVzdC5weToKKyAgICAgICAgKiBTY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21w eS93ZWJraXRzY21weS90ZXN0L2dpdF91bml0dGVzdC5weToKKyAgICAgICAgKFRlc3RHaXQudGVz dF9pbmZvKToKKyAgICAgICAgKiBTY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRz Y21weS90ZXN0L3N2bl91bml0dGVzdC5weToKKyAgICAgICAgKFRlc3RTdm4udGVzdF9pbmZvKToK KwogMjAyMC0xMC0yMiAgQW5nZWxvcyBPaWtvbm9tb3BvdWxvcyAgPGFuZ2Vsb3NAaWdhbGlhLmNv bT4KIAogICAgICAgICBEZXRlY3QgdW5yZWNvZ25pemVkIG9wdGlvbnMgaW4gYnVpbGQtanNjCklu ZGV4OiBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9fX2lu aXRfXy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21w eS93ZWJraXRzY21weS9fX2luaXRfXy5weQkocmV2aXNpb24gMjY4ODY3KQorKysgVG9vbHMvU2Ny aXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHkJKHdvcmtp bmcgY29weSkKQEAgLTQ2LDcgKzQ2LDcgQEAgZXhjZXB0IEltcG9ydEVycm9yOgogICAgICAgICAi UGxlYXNlIGluc3RhbGwgd2Via2l0Y29yZXB5IHdpdGggYHBpcCBpbnN0YWxsIHdlYmtpdGNvcmVw eSAtLWV4dHJhLWluZGV4LXVybCA8cGFja2FnZSBpbmRleCBVUkw+YCIKICAgICApCiAKLXZlcnNp b24gPSBWZXJzaW9uKDAsIDIsIDIpCit2ZXJzaW9uID0gVmVyc2lvbigwLCAyLCAzKQogCiBBdXRv SW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdkYXRldXRpbCcsIFZlcnNpb24oMiwgOCwgMSksIHB5 cGlfbmFtZT0ncHl0aG9uLWRhdGV1dGlsJykpCiAKSW5kZXg6IFRvb2xzL1NjcmlwdHMvbGlicmFy aWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L3Rlc3QvZmluZF91bml0dGVzdC5weQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS90 ZXN0L2ZpbmRfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI2ODg2NykKKysrIFRvb2xzL1NjcmlwdHMv bGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L3Rlc3QvZmluZF91bml0dGVzdC5weQko d29ya2luZyBjb3B5KQpAQCAtMjMsOSArMjMsMTAgQEAKIGltcG9ydCBqc29uCiBpbXBvcnQgdW5p dHRlc3QKIAorZnJvbSBkYXRldGltZSBpbXBvcnQgZGF0ZXRpbWUKIGZyb20gd2Via2l0Y29yZXB5 IGltcG9ydCBPdXRwdXRDYXB0dXJlCiBmcm9tIHdlYmtpdGNvcmVweS5tb2NrcyBpbXBvcnQgVGlt ZSBhcyBNb2NrVGltZQotZnJvbSB3ZWJraXRzY21weSBpbXBvcnQgbG9jYWwsICBwcm9ncmFtLCBt b2NrcworZnJvbSB3ZWJraXRzY21weSBpbXBvcnQgcHJvZ3JhbSwgbW9ja3MKIAogCiBjbGFzcyBU ZXN0RmluZCh1bml0dGVzdC5UZXN0Q2FzZSk6CkBAIC0xMjIsMTAgKzEyMywxMCBAQCBjbGFzcyBU ZXN0RmluZCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgICAgICAnJydUaXRsZTogNHRoIGNv bW1pdAogQXV0aG9yOiBKb25hdGhhbiBCZWRhcmQgPGpiZWRhcmRAYXBwbGUuY29tPgogSWRlbnRp ZmllcjogM0BtYWluCi1EYXRlOiBGcmkgT2N0IDAyIDExOjIzOjIwIDIwMjAKK0RhdGU6IHt9CiBS ZXZpc2lvbjogNAogSGFzaDogMWFiZTI1YjQ0M2U5Ci0nJycsCisnJycuZm9ybWF0KGRhdGV0aW1l LmZyb210aW1lc3RhbXAoMTYwMTY2MzAwMCkuc3RyZnRpbWUoJyVhICViICVkICVIOiVNOiVTICVZ JykpLAogICAgICAgICApCiAKICAgICBkZWYgdGVzdF92ZXJib3NlKHNlbGYpOgpAQCAtMTM5LDEy ICsxNDAsMTIgQEAgSGFzaDogMWFiZTI1YjQ0M2U5CiAgICAgICAgICAgICAnJydUaXRsZTogNHRo IGNvbW1pdAogQXV0aG9yOiBKb25hdGhhbiBCZWRhcmQgPGpiZWRhcmRAYXBwbGUuY29tPgogSWRl bnRpZmllcjogM0BtYWluCi1EYXRlOiBGcmkgT2N0IDAyIDExOjIzOjIwIDIwMjAKK0RhdGU6IHt9 CiBSZXZpc2lvbjogNAogSGFzaDogMWFiZTI1YjQ0M2U5CiAgICAgNHRoIGNvbW1pdAogICAgIHN2 bi1pZDogaHR0cHM6Ly9zdm4ud2Via2l0Lm9yZ3JlcG9zaXRvcnkvcmVwb3NpdG9yeS90cnVua0A0 IDI2OGY0NWNjLWNkMDktMDQxMC1hYjNjLWQ1MjY5MWI0ZGJmYwotJycnLAorJycnLmZvcm1hdChk YXRldGltZS5mcm9tdGltZXN0YW1wKDE2MDE2NjMwMDApLnN0cmZ0aW1lKCclYSAlYiAlZCAlSDol TTolUyAlWScpKSwKICAgICAgICAgKQogCiAgICAgZGVmIHRlc3RfanNvbihzZWxmKToKSW5kZXg6 IFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L3Rlc3QvZ2l0 X3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtp dHNjbXB5L3dlYmtpdHNjbXB5L3Rlc3QvZ2l0X3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyNjg4Njcp CisrKyBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS90ZXN0 L2dpdF91bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMjMsNiArMjMsNyBAQAogaW1wb3J0 IG9zCiBpbXBvcnQgdW5pdHRlc3QKIAorZnJvbSBkYXRldGltZSBpbXBvcnQgZGF0ZXRpbWUKIGZy b20gd2Via2l0Y29yZXB5IGltcG9ydCBMb2dnZXJDYXB0dXJlCiBmcm9tIHdlYmtpdGNvcmVweS5t b2NrcyBpbXBvcnQgVGltZSBhcyBNb2NrVGltZQogZnJvbSB3ZWJraXRzY21weSBpbXBvcnQgbG9j YWwsIG1vY2tzCkBAIC05Nyw3ICs5OCw3IEBAIGNsYXNzIFRlc3RHaXQodW5pdHRlc3QuVGVzdENh c2UpOgogICAgICAgICAgICAgICAgICAgICAnU2NoZWR1bGUnOiAnbm9ybWFsJywKICAgICAgICAg ICAgICAgICAgICAgJ0xhc3QgQ2hhbmdlZCBBdXRob3InOiAnamJlZGFyZEBhcHBsZS5jb20nLAog ICAgICAgICAgICAgICAgICAgICAnTGFzdCBDaGFuZ2VkIFJldic6ICc2JywKLSAgICAgICAgICAg ICAgICAgICAgJ0xhc3QgQ2hhbmdlZCBEYXRlJzogJzIwMjAtMTAtMDIgMTE6NTY6NDAnLAorICAg ICAgICAgICAgICAgICAgICAnTGFzdCBDaGFuZ2VkIERhdGUnOiBkYXRldGltZS5mcm9tdGltZXN0 YW1wKDE2MDE2NjUwMDApLnN0cmZ0aW1lKCclWS0lbS0lZCAlSDolTTolUycpLAogICAgICAgICAg ICAgICAgIH0sIGxvY2FsLkdpdChzZWxmLnBhdGgpLmluZm8oKSwKICAgICAgICAgICAgICkKIApJ bmRleDogVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvdGVz dC9zdm5fdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMv d2Via2l0c2NtcHkvd2Via2l0c2NtcHkvdGVzdC9zdm5fdW5pdHRlc3QucHkJKHJldmlzaW9uIDI2 ODg2NykKKysrIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5 L3Rlc3Qvc3ZuX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yNSw2ICsyNSw3IEBAIGlt cG9ydCBzaHV0aWwKIGltcG9ydCB0ZW1wZmlsZQogaW1wb3J0IHVuaXR0ZXN0CiAKK2Zyb20gZGF0 ZXRpbWUgaW1wb3J0IGRhdGV0aW1lCiBmcm9tIHdlYmtpdGNvcmVweSBpbXBvcnQgT3V0cHV0Q2Fw dHVyZQogZnJvbSB3ZWJraXRzY21weSBpbXBvcnQgbG9jYWwsIG1vY2tzCiAKQEAgLTg5LDcgKzkw LDcgQEAgY2xhc3MgVGVzdFN2bih1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgICAgICAgICAg ICAgIHUnU2NoZWR1bGUnOiB1J25vcm1hbCcsCiAgICAgICAgICAgICAgICAgICAgIHUnTGFzdCBD aGFuZ2VkIEF1dGhvcic6IHUnamJlZGFyZEBhcHBsZS5jb20nLAogICAgICAgICAgICAgICAgICAg ICB1J0xhc3QgQ2hhbmdlZCBSZXYnOiB1JzYnLAotICAgICAgICAgICAgICAgICAgICB1J0xhc3Qg Q2hhbmdlZCBEYXRlJzogdScyMDIwLTEwLTAyIDExOjU4OjIwIC0wMTAwIChGcmksIDAyIE9jdCAy MDIwKScsCisgICAgICAgICAgICAgICAgICAgIHUnTGFzdCBDaGFuZ2VkIERhdGUnOiBkYXRldGlt ZS5mcm9tdGltZXN0YW1wKDE2MDE2NjUxMDApLnN0cmZ0aW1lKCclWS0lbS0lZCAlSDolTTolUyAt MDEwMCAoJWEsICVkICViICVZKScpLAogICAgICAgICAgICAgICAgIH0sIGxvY2FsLlN2bihzZWxm LnBhdGgpLmluZm8oKSwKICAgICAgICAgICAgICkKIAo=