218058 2020-10-21 16:26:27 -0700 Web Inspector: Network: background color of rows from previous session is wrong 2020-10-28 14:34:10 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi webkit-unassigned fbucchi hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1700454 0 hi 2020-10-21 16:26:27 -0700 # STEPS TO REPRODUCE 1. inspect any page 2. enable the Preserve Log checkbox in the Network Tab 3. reload the page (might have to do this a few times) # EXPECTED rows from previous sessions have the same odd-even-odd-... background coloring # ACTUAL rows from previous sessions are made more transparent, causing even rows from previous sessions to have an extremely similar background color to odd rows from the current session 1700455 1 webkit-bug-importer 2020-10-21 16:27:03 -0700 <rdar://problem/70550459> 1702234 2 412509 fbucchi 2020-10-27 23:35:56 -0700 Created attachment 412509 Web Inspector: Network: Fix background color of rows from previous session 1702379 3 412509 hi 2020-10-28 10:49:37 -0700 Comment on attachment 412509 Web Inspector: Network: Fix background color of rows from previous session View in context: https://bugs.webkit.org/attachment.cgi?id=412509&action=review r=me > Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css:53 > +.network-table > .table li:not(.filler, .selected) .cell:not(.current-session):not(.name) { `:not(.name, .current-session)`? > Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css:61 > +.network-table > .table li:not(.filler) .cell.name:not(.current-session) > * { What about `.selected`? I'm actually kinda OK with the idea of still having it be slightly transparent when selected, but probably not this much. ``` .network-table > .table li:not(.filler).selected .cell.name:not(.current-session) > * { opacity: 0.8; } ``` 1702479 4 412571 fbucchi 2020-10-28 13:55:29 -0700 Created attachment 412571 Web Inspector: Network: Fix background color of rows from previous session 1702486 5 412571 hi 2020-10-28 14:06:07 -0700 Comment on attachment 412571 Web Inspector: Network: Fix background color of rows from previous session r=me 1702501 6 ews-feeder 2020-10-28 14:34:09 -0700 Committed r269127: <https://trac.webkit.org/changeset/269127> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412571. 412509 2020-10-27 23:35:56 -0700 2020-10-28 13:55:27 -0700 Web Inspector: Network: Fix background color of rows from previous session bug-218058-20201027233555.patch text/plain 1979 fbucchi U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MDk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk YTE0NzYwMWI0MDJiMWM5ZWRiODQ1MzdkYjE4ZmY1MGMyYjNiYWE5Li44NGRkMmExMmRjMmM2ZmU5 OWEzNTY1ODE2MzVjM2VlNWFhZjNjMTJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0xMC0yNyAgRmVkZXJpY28gQnVjY2hpICA8ZmJ1Y2NoaUBhcHBsZS5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTmV0d29yazogYmFja2dyb3VuZCBjb2xvciBv ZiByb3dzIGZyb20gcHJldmlvdXMgc2Vzc2lvbiBpcyB3cm9uZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4MDU4CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS83MDU1MDQ1OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya1RhYmxlQ29udGVudFZpZXcuY3Nz OgorICAgICAgICAoLm5ldHdvcmstdGFibGUgPiAudGFibGUgbGk6bm90KC5maWxsZXIsIC5zZWxl Y3RlZCkgLmNlbGw6bm90KC5jdXJyZW50LXNlc3Npb24pOm5vdCgubmFtZSkpOgorICAgICAgICAo Lm5ldHdvcmstdGFibGUgPiAudGFibGUgbGk6bm90KC5maWxsZXIpIC5jZWxsLm5hbWU6bm90KC5j dXJyZW50LXNlc3Npb24pID4gKik6CisgICAgICAgICgubmV0d29yay10YWJsZSA+IC50YWJsZSBs aTpub3QoLmZpbGxlciwgLnNlbGVjdGVkKSAuY2VsbDpub3QoLmN1cnJlbnQtc2Vzc2lvbikpOiBE ZWxldGVkLgorCiAyMDIwLTEwLTI3ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiB0cnVuY2F0ZSBkYXRhIFVSTHMgaW4gdGhlIFJlc291 cmNlcyBzaWRlYmFyIGFuZCBIZWFkZXJzIHBhbmVsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5jc3Mg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVD b250ZW50Vmlldy5jc3MKaW5kZXggM2I1MDY1ZmVhZjgxYWM0YTZmNWU0N2FkNzQ0MGE2ZmFiNDM2 ZWNkYi4uMWM5ZGY1Nzk2ZDM5OGE4ZTBiYzlkMTY0ZWFiZGY1NTY2Nzc3MjJiOCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya1RhYmxl Q29udGVudFZpZXcuY3NzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL05ldHdvcmtUYWJsZUNvbnRlbnRWaWV3LmNzcwpAQCAtNTAsNyArNTAsNyBAQAogICAg IC13ZWJraXQtbWFyZ2luLWVuZDogNHB4OwogfQogCi0ubmV0d29yay10YWJsZSA+IC50YWJsZSBs aTpub3QoLmZpbGxlciwgLnNlbGVjdGVkKSAuY2VsbDpub3QoLmN1cnJlbnQtc2Vzc2lvbikgewor Lm5ldHdvcmstdGFibGUgPiAudGFibGUgbGk6bm90KC5maWxsZXIsIC5zZWxlY3RlZCkgLmNlbGw6 bm90KC5jdXJyZW50LXNlc3Npb24pOm5vdCgubmFtZSkgewogICAgIG9wYWNpdHk6IDAuNTsKIH0K IApAQCAtNTgsNiArNTgsMTAgQEAKICAgICBjdXJzb3I6IHBvaW50ZXI7CiB9CiAKKy5uZXR3b3Jr LXRhYmxlID4gLnRhYmxlIGxpOm5vdCguZmlsbGVyKSAuY2VsbC5uYW1lOm5vdCguY3VycmVudC1z ZXNzaW9uKSA+ICogeworICAgIG9wYWNpdHk6IDAuNTsKK30KKwogLm5ldHdvcmstdGFibGUgPiAu dGFibGUgLmNlbGwuZG9tLW5vZGUubmFtZSAuaWNvbiB7CiAgICAgY29udGVudDogdXJsKC4uL0lt YWdlcy9UeXBlSWNvbnMuc3ZnI0RPTUVsZW1lbnQtbGlnaHQpOwogfQo= 412571 2020-10-28 13:55:29 -0700 2020-10-28 14:34:09 -0700 Web Inspector: Network: Fix background color of rows from previous session bug-218058-20201028135529.patch text/plain 1706 fbucchi U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5MDk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk YTE0NzYwMWI0MDJiMWM5ZWRiODQ1MzdkYjE4ZmY1MGMyYjNiYWE5Li4zNDU1MGFmY2JmYzM5MjZl NjdlNmE4ZDg1ZTljY2YzNWI0OWMwYzY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMC0xMC0yOCAgRmVkZXJpY28gQnVjY2hpICA8ZmJ1Y2NoaUBhcHBsZS5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTmV0d29yazogYmFja2dyb3VuZCBjb2xvciBv ZiByb3dzIGZyb20gcHJldmlvdXMgc2Vzc2lvbiBpcyB3cm9uZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4MDU4CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS83MDU1MDQ1OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya1RhYmxlQ29udGVudFZpZXcuY3Nz OgorICAgICAgICAoLm5ldHdvcmstdGFibGUgPiAudGFibGUgbGk6bm90KC5maWxsZXIsIC5zZWxl Y3RlZCkgLmNlbGw6bm90KC5uYW1lLCAuY3VycmVudC1zZXNzaW9uKSwpOgorICAgICAgICAoLm5l dHdvcmstdGFibGUgPiAudGFibGUgbGk6bm90KC5maWxsZXIsIC5zZWxlY3RlZCkgLmNlbGw6bm90 KC5jdXJyZW50LXNlc3Npb24pKTogRGVsZXRlZC4KKwogMjAyMC0xMC0yNyAgRGV2aW4gUm91c3Nv ICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogdHJ1bmNhdGUg ZGF0YSBVUkxzIGluIHRoZSBSZXNvdXJjZXMgc2lkZWJhciBhbmQgSGVhZGVycyBwYW5lbApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29y a1RhYmxlQ29udGVudFZpZXcuY3NzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvTmV0d29ya1RhYmxlQ29udGVudFZpZXcuY3NzCmluZGV4IDNiNTA2NWZlYWY4MWFj NGE2ZjVlNDdhZDc0NDBhNmZhYjQzNmVjZGIuLmVmZjBiMzk4ZGFkMWI2MjFiYjI0OTc3YThiMzZj ODY3NTU1Y2M5NDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL05ldHdvcmtUYWJsZUNvbnRlbnRWaWV3LmNzcworKysgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5jc3MK QEAgLTUwLDcgKzUwLDggQEAKICAgICAtd2Via2l0LW1hcmdpbi1lbmQ6IDRweDsKIH0KIAotLm5l dHdvcmstdGFibGUgPiAudGFibGUgbGk6bm90KC5maWxsZXIsIC5zZWxlY3RlZCkgLmNlbGw6bm90 KC5jdXJyZW50LXNlc3Npb24pIHsKKy5uZXR3b3JrLXRhYmxlID4gLnRhYmxlIGxpOm5vdCguZmls bGVyLCAuc2VsZWN0ZWQpIC5jZWxsOm5vdCgubmFtZSwgLmN1cnJlbnQtc2Vzc2lvbiksCisubmV0 d29yay10YWJsZSA+IC50YWJsZSBsaTpub3QoLmZpbGxlciwgLnNlbGVjdGVkKSAuY2VsbC5uYW1l Om5vdCguY3VycmVudC1zZXNzaW9uKSA+ICogewogICAgIG9wYWNpdHk6IDAuNTsKIH0KIAo=