218057 2020-10-21 16:08:59 -0700 Turn ScriptExecutionContext::vm() into a pure virtual function 2020-10-22 09:24:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218028 InRadar P2 Normal --- 1 cdumez cdumez esprehn+autocc ews-watchlist ggaren kangil.han sam webkit-bug-importer oldest_to_newest 1700445 0 cdumez 2020-10-21 16:08:59 -0700 Turn ScriptExecutionContext::vm() into a pure virtual function instead of using a non-virtual function that does type-checking inside. 1700447 1 412043 cdumez 2020-10-21 16:10:04 -0700 Created attachment 412043 Patch 1700452 2 412043 ggaren 2020-10-21 16:17:14 -0700 Comment on attachment 412043 Patch r=me 1700674 3 ews-feeder 2020-10-22 09:23:13 -0700 Committed r268868: <https://trac.webkit.org/changeset/268868> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412043. 1700675 4 webkit-bug-importer 2020-10-22 09:24:18 -0700 <rdar://problem/70576507> 412043 2020-10-21 16:10:04 -0700 2020-10-22 09:23:13 -0700 Patch bug-218057-20201021161004.patch text/plain 6294 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4ODQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmQxNmMzMzk3N2RjN2Iy MDk0ZGZkMWI3MzM5NTY1MGYyYmQ0YWQwMy4uODY1NmEwYmI2MWNmMTY2MTc0ZGY2YWFiYjMxNmEx Y2M0YzVkNWJkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTEwLTIxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVHVybiBTY3JpcHRFeGVjdXRp b25Db250ZXh0Ojp2bSgpIGludG8gYSBwdXJlIHZpcnR1YWwgZnVuY3Rpb24KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODA1NworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFR1cm4gU2NyaXB0RXhlY3V0aW9u Q29udGV4dDo6dm0oKSBpbnRvIGEgcHVyZSB2aXJ0dWFsIGZ1bmN0aW9uIGluc3RlYWQgb2YgdXNp bmcgYQorICAgICAgICBub24tdmlydHVhbCBmdW5jdGlvbiB0aGF0IGRvZXMgdHlwZS1jaGVja2lu ZyBpbnNpZGUuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RG9jdW1lbnQ6OnZtKToKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuaDoKKyAgICAgICAgKiBk b20vRW1wdHlTY3JpcHRFeGVjdXRpb25Db250ZXh0Lmg6CisgICAgICAgICogZG9tL1NjcmlwdEV4 ZWN1dGlvbkNvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0RXhlY3V0aW9uQ29u dGV4dDo6dm0pOiBEZWxldGVkLgorICAgICAgICAqIGRvbS9TY3JpcHRFeGVjdXRpb25Db250ZXh0 Lmg6CisgICAgICAgICogd29ya2Vycy9Xb3JrZXJPcldvcmtsZXRHbG9iYWxTY29wZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpXb3JrZXJPcldvcmtsZXRHbG9iYWxTY29wZTo6dm0pOgorICAgICAg ICAqIHdvcmtlcnMvV29ya2VyT3JXb3JrbGV0R2xvYmFsU2NvcGUuaDoKKwogMjAyMC0xMC0yMSAg Q2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZHJlc3MgcG9zdC1s YW5kaW5nIHJldmlldyBmZWVkYmFjayBmcm9tIFNhbSBXZWluaWcgZm9yIHIyNjg4MjAuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUv ZG9tL0RvY3VtZW50LmNwcAppbmRleCA2ZTVmMDFkOWMzMmZkMjI2NDVhMzJiNDAwNjBjYjA0YjFi MTk3NjgxLi4xOWU2ODU4YzliNDVhZTZkODcyNzI5ODIxYmU0NDBjNGVlMjE5YWY2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9Eb2N1bWVudC5jcHAKQEAgLTg2NjksNiArODY2OSwxMSBAQCB2b2lkIERvY3VtZW50Ojpj YW52YXNEZXN0cm95ZWQoQ2FudmFzQmFzZSYgY2FudmFzQmFzZSkKICAgICB9CiB9CiAKK0pTQzo6 Vk0mIERvY3VtZW50Ojp2bSgpCit7CisgICAgcmV0dXJuIGNvbW1vblZNKCk7Cit9CisKIH0gLy8g bmFtZXNwYWNlIFdlYkNvcmUKIAogI3VuZGVmIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oIGIvU291cmNlL1dlYkNvcmUvZG9t L0RvY3VtZW50LmgKaW5kZXggOTNmYjc0OGE3Zjk1MjMxZDVkNjk4ZWFlNDAyMGEzZTkxMzViNjAy NC4uNGJmNmNlZDM0OGY5MjdlODg4YjVlMTI2N2MzZjQzMDYwMjRhZmMyMyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0Rv Y3VtZW50LmgKQEAgLTE1OTQsNiArMTU5NCw4IEBAIHB1YmxpYzoKICAgICBib29sIGNvbnRhaW5z KGNvbnN0IE5vZGUmIG5vZGUpIGNvbnN0IHsgcmV0dXJuIHRoaXMgPT0gJm5vZGUudHJlZVNjb3Bl KCkgJiYgbm9kZS5pc0Nvbm5lY3RlZCgpOyB9CiAgICAgYm9vbCBjb250YWlucyhjb25zdCBOb2Rl KiBub2RlKSBjb25zdCB7IHJldHVybiBub2RlICYmIGNvbnRhaW5zKCpub2RlKTsgfQogCisgICAg V0VCQ09SRV9FWFBPUlQgSlNDOjpWTSYgdm0oKSBmaW5hbDsKKwogcHJvdGVjdGVkOgogICAgIGVu dW0gQ29uc3RydWN0aW9uRmxhZ3MgeyBTeW50aGVzaXplZCA9IDEsIE5vblJlbmRlcmVkUGxhY2Vo b2xkZXIgPSAxIDw8IDEgfTsKICAgICBXRUJDT1JFX0VYUE9SVCBEb2N1bWVudChGcmFtZSosIGNv bnN0IFNldHRpbmdzJiwgY29uc3QgVVJMJiwgRG9jdW1lbnRDbGFzc0ZsYWdzID0gRGVmYXVsdERv Y3VtZW50Q2xhc3MsIHVuc2lnbmVkIGNvbnN0cnVjdGlvbkZsYWdzID0gMCk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9kb20vRW1wdHlTY3JpcHRFeGVjdXRpb25Db250ZXh0LmggYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vRW1wdHlTY3JpcHRFeGVjdXRpb25Db250ZXh0LmgKaW5kZXggNzNmMDQ0 ZjA2ZTk0ZmYyYjI3NzkyZTI4MTI4NmE0Njk3ZDQ0MTNlMS4uYzZhZTBlYTEzOTgwMDVjODgxMjQz YWVjZmQ2NTBiZmE2MGE3ZTJlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0VtcHR5 U2NyaXB0RXhlY3V0aW9uQ29udGV4dC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbXB0eVNj cmlwdEV4ZWN1dGlvbkNvbnRleHQuaApAQCAtNzUsMTIgKzc1LDE1IEBAIHB1YmxpYzoKICAgICBi b29sIHVud3JhcENyeXB0b0tleShjb25zdCBWZWN0b3I8dWludDhfdD4mLCBWZWN0b3I8dWludDhf dD4mKSBmaW5hbCB7IHJldHVybiBmYWxzZTsgfQogI2VuZGlmCiAKKyAgICBKU0M6OlZNJiB2bSgp IGZpbmFsIHsgcmV0dXJuIG1fdm07IH0KKwogICAgIHVzaW5nIFJlZkNvdW50ZWQ6OnJlZjsKICAg ICB1c2luZyBSZWZDb3VudGVkOjpkZXJlZjsKIAogcHJpdmF0ZToKICAgICBFbXB0eVNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQoSlNDOjpWTSYgdm0pCi0gICAgICAgIDogbV9vcmlnaW4oU2VjdXJpdHlP cmlnaW46OmNyZWF0ZVVuaXF1ZSgpKQorICAgICAgICA6IG1fdm0odm0pCisgICAgICAgICwgbV9v cmlnaW4oU2VjdXJpdHlPcmlnaW46OmNyZWF0ZVVuaXF1ZSgpKQogICAgICAgICAsIG1fZXZlbnRM b29wKEVtcHR5RXZlbnRMb29wOjpjcmVhdGUodm0pKQogICAgICAgICAsIG1fZXZlbnRMb29wVGFz a0dyb3VwKG1ha2VVbmlxdWU8RXZlbnRMb29wVGFza0dyb3VwPihtX2V2ZW50TG9vcCkpCiAgICAg ewpAQCAtMTEyLDYgKzExNSw3IEBAIHByaXZhdGU6CiAgICAgICAgIE1pY3JvdGFza1F1ZXVlIG1f cXVldWU7CiAgICAgfTsKIAorICAgIFJlZjxKU0M6OlZNPiBtX3ZtOwogICAgIFJlZjxTZWN1cml0 eU9yaWdpbj4gbV9vcmlnaW47CiAgICAgVVJMIG1fdXJsOwogICAgIFJlZjxFbXB0eUV2ZW50TG9v cD4gbV9ldmVudExvb3A7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RXhl Y3V0aW9uQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RXhlY3V0aW9uQ29u dGV4dC5jcHAKaW5kZXggOTE3YzhiZGRkYmQ5MzQwN2JhNjE5MjBmNzBkMDM5ZjA4MDg2OWVjYy4u YTg5Yjc0ZWM3ZDM5NWYzZjgzMTNlNWE0NmZhOGQ3MjExZDM4N2JkNyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZG9tL1NjcmlwdEV4ZWN1dGlvbkNvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9TY3JpcHRFeGVjdXRpb25Db250ZXh0LmNwcApAQCAtNDc3LDE3ICs0NzcsNiBA QCBTZWNvbmRzIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OmRvbVRpbWVyQWxpZ25tZW50SW50ZXJ2 YWwoYm9vbCkgY29uc3QKICAgICByZXR1cm4gRE9NVGltZXI6OmRlZmF1bHRBbGlnbm1lbnRJbnRl cnZhbCgpOwogfQogCi1KU0M6OlZNJiBTY3JpcHRFeGVjdXRpb25Db250ZXh0Ojp2bSgpCi17Ci0g ICAgaWYgKGlzPERvY3VtZW50PigqdGhpcykpCi0gICAgICAgIHJldHVybiBjb21tb25WTSgpOwot ICAgIGlmIChpczxXb3JrZXJPcldvcmtsZXRHbG9iYWxTY29wZT4oKnRoaXMpKQotICAgICAgICBy ZXR1cm4gZG93bmNhc3Q8V29ya2VyT3JXb3JrbGV0R2xvYmFsU2NvcGU+KCp0aGlzKS5zY3JpcHQo KS0+dm0oKTsKLQotICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgcmV0dXJu IGNvbW1vblZNKCk7Ci19Ci0KIFJlamVjdGVkUHJvbWlzZVRyYWNrZXImIFNjcmlwdEV4ZWN1dGlv bkNvbnRleHQ6OmVuc3VyZVJlamVjdGVkUHJvbWlzZVRyYWNrZXJTbG93KCkKIHsKICAgICAvLyBT Y3JpcHRFeGVjdXRpb25Db250ZXh0Ojp2bSgpIGluIFdvcmtlciBpcyBvbmx5IGF2YWlsYWJsZSBh ZnRlciBXb3JrZXJHbG9iYWxTY29wZSBpbml0aWFsaXphdGlvbiBpcyBkb25lLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdEV4ZWN1dGlvbkNvbnRleHQuaCBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9TY3JpcHRFeGVjdXRpb25Db250ZXh0LmgKaW5kZXggNzY3ZDQ1ZTkxYjc0ZjFi M2M2ZGJmZmQzYTk4MzY2ODM3ZTI3MWFiMS4uMjE1MGQyMjYxMTVmMTU3YzRmNmRlYzllMTRhYzhl ZjgyMzk1ZjYxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdEV4ZWN1dGlv bkNvbnRleHQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RXhlY3V0aW9uQ29udGV4 dC5oCkBAIC0yMTEsNyArMjExLDcgQEAgcHVibGljOgogICAgIHZvaWQgcmVtb3ZlVGltZW91dChp bnQgdGltZW91dElkKSB7IG1fdGltZW91dHMucmVtb3ZlKHRpbWVvdXRJZCk7IH0KICAgICBET01U aW1lciogZmluZFRpbWVvdXQoaW50IHRpbWVvdXRJZCkgeyByZXR1cm4gbV90aW1lb3V0cy5nZXQo dGltZW91dElkKTsgfQogCi0gICAgV0VCQ09SRV9FWFBPUlQgSlNDOjpWTSYgdm0oKTsKKyAgICB2 aXJ0dWFsIEpTQzo6Vk0mIHZtKCkgPSAwOwogCiAgICAgdm9pZCBhZGp1c3RNaW5pbXVtRE9NVGlt ZXJJbnRlcnZhbChTZWNvbmRzIG9sZE1pbmltdW1UaW1lckludGVydmFsKTsKICAgICB2aXJ0dWFs IFNlY29uZHMgbWluaW11bURPTVRpbWVySW50ZXJ2YWwoKSBjb25zdDsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyT3JXb3JrbGV0R2xvYmFsU2NvcGUuY3BwIGIvU291 cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJPcldvcmtsZXRHbG9iYWxTY29wZS5jcHAKaW5kZXgg NDg4YTQ5ODgxNDMxYWE2MjZhMWIyNTViZjQyMTZjOWQ4MzgzNmE2My4uMWYwMmY0YTIxYjM1Y2Y3 YjAxYTYyOGU5NjA3ODhhNDA0YzAxZDQwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd29y a2Vycy9Xb3JrZXJPcldvcmtsZXRHbG9iYWxTY29wZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv d29ya2Vycy9Xb3JrZXJPcldvcmtsZXRHbG9iYWxTY29wZS5jcHAKQEAgLTY0LDYgKzY0LDExIEBA IHZvaWQgV29ya2VyT3JXb3JrbGV0R2xvYmFsU2NvcGU6OmNsZWFyU2NyaXB0KCkKICAgICBtX3Nj cmlwdCA9IG51bGxwdHI7CiB9CiAKK0pTQzo6Vk0mIFdvcmtlck9yV29ya2xldEdsb2JhbFNjb3Bl Ojp2bSgpCit7CisgICAgcmV0dXJuIHNjcmlwdCgpLT52bSgpOworfQorCiB2b2lkIFdvcmtlck9y V29ya2xldEdsb2JhbFNjb3BlOjpkaXNhYmxlRXZhbChjb25zdCBTdHJpbmcmIGVycm9yTWVzc2Fn ZSkKIHsKICAgICBtX3NjcmlwdC0+ZGlzYWJsZUV2YWwoZXJyb3JNZXNzYWdlKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyT3JXb3JrbGV0R2xvYmFsU2NvcGUuaCBi L1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyT3JXb3JrbGV0R2xvYmFsU2NvcGUuaAppbmRl eCBjMGIxY2Y5MTI4NTU5MzY1NDVhMTNkMmU0NTA0YWI5NzZmOWMzZTdlLi4zNjAwNGJhMmU4NzRh MTU5YWM4NzU2YTAwYmY0YjAxOTI2ODcxZjlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93 b3JrZXJzL1dvcmtlck9yV29ya2xldEdsb2JhbFNjb3BlLmgKKysrIGIvU291cmNlL1dlYkNvcmUv d29ya2Vycy9Xb3JrZXJPcldvcmtsZXRHbG9iYWxTY29wZS5oCkBAIC00Nyw2ICs0Nyw4IEBAIHB1 YmxpYzoKICAgICBXb3JrZXJPcldvcmtsZXRTY3JpcHRDb250cm9sbGVyKiBzY3JpcHQoKSBjb25z dCB7IHJldHVybiBtX3NjcmlwdC5nZXQoKTsgfQogICAgIHZvaWQgY2xlYXJTY3JpcHQoKTsKIAor ICAgIEpTQzo6Vk0mIHZtKCkgZmluYWw7CisKICAgICB1bnNpZ25lZCBsb25nIGNyZWF0ZVVuaXF1 ZUlkZW50aWZpZXIoKSB7IHJldHVybiBtX3VuaXF1ZUlkZW50aWZpZXIrKzsgfQogCiAgICAgLy8g U2NyaXB0RXhlY3V0aW9uQ29udGV4dC4K