218034 2020-10-21 10:05:53 -0700 [LFC][Integration] Add content dependent vertical line snapping 2020-10-21 14:25:18 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1700253 0 zalan 2020-10-21 10:05:53 -0700 apparently <div>foobar<img></div> does not snap to integral vertical position 1700258 1 412004 zalan 2020-10-21 10:09:52 -0700 Created attachment 412004 Patch 1700391 2 ews-feeder 2020-10-21 14:24:12 -0700 Committed r268825: <https://trac.webkit.org/changeset/268825> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412004. 1700392 3 webkit-bug-importer 2020-10-21 14:25:18 -0700 <rdar://problem/70545240> 412004 2020-10-21 10:09:52 -0700 2020-10-21 14:24:12 -0700 Patch bug-218034-20201021100951.patch text/plain 5504 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4Nzk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjFjNjUyZjJlMjU2NjI0 NTIyZWU0ZThjOTY3OTE1ZTQ5NGJiNTkyMS4uYjc4ZWFjZThlMTgwYTZhY2E0Y2I2YjJiZWU4NzIx NGRlNGE3ODg0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTEwLTIxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSW50ZWdyYXRpb25d IEFkZCBjb250ZW50IGRlcGVuZGVudCB2ZXJ0aWNhbCBsaW5lIHNuYXBwaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTgwMzQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGVuc3VyZXMg dGhhdCBJRkMgaW50ZWdyYXRpb24gbGluZSBzbmFwcGluZyBtYXRjaGVzIHRoZSBsZWdhY3kgbGlu ZSBsYXlvdXQgc25hcHBpbmcgYmVoYXZpb3IgKGUuZy4gaW1hZ2VzIHByZXZlbnQgbGluZSBzbmFw cGluZykuCisKKyAgICAgICAgKiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQm94 Lmg6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmVCb3g6OklubGluZUxldmVsQm94Ojpp c0F0b21pY0lubGluZUxldmVsQm94IGNvbnN0KToKKyAgICAgICAgKiBsYXlvdXQvaW50ZWdyYXRp b24vTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okxh eW91dEludGVncmF0aW9uOjpMaW5lTGF5b3V0Ojpjb25zdHJ1Y3RDb250ZW50KToKKwogMjAyMC0x MC0yMSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11b SW50ZWdyYXRpb25dIFVwZGF0ZSBzdHlsZSBvZiBjb250YWluZWQgbGF5b3V0IGJveGVzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5l Qm94LmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5l Qm94LmgKaW5kZXggZWI1ODMxNzljNDc2YjhjZTQxMGJjYzBhNWQ4YTU3OGI4YzFmNjdiNS4uYjQx MGQ3NDQzZWEyZTdkYzRhMmIwODg2MTZjM2IzZGIwYzE5NGE4YyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJveC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCb3guaApAQCAt ODMsNiArODMsNyBAQCBwdWJsaWM6CiAgICAgICAgIGNvbnN0IEJveCYgbGF5b3V0Qm94KCkgY29u c3QgeyByZXR1cm4gKm1fbGF5b3V0Qm94OyB9CiAKICAgICAgICAgYm9vbCBpc0lubGluZUJveCgp IGNvbnN0IHsgcmV0dXJuIG1fdHlwZSA9PSBUeXBlOjpJbmxpbmVCb3ggfHwgbV90eXBlID09IFR5 cGU6OlJvb3RJbmxpbmVCb3g7IH0KKyAgICAgICAgYm9vbCBpc0F0b21pY0lubGluZUxldmVsQm94 KCkgY29uc3QgeyByZXR1cm4gbV90eXBlID09IFR5cGU6OkF0b21pY0lubGluZUxldmVsQm94OyB9 CiAgICAgICAgIGJvb2wgaXNMaW5lQnJlYWtCb3goKSBjb25zdCB7IHJldHVybiBtX3R5cGUgPT0g VHlwZTo6TGluZUJyZWFrQm94OyB9CiAgICAgICAgIGJvb2wgaGFzTGluZUJveFJlbGF0aXZlQWxp Z25tZW50KCkgY29uc3Q7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRl Z3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUv bGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAKaW5kZXgg MjVhNThmNDIwZGJmZTFlNGJjZjAwZmMwMGE2ODYzY2ZkNWExMGVkMi4uOWI5MjVmNWQxNmVjMmFk YTU2YjZhNTI2MjY4ZTUyM2RlZTgwYTIyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5 b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91 dC5jcHAKQEAgLTEzNSw4ICsxMzUsMzEgQEAgdm9pZCBMaW5lTGF5b3V0Ojpjb25zdHJ1Y3RDb250 ZW50KCkKIHsKICAgICBhdXRvJiBkaXNwbGF5SW5saW5lQ29udGVudCA9IGVuc3VyZUlubGluZUNv bnRlbnQoKTsKIAorICAgIGF1dG8gbGluZU5lZWRzTGVnYWN5SW50ZWdyYWxWZXJ0aWNhbFBvc2l0 aW9uID0gWyZdKHNpemVfdCBsaW5lSW5kZXgpIHsKKyAgICAgICAgUkVMRUFTRV9BU1NFUlQobV9p bmxpbmVGb3JtYXR0aW5nU3RhdGUubGluZUJveGVzKCkuc2l6ZSgpID4gbGluZUluZGV4KTsKKyAg ICAgICAgLy8gSW5saW5lVHJlZSByb3VuZHMgeSBwb3NpdGlvbiB0byBpbnRlZ3JhbCB2YWx1ZSBm b3IgY2VydGFpbiBjb250ZW50IChzZWUgSW5saW5lRmxvd0JveDo6cGxhY2VCb3hlc0luQmxvY2tE aXJlY3Rpb24pLgorICAgICAgICBhdXRvIGlubGluZUxldmVsQm94TGlzdCA9IG1faW5saW5lRm9y bWF0dGluZ1N0YXRlLmxpbmVCb3hlcygpW2xpbmVJbmRleF0uaW5saW5lTGV2ZWxCb3hMaXN0KCk7 CisgICAgICAgIGlmIChpbmxpbmVMZXZlbEJveExpc3Quc2l6ZSgpID09IDEpIHsKKyAgICAgICAg ICAgIC8vIFRoaXMgaXMgdGV4dCBjb250ZW50IG9ubHkgd2l0aCByb290IGlubGluZSBib3guCisg ICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgfQorICAgICAgICAvLyBUZXh0ICsgPGJy PiAob3IganVzdCA8YnI+IG9yIHRleHQ8c3Bhbj48L3NwYW4+PGJyPikgYmVoYXZlcyBsaWtlIHRl eHQuCisgICAgICAgIGZvciAoYXV0byYgaW5saW5lTGV2ZWxCb3ggOiBpbmxpbmVMZXZlbEJveExp c3QpIHsKKyAgICAgICAgICAgIGlmIChpbmxpbmVMZXZlbEJveC0+aXNBdG9taWNJbmxpbmVMZXZl bEJveCgpKSB7CisgICAgICAgICAgICAgICAgLy8gQ29udGVudCBsaWtlIHRleHQ8aW1nPiBwcmV2 ZW50cyBsZWdhY3kgc25hcHBpbmcuCisgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAg ICAgICAgICAgfQorICAgICAgICB9CisgICAgICAgIHJldHVybiB0cnVlOworICAgIH07CisKICAg ICBhdXRvIGNvbnN0cnVjdERpc3BsYXlMaW5lUnVucyA9IFsmXSB7CiAgICAgICAgIGF1dG8gaW5p dGlhbENvbnRhaW5nQmxvY2tTaXplID0gbV9sYXlvdXRTdGF0ZS52aWV3cG9ydFNpemUoKTsKKyAg ICAgICAgc3RydWN0IExpbmVMZWdhY3lWZXJ0aWNhbFBvc2l0aW9uUG9saWN5IHsKKyAgICAgICAg ICAgIHNpemVfdCBsaW5lSW5kZXggeyAwIH07CisgICAgICAgICAgICBib29sIG5lZWRzSW50ZWdy YWxQb3NpdGlvbiB7IHRydWUgfTsgCisgICAgICAgIH07CisgICAgICAgIGF1dG8gbGluZUxlZ2Fj eVZlcnRpY2FsUG9zaXRpb25Qb2xpY3kgPSBMaW5lTGVnYWN5VmVydGljYWxQb3NpdGlvblBvbGlj eSB7IDAsIGxpbmVOZWVkc0xlZ2FjeUludGVncmFsVmVydGljYWxQb3NpdGlvbigwKSB9OwogICAg ICAgICBmb3IgKGF1dG8mIGxpbmVSdW4gOiBtX2lubGluZUZvcm1hdHRpbmdTdGF0ZS5saW5lUnVu cygpKSB7CiAgICAgICAgICAgICBhdXRvJiBsYXlvdXRCb3ggPSBsaW5lUnVuLmxheW91dEJveCgp OwogICAgICAgICAgICAgYXV0byBjb21wdXRlZElua092ZXJmbG93ID0gWyZdIChhdXRvIHJ1blJl Y3QpIHsKQEAgLTE2MSw5ICsxODQsOSBAQCB2b2lkIExpbmVMYXlvdXQ6OmNvbnN0cnVjdENvbnRl bnQoKQogICAgICAgICAgICAgYXV0byBsaW5lSW5kZXggPSBsaW5lUnVuLmxpbmVJbmRleCgpOwog ICAgICAgICAgICAgYXV0byBsaW5lQm94TG9naWNhbFJlY3QgPSBtX2lubGluZUZvcm1hdHRpbmdT dGF0ZS5saW5lcygpW2xpbmVJbmRleF0ubGluZUJveExvZ2ljYWxSZWN0KCk7CiAgICAgICAgICAg ICBydW5SZWN0Lm1vdmVCeSh7IGxpbmVCb3hMb2dpY2FsUmVjdC5sZWZ0KCksIGxpbmVCb3hMb2dp Y2FsUmVjdC50b3AoKSB9KTsKLSAgICAgICAgICAgIC8vIElubGluZVRyZWUgcm91bmRzIHkgcG9z aXRpb24gdG8gaW50ZWdyYWwgdmFsdWUsIHNlZSBJbmxpbmVGbG93Qm94OjpwbGFjZUJveGVzSW5C bG9ja0RpcmVjdGlvbi4KLSAgICAgICAgICAgIGF1dG8gbmVlZHNMZWdhY3lJbnRlZ3JhbFBvc2l0 aW9uID0gIWxheW91dEJveC5pc1JlcGxhY2VkQm94KCk7Ci0gICAgICAgICAgICBpZiAobmVlZHNM ZWdhY3lJbnRlZ3JhbFBvc2l0aW9uKQorICAgICAgICAgICAgaWYgKGxpbmVJbmRleCAhPSBsaW5l TGVnYWN5VmVydGljYWxQb3NpdGlvblBvbGljeS5saW5lSW5kZXgpCisgICAgICAgICAgICAgICAg bGluZUxlZ2FjeVZlcnRpY2FsUG9zaXRpb25Qb2xpY3kgPSBMaW5lTGVnYWN5VmVydGljYWxQb3Np dGlvblBvbGljeSB7IGxpbmVJbmRleCwgbGluZU5lZWRzTGVnYWN5SW50ZWdyYWxWZXJ0aWNhbFBv c2l0aW9uKGxpbmVJbmRleCkgfTsKKyAgICAgICAgICAgIGlmIChsaW5lTGVnYWN5VmVydGljYWxQ b3NpdGlvblBvbGljeS5uZWVkc0ludGVncmFsUG9zaXRpb24pCiAgICAgICAgICAgICAgICAgcnVu UmVjdC5zZXRZKHJvdW5kVG9JbnQocnVuUmVjdC55KCkpKTsKIAogICAgICAgICAgICAgV1RGOjpP cHRpb25hbDxSdW46OlRleHRDb250ZW50PiB0ZXh0Q29udGVudDsKQEAgLTIxMiw4ICsyMzUsOCBA QCB2b2lkIExpbmVMYXlvdXQ6OmNvbnN0cnVjdENvbnRlbnQoKQogICAgICAgICAgICAgYXV0byBs aW5lUmVjdCA9IEZsb2F0UmVjdCB7IGxpbmUubG9naWNhbFJlY3QoKSB9OwogICAgICAgICAgICAg Ly8gUGFpbnRpbmcgY29kZSAoc3BlY2lmaWNhbGx5IFRleHRSdW4ncyB4UG9zKSBuZWVkcyB0aGUg bGluZSBib3ggb2Zmc2V0IHRvIGJlIGFibGUgdG8gY29tcHV0ZSB0YWIgcG9zaXRpb25zLgogICAg ICAgICAgICAgbGluZVJlY3Quc2V0WChsaW5lQm94TG9naWNhbFJlY3QubGVmdCgpKTsKLSAgICAg ICAgICAgIC8vIElubGluZVRyZWUgcm91bmRzIHkgcG9zaXRpb24gdG8gaW50ZWdyYWwgdmFsdWUs IHNlZSBJbmxpbmVGbG93Qm94OjpwbGFjZUJveGVzSW5CbG9ja0RpcmVjdGlvbi4KLSAgICAgICAg ICAgIGxpbmVSZWN0LnNldFkocm91bmRUb0ludChsaW5lUmVjdC55KCkpKTsKKyAgICAgICAgICAg IGlmIChsaW5lTmVlZHNMZWdhY3lJbnRlZ3JhbFZlcnRpY2FsUG9zaXRpb24obGluZUluZGV4KSkK KyAgICAgICAgICAgICAgICBsaW5lUmVjdC5zZXRZKHJvdW5kVG9JbnQobGluZVJlY3QueSgpKSk7 CiAgICAgICAgICAgICBkaXNwbGF5SW5saW5lQ29udGVudC5saW5lcy5hcHBlbmQoeyBmaXJzdFJ1 bkluZGV4LCBydW5Db3VudCwgbGluZVJlY3QsIHNjcm9sbGFibGVPdmVyZmxvd1JlY3QsIGxpbmVJ bmtPdmVyZmxvd1JlY3QsIGxpbmUuYmFzZWxpbmUoKSwgbGluZS5ob3Jpem9udGFsQWxpZ25tZW50 T2Zmc2V0KCkgfSk7CiAgICAgICAgIH0KICAgICB9Owo=