218028 2020-10-21 08:50:59 -0700 Simplify ScriptExecutionContext::vm() 2020-10-21 16:10:32 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218057 InRadar P2 Normal --- 217724 1 cdumez cdumez cdumez darin eric.carlson esprehn+autocc ews-watchlist ggaren kangil.han sam webkit-bug-importer oldest_to_newest 1700202 0 cdumez 2020-10-21 08:50:59 -0700 Simplify ScriptExecutionContext::vm(). 1700204 1 411992 cdumez 2020-10-21 08:51:39 -0700 Created attachment 411992 Patch 1700238 2 ews-feeder 2020-10-21 09:40:50 -0700 Committed r268801: <https://trac.webkit.org/changeset/268801> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411992. 1700240 3 webkit-bug-importer 2020-10-21 09:41:20 -0700 <rdar://problem/70532783> 1700420 4 411992 sam 2020-10-21 15:24:43 -0700 Comment on attachment 411992 Patch I feel like this would be even better as a pure-virtual function that the subclasses would implement. That would avoid one virtual function call in the worker/worklet case as well. 1700422 5 cdumez 2020-10-21 15:27:29 -0700 (In reply to Sam Weinig from comment #4) > Comment on attachment 411992 [details] > Patch > > I feel like this would be even better as a pure-virtual function that the > subclasses would implement. That would avoid one virtual function call in > the worker/worklet case as well. Good idea. I will look into this shortly. 1700425 6 sam 2020-10-21 15:33:38 -0700 (In reply to Chris Dumez from comment #5) > (In reply to Sam Weinig from comment #4) > > Comment on attachment 411992 [details] > > Patch > > > > I feel like this would be even better as a pure-virtual function that the > > subclasses would implement. That would avoid one virtual function call in > > the worker/worklet case as well. > > Good idea. I will look into this shortly. 👍 1700449 7 cdumez 2020-10-21 16:10:32 -0700 (In reply to Sam Weinig from comment #6) > (In reply to Chris Dumez from comment #5) > > (In reply to Sam Weinig from comment #4) > > > Comment on attachment 411992 [details] > > > Patch > > > > > > I feel like this would be even better as a pure-virtual function that the > > > subclasses would implement. That would avoid one virtual function call in > > > the worker/worklet case as well. > > > > Good idea. I will look into this shortly. > > 👍 https://bugs.webkit.org/show_bug.cgi?id=218057 411992 2020-10-21 08:51:39 -0700 2020-10-21 09:40:50 -0700 Patch bug-218028-20201021085138.patch text/plain 1484 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4Nzk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmUzNTJjMWYzYjhiY2M3 MmM5YjBiODQwNjYzMTZhMGM4NWU1ODgyYi4uNTFmOGFjMWU0YzJiMjRkNTIzYjExYjExYWIzMzQy MTA0ZmY3MDMzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTEwLTIxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2ltcGxpZnkgU2NyaXB0RXhl Y3V0aW9uQ29udGV4dDo6dm0oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjE4MDI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBkb20vU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTY3JpcHRFeGVjdXRpb25Db250ZXh0Ojp2bSk6CisKIDIwMjAtMTAtMjAgIFNlcmdp byBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAgW2Nzcy1mbGV4 Ym94XSBmbGV4LWJhc2lzIG5vdCBhbmltYXRhYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9kb20vU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2Ny aXB0RXhlY3V0aW9uQ29udGV4dC5jcHAKaW5kZXggMzdhNmJmYTk2MGJkNjcxNDc1ZDgwOWNhOTk4 OGQxM2E2Zjg0MzBiYy4uOTE3YzhiZGRkYmQ5MzQwN2JhNjE5MjBmNzBkMDM5ZjA4MDg2OWVjYyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdEV4ZWN1dGlvbkNvbnRleHQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFeGVjdXRpb25Db250ZXh0LmNwcApAQCAt NDgxLDEwICs0ODEsOCBAQCBKU0M6OlZNJiBTY3JpcHRFeGVjdXRpb25Db250ZXh0Ojp2bSgpCiB7 CiAgICAgaWYgKGlzPERvY3VtZW50PigqdGhpcykpCiAgICAgICAgIHJldHVybiBjb21tb25WTSgp OwotICAgIGlmIChpczxXb3JrZXJHbG9iYWxTY29wZT4oKnRoaXMpKQotICAgICAgICByZXR1cm4g ZG93bmNhc3Q8V29ya2VyR2xvYmFsU2NvcGU+KCp0aGlzKS5zY3JpcHQoKS0+dm0oKTsKLSAgICBp ZiAoaXM8V29ya2xldEdsb2JhbFNjb3BlPigqdGhpcykpCi0gICAgICAgIHJldHVybiBkb3duY2Fz dDxXb3JrbGV0R2xvYmFsU2NvcGU+KCp0aGlzKS5zY3JpcHQoKS0+dm0oKTsKKyAgICBpZiAoaXM8 V29ya2VyT3JXb3JrbGV0R2xvYmFsU2NvcGU+KCp0aGlzKSkKKyAgICAgICAgcmV0dXJuIGRvd25j YXN0PFdvcmtlck9yV29ya2xldEdsb2JhbFNjb3BlPigqdGhpcykuc2NyaXB0KCktPnZtKCk7CiAK ICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIHJldHVybiBjb21tb25WTSgp Owo=