218025 2020-10-21 08:20:55 -0700 Don't crash when deallocating WKWebView during TLS handshake 2020-10-21 09:01:37 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen thorton webkit-bug-importer oldest_to_newest 1700188 0 achristensen 2020-10-21 08:20:55 -0700 Don't crash when deallocating WKWebView during TLS handshake 1700189 1 411987 achristensen 2020-10-21 08:24:43 -0700 Created attachment 411987 Patch 1700190 2 achristensen 2020-10-21 08:24:47 -0700 <rdar://problem/70225969> 1700206 3 ews-feeder 2020-10-21 09:01:36 -0700 Committed r268796: <https://trac.webkit.org/changeset/268796> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411987. 411987 2020-10-21 08:24:43 -0700 2020-10-21 09:01:36 -0700 Patch bug-218025-20201021092442.patch text/plain 5381 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4NjY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGMzOGUwZGE0ZTU0MzVhYmVk NDZlNTM1ZTJlZmY3ODdkN2Q1NTU4OTYuLjk4M2RlYWNhNTM1NjE4ODk4MTA5MTEzYmMzODBiNTI0 NTRlYmE4NGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMTAtMjEgIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBEb24ndCBjcmFz aCB3aGVuIGRlYWxsb2NhdGluZyBXS1dlYlZpZXcgZHVyaW5nIFRMUyBoYW5kc2hha2UKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODAyNQorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNzAyMjU5Njk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTmV0d29ya1Byb2Nlc3NQcm94eTo6ZGlkUmVjZWl2ZUF1dGhl bnRpY2F0aW9uQ2hhbGxlbmdlIHdvdWxkIHNvbWV0aW1lcyBkZXJlZmVyZW5jZSBhbiB1bmNoZWNr ZWQKKyAgICAgICAgT3B0aW9uYWw8U2VjdXJpdHlPcmlnaW5EYXRhPiB3aGljaCB3b3VsZCByZXN1 bHQgaW4gYSBudWxsIGRlcmVmZXJlbmNlIGNyYXNoLiAgQWxzbywgc29tZXRpbWVzCisgICAgICAg IENvbm5lY3Rpb246OmluaXRpYWxpemVTZW5kU291cmNlIHdvdWxkIGFzc2VydCBiZWNhdXNlIGl0 IHdhcyB0cnlpbmcgdG8gc2V0IHVwIGEgY2FuY2VsIGhhbmRsZXIgZm9yCisgICAgICAgIGEgc2Vu ZCBwb3J0IHRoYXQgaGFkIG5vdCBiZWVuIHN1Y2Nlc3NmdWxseSBzZXQgdXAgeWV0LiAgSSBhZGRl ZCBhIHRlc3QgdGhhdCByZXByb2R1Y2VzIGJvdGggb2YgdGhlc2UKKyAgICAgICAgaXNzdWVzIG1v c3Qgb2YgdGhlIHRpbWUuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9JUEMvY29jb2EvQ29ubmVjdGlv bkNvY29hLm1tOgorICAgICAgICAoSVBDOjpDb25uZWN0aW9uOjppbml0aWFsaXplU2VuZFNvdXJj ZSk6CisgICAgICAgICogVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NQcm94eS5jcHA6 CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtQcm9jZXNzUHJveHk6OmRpZFJlY2VpdmVBdXRoZW50 aWNhdGlvbkNoYWxsZW5nZSk6CisKIDIwMjAtMTAtMTggIEZ1amlpIEhpcm9ub3JpICA8SGlyb25v cmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgW1dpbkNhaXJvXSBzbHVnZ2lzaCBwYWdlIHNj cm9sbGluZyBmb3Igd2hlZWwgZXZlbnRzIHNpbmNlIHIyNjg0OTkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvUGxhdGZvcm0vSVBDL2NvY29hL0Nvbm5lY3Rpb25Db2NvYS5tbSBiL1NvdXJjZS9X ZWJLaXQvUGxhdGZvcm0vSVBDL2NvY29hL0Nvbm5lY3Rpb25Db2NvYS5tbQppbmRleCA1MzA4NTNi ZTRhYjlkYTUzNTA4ZmNmMGQzMDE4YTFmZTFmYzUxMjlmLi4xODk0YzlmM2ZlYWE2YzlhZWM3MTUz YzgxOTkwNGU0YWNlODY4OWYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQ Qy9jb2NvYS9Db25uZWN0aW9uQ29jb2EubW0KKysrIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9J UEMvY29jb2EvQ29ubmVjdGlvbkNvY29hLm1tCkBAIC0zOTQsMTIgKzM5NCwxMyBAQCB2b2lkIENv bm5lY3Rpb246OmluaXRpYWxpemVTZW5kU291cmNlKCkKICAgICAgICAgfQogICAgIH0pOwogCi0g ICAgQVNTRVJUKE1BQ0hfUE9SVF9WQUxJRChtX3NlbmRQb3J0KSk7Ci0gICAgbWFjaF9wb3J0X3Qg c2VuZFBvcnQgPSBtX3NlbmRQb3J0OwotICAgIGRpc3BhdGNoX3NvdXJjZV9zZXRfY2FuY2VsX2hh bmRsZXIobV9zZW5kU291cmNlLCBeewotICAgICAgICAvLyBSZWxlYXNlIG91ciBzZW5kIHJpZ2h0 LgotICAgICAgICBkZWFsbG9jYXRlU2VuZFJpZ2h0U2FmZWx5KHNlbmRQb3J0KTsKLSAgICB9KTsK KyAgICBpZiAoTUFDSF9QT1JUX1ZBTElEKG1fc2VuZFBvcnQpKSB7CisgICAgICAgIG1hY2hfcG9y dF90IHNlbmRQb3J0ID0gbV9zZW5kUG9ydDsKKyAgICAgICAgZGlzcGF0Y2hfc291cmNlX3NldF9j YW5jZWxfaGFuZGxlcihtX3NlbmRTb3VyY2UsIF57CisgICAgICAgICAgICAvLyBSZWxlYXNlIG91 ciBzZW5kIHJpZ2h0LgorICAgICAgICAgICAgZGVhbGxvY2F0ZVNlbmRSaWdodFNhZmVseShzZW5k UG9ydCk7CisgICAgICAgIH0pOworICAgIH0KIH0KIAogdm9pZCBDb25uZWN0aW9uOjpyZXN1bWVT ZW5kU291cmNlKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL05ldHdvcmsv TmV0d29ya1Byb2Nlc3NQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9OZXR3b3Jr L05ldHdvcmtQcm9jZXNzUHJveHkuY3BwCmluZGV4IDA0ZDllNzU1MThjMzdhMTcxM2VmOTNiYTYy ZGE0OTczNmE2YmE3NjkuLjZlZTI2ZDA0NmIwYjIxODg3MDczZTZlZTczNDk4NDNkYWQzMzVhZmEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nl c3NQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTmV0d29yay9OZXR3b3Jr UHJvY2Vzc1Byb3h5LmNwcApAQCAtNDMyLDYgKzQzMiwxMSBAQCB2b2lkIE5ldHdvcmtQcm9jZXNz UHJveHk6OmRpZFJlY2VpdmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZShQQUw6OlNlc3Npb25JRCBz ZXNzaQogICAgICAgICByZXR1cm47CiAgICAgfQogCisgICAgaWYgKCF0b3BPcmlnaW4pIHsKKyAg ICAgICAgYXV0aGVudGljYXRpb25DaGFsbGVuZ2UtPmxpc3RlbmVyKCkuY29tcGxldGVDaGFsbGVu Z2UoQXV0aGVudGljYXRpb25DaGFsbGVuZ2VEaXNwb3NpdGlvbjo6UmVqZWN0UHJvdGVjdGlvblNw YWNlQW5kQ29udGludWUpOworICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgV2ViUGFnZVBy b3h5Ojpmb3JNb3N0VmlzaWJsZVdlYlBhZ2VJZkFueShzZXNzaW9uSUQsICp0b3BPcmlnaW4sIFt0 aGlzLCB3ZWFrVGhpcyA9IG1ha2VXZWFrUHRyKHRoaXMpLCBzZXNzaW9uSUQsIGF1dGhlbnRpY2F0 aW9uQ2hhbGxlbmdlID0gV1RGTW92ZShhdXRoZW50aWNhdGlvbkNoYWxsZW5nZSksIG5lZ290aWF0 ZWRMZWdhY3lUTFNdKGF1dG8qIHBhZ2UpIG11dGFibGUgewogICAgICAgICBpZiAoIXdlYWtUaGlz KQogICAgICAgICAgICAgcmV0dXJuOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9v bHMvQ2hhbmdlTG9nCmluZGV4IDc4ZTk3MmNkNzdhZjRhOWNkZGFhMDc5ZmE2MWU0YTBhMDVjMDFh NmMuLjgwYjVkMTJkMzNiYzIwYjIxNzAyZDRhNzQ5MDhhYmEyMmI5NGJiNmUgMTAwNjQ0Ci0tLSBh L1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAyMC0xMC0yMSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgor CisgICAgICAgIERvbid0IGNyYXNoIHdoZW4gZGVhbGxvY2F0aW5nIFdLV2ViVmlldyBkdXJpbmcg VExTIGhhbmRzaGFrZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjE4MDI1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MDIyNTk2OT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkv VGVzdHMvV2ViS2l0Q29jb2EvQ2hhbGxlbmdlLm1tOgorICAgICAgICAoVEVTVCk6CisKIDIwMjAt MTAtMTggIExhdXJvIE1vdXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CiAKICAgICAgICAgd2Via2l0 Y29yZXB5OiBBbGxvdyBvbmUgcGFja2FnZSB0byByZXF1aXJlIGFub3RoZXIgcGFja2FnZQpkaWZm IC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9DaGFsbGVuZ2Uu bW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0NoYWxsZW5nZS5tbQpp bmRleCBhMmI3Yjg0ZDc3OTFkYmU2M2ZmOWJhNzBkMzE3OTllZDg2NTcwYjJmLi4wYzljZDUzNDc4 OTRkMjMyY2E2YzgyMGZhOTBlZDMyNWYxZjE1NDVlIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0NoYWxsZW5nZS5tbQorKysgYi9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0NoYWxsZW5nZS5tbQpAQCAtMjQwLDYgKzI0MCwyOSBA QCBURVNUKENoYWxsZW5nZSwgU2VjSWRlbnRpdHkpCiAgICAgVXRpbDo6cnVuKCZuYXZpZ2F0aW9u RmluaXNoZWQpOwogfQogCitURVNUKENoYWxsZW5nZSwgRGVhbGxvY2F0ZUR1cmluZ0NoYWxsZW5n ZSkKK3sKKyAgICB1c2luZyBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSTsKKyAgICBIVFRQU2VydmVy IHNlcnZlcih7eyAiLyIsIHsgImhpIiB9fX0sIEhUVFBTZXJ2ZXI6OlByb3RvY29sOjpIdHRwcyk7 CisKKyAgICBhdXRvIGRlbGVnYXRlID0gW1tUZXN0TmF2aWdhdGlvbkRlbGVnYXRlIG5ld10gYXV0 b3JlbGVhc2VdOworICAgIGRlbGVnYXRlLmRpZFJlY2VpdmVBdXRoZW50aWNhdGlvbkNoYWxsZW5n ZSA9IF4oV0tXZWJWaWV3ICosIE5TVVJMQXV0aGVudGljYXRpb25DaGFsbGVuZ2UgKmNoYWxsZW5n ZSwgdm9pZCAoXmNvbXBsZXRpb25IYW5kbGVyKShOU1VSTFNlc3Npb25BdXRoQ2hhbGxlbmdlRGlz cG9zaXRpb24sIE5TVVJMQ3JlZGVudGlhbCAqKSkgeworICAgICAgICBjb21wbGV0aW9uSGFuZGxl cihOU1VSTFNlc3Npb25BdXRoQ2hhbGxlbmdlVXNlQ3JlZGVudGlhbCwgW05TVVJMQ3JlZGVudGlh bCBjcmVkZW50aWFsRm9yVHJ1c3Q6Y2hhbGxlbmdlLnByb3RlY3Rpb25TcGFjZS5zZXJ2ZXJUcnVz dF0pOworICAgIH07CisKKyAgICBAYXV0b3JlbGVhc2Vwb29sIHsKKyAgICAgICAgVmVjdG9yPFJl dGFpblB0cjxXS1dlYlZpZXc+PiB2aWV3czsKKyAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkg PCAxMDA7IGkrKykKKyAgICAgICAgICAgIHZpZXdzLmFwcGVuZChhZG9wdE5TKFtXS1dlYlZpZXcg bmV3XSkpOworICAgICAgICBmb3IgKGF1dG8mIHZpZXcgOiB2aWV3cykgeworICAgICAgICAgICAg W3ZpZXcgc2V0TmF2aWdhdGlvbkRlbGVnYXRlOmRlbGVnYXRlXTsKKyAgICAgICAgICAgIFt2aWV3 IGxvYWRSZXF1ZXN0OnNlcnZlci5yZXF1ZXN0KCldOworICAgICAgICB9CisgICAgICAgIFV0aWw6 OnNwaW5SdW5Mb29wKDEwKTsKKyAgICB9CisgICAgVXRpbDo6c3BpblJ1bkxvb3AoMTAwMCk7Cit9 CisKIEBpbnRlcmZhY2UgQ2xpZW50Q2VydGlmaWNhdGVEZWxlZ2F0ZSA6IE5TT2JqZWN0IDxXS05h dmlnYXRpb25EZWxlZ2F0ZT4gewogICAgIFZlY3RvcjxSZXRhaW5QdHI8TlNTdHJpbmc+PiBfYXV0 aGVudGljYXRpb25NZXRob2RzOwogfQo=