21799 2008-10-22 09:01:28 -0700 Crash in dumpFramesAsText() when running http/tests/security/cross-origin-xsl-BLOCKED.html 2009-01-15 11:54:55 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP RESOLVED FIXED InRadar, LayoutTestFailure P2 Normal --- 1 aroben webkit-unassigned oldest_to_newest 96177 0 aroben 2008-10-22 09:01:28 -0700 To reproduce: 1. Run http/tests/security/cross-origin-xsl-BLOCKED.html You'll hit a crash in dumpFramesAsText (documentElement is 0). Here's the backtrace: DumpRenderTree_debug.exe!IUnknown::QueryInterface<IDOMElementPrivate>(IDOMElementPrivate * * pp=0x0012ebec) Line 124 + 0xe bytes C++ > DumpRenderTree_debug.exe!dumpFramesAsText(IWebFrame * frame=0x05277bd0) Line 340 + 0x17 bytes C++ DumpRenderTree_debug.exe!dumpFramesAsText(IWebFrame * frame=0x02146680) Line 358 + 0x18 bytes C++ DumpRenderTree_debug.exe!dump() Line 562 + 0x10 bytes C++ DumpRenderTree_debug.exe!FrameLoadDelegate::locationChangeDone(IWebError * __formal=0x00000000, IWebFrame * frame=0x02146680) Line 225 C++ DumpRenderTree_debug.exe!FrameLoadDelegate::didFinishLoadForFrame(IWebView * webView=0x02126990, IWebFrame * frame=0x02146680) Line 236 C++ WebKit_debug.dll!WebFrameLoaderClient::dispatchDidFinishLoad() Line 289 + 0x26 bytes C++ WebKit_debug.dll!WebCore::FrameLoader::checkLoadCompleteForThisFrame() Line 3185 + 0x18 bytes C++ WebKit_debug.dll!WebCore::FrameLoader::recursiveCheckLoadComplete() Line 3291 C++ WebKit_debug.dll!WebCore::FrameLoader::checkLoadComplete() Line 3302 C++ WebKit_debug.dll!WebCore::FrameLoader::finishedLoading() Line 2981 C++ WebKit_debug.dll!WebCore::MainResourceLoader::didFinishLoading() Line 334 C++ WebKit_debug.dll!WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle * __formal=0x04fd6d20) Line 398 + 0xf bytes C++ WebKit_debug.dll!WebCore::didFinishLoading(_CFURLConnection * conn=0x0511ad00, const void * clientInfo=0x04fd6d20) Line 119 + 0x1e bytes C++ ...CFNetwork frames elided... user32.dll!_InternalCallWinProc@20() + 0x28 bytes user32.dll!_UserCallWinProcCheckWow@32() + 0xb7 bytes user32.dll!_DispatchMessageWorker@8() + 0xdc bytes user32.dll!_DispatchMessageW@4() + 0xf bytes DumpRenderTree_debug.exe!runTest(const char * pathOrURL=0x0012f6e8) Line 751 + 0xc bytes C++ DumpRenderTree_debug.exe!main(int argc=2, char * * argv=0x01bf1208) Line 1088 + 0xc bytes C++ DumpRenderTree_debug.exe!__tmainCRTStartup() Line 597 + 0x19 bytes C DumpRenderTree_debug.exe!mainCRTStartup() Line 414 C kernel32.dll!_BaseProcessStart@4() + 0x23 bytes 96182 1 aroben 2008-10-22 09:06:16 -0700 <rdar://problem/6310684> 105930 2 26764 adele 2009-01-15 11:32:08 -0800 Created attachment 26764 patch I'm having some trouble running all the layout tests right now (unrelated to this patch), but in the meantime, I wanted to post this fix. I verified it does fix the crash. 105931 3 26764 darin 2009-01-15 11:34:15 -0800 Comment on attachment 26764 patch r=me 105936 4 adele 2009-01-15 11:54:55 -0800 Committed revision 39940. 26764 2009-01-15 11:32:08 -0800 2009-01-15 11:34:15 -0800 patch test.txt text/plain 5481 adele SW5kZXg6IHdpbi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gd2luL0NoYW5nZUxvZwkocmV2aXNp b24gMzk5MzMpCisrKyB3aW4vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjYg QEAKKzIwMDktMDEtMTUgIEFkZWxlIFBldGVyc29uICA8YWRlbGVAYXBwbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgRml4IGZv ciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3OTkKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzYzMTA2ODQ+IENyYXNoIGluIGR1bXBGcmFtZXNBc1RleHQoKSB3aGVu IHJ1bm5pbmcgaHR0cC90ZXN0cy9zZWN1cml0eS9jcm9zcy1vcmlnaW4teHNsLUJMT0NLRUQuaHRt bAorICAgICAgICAKKyAgICAgICAgUmV0dXJuIFNfT0sgb3IgRV9GQUlMIGJhc2VkIG9uIHRoZSBy ZXN1bHQgZnJvbSBDcmVhdGVJbnN0YW5jZS4KKyAgICAgICAgVGhpcyB3YXMgY2F1c2luZyBEdW1w UmVuZGVyVHJlZSB0byBub3QgcmVhbGl6ZSBpdCBoYWQganVzdCBnb3R0ZW4gYSBudWxsIGRvY3Vt ZW50RWxlbWVudC4KKyAgICAgICAgCisgICAgICAgICogRE9NQ29yZUNsYXNzZXMuY3BwOiBNYWRl IGFsbCBmdW5jdGlvbnMgdGhhdCByZXR1cm4gdGhlIHJlc3VsdCBvZiBDcmVhdGVJbnN0YW5jZSBj b25zaXN0ZW50LgorICAgICAgICAoRE9NTm9kZTo6cGFyZW50Tm9kZSk6CisgICAgICAgIChET01O b2RlOjpvd25lckRvY3VtZW50KToKKyAgICAgICAgKERPTU5vZGVMaXN0OjppdGVtKToKKyAgICAg ICAgKERPTURvY3VtZW50Ojpkb2N1bWVudEVsZW1lbnQpOgorICAgICAgICAoRE9NRG9jdW1lbnQ6 OmNyZWF0ZUVsZW1lbnQpOgorICAgICAgICAoRE9NRG9jdW1lbnQ6OmdldEVsZW1lbnRzQnlUYWdO YW1lKToKKyAgICAgICAgKERPTURvY3VtZW50OjpnZXRFbGVtZW50c0J5VGFnTmFtZU5TKToKKyAg ICAgICAgKERPTURvY3VtZW50OjpnZXRFbGVtZW50QnlJZCk6CisgICAgICAgIChET01Eb2N1bWVu dDo6Z2V0Q29tcHV0ZWRTdHlsZSk6CisgICAgICAgIChET01Eb2N1bWVudDo6Y3JlYXRlRXZlbnQp OgorICAgICAgICAoRE9NRWxlbWVudDo6c3R5bGUpOgorCiAyMDA5LTAxLTE0ICBBZGVsZSBQZXRl cnNvbiAgPGFkZWxlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxl ci4KSW5kZXg6IHdpbi9ET01Db3JlQ2xhc3Nlcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gd2luL0RPTUNv cmVDbGFzc2VzLmNwcAkocmV2aXNpb24gMzk5MDMpCisrKyB3aW4vRE9NQ29yZUNsYXNzZXMuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAw NiwgMjAwNyBBcHBsZSBJbmMuICBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChD KSAyMDA2LCAyMDA3LCAyMDA5IEFwcGxlIEluYy4gIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgog ICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0 aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhh dCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTEyOSw3ICsxMjksNyBAQCBIUkVTVUxUIFNU RE1FVEhPRENBTExUWVBFIERPTU5vZGU6OnBhcmVuCiAgICAgaWYgKCFtX25vZGUgfHwgIW1fbm9k ZS0+cGFyZW50Tm9kZSgpKQogICAgICAgICByZXR1cm4gRV9GQUlMOwogICAgICpyZXN1bHQgPSBE T01Ob2RlOjpjcmVhdGVJbnN0YW5jZShtX25vZGUtPnBhcmVudE5vZGUoKSk7Ci0gICAgcmV0dXJu IFNfT0s7CisgICAgcmV0dXJuICpyZXN1bHQgPyBTX09LIDogRV9GQUlMOwogfQogCiBIUkVTVUxU IFNURE1FVEhPRENBTExUWVBFIERPTU5vZGU6OmNoaWxkTm9kZXMoIApAQCAtMTgzLDcgKzE4Myw3 IEBAIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgRE9NTm9kZTo6b3duZXIKICAgICBpZiAoIW1f bm9kZSkKICAgICAgICAgcmV0dXJuIEVfRkFJTDsKICAgICAqcmVzdWx0ID0gRE9NRG9jdW1lbnQ6 OmNyZWF0ZUluc3RhbmNlKG1fbm9kZS0+b3duZXJEb2N1bWVudCgpKTsKLSAgICByZXR1cm4gU19P SzsKKyAgICByZXR1cm4gKnJlc3VsdCA/IFNfT0sgOiBFX0ZBSUw7CiB9CiAKIEhSRVNVTFQgU1RE TUVUSE9EQ0FMTFRZUEUgRE9NTm9kZTo6aW5zZXJ0QmVmb3JlKCAKQEAgLTQ2NSw5ICs0NjUsNyBA QCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIERPTU5vZGVMaXN0OjppCiAgICAgICAgIHJldHVy biBFX0ZBSUw7CiAKICAgICAqcmVzdWx0ID0gRE9NTm9kZTo6Y3JlYXRlSW5zdGFuY2UoaXRlbU5v ZGUpOwotICAgIGlmICghKCpyZXN1bHQpKQotICAgICAgICByZXR1cm4gRV9GQUlMOwotICAgIHJl dHVybiBTX09LOworICAgIHJldHVybiAqcmVzdWx0ID8gU19PSyA6IEVfRkFJTDsKIH0KIAogSFJF U1VMVCBTVERNRVRIT0RDQUxMVFlQRSBET01Ob2RlTGlzdDo6bGVuZ3RoKCAKQEAgLTU0OCw3ICs1 NDYsNyBAQCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIERPTURvY3VtZW50OjpkCiAgICAgLyog W3JldHZhbF1bb3V0XSAqLyBJRE9NRWxlbWVudCoqIHJlc3VsdCkKIHsKICAgICAqcmVzdWx0ID0g RE9NRWxlbWVudDo6Y3JlYXRlSW5zdGFuY2UobV9kb2N1bWVudC0+ZG9jdW1lbnRFbGVtZW50KCkp OwotICAgIHJldHVybiBTX09LOworICAgIHJldHVybiAqcmVzdWx0ID8gU19PSyA6IEVfRkFJTDsK IH0KIAogSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBET01Eb2N1bWVudDo6Y3JlYXRlRWxlbWVu dCggCkBAIC01NjEsOSArNTU5LDcgQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBET01Eb2N1 bWVudDo6YwogICAgIFN0cmluZyB0YWdOYW1lU3RyaW5nKHRhZ05hbWUpOwogICAgIEV4Y2VwdGlv bkNvZGUgZWM7CiAgICAgKnJlc3VsdCA9IERPTUVsZW1lbnQ6OmNyZWF0ZUluc3RhbmNlKG1fZG9j dW1lbnQtPmNyZWF0ZUVsZW1lbnQodGFnTmFtZVN0cmluZywgZWMpLmdldCgpKTsKLSAgICBpZiAo ISgqcmVzdWx0KSkKLSAgICAgICAgcmV0dXJuIEVfRkFJTDsKLSAgICByZXR1cm4gU19PSzsgICAg CisgICAgcmV0dXJuICpyZXN1bHQgPyBTX09LIDogRV9GQUlMOwogfQogCiBIUkVTVUxUIFNURE1F VEhPRENBTExUWVBFIERPTURvY3VtZW50OjpjcmVhdGVEb2N1bWVudEZyYWdtZW50KCAKQEAgLTYz MSw5ICs2MjcsNyBAQCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIERPTURvY3VtZW50OjpnCiAK ICAgICBTdHJpbmcgdGFnTmFtZVN0cmluZyh0YWdOYW1lKTsKICAgICAqcmVzdWx0ID0gRE9NTm9k ZUxpc3Q6OmNyZWF0ZUluc3RhbmNlKG1fZG9jdW1lbnQtPmdldEVsZW1lbnRzQnlUYWdOYW1lKHRh Z05hbWVTdHJpbmcpLmdldCgpKTsKLSAgICBpZiAoISgqcmVzdWx0KSkKLSAgICAgICAgcmV0dXJu IEVfRkFJTDsKLSAgICByZXR1cm4gU19PSzsKKyAgICByZXR1cm4gKnJlc3VsdCA/IFNfT0sgOiBF X0ZBSUw7CiB9CiAKIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgRE9NRG9jdW1lbnQ6OmltcG9y dE5vZGUoIApAQCAtNjc0LDkgKzY2OCw3IEBAIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgRE9N RG9jdW1lbnQ6OmcKICAgICBTdHJpbmcgbmFtZXNwYWNlVVJJU3RyaW5nKG5hbWVzcGFjZVVSSSk7 CiAgICAgU3RyaW5nIGxvY2FsTmFtZVN0cmluZyhsb2NhbE5hbWUpOwogICAgICpyZXN1bHQgPSBE T01Ob2RlTGlzdDo6Y3JlYXRlSW5zdGFuY2UobV9kb2N1bWVudC0+Z2V0RWxlbWVudHNCeVRhZ05h bWVOUyhuYW1lc3BhY2VVUklTdHJpbmcsIGxvY2FsTmFtZVN0cmluZykuZ2V0KCkpOwotICAgIGlm ICghKCpyZXN1bHQpKQotICAgICAgICByZXR1cm4gRV9GQUlMOwotICAgIHJldHVybiBTX09LOwor ICAgIHJldHVybiAqcmVzdWx0ID8gU19PSyA6IEVfRkFJTDsKIH0KIAogSFJFU1VMVCBTVERNRVRI T0RDQUxMVFlQRSBET01Eb2N1bWVudDo6Z2V0RWxlbWVudEJ5SWQoIApAQCAtNjg4LDkgKzY4MCw3 IEBAIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgRE9NRG9jdW1lbnQ6OmcKIAogICAgIFN0cmlu ZyBpZFN0cmluZyhlbGVtZW50SWQpOwogICAgICpyZXN1bHQgPSBET01FbGVtZW50OjpjcmVhdGVJ bnN0YW5jZShtX2RvY3VtZW50LT5nZXRFbGVtZW50QnlJZChpZFN0cmluZykpOwotICAgIGlmICgh KCpyZXN1bHQpKQotICAgICAgICByZXR1cm4gRV9GQUlMOwotICAgIHJldHVybiBTX09LOworICAg IHJldHVybiAqcmVzdWx0ID8gU19PSyA6IEVfRkFJTDsKIH0KIAogLy8gRE9NRG9jdW1lbnQgLSBJ RE9NVmlld0NTUyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQpAQCAtNzE2LDcgKzcwNiw3IEBAIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgRE9NRG9j dW1lbnQ6OmcKICAgICAgICAgcmV0dXJuIEVfRkFJTDsKICAgICAKICAgICAqcmVzdWx0ID0gRE9N Q1NTU3R5bGVEZWNsYXJhdGlvbjo6Y3JlYXRlSW5zdGFuY2UoZHYtPmdldENvbXB1dGVkU3R5bGUo ZWxlbWVudCwgcHNldWRvRWx0U3RyaW5nLmltcGwoKSkuZ2V0KCkpOwotICAgIHJldHVybiBTX09L OworICAgIHJldHVybiAqcmVzdWx0ID8gU19PSyA6IEVfRkFJTDsKIH0KIAogLy8gRE9NRG9jdW1l bnQgLSBJRE9NRG9jdW1lbnRFdmVudCAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLQpAQCAtNzI4LDcgKzcxOCw3IEBAIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUg RE9NRG9jdW1lbnQ6OmMKICAgICBTdHJpbmcgZXZlbnRUeXBlU3RyaW5nKGV2ZW50VHlwZSwgU3lz U3RyaW5nTGVuKGV2ZW50VHlwZSkpOwogICAgIFdlYkNvcmU6OkV4Y2VwdGlvbkNvZGUgZWMgPSAw OwogICAgICpyZXN1bHQgPSBET01FdmVudDo6Y3JlYXRlSW5zdGFuY2UobV9kb2N1bWVudC0+Y3Jl YXRlRXZlbnQoZXZlbnRUeXBlU3RyaW5nLCBlYykpOwotICAgIHJldHVybiBTX09LOworICAgIHJl dHVybiAqcmVzdWx0ID8gU19PSyA6IEVfRkFJTDsKIH0KIAogLy8gRE9NRG9jdW1lbnQgLSBET01E b2N1bWVudCAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQpAQCAtMTEwNCw3ICsxMDk0LDcgQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBET01FbGVt ZW50OjpzdAogICAgICAgICByZXR1cm4gRV9GQUlMOwogCiAgICAgKnJlc3VsdCA9IERPTUNTU1N0 eWxlRGVjbGFyYXRpb246OmNyZWF0ZUluc3RhbmNlKHN0eWxlKTsKLSAgICByZXR1cm4gU19PSzsK KyAgICByZXR1cm4gKnJlc3VsdCA/IFNfT0sgOiBFX0ZBSUw7CiB9CiAKIC8vIElET01FbGVtZW50 RXh0ZW5zaW9ucyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0K