217985 2020-10-20 13:34:38 -0700 [webkitpy] Use allowlist and blocklist 2020-10-30 13:32:14 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ews-watchlist glenn tsavell webkit-bug-importer oldest_to_newest 1699904 0 jbedard 2020-10-20 13:34:38 -0700 We should replace blacklist with blocklist and whitelist with allowlist in webkitpy. 1699905 1 webkit-bug-importer 2020-10-20 13:34:58 -0700 <rdar://problem/70499499> 1699909 2 411912 jbedard 2020-10-20 13:44:43 -0700 Created attachment 411912 Patch 1699929 3 ews-feeder 2020-10-20 14:40:45 -0700 Committed r268761: <https://trac.webkit.org/changeset/268761> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411912. 1701125 4 tsavell 2020-10-23 13:13:43 -0700 Reverted r268761 for reason: May have casued webrtc crashes on Catalina Debug. Committed r268938: <https://trac.webkit.org/changeset/268938> 1701128 5 jbedard 2020-10-23 13:20:05 -0700 (In reply to Truitt Savell from comment #4) > Reverted r268761 for reason: > > May have casued webrtc crashes on Catalina Debug. > > Committed r268938: <https://trac.webkit.org/changeset/268938> Seems super unlikely this is the culprit, but it's also not particularly harmful to revert. 1703170 6 412789 jbedard 2020-10-30 13:03:58 -0700 Created attachment 412789 Patch 1703186 7 ews-feeder 2020-10-30 13:32:13 -0700 Committed r269205: <https://trac.webkit.org/changeset/269205> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412789. 411912 2020-10-20 13:44:43 -0700 2020-10-30 13:03:56 -0700 Patch bug-217985-20201020134442.patch text/plain 3729 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2ODc1NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDIwLTEwLTIwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0cHldIFVzZSBhbGxvd2xpc3QgYW5kIGJsb2NrbGlzdAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3OTg1CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS83MDQ5OTQ5OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcHlsaW50cmM6CisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChj aGVja19uYW1lc3BhY2VfaW5kZW50YXRpb24pOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv dzNjL2NvbW1vbi5weToKKyAgICAgICAgKGlzX2Jhc2VuYW1lX3NraXBwZWQpOgorICAgICAgICAq IGZsYXRwYWsvZmxhdHBha3V0aWxzLnB5OgorICAgICAgICAoV2Via2l0RmxhdHBhay5zZXR1cF9n c3RidWlsZCk6CisKIDIwMjAtMTAtMjAgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUu Y29tPgogCiAgICAgICAgIE1ha2UgcmVwb3J0LW5vbi1pbmNsdXNpdmUtbGFuZ3VhZ2UgaWdub3Jl IGF1dG9pbnN0YWxsZWQgZGlyZWN0b3JpZXMgYW5kIGNlcnRhaW4gZmlsZSB0eXBlcwpJbmRleDog VG9vbHMvU2NyaXB0cy93ZWJraXRweS9weWxpbnRyYwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3B5bGludHJjCShyZXZpc2lvbiAyNjg3NTcpCisrKyBUb29scy9TY3JpcHRz L3dlYmtpdHB5L3B5bGludHJjCSh3b3JraW5nIGNvcHkpCkBAIC0zOCw3ICszOCw3IEBACiAjIFBy b2ZpbGVkIGV4ZWN1dGlvbi4KIHByb2ZpbGU9bm8KIAotIyBBZGQgZmlsZXMgb3IgZGlyZWN0b3Jp ZXMgdG8gdGhlIGJsYWNrbGlzdC4gVGhleSBzaG91bGQgYmUgYmFzZSBuYW1lcywgbm90CisjIEFk ZCBmaWxlcyBvciBkaXJlY3RvcmllcyB0byB0aGUgYmxvY2tsaXN0LiBUaGV5IHNob3VsZCBiZSBi YXNlIG5hbWVzLCBub3QKICMgcGF0aHMuCiBpZ25vcmU9Q1ZTCiAKSW5kZXg6IFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CShyZXZpc2lvbiAyNjg3NTcpCisr KyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQkod29ya2luZyBj b3B5KQpAQCAtMjQ4NCw3ICsyNDg0LDcgQEAgZGVmIGNoZWNrX25hbWVzcGFjZV9pbmRlbnRhdGlv bihjbGVhbl9saQogICAgICAgICAgICAgYnJlYWsKIAogCi0jIEVudW0gZGVjbGFyYXRpb24gd2hp dGVsaXN0CisjIEVudW0gZGVjbGFyYXRpb24gYWxsb3dsaXN0CiBfQUxMT1dfQUxMX1VQUEVSQ0FT RV9FTlVNID0gWydKU1Rva2VuVHlwZSddCiAKIApJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRw eS93M2MvY29tbW9uLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNj L2NvbW1vbi5weQkocmV2aXNpb24gMjY4NzU3KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS93 M2MvY29tbW9uLnB5CSh3b3JraW5nIGNvcHkpCkBAIC03OSwxMiArNzksMTIgQEAgZGVmIGlzX2Jh c2VuYW1lX3NraXBwZWQoYmFzZW5hbWUpOgogICAgIHNraXBwZWQgYmFzZW5hbWVzIGFyZSBuZXZl ciBpbXBvcnRlZCBvciBleHBvcnRlZC4KICAgICAiIiIKICAgICBhc3NlcnQgJy8nIG5vdCBpbiBi YXNlbmFtZQotICAgIGJsYWNrbGlzdCA9IFsKKyAgICBibG9ja2xpc3QgPSBbCiAgICAgICAgICdN QU5JRkVTVC5qc29uJywgICAgIyBNQU5JRkVTVC5qc29uIGlzIGF1dG9tYXRpY2FsbHkgcmVnZW5l cmF0ZWQuCiAgICAgICAgICdPV05FUlMnLCAgICAgICAgICAgIyBodHRwczovL2NyYnVnLmNvbS81 ODQ2NjAgaHR0cHM6Ly9jcmJ1Zy5jb20vNzAyMjgzCiAgICAgICAgICdyZWZ0ZXN0Lmxpc3QnLCAg ICAgIyBodHRwczovL2NyYnVnLmNvbS81ODI4MzgKICAgICBdCi0gICAgcmV0dXJuIChiYXNlbmFt ZSBpbiBibGFja2xpc3QKKyAgICByZXR1cm4gKGJhc2VuYW1lIGluIGJsb2NrbGlzdAogICAgICAg ICAgICAgb3IgaXNfdGVzdGhhcm5lc3NfYmFzZWxpbmUoYmFzZW5hbWUpCiAgICAgICAgICAgICBv ciBiYXNlbmFtZS5zdGFydHN3aXRoKCcuJykpCiAKSW5kZXg6IFRvb2xzL2ZsYXRwYWsvZmxhdHBh a3V0aWxzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5CShy ZXZpc2lvbiAyNjg3NTcpCisrKyBUb29scy9mbGF0cGFrL2ZsYXRwYWt1dGlscy5weQkod29ya2lu ZyBjb3B5KQpAQCAtNjE1LDEzICs2MTUsMTMgQEAgY2xhc3MgV2Via2l0RmxhdHBhazoKIAogICAg ICAgICBjb21tYW5kID0gW29zLnBhdGguam9pbihnc3RfZGlyLCAnZ3N0LWVudi5weScpLCAnLS1i dWlsZGRpcicsIGdzdF9idWlsZGRpciwgJy0tc3JjZGlyJywgZ3N0X2RpciwgIi0tb25seS1lbnZp cm9ubWVudCJdCiAgICAgICAgIGdzdF9lbnYgPSBydW5fc2FuaXRpemVkKGNvbW1hbmQsIGdhdGhl cl9vdXRwdXQ9VHJ1ZSkKLSAgICAgICAgd2hpdGVsaXN0ID0gKCJMRF9MSUJSQVJZX1BBVEgiLCAi UEFUSCIsICJQS0dfQ09ORklHX1BBVEgiKQorICAgICAgICBhbGxvd2xpc3QgPSAoIkxEX0xJQlJB UllfUEFUSCIsICJQQVRIIiwgIlBLR19DT05GSUdfUEFUSCIpCiAgICAgICAgIG5vcGF0aGxpc3Qg PSAoIkdTVF9ERUJVRyIsICJHU1RfVkVSU0lPTiIsICJHU1RfRU5WIikKICAgICAgICAgZW52ID0g W10KICAgICAgICAgZm9yIGxpbmUgaW4gW2xpbmUgZm9yIGxpbmUgaW4gZ3N0X2Vudi5zcGxpdGxp bmVzKCkgaWYgbm90IGxpbmUuc3RhcnRzd2l0aCgiZXhwb3J0IildOgogICAgICAgICAgICAgdG9r ZW5zID0gbGluZS5zcGxpdCgiPSIpCiAgICAgICAgICAgICB2YXJfbmFtZSwgY29udGVudHMgPSB0 b2tlbnNbMF0sICI9Ii5qb2luKHRva2Vuc1sxOl0pCi0gICAgICAgICAgICBpZiBub3QgdmFyX25h bWUuc3RhcnRzd2l0aCgiR1NUXyIpIGFuZCB2YXJfbmFtZSBub3QgaW4gd2hpdGVsaXN0OgorICAg ICAgICAgICAgaWYgbm90IHZhcl9uYW1lLnN0YXJ0c3dpdGgoIkdTVF8iKSBhbmQgdmFyX25hbWUg bm90IGluIGFsbG93bGlzdDoKICAgICAgICAgICAgICAgICBjb250aW51ZQogICAgICAgICAgICAg aWYgdmFyX25hbWUgbm90IGluIG5vcGF0aGxpc3Q6CiAgICAgICAgICAgICAgICAgbmV3X2NvbnRl bnRzID0gJzonLmpvaW4oW3NlbGYuaG9zdF9wYXRoX3RvX3NhbmRib3hfcGF0aChwKSBmb3IgcCBp biBjb250ZW50cy5zcGxpdCgiOiIpXSkK 412789 2020-10-30 13:03:58 -0700 2020-10-30 13:32:14 -0700 Patch bug-217985-20201030130357.patch text/plain 3678 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2OTIwMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDIwLTEwLTMwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0cHldIFVzZSBhbGxvd2xpc3QgYW5kIGJsb2NrbGlzdAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3OTg1CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS83MDQ5OTQ5OT4KKworICAgICAgICBSZXZpZXdlZCBieSBBYWth c2ggSmFpbi4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcHlsaW50cmM6CisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChjaGVj a19uYW1lc3BhY2VfaW5kZW50YXRpb24pOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdzNj L2NvbW1vbi5weToKKyAgICAgICAgKGlzX2Jhc2VuYW1lX3NraXBwZWQpOgorICAgICAgICAqIGZs YXRwYWsvZmxhdHBha3V0aWxzLnB5OgorICAgICAgICAoV2Via2l0RmxhdHBhay5zZXR1cF9nc3Ri dWlsZCk6CisKIDIwMjAtMTAtMzAgIExhdXJvIE1vdXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CiAK ICAgICAgICAgd2Via2l0cHk6IFN5bmMgcGFja2FnZSB2ZXJzaW9ucyB3aXRoIFdQVCBzdWl0ZQpJ bmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9weWxpbnRyYwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3B5bGludHJjCShyZXZpc2lvbiAyNjkyMDIpCisrKyBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3B5bGludHJjCSh3b3JraW5nIGNvcHkpCkBAIC0zOCw3ICszOCw3IEBA CiAjIFByb2ZpbGVkIGV4ZWN1dGlvbi4KIHByb2ZpbGU9bm8KIAotIyBBZGQgZmlsZXMgb3IgZGly ZWN0b3JpZXMgdG8gdGhlIGJsYWNrbGlzdC4gVGhleSBzaG91bGQgYmUgYmFzZSBuYW1lcywgbm90 CisjIEFkZCBmaWxlcyBvciBkaXJlY3RvcmllcyB0byB0aGUgYmxvY2tsaXN0LiBUaGV5IHNob3Vs ZCBiZSBiYXNlIG5hbWVzLCBub3QKICMgcGF0aHMuCiBpZ25vcmU9Q1ZTCiAKSW5kZXg6IFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CShyZXZpc2lvbiAyNjky MDIpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQkod29y a2luZyBjb3B5KQpAQCAtMjQ4NCw3ICsyNDg0LDcgQEAgZGVmIGNoZWNrX25hbWVzcGFjZV9pbmRl bnRhdGlvbihjbGVhbl9saQogICAgICAgICAgICAgYnJlYWsKIAogCi0jIEVudW0gZGVjbGFyYXRp b24gd2hpdGVsaXN0CisjIEVudW0gZGVjbGFyYXRpb24gYWxsb3dsaXN0CiBfQUxMT1dfQUxMX1VQ UEVSQ0FTRV9FTlVNID0gWydKU1Rva2VuVHlwZSddCiAKIApJbmRleDogVG9vbHMvU2NyaXB0cy93 ZWJraXRweS93M2MvY29tbW9uLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdzNjL2NvbW1vbi5weQkocmV2aXNpb24gMjY5MjAyKQorKysgVG9vbHMvU2NyaXB0cy93ZWJr aXRweS93M2MvY29tbW9uLnB5CSh3b3JraW5nIGNvcHkpCkBAIC03OSwxMiArNzksMTIgQEAgZGVm IGlzX2Jhc2VuYW1lX3NraXBwZWQoYmFzZW5hbWUpOgogICAgIHNraXBwZWQgYmFzZW5hbWVzIGFy ZSBuZXZlciBpbXBvcnRlZCBvciBleHBvcnRlZC4KICAgICAiIiIKICAgICBhc3NlcnQgJy8nIG5v dCBpbiBiYXNlbmFtZQotICAgIGJsYWNrbGlzdCA9IFsKKyAgICBibG9ja2xpc3QgPSBbCiAgICAg ICAgICdNQU5JRkVTVC5qc29uJywgICAgIyBNQU5JRkVTVC5qc29uIGlzIGF1dG9tYXRpY2FsbHkg cmVnZW5lcmF0ZWQuCiAgICAgICAgICdPV05FUlMnLCAgICAgICAgICAgIyBodHRwczovL2NyYnVn LmNvbS81ODQ2NjAgaHR0cHM6Ly9jcmJ1Zy5jb20vNzAyMjgzCiAgICAgICAgICdyZWZ0ZXN0Lmxp c3QnLCAgICAgIyBodHRwczovL2NyYnVnLmNvbS81ODI4MzgKICAgICBdCi0gICAgcmV0dXJuIChi YXNlbmFtZSBpbiBibGFja2xpc3QKKyAgICByZXR1cm4gKGJhc2VuYW1lIGluIGJsb2NrbGlzdAog ICAgICAgICAgICAgb3IgaXNfdGVzdGhhcm5lc3NfYmFzZWxpbmUoYmFzZW5hbWUpCiAgICAgICAg ICAgICBvciBiYXNlbmFtZS5zdGFydHN3aXRoKCcuJykpCiAKSW5kZXg6IFRvb2xzL2ZsYXRwYWsv ZmxhdHBha3V0aWxzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxz LnB5CShyZXZpc2lvbiAyNjkyMDIpCisrKyBUb29scy9mbGF0cGFrL2ZsYXRwYWt1dGlscy5weQko d29ya2luZyBjb3B5KQpAQCAtNjE1LDEzICs2MTUsMTMgQEAgY2xhc3MgV2Via2l0RmxhdHBhazoK IAogICAgICAgICBjb21tYW5kID0gW29zLnBhdGguam9pbihnc3RfZGlyLCAnZ3N0LWVudi5weScp LCAnLS1idWlsZGRpcicsIGdzdF9idWlsZGRpciwgJy0tc3JjZGlyJywgZ3N0X2RpciwgIi0tb25s eS1lbnZpcm9ubWVudCJdCiAgICAgICAgIGdzdF9lbnYgPSBydW5fc2FuaXRpemVkKGNvbW1hbmQs IGdhdGhlcl9vdXRwdXQ9VHJ1ZSkKLSAgICAgICAgd2hpdGVsaXN0ID0gKCJMRF9MSUJSQVJZX1BB VEgiLCAiUEFUSCIsICJQS0dfQ09ORklHX1BBVEgiKQorICAgICAgICBhbGxvd2xpc3QgPSAoIkxE X0xJQlJBUllfUEFUSCIsICJQQVRIIiwgIlBLR19DT05GSUdfUEFUSCIpCiAgICAgICAgIG5vcGF0 aGxpc3QgPSAoIkdTVF9ERUJVRyIsICJHU1RfVkVSU0lPTiIsICJHU1RfRU5WIikKICAgICAgICAg ZW52ID0gW10KICAgICAgICAgZm9yIGxpbmUgaW4gW2xpbmUgZm9yIGxpbmUgaW4gZ3N0X2Vudi5z cGxpdGxpbmVzKCkgaWYgbm90IGxpbmUuc3RhcnRzd2l0aCgiZXhwb3J0IildOgogICAgICAgICAg ICAgdG9rZW5zID0gbGluZS5zcGxpdCgiPSIpCiAgICAgICAgICAgICB2YXJfbmFtZSwgY29udGVu dHMgPSB0b2tlbnNbMF0sICI9Ii5qb2luKHRva2Vuc1sxOl0pCi0gICAgICAgICAgICBpZiBub3Qg dmFyX25hbWUuc3RhcnRzd2l0aCgiR1NUXyIpIGFuZCB2YXJfbmFtZSBub3QgaW4gd2hpdGVsaXN0 OgorICAgICAgICAgICAgaWYgbm90IHZhcl9uYW1lLnN0YXJ0c3dpdGgoIkdTVF8iKSBhbmQgdmFy X25hbWUgbm90IGluIGFsbG93bGlzdDoKICAgICAgICAgICAgICAgICBjb250aW51ZQogICAgICAg ICAgICAgaWYgdmFyX25hbWUgbm90IGluIG5vcGF0aGxpc3Q6CiAgICAgICAgICAgICAgICAgbmV3 X2NvbnRlbnRzID0gJzonLmpvaW4oW3NlbGYuaG9zdF9wYXRoX3RvX3NhbmRib3hfcGF0aChwKSBm b3IgcCBpbiBjb250ZW50cy5zcGxpdCgiOiIpXSkK