<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>217979</bug_id>
          
          <creation_ts>2020-10-20 12:01:49 -0700</creation_ts>
          <short_desc>Fix non-c-typedef-for-linkage warning in SocketStreamHandle</short_desc>
          <delta_ts>2020-10-20 13:22:18 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Don Olmstead">don.olmstead</reporter>
          <assigned_to name="Don Olmstead">don.olmstead</assigned_to>
          <cc>achristensen</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>toyoshim</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>yutak</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1699868</commentid>
    <comment_count>0</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2020-10-20 12:01:49 -0700</bug_when>
    <thetext>..\..\Source\WebCore\platform\network\SocketStreamHandle.h(42,15): warning: anonymous non-C-compatible type given name for linkage purposes by typedef declaration; add a tag name here [-Wnon-c-typedef-for-linkage]
typedef struct {
              ^
               SourceApplicationAuditToken
..\..\Source\WebCore\platform\network\SocketStreamHandle.h(46,17): note: type is not C-compatible due to this default member initializer
    void *empty { nullptr };
                ^~~~~~~~~~~
..\..\Source\WebCore\platform\network\SocketStreamHandle.h(48,3): note: type is given name &apos;SourceApplicationAuditToken&apos; for linkage purposes by this typedef declaration
} SourceApplicationAuditToken;
  ^
1 warning generated.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1699877</commentid>
    <comment_count>1</comment_count>
      <attachid>411898</attachid>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2020-10-20 12:33:48 -0700</bug_when>
    <thetext>Created attachment 411898
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1699896</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-10-20 13:21:12 -0700</bug_when>
    <thetext>Committed r268757: &lt;https://trac.webkit.org/changeset/268757&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411898.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1699897</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-10-20 13:22:18 -0700</bug_when>
    <thetext>&lt;rdar://problem/70498896&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>411898</attachid>
            <date>2020-10-20 12:33:48 -0700</date>
            <delta_ts>2020-10-20 13:21:12 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-217979.diff</filename>
            <type>text/plain</type>
            <size>1601</size>
            <attacher name="Don Olmstead">don.olmstead</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBiMzM0M2JjODBjMGEuLmNkODdlMjkxNDJkNSAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt
MSwzICsxLDE3IEBACisyMDIwLTEwLTIwICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29u
eS5jb20+CisKKyAgICAgICAgRml4IG5vbi1jLXR5cGVkZWYtZm9yLWxpbmthZ2Ugd2FybmluZyBp
biBTb2NrZXRTdHJlYW1IYW5kbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTIxNzk3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIFRoZSB3YXJuaW5nIHdhcyBiZWNhdXNlIHRoZSBhbm9ueW1vdXMgdHlwZSB3
YXMgbm90IEMtY29tcGF0aWJsZSBkdWUgdG8gYSBkZWZhdWx0IG1lbWJlcgorICAgICAgICBpbml0
aWFsaXplciwgc28gcmVtb3ZlIHRoZSB0eXBlZGVmIGFuZCBuYW1lIHRoZSBzdHJ1Y3QuCisKKyAg
ICAgICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBw
bGF0Zm9ybS9uZXR3b3JrL1NvY2tldFN0cmVhbUhhbmRsZS5oOgorCiAyMDIwLTEwLTIwICBQaGls
aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVy
XSBSRUdSRVNTSU9OKHIyNjY1NTkpOiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3dl
YmF1ZGlvL3RoZS1hdWRpby1hcGkvdGhlLWRlc3RpbmF0aW9ubm9kZS1pbnRlcmZhY2UvZGVzdGlu
YXRpb24uaHRtbCBpcyBmYWlsaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9uZXR3b3JrL1NvY2tldFN0cmVhbUhhbmRsZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
bmV0d29yay9Tb2NrZXRTdHJlYW1IYW5kbGUuaAppbmRleCA2OGI1MDJhNDNiYjEuLjQxNmU1OWE5
MzRhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9Tb2NrZXRT
dHJlYW1IYW5kbGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1NvY2tl
dFN0cmVhbUhhbmRsZS5oCkBAIC0zOSwxMyArMzksMTMgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog
c3RydWN0IENvb2tpZVJlcXVlc3RIZWFkZXJGaWVsZFByb3h5OwogY2xhc3MgU29ja2V0U3RyZWFt
SGFuZGxlQ2xpZW50OwogCi10eXBlZGVmIHN0cnVjdCB7CitzdHJ1Y3QgU291cmNlQXBwbGljYXRp
b25BdWRpdFRva2VuIHsKICNpZiBQTEFURk9STShDT0NPQSkKICAgICBSZXRhaW5QdHI8Q0ZEYXRh
UmVmPiBzb3VyY2VBcHBsaWNhdGlvbkF1ZGl0RGF0YTsKICNlbHNlCiAgICAgdm9pZCAqZW1wdHkg
eyBudWxscHRyIH07CiAjZW5kaWYKLX0gU291cmNlQXBwbGljYXRpb25BdWRpdFRva2VuOworfTsK
IAogY2xhc3MgU29ja2V0U3RyZWFtSGFuZGxlIDogcHVibGljIFRocmVhZFNhZmVSZWZDb3VudGVk
PFNvY2tldFN0cmVhbUhhbmRsZSwgV1RGOjpEZXN0cnVjdGlvblRocmVhZDo6TWFpbj4gewogcHVi
bGljOgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>