217974 2020-10-20 10:53:36 -0700 [GStreamer] Create video sink only for video player 2020-10-21 03:52:21 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand calvaris cgarcia eric.carlson ews-watchlist glenn gustavo jer.noble menard philipj sergio vjaquez webkit-bug-importer oldest_to_newest 1699839 0 pnormand 2020-10-20 10:53:36 -0700 . 1699844 1 411888 pnormand 2020-10-20 10:58:07 -0700 Created attachment 411888 Patch 1700121 2 vjaquez 2020-10-21 02:36:23 -0700 unofficial lgtm :) 1700127 3 411888 calvaris 2020-10-21 02:48:06 -0700 Comment on attachment 411888 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411888&action=review > Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:320 > - gst_element_register(0, "webkitglvideosink", GST_RANK_PRIMARY, WEBKIT_TYPE_GL_VIDEO_SINK); > + gst_element_register(0, "webkitglvideosink", GST_RANK_NONE, WEBKIT_TYPE_GL_VIDEO_SINK); Why do you need this? > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2732 > + GST_INFO("Creating pipeline for %s player", m_player->isVideoPlayer() ? "video":"audio"); Nit: spaces around : 1700131 4 411888 pnormand 2020-10-21 03:11:29 -0700 Comment on attachment 411888 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411888&action=review >> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:320 >> + gst_element_register(0, "webkitglvideosink", GST_RANK_NONE, WEBKIT_TYPE_GL_VIDEO_SINK); > > Why do you need this? Because if we don't give a video-sink to playbin it will create an autovideosink, which, without this change, would create a webkitglvideosink. 1700134 5 pnormand 2020-10-21 03:51:08 -0700 Committed r268790: <https://trac.webkit.org/changeset/268790> 1700135 6 webkit-bug-importer 2020-10-21 03:52:21 -0700 <rdar://problem/70523722> 411888 2020-10-20 10:58:07 -0700 2020-10-21 02:48:06 -0700 Patch bug-217974-20201020105806.patch text/plain 3719 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4NzQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGJkYzdkMWZmODQ0NWFm OGJhYmZmOTQyOGUwM2NiYzg1ZTZlNTlkMS4uYWExMGQ2ZTQ5MzgzYWQzNGJlMzhmZGUyZGU0NjM3 ZTVlYWM0ZjUzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTEwLTIwICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBDcmVhdGUgdmlkZW8gc2luayBvbmx5IGZvciB2aWRlbyBwbGF5ZXIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzk3NAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlJ3Mgbm8gbmVlZCBmb3IgYSB2 aWRlbyBzaW5rIHdoZW4gdGhlIG1lZGlhIHBsYXllciBpcyBjcmVhdGVkIGZvciBhbiA8YXVkaW8+ IGVsZW1lbnQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVh bWVyQ29tbW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmluaXRpYWxpemVHU3RyZWFtZXJBbmRS ZWdpc3RlcldlYktpdEVsZW1lbnRzKTogRG93bnJhbmsgdGhlIEdMIHZpZGVvIHNpbmssIGFzIHdl CisgICAgICAgIGNyZWF0ZSBpdCBvbi1kZW1hbmQgYW5kIG5vdCB0aHJvdWdoIGF1dG92aWRlb3Np bmsgYW55d2F5LgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyOjpjcmVhdGVHU1RQbGF5QmluKTogQXZvaWQgY3JlYXRpbmcgdXNlbGVz cyB2aWRlbyBzaW5rLgorCiAyMDIwLTEwLTIwICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJr aXQub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjI2ODYxNSk6IHNvbWUgYWNjZWxlcmF0ZWQg dHJhbnNmb3JtIHRlc3RzIGFyZSBmYWlsaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyQ29tbW9uLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJDb21tb24uY3BwCmlu ZGV4IDdhZDFjMmJhODM2ZTBiNWVhNzNiYjExMTAxZGQ3Yzg3NmMyZWY0YjUuLmEwYzkzZDU3ZjQ1 YmM4MGY2OTI4NGNlNzE5MWZlNzRkOTZlNmM4ZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJDb21tb24uY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJDb21tb24u Y3BwCkBAIC0zMTcsNyArMzE3LDcgQEAgYm9vbCBpbml0aWFsaXplR1N0cmVhbWVyQW5kUmVnaXN0 ZXJXZWJLaXRFbGVtZW50cygpCiAjaWYgRU5BQkxFKFZJREVPKQogICAgICAgICBnc3RfZWxlbWVu dF9yZWdpc3RlcigwLCAid2Via2l0d2Vic3JjIiwgR1NUX1JBTktfUFJJTUFSWSArIDEwMCwgV0VC S0lUX1RZUEVfV0VCX1NSQyk7CiAjaWYgVVNFKEdTVFJFQU1FUl9HTCkKLSAgICAgICAgZ3N0X2Vs ZW1lbnRfcmVnaXN0ZXIoMCwgIndlYmtpdGdsdmlkZW9zaW5rIiwgR1NUX1JBTktfUFJJTUFSWSwg V0VCS0lUX1RZUEVfR0xfVklERU9fU0lOSyk7CisgICAgICAgIGdzdF9lbGVtZW50X3JlZ2lzdGVy KDAsICJ3ZWJraXRnbHZpZGVvc2luayIsIEdTVF9SQU5LX05PTkUsIFdFQktJVF9UWVBFX0dMX1ZJ REVPX1NJTkspOwogI2VuZGlmCiAjZW5kaWYKICAgICAgICAgLy8gV2UgZG9uJ3Qgd2FudCBhdXRv YXVkaW9zaW5rIHRvIGF1dG9wbHVnIG91ciBzaW5rLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQ bGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAppbmRleCBiMGViMTU1YTUyOWE5Y2MzYmQ4MWZjNGNm ZWJmNjdjM2NhNWY0NWQ2Li40NDc3ODZjN2RiNzZhYmY4NThiMGU5YTFmNmNlZDEwNDgzNDE4ZGZh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApA QCAtMjcyOSw2ICsyNzI5LDcgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OnVw ZGF0ZURvd25sb2FkQnVmZmVyaW5nRmxhZygpCiAKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyOjpjcmVhdGVHU1RQbGF5QmluKGNvbnN0IFVSTCYgdXJsLCBjb25zdCBTdHJpbmcmIHBp cGVsaW5lTmFtZSkKIHsKKyAgICBHU1RfSU5GTygiQ3JlYXRpbmcgcGlwZWxpbmUgZm9yICVzIHBs YXllciIsIG1fcGxheWVyLT5pc1ZpZGVvUGxheWVyKCkgPyAidmlkZW8iOiJhdWRpbyIpOwogICAg IGNvbnN0IGNoYXIqIHBsYXliaW5OYW1lID0gInBsYXliaW4iOwogCiAgICAgLy8gTVNFIGRvZXNu J3Qgc3VwcG9ydCBwbGF5YmluMy4gTWVkaWFzdHJlYW0gcmVxdWlyZXMgcGxheWJpbjMuIFJlZ3Vs YXIKQEAgLTI4MTMsNyArMjgxNCw5IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy OjpjcmVhdGVHU1RQbGF5QmluKGNvbnN0IFVSTCYgdXJsLCBjb25zdCBTdHJpbmcmCiAKICAgICBn X29iamVjdF9zZXQobV9waXBlbGluZS5nZXQoKSwgInRleHQtc2luayIsIG1fdGV4dEFwcFNpbmsu Z2V0KCksIG51bGxwdHIpOwogCi0gICAgZ19vYmplY3Rfc2V0KG1fcGlwZWxpbmUuZ2V0KCksICJ2 aWRlby1zaW5rIiwgY3JlYXRlVmlkZW9TaW5rKCksICJhdWRpby1zaW5rIiwgY3JlYXRlQXVkaW9T aW5rKCksIG51bGxwdHIpOworICAgIGdfb2JqZWN0X3NldChtX3BpcGVsaW5lLmdldCgpLCAiYXVk aW8tc2luayIsIGNyZWF0ZUF1ZGlvU2luaygpLCBudWxscHRyKTsKKyAgICBpZiAobV9wbGF5ZXIt PmlzVmlkZW9QbGF5ZXIoKSkKKyAgICAgICAgZ19vYmplY3Rfc2V0KG1fcGlwZWxpbmUuZ2V0KCks ICJ2aWRlby1zaW5rIiwgY3JlYXRlVmlkZW9TaW5rKCksIG51bGxwdHIpOwogCiAgICAgY29uZmln dXJlUGxheVNpbmsoKTsKIApAQCAtMjgyNiw2ICsyODI5LDkgQEAgdm9pZCBNZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXI6OmNyZWF0ZUdTVFBsYXlCaW4oY29uc3QgVVJMJiB1cmwsIGNvbnN0IFN0 cmluZyYKICAgICAgICAgICAgIGdfb2JqZWN0X3NldChtX3BpcGVsaW5lLmdldCgpLCAiYXVkaW8t ZmlsdGVyIiwgc2NhbGUsIG51bGxwdHIpOwogICAgIH0KIAorICAgIGlmICghbV9wbGF5ZXItPmlz VmlkZW9QbGF5ZXIoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgaWYgKCFtX2NhblJlbmRlcmlu Z0JlQWNjZWxlcmF0ZWQpIHsKICAgICAgICAgLy8gSWYgbm90IHVzaW5nIGFjY2VsZXJhdGVkIGNv bXBvc2l0aW5nLCBsZXQgR1N0cmVhbWVyIGhhbmRsZQogICAgICAgICAvLyB0aGUgaW1hZ2Utb3Jp ZW50YXRpb24gdGFnLgo=