217927 2020-10-19 16:00:23 -0700 Remove iOS-only NSUserDefaults-backed UA override 2023-06-09 14:05:17 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton webkit-unassigned ahmad.saleem792 a_protyasha ap bfulgham webkit-bug-importer wenson_hsieh oldest_to_newest 1699498 0 thorton 2020-10-19 16:00:23 -0700 We should remove the code in UserAgentIOS.mm that reads an override UA from the NSUserDefault [com.apple.WebFoundation UserAgent]. It is incompatible with the modern need to compose the UA from various bits of information these days (e.g. desktop vs. mobile). Clients should use the API to set the application name or UA instead. I have stumbled upon one client (com.fark.hey), and there are likely others, so it should be a linked-on-or-after change. 1699501 1 thorton 2020-10-19 16:04:40 -0700 I left a reference here next to the code in https://trac.webkit.org/changeset/268697/webkit 1701663 2 webkit-bug-importer 2020-10-26 16:01:21 -0700 <rdar://problem/70699433> 1898009 3 ahmad.saleem792 2022-09-12 14:37:01 -0700 Just to update that this FIXME is still present: https://github.com/WebKit/WebKit/blob/6ead5274db5f92656360fa1fbae3e0091481fc4f/Source/WebCore/platform/ios/UserAgentIOS.mm#L90 1960712 4 a_protyasha 2023-06-09 00:24:06 -0700 Pull request: https://github.com/WebKit/WebKit/pull/14805 1960832 5 ews-feeder 2023-06-09 14:05:15 -0700 Committed 265034@main (6a68b0c65d6c): <https://commits.webkit.org/265034@main> Reviewed commits have been landed. Closing PR #14805 and removing active labels.