217914 2020-10-19 11:26:03 -0700 [ews] use -o while unzipping layout-test-results.zip 2021-02-08 07:37:49 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 175056 1 aakash_jain aakash_jain jbedard lingcherd_ho lingho ryanhaddad webkit-bug-importer oldest_to_newest 1699334 0 aakash_jain 2020-10-19 11:26:03 -0700 We should use -o flag while unzipping layout-test-results.zip in EWS to improve unzip performance. 1699340 1 411767 aakash_jain 2020-10-19 11:41:51 -0700 Created attachment 411767 Patch 1699343 2 411767 jbedard 2020-10-19 11:52:33 -0700 Comment on attachment 411767 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411767&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:2740 > unzip says that -o overwrites files without prompting....how did we get away with this in the first place? 1699349 3 aakash_jain 2020-10-19 11:58:07 -0700 In case of EWS, the file shouldn't exist previously. The uploaded file name is unique for each build. 1699401 4 lingcherd_ho 2020-10-19 13:27:25 -0700 This is to eliminate the unecessary four lstat and stat calls everytime a file is getting extracted. But I haven't verified if -o indeed does that. Aakash have you? 1699442 5 ews-feeder 2020-10-19 14:35:47 -0700 Committed r268689: <https://trac.webkit.org/changeset/268689> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411767. 1699443 6 webkit-bug-importer 2020-10-19 14:36:19 -0700 <rdar://problem/70456769> 1699445 7 lingcherd_ho 2020-10-19 14:38:43 -0700 Looks like adding -o won't help. Unzip is still calling lstat and stat (twice each) before creating a file. So don't expect any performance improvement. 1701516 8 aakash_jain 2020-10-26 10:27:05 -0700 Discussed with Ling offline. As per him: I guess there is no harm leaving -o there. Might be the right thing to do because if for whatever reason the files were there before, we should overwrite. 411767 2020-10-19 11:41:51 -0700 2020-10-19 14:35:48 -0700 Patch bug-217914-20201019144150.patch text/plain 3444 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2ODY3NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTEwLTE5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSB1c2UgLW8gd2hpbGUgdW56aXBwaW5nIGxheW91dC10ZXN0LXJl c3VsdHMuemlwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTc5MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAgKEV4dHJh Y3RUZXN0UmVzdWx0cy5fX2luaXRfXyk6CisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdz LWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5OgorCiAyMDIwLTEwLTE5ICBBYWthc2ggSmFpbiAgPGFh a2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbYnVpbGQud2Via2l0Lm9yZ10gVXNlIGZl YXR1cmUgZmxhZyB0byBzdXBwb3J0IEJ1aWxkYm90IDIgY29kZQpJbmRleDogVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjY4Njc0KQorKysgVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBA IC0yNzM2LDcgKzI3MzYsNyBAQCBjbGFzcyBFeHRyYWN0VGVzdFJlc3VsdHMobWFzdGVyLk1hc3Rl clNoCiAKICAgICAgICAgc2VsZi56aXBGaWxlID0gSW50ZXJwb2xhdGUoJ3B1YmxpY19odG1sL3Jl c3VsdHMvJShwcm9wOmJ1aWxkZXJuYW1lKXMvciUocHJvcDpwYXRjaF9pZClzLSUocHJvcDpidWls ZG51bWJlcilze30uemlwJy5mb3JtYXQoaWRlbnRpZmllcikpCiAgICAgICAgIHNlbGYucmVzdWx0 RGlyZWN0b3J5ID0gSW50ZXJwb2xhdGUoJ3B1YmxpY19odG1sL3Jlc3VsdHMvJShwcm9wOmJ1aWxk ZXJuYW1lKXMvciUocHJvcDpwYXRjaF9pZClzLSUocHJvcDpidWlsZG51bWJlcilze30nLmZvcm1h dChpZGVudGlmaWVyKSkKLSAgICAgICAgc2VsZi5jb21tYW5kID0gWyd1bnppcCcsICctcScsIHNl bGYuemlwRmlsZSwgJy1kJywgc2VsZi5yZXN1bHREaXJlY3RvcnldCisgICAgICAgIHNlbGYuY29t bWFuZCA9IFsndW56aXAnLCAnLXEnLCAnLW8nLCBzZWxmLnppcEZpbGUsICctZCcsIHNlbGYucmVz dWx0RGlyZWN0b3J5XQogCiAgICAgICAgIG1hc3Rlci5NYXN0ZXJTaGVsbENvbW1hbmQuX19pbml0 X18oc2VsZiwgY29tbWFuZD1zZWxmLmNvbW1hbmQsIGxvZ0Vudmlyb249RmFsc2UpCiAKSW5kZXg6 IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRl c3QucHkJKHJldmlzaW9uIDI2ODY3NCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1i dWlsZC9zdGVwc191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMzE5OCw2ICszMTk4LDcg QEAgY2xhc3MgVGVzdEV4dHJhY3RUZXN0UmVzdWx0cyhCdWlsZFN0ZXBNaQogICAgICAgICBzZWxm LmV4cGVjdExvY2FsQ29tbWFuZHMoCiAgICAgICAgICAgICBFeHBlY3RNYXN0ZXJTaGVsbENvbW1h bmQoY29tbWFuZD1bJ3VuemlwJywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAnLXEnLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICctbycsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgJ3B1YmxpY19odG1sL3Jlc3VsdHMvbWFjT1MtU2llcnJhLVJlbGVhc2UtV0syLVRlc3RzLUVX Uy9yMTIzNC0xMi56aXAnLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICctZCcsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgJ3B1YmxpY19odG1sL3Jlc3VsdHMvbWFjT1MtU2llcnJhLVJlbGVhc2UtV0syLVRlc3RzLUVX Uy9yMTIzNC0xMicsCkBAIC0zMjE3LDYgKzMyMTgsNyBAQCBjbGFzcyBUZXN0RXh0cmFjdFRlc3RS ZXN1bHRzKEJ1aWxkU3RlcE1pCiAgICAgICAgIHNlbGYuZXhwZWN0TG9jYWxDb21tYW5kcygKICAg ICAgICAgICAgIEV4cGVjdE1hc3RlclNoZWxsQ29tbWFuZChjb21tYW5kPVsndW56aXAnLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICctcScsCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJy1vJywKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAncHVibGljX2h0bWwvcmVzdWx0cy9p T1MtMTItU2ltdWxhdG9yLVdLMi1UZXN0cy1FV1MvcjEyMzQtMTItcmVydW4uemlwJywKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnLWQnLAogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdwdWJsaWNfaHRtbC9yZXN1bHRz L2lPUy0xMi1TaW11bGF0b3ItV0syLVRlc3RzLUVXUy9yMTIzNC0xMi1yZXJ1bicsCkBAIC0zMjM2 LDYgKzMyMzgsNyBAQCBjbGFzcyBUZXN0RXh0cmFjdFRlc3RSZXN1bHRzKEJ1aWxkU3RlcE1pCiAg ICAgICAgIHNlbGYuZXhwZWN0TG9jYWxDb21tYW5kcygKICAgICAgICAgICAgIEV4cGVjdE1hc3Rl clNoZWxsQ29tbWFuZChjb21tYW5kPVsndW56aXAnLAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICctcScsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJy1vJywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAncHVibGljX2h0bWwvcmVzdWx0cy9tYWNPUy1TaWVycmEtUmVsZWFzZS1X SzItVGVzdHMtRVdTL3IxMjM0LTEyLnppcCcsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJy1kJywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAncHVibGljX2h0bWwvcmVzdWx0cy9tYWNPUy1TaWVycmEtUmVsZWFzZS1X SzItVGVzdHMtRVdTL3IxMjM0LTEyJywK