217872 2020-10-17 05:57:07 -0700 [LFC][IFC] Remove redundant InlineFormattingContext::Geometry::LineRectAndLineBoxOffset 2020-10-17 07:22:18 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1698944 0 zalan 2020-10-17 05:57:07 -0700 Offset is always 0 now. 1698945 1 411665 zalan 2020-10-17 06:03:14 -0700 Created attachment 411665 Patch 1698950 2 ews-feeder 2020-10-17 07:21:02 -0700 Committed r268643: <https://trac.webkit.org/changeset/268643> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411665. 1698952 3 webkit-bug-importer 2020-10-17 07:22:18 -0700 <rdar://problem/70407566> 411665 2020-10-17 06:03:14 -0700 2020-10-17 07:21:02 -0700 Patch bug-217872-20201017060313.patch text/plain 7013 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4NjA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmM1NTZjM2NkZGY3YmFl YjQ4MDRkY2ZiN2NiMjI1Y2QxODFjNTk5My4uMWI5ODkzZDgyMjhlYmU2ZjhmNDBiMjdjNzc1MjJi ZGMyODAwMDAyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTEwLTE3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBSZW1vdmUg cmVkdW5kYW50IElubGluZUZvcm1hdHRpbmdDb250ZXh0OjpHZW9tZXRyeTo6TGluZVJlY3RBbmRM aW5lQm94T2Zmc2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTc4NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZnRlciB3ZWJraXQub3JnL2IvMjE3ODMyLCB0aGUgbGluZSBib3ggb2Zmc2V0IGlzIGFs d2F5cyAwIChsaW5lIHNwYWNlIG9mZnNldHRpbmcgaGFzIG1vdmVkIHRvIHRoZSBpbmxpbmUgYm94 IGFsaWdubWVudCkuCisKKyAgICAgICAgKiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVG b3JtYXR0aW5nQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OklubGluZUZv cm1hdHRpbmdDb250ZXh0Ojpjb21wdXRlR2VvbWV0cnlGb3JMaW5lQ29udGVudCk6CisgICAgICAg ICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHQuaDoKKyAg ICAgICAgKiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dEdl b21ldHJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6SW5saW5lRm9ybWF0dGluZ0Nv bnRleHQ6Okdlb21ldHJ5Ojpjb21wdXRlZExpbmVMb2dpY2FsUmVjdCBjb25zdCk6CisKIDIwMjAt MTAtMTcgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJ RkNdIEludHJvZHVjZSBsYXlvdXQgYm91bmRzIGJhc2VkIHZlcnRpY2FsIGFsaWdubWVudApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9y bWF0dGluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRp bmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHQuY3BwCmluZGV4IDg1YjcxYzdjNTM0NGExMzFmZGZl OWY1YjJhOTM2NTY5NTRlZGYxMmQuLjczMjU4YWM1OWU4MDQzMjM2OTgyNTk2ZTczYzQwZTkxYzI4 ZjU5NGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5n L0lubGluZUZvcm1hdHRpbmdDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv aW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dC5jcHAKQEAgLTQxMCwxMCAr NDEwLDcgQEAgSW5saW5lUmVjdCBJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6Y29tcHV0ZUdlb21l dHJ5Rm9yTGluZUNvbnRlbnQoY29uc3QgTGluZUJ1aWwKIAogICAgIGZvcm1hdHRpbmdTdGF0ZS5h ZGRMaW5lQm94KGdlb21ldHJ5LmxpbmVCb3hGb3JMaW5lQ29udGVudChsaW5lQ29udGVudCkpOwog ICAgIGNvbnN0IGF1dG8mIGxpbmVCb3ggPSBmb3JtYXR0aW5nU3RhdGUubGluZUJveGVzKCkubGFz dCgpOwotCi0gICAgYXV0byBsaW5lUmVjdEFuZExpbmVCb3hPZmZzZXQgPSBnZW9tZXRyeS5jb21w dXRlZExpbmVMb2dpY2FsUmVjdChsaW5lQm94LCByb290KCkuc3R5bGUoKSwgbGluZUNvbnRlbnQp OwotICAgIGF1dG8gbGluZUxvZ2ljYWxSZWN0ID0gbGluZVJlY3RBbmRMaW5lQm94T2Zmc2V0Lmxv Z2ljYWxSZWN0OwotICAgIGF1dG8gbGluZUJveFZlcnRpY2FsT2Zmc2V0ID0gbGluZVJlY3RBbmRM aW5lQm94T2Zmc2V0LmxpbmVCb3hWZXJ0aWNhbE9mZnNldDsKKyAgICBhdXRvIGxpbmVMb2dpY2Fs UmVjdCA9IGdlb21ldHJ5LmNvbXB1dGVkTGluZUxvZ2ljYWxSZWN0KGxpbmVCb3gsIGxpbmVDb250 ZW50KTsKIAogICAgIGF1dG8gdXBkYXRlRmxvYXRHZW9tZXRyeSA9IFsmXSB7CiAgICAgICAgIGlm IChsaW5lQ29udGVudC5mbG9hdHMuaXNFbXB0eSgpKQpAQCAtNDU5LDcgKzQ1Niw2IEBAIElubGlu ZVJlY3QgSW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OmNvbXB1dGVHZW9tZXRyeUZvckxpbmVDb250 ZW50KGNvbnN0IExpbmVCdWlsCiAgICAgICAgICAgICAvLyBJbmxpbmUgYm94IGNvb3JkaW5hdGVz IGFyZSByZWxhdGl2ZSB0byB0aGUgbGluZSBib3guCiAgICAgICAgICAgICAvLyBMZXQncyBjb252 ZXJ0IHRvcC9sZWZ0IHJlbGF0aXZlIHRvIHRoZSBmb3JtYXR0aW5nIGNvbnRleHQgcm9vdC4KICAg ICAgICAgICAgIGF1dG8gYm9yZGVyQm94TG9naWNhbFRvcExlZnQgPSBsaW5lTG9naWNhbFJlY3Qu dG9wTGVmdCgpOwotICAgICAgICAgICAgYm9yZGVyQm94TG9naWNhbFRvcExlZnQubW92ZSh7IH0s IGxpbmVCb3hWZXJ0aWNhbE9mZnNldCk7CiAgICAgICAgICAgICBhdXRvIGlubGluZUxldmVsQm94 TG9naWNhbFRvcExlZnQgPSBpbmxpbmVMZXZlbEJveC0+bG9naWNhbFJlY3QoKS50b3BMZWZ0KCk7 CiAgICAgICAgICAgICAvLyBJbmxpbmUgYm94IGhlaWdodCBpbmNsdWRlcyB0aGUgbWFyZ2luIGJv eC4gTGV0J3MgYWNjb3VudCBmb3IgdGhhdC4KICAgICAgICAgICAgIGJvcmRlckJveExvZ2ljYWxU b3BMZWZ0Lm1vdmUoaW5saW5lTGV2ZWxCb3hMb2dpY2FsVG9wTGVmdC54KCksIGlubGluZUxldmVs Qm94TG9naWNhbFRvcExlZnQueSgpICsgYm94R2VvbWV0cnkubWFyZ2luQmVmb3JlKCkpOwpAQCAt NDk3LDggKzQ5Myw4IEBAIElubGluZVJlY3QgSW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OmNvbXB1 dGVHZW9tZXRyeUZvckxpbmVDb250ZW50KGNvbnN0IExpbmVCdWlsCiAgICAgdXBkYXRlQm94R2Vv bWV0cnkoKTsKIAogICAgIGF1dG8gY29uc3RydWN0TGluZUdlb21ldHJ5ID0gWyZdIHsKLSAgICAg ICAgYXV0byBsaW5lQm94TG9naWNhbFJlY3QgPSBJbmxpbmVSZWN0IHsgbGluZUxvZ2ljYWxSZWN0 LnRvcCgpICsgbGluZUJveFZlcnRpY2FsT2Zmc2V0LCBsaW5lTG9naWNhbFJlY3QubGVmdCgpLCBs aW5lQm94LmxvZ2ljYWxXaWR0aCgpLCBsaW5lQm94LmxvZ2ljYWxIZWlnaHQoKSB9OwotICAgICAg ICBmb3JtYXR0aW5nU3RhdGUuYWRkTGluZSh7IGxpbmVMb2dpY2FsUmVjdCwgbGluZUJveExvZ2lj YWxSZWN0LCBsaW5lQm94VmVydGljYWxPZmZzZXQgKyBsaW5lQm94LmFsaWdubWVudEJhc2VsaW5l KCksIGxpbmVCb3guaG9yaXpvbnRhbEFsaWdubWVudE9mZnNldCgpLnZhbHVlT3IoSW5saW5lTGF5 b3V0VW5pdCB7IH0pIH0pOworICAgICAgICBhdXRvIGxpbmVCb3hMb2dpY2FsUmVjdCA9IElubGlu ZVJlY3QgeyBsaW5lTG9naWNhbFJlY3QudG9wKCksIGxpbmVMb2dpY2FsUmVjdC5sZWZ0KCksIGxp bmVCb3gubG9naWNhbFdpZHRoKCksIGxpbmVCb3gubG9naWNhbEhlaWdodCgpIH07CisgICAgICAg IGZvcm1hdHRpbmdTdGF0ZS5hZGRMaW5lKHsgbGluZUxvZ2ljYWxSZWN0LCBsaW5lQm94TG9naWNh bFJlY3QsIGxpbmVCb3guYWxpZ25tZW50QmFzZWxpbmUoKSwgbGluZUJveC5ob3Jpem9udGFsQWxp Z25tZW50T2Zmc2V0KCkudmFsdWVPcihJbmxpbmVMYXlvdXRVbml0IHsgfSkgfSk7CiAgICAgfTsK ICAgICBjb25zdHJ1Y3RMaW5lR2VvbWV0cnkoKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHQuaCBiL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250 ZXh0LmgKaW5kZXggMGQzYjFmOTIzZWUzN2MzZjkwOGNlNDY0YzAyYWZkNmI4ZWQyYzYxMS4uYzQ5 MGY1NDYzNzZhZDY2NDk2YWI0NTcwNmE4NWJjY2I3ZWY2NDhmYSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHQu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3Jt YXR0aW5nQ29udGV4dC5oCkBAIC02NSwxMSArNjUsNyBAQCBwcml2YXRlOgogICAgIGNsYXNzIEdl b21ldHJ5IDogcHVibGljIEZvcm1hdHRpbmdDb250ZXh0OjpHZW9tZXRyeSB7CiAgICAgcHVibGlj OgogICAgICAgICBMaW5lQm94IGxpbmVCb3hGb3JMaW5lQ29udGVudChjb25zdCBMaW5lQnVpbGRl cjo6TGluZUNvbnRlbnQmKTsKLSAgICAgICAgc3RydWN0IExpbmVSZWN0QW5kTGluZUJveE9mZnNl dCB7Ci0gICAgICAgICAgICBJbmxpbmVMYXlvdXRVbml0IGxpbmVCb3hWZXJ0aWNhbE9mZnNldDsK LSAgICAgICAgICAgIElubGluZVJlY3QgbG9naWNhbFJlY3Q7Ci0gICAgICAgIH07Ci0gICAgICAg IExpbmVSZWN0QW5kTGluZUJveE9mZnNldCBjb21wdXRlZExpbmVMb2dpY2FsUmVjdChjb25zdCBM aW5lQm94JiwgY29uc3QgUmVuZGVyU3R5bGUmIHJvb3RTdHlsZSwgY29uc3QgTGluZUJ1aWxkZXI6 OkxpbmVDb250ZW50JikgY29uc3Q7CisgICAgICAgIElubGluZVJlY3QgY29tcHV0ZWRMaW5lTG9n aWNhbFJlY3QoY29uc3QgTGluZUJveCYsIGNvbnN0IExpbmVCdWlsZGVyOjpMaW5lQ29udGVudCYp IGNvbnN0OwogICAgICAgICBJbmxpbmVMYXlvdXRVbml0IGxvZ2ljYWxUb3BGb3JOZXh0TGluZShj b25zdCBMaW5lQnVpbGRlcjo6TGluZUNvbnRlbnQmLCBJbmxpbmVMYXlvdXRVbml0IHByZXZpb3Vz TGluZUxvZ2ljYWxCb3R0b20sIGNvbnN0IEZsb2F0aW5nQ29udGV4dCYpIGNvbnN0OwogCiAgICAg ICAgIENvbnRlbnRIZWlnaHRBbmRNYXJnaW4gaW5saW5lQmxvY2tIZWlnaHRBbmRNYXJnaW4oY29u c3QgQm94JiwgY29uc3QgSG9yaXpvbnRhbENvbnN0cmFpbnRzJiwgY29uc3QgT3ZlcnJpZGRlblZl cnRpY2FsVmFsdWVzJikgY29uc3Q7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv aW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250 ZXh0R2VvbWV0cnkuY3BwCmluZGV4IDI5MmE5NmQzZDZhMzUzNjM5ZWU1ZTI2Y2NhZTMyNGUyZTJm NmJhMmMuLmFlMDBkMmUzNzRjZjcxOTFhN2I3Y2M3ZjE5ZjgxZDhjNDEzODVmZjEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRp bmdDb250ZXh0R2VvbWV0cnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVm b3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0R2VvbWV0cnkuY3BwCkBAIC0zOTksMTcg KzM5OSwxMCBAQCBMaW5lQm94IElubGluZUZvcm1hdHRpbmdDb250ZXh0OjpHZW9tZXRyeTo6bGlu ZUJveEZvckxpbmVDb250ZW50KGNvbnN0IExpbmVCdWlsZAogICAgIHJldHVybiBMaW5lQm94QnVp bGRlcihmb3JtYXR0aW5nQ29udGV4dCgpKS5idWlsZChsaW5lQ29udGVudCk7CiB9CiAKLUlubGlu ZUZvcm1hdHRpbmdDb250ZXh0OjpHZW9tZXRyeTo6TGluZVJlY3RBbmRMaW5lQm94T2Zmc2V0IElu bGluZUZvcm1hdHRpbmdDb250ZXh0OjpHZW9tZXRyeTo6Y29tcHV0ZWRMaW5lTG9naWNhbFJlY3Qo Y29uc3QgTGluZUJveCYgbGluZUJveCwgY29uc3QgUmVuZGVyU3R5bGUmLCBjb25zdCBMaW5lQnVp bGRlcjo6TGluZUNvbnRlbnQmIGxpbmVDb250ZW50KSBjb25zdAorSW5saW5lUmVjdCBJbmxpbmVG b3JtYXR0aW5nQ29udGV4dDo6R2VvbWV0cnk6OmNvbXB1dGVkTGluZUxvZ2ljYWxSZWN0KGNvbnN0 IExpbmVCb3gmIGxpbmVCb3gsIGNvbnN0IExpbmVCdWlsZGVyOjpMaW5lQ29udGVudCYgbGluZUNv bnRlbnQpIGNvbnN0CiB7Ci0gICAgaWYgKGxpbmVDb250ZW50LnJ1bnMuaXNFbXB0eSgpIHx8IGxp bmVCb3guaXNMaW5lVmlzdWFsbHlFbXB0eSgpKQotICAgICAgICByZXR1cm4geyB7IH0sIHsgbGlu ZUNvbnRlbnQubG9naWNhbFRvcExlZnQsIGxpbmVDb250ZW50LmxpbmVMb2dpY2FsV2lkdGgsIHsg fSB9IH07Ci0KLSAgICBhdXRvIGxpbmVCb3hMb2dpY2FsSGVpZ2h0ID0gbGluZUJveC5sb2dpY2Fs SGVpZ2h0KCk7Ci0gICAgYXV0byBsaW5lTG9naWNhbEhlaWdodCA9IGxpbmVCb3gubG9naWNhbEhl aWdodCgpOwotICAgIGF1dG8gbG9naWNhbFJlY3QgPSBJbmxpbmVSZWN0IHsgbGluZUNvbnRlbnQu bG9naWNhbFRvcExlZnQsIGxpbmVDb250ZW50LmxpbmVMb2dpY2FsV2lkdGgsIGxpbmVMb2dpY2Fs SGVpZ2h0fTsKLSAgICAvLyBJbmxpbmUgdHJlZSBoZWlnaHQgaXMgYWxsIGludGVnZXIgYmFzZWQu Ci0gICAgYXV0byBsaW5lQm94T2Zmc2V0ID0gZmxvb3JmKChsaW5lTG9naWNhbEhlaWdodCAtIGxp bmVCb3hMb2dpY2FsSGVpZ2h0KSAvIDIpOwotICAgIHJldHVybiB7IGxpbmVCb3hPZmZzZXQsIGxv Z2ljYWxSZWN0IH07CisgICAgYXV0byBpc0NvbnNpZGVyZWRFbXB0eSA9IGxpbmVDb250ZW50LnJ1 bnMuaXNFbXB0eSgpIHx8IGxpbmVCb3guaXNMaW5lVmlzdWFsbHlFbXB0eSgpOworICAgIHJldHVy biB7IGxpbmVDb250ZW50LmxvZ2ljYWxUb3BMZWZ0LCBsaW5lQ29udGVudC5saW5lTG9naWNhbFdp ZHRoLCBpc0NvbnNpZGVyZWRFbXB0eSA/IElubGluZUxheW91dFVuaXQoKSA6IGxpbmVCb3gubG9n aWNhbEhlaWdodCgpfTsKIH0KIAogSW5saW5lTGF5b3V0VW5pdCBJbmxpbmVGb3JtYXR0aW5nQ29u dGV4dDo6R2VvbWV0cnk6OmxvZ2ljYWxUb3BGb3JOZXh0TGluZShjb25zdCBMaW5lQnVpbGRlcjo6 TGluZUNvbnRlbnQmIGxpbmVDb250ZW50LCBJbmxpbmVMYXlvdXRVbml0IHByZXZpb3VzTGluZUxv Z2ljYWxCb3R0b20sIGNvbnN0IEZsb2F0aW5nQ29udGV4dCYgZmxvYXRpbmdDb250ZXh0KSBjb25z dAo=