217865 2020-10-16 20:11:51 -0700 Web Inspector: REGRESSION(r266669): DOMBreakpoint.js:106:23: CONSOLE ASSERT ERROR domNode should not change once set 2020-10-19 11:03:00 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 215795 1 hi hi bburg hi inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1698877 0 hi 2020-10-16 20:11:51 -0700 . 1698881 1 411649 hi 2020-10-16 20:26:15 -0700 Created attachment 411649 Patch 1698906 2 ews-feeder 2020-10-16 21:34:30 -0700 Committed r268634: <https://trac.webkit.org/changeset/268634> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411649. 1698907 3 webkit-bug-importer 2020-10-16 21:35:17 -0700 <rdar://problem/70402343> 1698989 4 411649 bburg 2020-10-17 13:37:08 -0700 Comment on attachment 411649 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411649&action=review > LayoutTests/inspector/unit-tests/utilities.html:16 > + InspectorTest.expectEqual(xor(42, "test"), false, "xor should explicitly return false when both values are truthy."); I would have expected a logical operator to return true or false, not false or anything. What is the use case for returning the value instead of converting it to boolean first? 1699314 5 411649 hi 2020-10-19 11:03:00 -0700 Comment on attachment 411649 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411649&action=review >> LayoutTests/inspector/unit-tests/utilities.html:16 >> + InspectorTest.expectEqual(xor(42, "test"), false, "xor should explicitly return false when both values are truthy."); > > I would have expected a logical operator to return true or false, not false or anything. What is the use case for returning the value instead of converting it to boolean first? This way it behaves like `||` and `&&` in JavaScript, where the actual value is used in the "positive" case instead of `true`. 411649 2020-10-16 20:26:15 -0700 2020-10-16 21:34:30 -0700 Patch bug-217865-20201016202614.patch text/plain 5453 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDFkY2E5YTEwNDFjYzUwZGNjNDA4ZjUzYzMxZTY0 N2IxYWM1MGQxNDguLjkzZjlmY2Y2YjE5MTc1ZTFiN2JhNWEyNWIxMmQzMWQ0NmQ2ZDY4ODcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTEwLTE2ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKHIyNjY2NjkpOiBET01CcmVha3BvaW50LmpzOjEwNjoyMzogQ09OU09MRSBBU1NF UlQgRVJST1IgZG9tTm9kZSBzaG91bGQgbm90IGNoYW5nZSBvbmNlIHNldAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3ODY1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVs cy9ET01CcmVha3BvaW50LmpzOgorICAgICAgICAoV0kuRE9NQnJlYWtwb2ludC5wcm90b3R5cGUu c2V0IGRvbU5vZGUpOgorICAgICAgICBBZGp1c3QgdGhlIGFzc2VydGlvbiBzdWNoIHRoYXQgYG51 bGxgIGlzIGFsbG93ZWQgaWYgYF9kb21Ob2RlYCBpcyBhbHJlYWR5IGBudWxsYC4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9VdGlsaXRpZXMuanM6CisgICAgICAgICh4b3IpOiBBZGRl ZC4KKyAgICAgICAgR2xvYmFsIHV0aWxpdHkgZnVuY3Rpb24gZm9yIGRvaW5nIGEgbm9uLWJpdHdp c2Ugb3IgdGhhdCByZXR1cm5zIGBmYWxzZWAgaWYgYm90aCB2YWx1ZXMgYXJlCisgICAgICAgIHRy dXRoeS9mYWxzeSBhbmQgdGhlIHRydXRoeSB2YWx1ZSBpZiBvbmx5IG9uZSBpcyB0cnV0aHkuCisK IDIwMjAtMTAtMTYgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IFJFR1JFU1NJT04ocjI2NjQ4MCk6IGxpbmUtYmFzZWQgSmF2YVNjcmlw dCBicmVha3BvaW50IHRyZWUgZWxlbWVudCB0aXRsZXMgYWxzbyBzaG93IHRoZSBmaWxlIG5hbWUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvVXRp bGl0aWVzLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9VdGls aXRpZXMuanMKaW5kZXggODc2YmI2YTY1MDk3ZGFiMTJlNDkyZWE4NDUyZGYyYzQ3OWZmMWY4OS4u Y2MwYzkwMTExZWY4YjY4ZTJlNTEyMDhlZDA1OGMwOGVjNjRhZWQxMCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9VdGlsaXRpZXMuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9VdGlsaXRpZXMuanMKQEAg LTMwLDYgKzMwLDEzIEBAIHZhciBlbGxpcHNpcyA9ICJcdTIwMjYiOwogdmFyIHplcm9XaWR0aFNw YWNlID0gIlx1MjAwYiI7CiB2YXIgbXVsdGlwbGljYXRpb25TaWduID0gIlx1MDBkNyI7CiAKK2Z1 bmN0aW9uIHhvcihhLCBiKQoreworICAgIGlmIChhKQorICAgICAgICByZXR1cm4gYiA/IGZhbHNl IDogYTsKKyAgICByZXR1cm4gYiB8fCBmYWxzZTsKK30KKwogT2JqZWN0LmRlZmluZVByb3BlcnR5 KE9iamVjdCwgInNoYWxsb3dDb3B5IiwKIHsKICAgICB2YWx1ZShvYmplY3QpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRE9NQnJlYWtwb2lu dC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01CcmVh a3BvaW50LmpzCmluZGV4IDg1OWI1NjA1ZWRiYTgwNjA3NDBhM2U5YTFlNGU4ODBlNzZhNmExZTku LjZlZWIzMjA4ZTJkNjQyNTI5YjlkZTFiMzYyOTM4NWQ0NmE0MmIwYWEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01CcmVha3BvaW50Lmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01CcmVh a3BvaW50LmpzCkBAIC0xMDIsOSArMTAyLDkgQEAgV0kuRE9NQnJlYWtwb2ludCA9IGNsYXNzIERP TUJyZWFrcG9pbnQgZXh0ZW5kcyBXSS5CcmVha3BvaW50CiAKICAgICBzZXQgZG9tTm9kZShkb21O b2RlKQogICAgIHsKLSAgICAgICAgY29uc29sZS5hc3NlcnQoZG9tTm9kZSBpbnN0YW5jZW9mIFdJ LkRPTU5vZGUsIGRvbU5vZGUpOwotICAgICAgICBjb25zb2xlLmFzc2VydCghdGhpcy5fZG9tTm9k ZSAhPT0gIWRvbU5vZGUsICJkb21Ob2RlIHNob3VsZCBub3QgY2hhbmdlIG9uY2Ugc2V0Iik7Ci0g ICAgICAgIGlmICghdGhpcy5fZG9tTm9kZSA9PT0gIWRvbU5vZGUpCisgICAgICAgIGNvbnNvbGUu YXNzZXJ0KCFkb21Ob2RlIHx8IGRvbU5vZGUgaW5zdGFuY2VvZiBXSS5ET01Ob2RlLCBkb21Ob2Rl KTsKKyAgICAgICAgY29uc29sZS5hc3NlcnQoIWRvbU5vZGUgfHwgeG9yKGRvbU5vZGUsIHRoaXMu X2RvbU5vZGUpLCAiZG9tTm9kZSBzaG91bGQgbm90IGNoYW5nZSBvbmNlIHNldCIsIGRvbU5vZGUs IHRoaXMuX2RvbU5vZGUpOworICAgICAgICBpZiAoIXhvcihkb21Ob2RlLCB0aGlzLl9kb21Ob2Rl KSkKICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xp c3RlbmVycyhXSS5ET01CcmVha3BvaW50LkV2ZW50LkRPTU5vZGVXaWxsQ2hhbmdlKTsKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCBhMTUzNDM1ZGNiOGJiOTBlMTMzZDY4YzE2YzQyMWMyNjAwZTYyYmU4Li42NTU0YmZlYjQxMGVh ZjM0ZDJhYzZlNzVlYzA3N2ZiODc5NTM0Mzk5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAt MTAtMTYgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJ bnNwZWN0b3I6IFJFR1JFU1NJT04ocjI2NjY2OSk6IERPTUJyZWFrcG9pbnQuanM6MTA2OjIzOiBD T05TT0xFIEFTU0VSVCBFUlJPUiBkb21Ob2RlIHNob3VsZCBub3QgY2hhbmdlIG9uY2Ugc2V0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTc4NjUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rv ci91bml0LXRlc3RzL3V0aWxpdGllcy5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBpbnNwZWN0b3Iv dW5pdC10ZXN0cy91dGlsaXRpZXMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKwogMjAyMC0xMC0xNiAg RGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgU3VwcG9ydCBhY2NlbGVy YXRlZCBhbmltYXRpb24gb2YgaW5kaXZpZHVhbCB0cmFuc2Zvcm0gQ1NTIHByb3BlcnRpZXMKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci91bml0LXRlc3RzL3V0aWxpdGllcy1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvdW5pdC10ZXN0cy91dGlsaXRpZXMtZXhw ZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjM4YzY4MjFiMDc3MTk2M2QzMWE3NWZiNjNhN2EyNmY3YmQ2 NWQ1OWQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvdW5pdC10ZXN0 cy91dGlsaXRpZXMtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsOCBAQAorCis9PSBSdW5uaW5nIHRl c3Qgc3VpdGU6IFV0aWxpdGllcworLS0gUnVubmluZyB0ZXN0IGNhc2U6IHhvcgorUEFTUzogeG9y IHNob3VsZCBleHBsaWNpdGx5IHJldHVybiBmYWxzZSB3aGVuIGJvdGggdmFsdWVzIGFyZSBmYWxz eS4KK1BBU1M6IHhvciBzaG91bGQgcmV0dXJuIHRoZSBmaXJzdCB2YWx1ZSB3aGVuIHRoZSBzZWNv bmQgdmFsdWUgaXMgZmFsc3kuCitQQVNTOiB4b3Igc2hvdWxkIHJldHVybiB0aGUgc2Vjb25kIHZh bHVlIHdoZW4gdGhlIGZpcnN0IHZhbHVlIGlzIGZhbHN5LgorUEFTUzogeG9yIHNob3VsZCBleHBs aWNpdGx5IHJldHVybiBmYWxzZSB3aGVuIGJvdGggdmFsdWVzIGFyZSB0cnV0aHkuCisKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci91bml0LXRlc3RzL3V0aWxpdGllcy5odG1sIGIv TGF5b3V0VGVzdHMvaW5zcGVjdG9yL3VuaXQtdGVzdHMvdXRpbGl0aWVzLmh0bWwKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MC4uMWFlYTczZjk3MjYyMzdjZTZjMmZjODc5ZDczM2ZlODA0NjFlNzY5ZQotLS0gL2Rldi9udWxs CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci91bml0LXRlc3RzL3V0aWxpdGllcy5odG1sCkBA IC0wLDAgKzEsMjYgQEAKKzwhZG9jdHlwZSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQg c3JjPSIuLi8uLi9odHRwL3Rlc3RzL2luc3BlY3Rvci9yZXNvdXJjZXMvaW5zcGVjdG9yLXRlc3Qu anMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK2Z1bmN0aW9uIHRlc3QoKQoreworICAgIGxldCBzdWl0 ZSA9IEluc3BlY3RvclRlc3QuY3JlYXRlU3luY1N1aXRlKCJVdGlsaXRpZXMiKTsKKworICAgIHN1 aXRlLmFkZFRlc3RDYXNlKHsKKyAgICAgICAgbmFtZTogInhvciIsCisgICAgICAgIHRlc3QoKSB7 CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4cGVjdEVxdWFsKHhvcigwLCB1bmRlZmluZWQp LCBmYWxzZSwgInhvciBzaG91bGQgZXhwbGljaXRseSByZXR1cm4gZmFsc2Ugd2hlbiBib3RoIHZh bHVlcyBhcmUgZmFsc3kuIik7CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4cGVjdEVxdWFs KHhvcig0MiwgdW5kZWZpbmVkKSwgNDIsICJ4b3Igc2hvdWxkIHJldHVybiB0aGUgZmlyc3QgdmFs dWUgd2hlbiB0aGUgc2Vjb25kIHZhbHVlIGlzIGZhbHN5LiIpOworICAgICAgICAgICAgSW5zcGVj dG9yVGVzdC5leHBlY3RFcXVhbCh4b3IodW5kZWZpbmVkLCAidGVzdCIpLCAidGVzdCIsICJ4b3Ig c2hvdWxkIHJldHVybiB0aGUgc2Vjb25kIHZhbHVlIHdoZW4gdGhlIGZpcnN0IHZhbHVlIGlzIGZh bHN5LiIpOworICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5leHBlY3RFcXVhbCh4b3IoNDIsICJ0 ZXN0IiksIGZhbHNlLCAieG9yIHNob3VsZCBleHBsaWNpdGx5IHJldHVybiBmYWxzZSB3aGVuIGJv dGggdmFsdWVzIGFyZSB0cnV0aHkuIik7CisgICAgICAgIH0sCisgICAgfSk7CisKKyAgICBzdWl0 ZS5ydW5UZXN0Q2FzZXNBbmRGaW5pc2goKTsKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkg b25Mb2FkPSJydW5UZXN0KCkiPgorPC9ib2R5PgorPC9odG1sPgo=