217862 2020-10-16 18:38:15 -0700 Web Inspector: REGRESSION(r266074): line-based JavaScript breakpoints don't hit after reload 2020-10-19 17:41:46 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=217934 InRadar P2 Normal --- 215362 1 hi hi ews-watchlist hi inspector-bugzilla-changes joepeck keith_miller mark.lam msaboff saam timothy tzagallo webkit-bug-importer oldest_to_newest 1698850 0 hi 2020-10-16 18:38:15 -0700 # STEPS TO REPRODUCE 1. inspect <https://webkit.org> 2. set a breakpoint inside the `DOMContentLoaded` event listener callback in `global.js` 3. reload the page # EXPECTED pause # ACTUAL no-pause, and the breakpoint shows as unresolved 1698874 1 411646 hi 2020-10-16 20:11:16 -0700 Created attachment 411646 Patch 1698894 2 ews-feeder 2020-10-16 21:07:27 -0700 Committed r268629: <https://trac.webkit.org/changeset/268629> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411646. 1698895 3 webkit-bug-importer 2020-10-16 21:08:18 -0700 <rdar://problem/70402083> 1699408 4 ryanhaddad 2020-10-19 13:34:39 -0700 inspector/debugger/breakpoint-resolve-when-script-added.html, added with this change, is frequently timing out on macOS debug bots. https://results.webkit.org/?suite=layout-tests&test=inspector%2Fdebugger%2Fbreakpoint-resolve-when-script-added.html 1699413 5 ryanhaddad 2020-10-19 13:42:47 -0700 (In reply to Ryan Haddad from comment #4) > inspector/debugger/breakpoint-resolve-when-script-added.html, added with > this change, is frequently timing out on macOS debug bots. > > https://results.webkit.org/?suite=layout- > tests&test=inspector%2Fdebugger%2Fbreakpoint-resolve-when-script-added.html Marked the test as slow in https://trac.webkit.org/changeset/268684/webkit 1699478 6 bburg 2020-10-19 15:12:20 -0700 *** Bug 216807 has been marked as a duplicate of this bug. *** 1699529 7 ryanhaddad 2020-10-19 17:01:49 -0700 (In reply to Ryan Haddad from comment #4) > inspector/debugger/breakpoint-resolve-when-script-added.html, added with > this change, is frequently timing out on macOS debug bots. > > https://results.webkit.org/?suite=layout- > tests&test=inspector%2Fdebugger%2Fbreakpoint-resolve-when-script-added.html My statement was incorrect, this is also affecting release bots. Devin, can you investigate this urgently or should we revert for now? 1699547 8 ryanhaddad 2020-10-19 17:41:46 -0700 (In reply to Ryan Haddad from comment #7) > (In reply to Ryan Haddad from comment #4) > > inspector/debugger/breakpoint-resolve-when-script-added.html, added with > > this change, is frequently timing out on macOS debug bots. > > > > https://results.webkit.org/?suite=layout- > > tests&test=inspector%2Fdebugger%2Fbreakpoint-resolve-when-script-added.html > My statement was incorrect, this is also affecting release bots. > > Devin, can you investigate this urgently or should we revert for now? Tracking with https://bugs.webkit.org/show_bug.cgi?id=217934 411646 2020-10-16 20:11:16 -0700 2020-10-16 21:07:27 -0700 Patch bug-217862-20201016201116.patch text/plain 6855 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGQ2ODJmMzE3MWRiNzlkZTc0MWJlMjc1MzVlYzNi YTkzODBiZGM4MTQuLmI2YWYxOGFlN2NkOTA2ZTU4MmUzYjg3NTJiZDE2ZDdjZmQ5MDZlOWEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTEwLTE2ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKHIyNjYwNzQpOiBsaW5lLWJhc2VkIEphdmFTY3JpcHQgYnJlYWtwb2ludHMgZG9u J3QgaGl0IGFmdGVyIHJlbG9hZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjE3ODYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBpbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuY3Bw OgorICAgICAgICAoSW5zcGVjdG9yOjpJbnNwZWN0b3JEZWJ1Z2dlckFnZW50OjpjbGVhckRlYnVn Z2VyQnJlYWtwb2ludFN0YXRlKToKKyAgICAgICAgRG9uJ3QgY2xlYXIgdGhlIGxpc3Qgb2YgcHJv dG9jb2wgYnJlYWtwb2ludHMgd2hlbiB0aGUgZ2xvYmFsIG9iamVjdCBjaGFuZ2VzLiBQcm90b2Nv bAorICAgICAgICBicmVha3BvaW50cyBzaG91bGQgb25seSBiZSBjbGVhcmVkIHdoZW4gaW5kaXZp ZHVhbGx5IHJlbW92ZWQgb3IgYnkgYERlYnVnZ2VyLmRpc2FibGVgLgorCiAyMDIwLTEwLTE2ICBT YWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIERvbid0IGVtaXQgT3BT cHJlYWQgd2l0aCBhIGNvbnN0YW50IGFzIHRoZSBkZXN0aW5hdGlvbgpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yRGVidWdnZXJBZ2Vu dC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JE ZWJ1Z2dlckFnZW50LmNwcAppbmRleCA0MWY0YmE0MjdlYTRmNzlkYzE0NDdmZWE1OTY0YWQ4MDYz Y2JkZjcyLi4xMzBlZTVhNzNjZTEyMWFlYTc4YThkOGExM2RmMzE0OTllMDY0MjQxIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JEZWJ1 Z2dlckFnZW50LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50 cy9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmNwcApAQCAtMTMzNyw3ICsxMzM3LDYgQEAgdm9pZCBJ bnNwZWN0b3JEZWJ1Z2dlckFnZW50OjpjbGVhckRlYnVnZ2VyQnJlYWtwb2ludFN0YXRlKCkKICAg ICBtX3BhdXNlZEdsb2JhbE9iamVjdCA9IG51bGxwdHI7CiAgICAgbV9jdXJyZW50Q2FsbFN0YWNr ID0geyB9OwogICAgIG1fc2NyaXB0cy5jbGVhcigpOwotICAgIG1fcHJvdG9jb2xCcmVha3BvaW50 Rm9yUHJvdG9jb2xCcmVha3BvaW50SUQuY2xlYXIoKTsKICAgICBtX2RlYnVnZ2VyQnJlYWtwb2lu dHNGb3JQcm90b2NvbEJyZWFrcG9pbnRJRC5jbGVhcigpOwogICAgIG1fbmV4dERlYnVnZ2VyQnJl YWtwb2ludElEID0gSlNDOjpub0JyZWFrcG9pbnRJRCArIDE7CiAgICAgbV9jb250aW51ZVRvTG9j YXRpb25EZWJ1Z2dlckJyZWFrcG9pbnQgPSBudWxscHRyOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGExNTM0MzVkY2I4YmI5 MGUxMzNkNjhjMTZjNDIxYzI2MDBlNjJiZTguLmIxZmU2MjkxNTM1MDk4OGFiNTU1ZmE5NDE2ZjM3 ZmY5ZDAyNmMwZDQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAyMC0xMC0xNiAgRGV2aW4gUm91 c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVT U0lPTihyMjY2MDc0KTogbGluZS1iYXNlZCBKYXZhU2NyaXB0IGJyZWFrcG9pbnRzIGRvbid0IGhp dCBhZnRlciByZWxvYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIxNzg2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogaW5zcGVjdG9yL2RlYnVnZ2VyL3Jlc291cmNlcy9uZXN0ZWQtY2FsbHMuanM6IEFk ZGVkLgorICAgICAgICAoaW5uZXIpOgorICAgICAgICAob3V0ZXIpOgorCisgICAgICAgICogaW5z cGVjdG9yL2RlYnVnZ2VyL2JyZWFrcG9pbnQtcmVzb2x2ZS13aGVuLXNjcmlwdC1hZGRlZC5odG1s OiBBZGRlZC4KKyAgICAgICAgKiBpbnNwZWN0b3IvZGVidWdnZXIvYnJlYWtwb2ludC1yZXNvbHZl LXdoZW4tc2NyaXB0LWFkZGVkLWV4cGVjdGVkLnR4dDogQWRkZWQuCisKIDIwMjAtMTAtMTYgIERl YW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIFN1cHBvcnQgYWNjZWxlcmF0 ZWQgYW5pbWF0aW9uIG9mIGluZGl2aWR1YWwgdHJhbnNmb3JtIENTUyBwcm9wZXJ0aWVzCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZGVidWdnZXIvYnJlYWtwb2ludC1yZXNvbHZl LXdoZW4tc2NyaXB0LWFkZGVkLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9k ZWJ1Z2dlci9icmVha3BvaW50LXJlc29sdmUtd2hlbi1zY3JpcHQtYWRkZWQtZXhwZWN0ZWQudHh0 Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjQzN2NlMTE5ZTk3NmRhYjM4ZGFjZGQ5ZTI0YmU0YzQ3MTc2YWU0NGQKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZGVidWdnZXIvYnJlYWtwb2lu dC1yZXNvbHZlLXdoZW4tc2NyaXB0LWFkZGVkLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDE2IEBA CitUZXN0cyBmb3IgYnJlYWtwb2ludCByZXNvbHZpbmcgYmVoYXZpb3IuCisKKworPT0gUnVubmlu ZyB0ZXN0IHN1aXRlOiBCcmVha3BvaW50LlJlc29sdmUKKy0tIFJ1bm5pbmcgdGVzdCBjYXNlOiBC cmVha3BvaW50LlJlc29sdmUuV2hlblNjcmlwdEFkZGVkCitXYWl0aW5nIGZvciBzY3JpcHQuLi4K K1BBU1M6IEZvdW5kIHNjcmlwdC4KK0FkZGluZyBicmVha3BvaW50Li4uCitSZWxvYWRpbmcgcGFn ZS4uLgorUEFTUzogUGF1c2VkCitDQUxMIFNUQUNLOgorMDogW0ZdIG91dGVyCisxOiBbUF0gR2xv YmFsIENvZGUKK1JlbW92aW5nIGJyZWFrcG9pbnQuLi4KK1Jlc3VtaW5nLi4uCisKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9icmVha3BvaW50LXJlc29sdmUtd2hl bi1zY3JpcHQtYWRkZWQuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9icmVh a3BvaW50LXJlc29sdmUtd2hlbi1zY3JpcHQtYWRkZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5mNTg3ZjEw YWMzYTRjZDQzNTUyOWM3ZWIxNDEwNzEzOTJmZDFlODMxCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvaW5zcGVjdG9yL2RlYnVnZ2VyL2JyZWFrcG9pbnQtcmVzb2x2ZS13aGVuLXNjcmlw dC1hZGRlZC5odG1sCkBAIC0wLDAgKzEsNjYgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8 aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9odHRwL3Rlc3RzL2luc3BlY3Rvci9yZXNvdXJjZXMv aW5zcGVjdG9yLXRlc3QuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9InJlc291cmNlcy9sb2ct YWN0aXZlLXN0YWNrLXRyYWNlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMv bmVzdGVkLWNhbGxzLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CitmdW5jdGlvbiB0ZXN0KCkKK3sK KyAgICBJbnNwZWN0b3JUZXN0LmRlYnVnKCk7CisgICAgbGV0IHN1aXRlID0gSW5zcGVjdG9yVGVz dC5jcmVhdGVBc3luY1N1aXRlKCJCcmVha3BvaW50LlJlc29sdmUiKTsKKworICAgIHN1aXRlLmFk ZFRlc3RDYXNlKHsKKyAgICAgICAgbmFtZTogIkJyZWFrcG9pbnQuUmVzb2x2ZS5XaGVuU2NyaXB0 QWRkZWQiLAorICAgICAgICBkZXNjcmlwdGlvbjogIlRlc3QgdGhhdCBicmVha3BvaW50cyBhbHJl YWR5IHNlbnQgdG8gdGhlIGJhY2tlbmQgYXV0b21hdGljYWxseSByZXNvbHZlIHdoZW4gc2NyaXB0 cyBtYXRjaGluZyB0aGF0IGJyZWFrcG9pbnQgYXJlIGxvYWRlZC4iLAorICAgICAgICBhc3luYyB0 ZXN0KCkgeworICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5sb2coIldhaXRpbmcgZm9yIHNjcmlw dC4uLiIpOworICAgICAgICAgICAgbGV0IHNjcmlwdCA9IGF3YWl0IG5ldyBQcm9taXNlKChyZXNv bHZlLCByZWplY3QpID0+IHsKKyAgICAgICAgICAgICAgICBmb3IgKGxldCByZXNvdXJjZSBvZiBX SS5uZXR3b3JrTWFuYWdlci5tYWluRnJhbWUucmVzb3VyY2VDb2xsZWN0aW9uKSB7CisgICAgICAg ICAgICAgICAgICAgIGlmIChyZXNvdXJjZS51cmwuZW5kc1dpdGgoInJlc291cmNlcy9uZXN0ZWQt Y2FsbHMuanMiKSkgeworICAgICAgICAgICAgICAgICAgICAgICAgcmVzb2x2ZShyZXNvdXJjZSk7 CisgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICAgICAgICAgIH0K KyAgICAgICAgICAgICAgICB9CisKKyAgICAgICAgICAgICAgICBsZXQgbGlzdGVuZXIgPSBXSS5u ZXR3b3JrTWFuYWdlci5tYWluRnJhbWUuYWRkRXZlbnRMaXN0ZW5lcihXSS5GcmFtZS5FdmVudC5S ZXNvdXJjZVdhc0FkZGVkLCAoZXZlbnQpID0+IHsKKyAgICAgICAgICAgICAgICAgICAgaWYgKGV2 ZW50LnJlc291cmNlLnVybC5lbmRzV2l0aCgicmVzb3VyY2VzL25lc3RlZC1jYWxscy5qcyIpKSB7 CisgICAgICAgICAgICAgICAgICAgICAgICBXSS5uZXR3b3JrTWFuYWdlci5tYWluRnJhbWUucmVt b3ZlRXZlbnRMaXN0ZW5lcihXSS5GcmFtZS5FdmVudC5SZXNvdXJjZVdhc0FkZGVkLCBsaXN0ZW5l cik7CisgICAgICAgICAgICAgICAgICAgICAgICByZXNvbHZlKGV2ZW50LnJlc291cmNlKTsKKyAg ICAgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgIH0pOworICAgICAgICAgICAgfSk7 CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LnBhc3MoIkZvdW5kIHNjcmlwdC4iKTsKKworICAg ICAgICAgICAgbGV0IGJyZWFrcG9pbnQgPSBuZXcgV0kuSmF2YVNjcmlwdEJyZWFrcG9pbnQoc2Ny aXB0LmNyZWF0ZVNvdXJjZUNvZGVMb2NhdGlvbig3LCAwKSk7CisKKyAgICAgICAgICAgIEluc3Bl Y3RvclRlc3QubG9nKCJBZGRpbmcgYnJlYWtwb2ludC4uLiIpOworICAgICAgICAgICAgbGV0IGJy ZWFrcG9pbmdSZXNvbHZlZFN0YXRlRGlkQ2hhbmdlUHJvbWlzZSA9IGJyZWFrcG9pbnQuYXdhaXRF dmVudChXSS5KYXZhU2NyaXB0QnJlYWtwb2ludC5FdmVudC5SZXNvbHZlZFN0YXRlRGlkQ2hhbmdl KTsKKyAgICAgICAgICAgIFdJLmRlYnVnZ2VyTWFuYWdlci5hZGRCcmVha3BvaW50KGJyZWFrcG9p bnQpOworICAgICAgICAgICAgYXdhaXQgYnJlYWtwb2luZ1Jlc29sdmVkU3RhdGVEaWRDaGFuZ2VQ cm9taXNlOworICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5hc3NlcnQoYnJlYWtwb2ludC5yZXNv bHZlZCwgIkJyZWFrcG9pbnQgc2hvdWxkIGJlIHJlc29sdmVkLiIpOworCisgICAgICAgICAgICBJ bnNwZWN0b3JUZXN0LmxvZygiUmVsb2FkaW5nIHBhZ2UuLi4iKTsKKyAgICAgICAgICAgIGF3YWl0 IFByb21pc2UuYWxsKFsKKyAgICAgICAgICAgICAgICBXSS5kZWJ1Z2dlck1hbmFnZXIuYXdhaXRF dmVudChXSS5EZWJ1Z2dlck1hbmFnZXIuRXZlbnQuUGF1c2VkKSwKKyAgICAgICAgICAgICAgICBJ bnNwZWN0b3JUZXN0LnJlbG9hZFBhZ2UoKSwKKyAgICAgICAgICAgIF0pOworICAgICAgICAgICAg SW5zcGVjdG9yVGVzdC5wYXNzKCJQYXVzZWQiKTsKKyAgICAgICAgICAgIGxvZ0FjdGl2ZVN0YWNr VHJhY2UoKTsKKworICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5sb2coIlJlbW92aW5nIGJyZWFr cG9pbnQuLi4iKTsKKyAgICAgICAgICAgIGJyZWFrcG9pbnQucmVtb3ZlKCk7CisKKyAgICAgICAg ICAgIEluc3BlY3RvclRlc3QubG9nKCJSZXN1bWluZy4uLiIpOworICAgICAgICAgICAgYXdhaXQg V0kuZGVidWdnZXJNYW5hZ2VyLnJlc3VtZSgpOworICAgICAgICB9LAorICAgfSk7CisKKyAgIHN1 aXRlLnJ1blRlc3RDYXNlc0FuZEZpbmlzaCgpOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9k eSBvbmxvYWQ9InJ1blRlc3QoKSI+Cis8cD5UZXN0cyBmb3IgYnJlYWtwb2ludCByZXNvbHZpbmcg YmVoYXZpb3IuPC9wPgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aW5zcGVjdG9yL2RlYnVnZ2VyL3Jlc291cmNlcy9uZXN0ZWQtY2FsbHMuanMgYi9MYXlvdXRUZXN0 cy9pbnNwZWN0b3IvZGVidWdnZXIvcmVzb3VyY2VzL25lc3RlZC1jYWxscy5qcwpuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li44NjViMWQ0ODU5MWU2NzZmYjk4N2NhMTI0MGM5NTgwZTgxMGU4ZGNlCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2RlYnVnZ2VyL3Jlc291cmNlcy9uZXN0ZWQtY2Fs bHMuanMKQEAgLTAsMCArMSwxMCBAQAorZnVuY3Rpb24gaW5uZXIoKSB7CisgICAgbGV0IHggPSA0 MjsKKyAgICByZXR1cm4geDsKK30KKworZnVuY3Rpb24gb3V0ZXIoKSB7CisgICAgaW5uZXIoKTsK K30KKworb3V0ZXIoKTsK