217859 2020-10-16 17:55:23 -0700 Web Inspector: REGRESSION(r266480): line-based JavaScript breakpoint tree element titles also show the file name 2020-10-16 18:52:16 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 215747 1 hi hi hi inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1698841 0 hi 2020-10-16 17:55:23 -0700 # STEPS TO REPRODUCE 1. inspect any page with a JavaScript resource 2. set a breakpoint in that JavaScript resource # EXPECTED breakpoint tree element has title of "Line #:#" # ACTUAL breakpoint tree element has title of "<file>:#:#" 1698843 1 411638 hi 2020-10-16 18:05:59 -0700 Created attachment 411638 Patch 1698852 2 ews-feeder 2020-10-16 18:51:01 -0700 Committed r268626: <https://trac.webkit.org/changeset/268626> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411638. 1698853 3 webkit-bug-importer 2020-10-16 18:52:16 -0700 <rdar://problem/70400044> 411638 2020-10-16 18:05:59 -0700 2020-10-16 18:51:02 -0700 Patch bug-217859-20201016180558.patch text/plain 5213 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGFhNmNjZjdlMmMyYzUzYjVmN2FlZDA2ZGYwZWZh YTM0NzU1MDExY2EuLjIwNmU0NTJiN2VkZTJlY2I0ZDhmYjdjNzU5MjMwYTBhMjFiMmNmMTIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDIwLTEwLTE2ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKHIyNjY0ODApOiBsaW5lLWJhc2VkIEphdmFTY3JpcHQgYnJlYWtwb2ludCB0cmVl IGVsZW1lbnQgdGl0bGVzIGFsc28gc2hvdyB0aGUgZmlsZSBuYW1lCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTc4NTkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByMjY2NDgwIGNoYW5nZWQgaXQgc3VjaCB0 aGF0IGBXSS5CcmVha3BvaW50VHJlZUVsZW1lbnRgIHdvdWxkIG9ubHkgY2FsbCBgdXBkYXRlVGl0 bGVzYCBpZgorICAgICAgICB0aGUgY29uc3RydWN0b3Igd2FzIG5vdCBwcm92aWRlZCBhIGB0aXRs ZWAgd2hpbGUgYWxzbyBhZGRpbmcgYSBmYWxsYmFjayBmb3IgYHRpdGxlYCBpbiB0aGUKKyAgICAg ICAgY29uc3RydWN0b3Igb2YgYFdJLkphdmFTY3JpcHRCcmVha3BvaW50VHJlZUVsZW1lbnRgLCBl bnN1cmluZyB0aGF0IGl0IHdvdWxkIGFsd2F5cyBiZSBzZXQKKyAgICAgICAgYnkgdGhlIHRpbWUg aXQgcmVhY2hlZCBgV0kuQnJlYWtwb2ludFRyZWVFbGVtZW50YCwgbWVhbmluZyB0aGF0IGB1cGRh dGVUaXRsZXNgIHdvdWxkIG5ldmVyCisgICAgICAgIGJlIGNhbGxlZC4KKworICAgICAgICBTaW5j ZSBgdXBkYXRlVGl0bGVzYCB3YXMgb25seSBpbXBsZW1lbnRlZCBieSBgV0kuSmF2YVNjcmlwdEJy ZWFrcG9pbnRUcmVlRWxlbWVudGAsIHJlbW92ZQorICAgICAgICBpdCBmcm9tIGBXSS5CcmVha3Bv aW50VHJlZUVsZW1lbnRgIGFuZCBlbnN1cmUgdGhhdCBpdCBpcyBhbHdheXMgY2FsbGVkIGZvciBu b24tc3BlY2lhbAorICAgICAgICBKYXZhU2NyaXB0IGJyZWFrcG9pbnRzIChpbiBhZGRpdGlvbiB0 byB3aGVuZXZlciB0aGUgYFdJLlNvdXJjZUNvZGVMb2NhdGlvbmAgY2hhbmdlcykuCisKKyAgICAg ICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0JyZWFrcG9pbnRUcmVlRWxlbWVudC5qczoKKyAgICAg ICAgKFdJLkJyZWFrcG9pbnRUcmVlRWxlbWVudC5wcm90b3R5cGUudXBkYXRlVGl0bGVzKTogRGVs ZXRlZC4KKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0phdmFTY3JpcHRCcmVha3BvaW50 VHJlZUVsZW1lbnQuanM6CisgICAgICAgIChXSS5KYXZhU2NyaXB0QnJlYWtwb2ludFRyZWVFbGVt ZW50KToKKyAgICAgICAgKFdJLkphdmFTY3JpcHRCcmVha3BvaW50VHJlZUVsZW1lbnQucHJvdG90 eXBlLl91cGRhdGVUaXRsZXMpOiBBZGRlZC4KKyAgICAgICAgKFdJLkphdmFTY3JpcHRCcmVha3Bv aW50VHJlZUVsZW1lbnQucHJvdG90eXBlLl9icmVha3BvaW50TG9jYXRpb25EaWRDaGFuZ2UpOgor ICAgICAgICAoV0kuSmF2YVNjcmlwdEJyZWFrcG9pbnRUcmVlRWxlbWVudC5wcm90b3R5cGUudXBk YXRlVGl0bGVzKTogRGVsZXRlZC4KKwogMjAyMC0xMC0xNCAgRGV2aW4gUm91c3NvICA8ZHJvdXNz b0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTihyMjY3MTQ4 KTogbmV3IEJpZyBTdXIgc3R5bGVzIGFyZSBub3QgdXNlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQnJlYWtwb2ludFRyZWVFbGVtZW50Lmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQnJlYWtwb2ludFRy ZWVFbGVtZW50LmpzCmluZGV4IDYyNTI1ZTNiNGUwODY0ZTE3YWQzMzg5M2Y1ZDE1NzM1MmI2OGFk MzcuLjJhMjFiMTlkOWU2ODQzNjA0NDU4MWMyYzdkNmFjOWIxZGFkNDQ4NTQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0JyZWFrcG9pbnRUcmVl RWxlbWVudC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9CcmVha3BvaW50VHJlZUVsZW1lbnQuanMKQEAgLTU0LDggKzU0LDYgQEAgV0kuQnJlYWtwb2lu dFRyZWVFbGVtZW50ID0gY2xhc3MgQnJlYWtwb2ludFRyZWVFbGVtZW50IGV4dGVuZHMgV0kuR2Vu ZXJhbFRyZWVFbGUKICAgICAgICAgdGhpcy5fbGlzdGVuZXJTZXQucmVnaXN0ZXIodGhpcy5zdGF0 dXMsICJtb3VzZWRvd24iLCB0aGlzLl9zdGF0dXNJbWFnZUVsZW1lbnRNb3VzZURvd24pOwogICAg ICAgICB0aGlzLl9saXN0ZW5lclNldC5yZWdpc3Rlcih0aGlzLnN0YXR1cywgImNsaWNrIiwgdGhp cy5fc3RhdHVzSW1hZ2VFbGVtZW50Q2xpY2tlZCk7CiAKLSAgICAgICAgaWYgKCF0aXRsZSkKLSAg ICAgICAgICAgIHRoaXMudXBkYXRlVGl0bGVzKCk7CiAgICAgICAgIHRoaXMudXBkYXRlU3RhdHVz KCk7CiAKICAgICAgICAgdGhpcy5faWNvbkFuaW1hdGlvbkxheWVyRWxlbWVudCA9IGRvY3VtZW50 LmNyZWF0ZUVsZW1lbnQoInNwYW4iKTsKQEAgLTE0NSwxMSArMTQzLDYgQEAgV0kuQnJlYWtwb2lu dFRyZWVFbGVtZW50ID0gY2xhc3MgQnJlYWtwb2ludFRyZWVFbGVtZW50IGV4dGVuZHMgV0kuR2Vu ZXJhbFRyZWVFbGUKICAgICAgICAgICAgIHRoaXMuc3RhdHVzLmNsYXNzTGlzdC50b2dnbGUoV0ku QnJlYWtwb2ludFRyZWVFbGVtZW50LlN0YXR1c0ltYWdlQXV0b0NvbnRpbnVlU3R5bGVDbGFzc05h bWUsIHRoaXMuX2JyZWFrcG9pbnQuYXV0b0NvbnRpbnVlKTsKICAgICB9CiAKLSAgICB1cGRhdGVU aXRsZXMoKQotICAgIHsKLSAgICAgICAgLy8gT3ZlcnJpZGRlbiBieSBzdWJjbGFzc2VzIGlmIG5l ZWRlZC4KLSAgICB9Ci0KICAgICAvLyBQcml2YXRlCiAKICAgICBfYWRkUHJvYmVTZXQocHJvYmVT ZXQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9KYXZhU2NyaXB0QnJlYWtwb2ludFRyZWVFbGVtZW50LmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvSmF2YVNjcmlwdEJyZWFrcG9pbnRUcmVlRWxlbWVudC5q cwppbmRleCBiYmNkZWQ0NDQwOTllZTQyOGY0NDc2YTU1MjA1NmFiYTFlNjA0MDY5Li43ZGU3ZjQx ZDIzYTBlZDMzYTRmMWEyNWQ1YjNhYTdlOTY5OTdhMTAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9KYXZhU2NyaXB0QnJlYWtwb2ludFRyZWVF bGVtZW50LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0phdmFTY3JpcHRCcmVha3BvaW50VHJlZUVsZW1lbnQuanMKQEAgLTMzLDEzICszMywxNSBAQCBX SS5KYXZhU2NyaXB0QnJlYWtwb2ludFRyZWVFbGVtZW50ID0gY2xhc3MgSmF2YVNjcmlwdEJyZWFr cG9pbnRUcmVlRWxlbWVudCBleHRlbgogICAgICAgICAgICAgY2xhc3NOYW1lcyA9IFsibGluZSJd OwogICAgICAgICBjbGFzc05hbWVzLnB1c2goImphdmFzY3JpcHQiKTsKIAotICAgICAgICBpZiAo IXRpdGxlKQorICAgICAgICBpZiAoIXRpdGxlICYmIGJyZWFrcG9pbnQuc3BlY2lhbCkKICAgICAg ICAgICAgIHRpdGxlID0gYnJlYWtwb2ludC5kaXNwbGF5TmFtZTsKIAogICAgICAgICBzdXBlcihi cmVha3BvaW50LCB7Y2xhc3NOYW1lcywgdGl0bGV9KTsKIAotICAgICAgICBpZiAoIWJyZWFrcG9p bnQuc3BlY2lhbCkKKyAgICAgICAgaWYgKCFicmVha3BvaW50LnNwZWNpYWwpIHsKICAgICAgICAg ICAgIHRoaXMubGlzdGVuZXJTZXQucmVnaXN0ZXIoYnJlYWtwb2ludCwgV0kuSmF2YVNjcmlwdEJy ZWFrcG9pbnQuRXZlbnQuTG9jYXRpb25EaWRDaGFuZ2UsIHRoaXMuX2JyZWFrcG9pbnRMb2NhdGlv bkRpZENoYW5nZSk7CisgICAgICAgICAgICB0aGlzLl91cGRhdGVUaXRsZXMoKTsKKyAgICAgICAg fQogICAgICAgICB0aGlzLmxpc3RlbmVyU2V0LnJlZ2lzdGVyKGJyZWFrcG9pbnQsIFdJLkphdmFT Y3JpcHRCcmVha3BvaW50LkV2ZW50LlJlc29sdmVkU3RhdGVEaWRDaGFuZ2UsIHRoaXMudXBkYXRl U3RhdHVzKTsKICAgICB9CiAKQEAgLTYyLDEwICs2NCwxMCBAQCBXSS5KYXZhU2NyaXB0QnJlYWtw b2ludFRyZWVFbGVtZW50ID0gY2xhc3MgSmF2YVNjcmlwdEJyZWFrcG9pbnRUcmVlRWxlbWVudCBl eHRlbgogICAgICAgICB0aGlzLnN0YXR1cy5jbGFzc0xpc3QudG9nZ2xlKCJyZXNvbHZlZCIsIHRo aXMuYnJlYWtwb2ludC5yZXNvbHZlZCAmJiBXSS5kZWJ1Z2dlck1hbmFnZXIuYnJlYWtwb2ludHNF bmFibGVkKTsKICAgICB9CiAKLSAgICB1cGRhdGVUaXRsZXMoKQotICAgIHsKLSAgICAgICAgc3Vw ZXIudXBkYXRlVGl0bGVzKCk7CisgICAgLy8gUHJpdmF0ZQogCisgICAgX3VwZGF0ZVRpdGxlcygp CisgICAgewogICAgICAgICBjb25zb2xlLmFzc2VydCghdGhpcy5icmVha3BvaW50LnNwZWNpYWwp OwogCiAgICAgICAgIGxldCBzb3VyY2VDb2RlTG9jYXRpb24gPSB0aGlzLmJyZWFrcG9pbnQuc291 cmNlQ29kZUxvY2F0aW9uOwpAQCAtODksOCArOTEsNiBAQCBXSS5KYXZhU2NyaXB0QnJlYWtwb2lu dFRyZWVFbGVtZW50ID0gY2xhc3MgSmF2YVNjcmlwdEJyZWFrcG9pbnRUcmVlRWxlbWVudCBleHRl bgogICAgICAgICB9CiAgICAgfQogCi0gICAgLy8gUHJpdmF0ZQotCiAgICAgX2JyZWFrcG9pbnRM b2NhdGlvbkRpZENoYW5nZShldmVudCkKICAgICB7CiAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KGV2 ZW50LnRhcmdldCA9PT0gdGhpcy5icmVha3BvaW50KTsKQEAgLTk5LDYgKzk5LDYgQEAgV0kuSmF2 YVNjcmlwdEJyZWFrcG9pbnRUcmVlRWxlbWVudCA9IGNsYXNzIEphdmFTY3JpcHRCcmVha3BvaW50 VHJlZUVsZW1lbnQgZXh0ZW4KICAgICAgICAgaWYgKGV2ZW50LmRhdGEub2xkRGlzcGxheVNvdXJj ZUNvZGUgPT09IHRoaXMuYnJlYWtwb2ludC5kaXNwbGF5U291cmNlQ29kZSkKICAgICAgICAgICAg IHJldHVybjsKIAotICAgICAgICB0aGlzLnVwZGF0ZVRpdGxlcygpOworICAgICAgICB0aGlzLl91 cGRhdGVUaXRsZXMoKTsKICAgICB9CiB9Owo=