21784 2008-10-22 00:14:52 -0700 [GTK] Make layout tests / jsc tests usable without build-webkit 2009-04-27 08:10:11 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Gtk P2 Minor --- 1 alp webkit-unassigned mrowe oldest_to_newest 96142 0 alp 2008-10-22 00:14:52 -0700 The build-webkit script is rarely used by GTK+ port developers as the port uses autotools. The DRT and JavaScriptCore test drivers currently expect the built products (binaries) to be where build-webkit puts them, which is fine and useful for the build bot harness. This is not a good default for most developers though. I've had some success with this command line: ~/Projects/webkit/ng/build$ ../webkit/WebKitTools/Scripts/run-webkit-tests --root=. --gtk --strict I don't remember the command to run the JS tests off hand, but it was similar. This is probably very non-obvious to casual WebKit GTK+ contributors (and distribution packagers, for whom we need to make it really easy to run the tests before they ship their binaries). I think the output directory of results was also not ideal (maybe it was littering srcdir?). We need to modify the scripts to make this more obvious and/or document the correct invocation of the commands for this use case. 96640 1 alp 2008-10-24 22:50:09 -0700 I can't actually get run-webkit-tests to work at all right now. The gtk/DumpRenderTree binary works fine when invoked directly, but the run-webkit-tests perl script seems not to be working. One guess is that it's scrubbing important environment variables that need to be defined. 96641 2 alp 2008-10-24 22:56:44 -0700 (In reply to comment #1) > I can't actually get run-webkit-tests to work at all right now. The > gtk/DumpRenderTree binary works fine when invoked directly, but the > run-webkit-tests perl script seems not to be working. One guess is that it's > scrubbing important environment variables that need to be defined. > It works with webkitdirs.pm and run-webkit-tests from r35816, so appears to be a regression that showed up in the perl scripts since 2008-08-18. 114599 3 28810 jmalonzo 2009-03-20 16:50:26 -0700 Created attachment 28810 set the product dir to the value of WEBKITOUTPUTDIR This requires WEBKITOUTPUTDIR pointed to the location of the build directory - doesn't work with relative paths currently. e.g. WEBKITOUTPUTDIR=~/WebKit/build ./WebKitTools/Scripts/run-webkit-tests --gtk ..... 118968 4 28810 gustavo 2009-04-27 06:43:43 -0700 Comment on attachment 28810 set the product dir to the value of WEBKITOUTPUTDIR Like I said on IRC, as long as this keeps working with build-webkit builds, r=me, with a less confusing comment ;D. 118978 5 jmalonzo 2009-04-27 08:10:11 -0700 Landed in r42891 28810 2009-03-20 16:50:26 -0700 2009-04-27 06:43:43 -0700 set the product dir to the value of WEBKITOUTPUTDIR runningtestsautotoolsbuild.patch text/plain 1569 jmalonzo ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjY2FmYmViLi40YWUzYTQ0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDMt MjAgIEphbiBNaWNoYWVsIEFsb256byAgPGptYWxvbnpvQHdlYmtpdC5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gTWFrZSBsYXlvdXQg dGVzdHMgLyBqc2MgdGVzdHMgdXNhYmxlIHdpdGhvdXQgYnVpbGQtd2Via2l0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTc4NAorCisgICAgICAgIFRo aXMgcmVxdWlyZXMgV0VCS0lUT1VUUFVURElSIHRvIGJlIHNldCB0byB0aGUgYnVpbGQgZGlyZWN0 b3J5LgorICAgICAgICBTZXQgdGhlIGxvY2F0aW9uIG9mIHRoZSBwcm9kdWN0IGRpciB0byB0aGUg bG9jYXRpb24gcG9pbnRlZCB0byBieSBXRUJLSVRPVVRQVVRESVIKKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0ZGlycy5wbToKKwogMjAwOS0wMy0yMCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJz Y2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IGY5ZjA1ZDMuLmNkMDliZmMgMTAwNjQ0Ci0tLSBhL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdGRpcnMucG0KQEAgLTIyOCw3ICsyMjgsMTQgQEAgc3ViIGRldGVybWluZUNvbmZpZ3Vy YXRpb25Qcm9kdWN0RGlyCiAgICAgaWYgKGlzQXBwbGVXaW5XZWJLaXQoKSAmJiAhaXNXeCgpKSB7 CiAgICAgICAgICRjb25maWd1cmF0aW9uUHJvZHVjdERpciA9ICIkYmFzZVByb2R1Y3REaXIvYmlu IjsKICAgICB9IGVsc2UgewotICAgICAgICAkY29uZmlndXJhdGlvblByb2R1Y3REaXIgPSAiJGJh c2VQcm9kdWN0RGlyLyRjb25maWd1cmF0aW9uIjsKKyAgICAgICAgIyBbR3RrXSBXZSBkb24ndCB1 c2UgUmVsZWFzZS9EZWJ1ZyBpbiBzdHJhaWdodCBhdXRvdG9vbCBidWlsZHMgKG5vbiBidWlsZC13 ZWJraXQpCisgICAgICAgICMgc28gbWFrZSB0aGUgY29uZmlndXJhdGlvblByb2R1Y3REaXIgdGhl IHNhbWUgYXMgdGhlIGJhc2VQcm9kdWN0RGlyCisgICAgICAgICMgYmFzZVByb2R1Y3REaXIgPSAk RU5WeyJXRUJLSVRPVVRQVVRESVIifSBpZiBleGlzdHMKKyAgICAgICAgaWYgKCRFTlZ7IldFQktJ VE9VVFBVVERJUiJ9ICYmIGlzR3RrKCkpIHsKKyAgICAgICAgICAgICRjb25maWd1cmF0aW9uUHJv ZHVjdERpciA9ICIkYmFzZVByb2R1Y3REaXIiOworICAgICAgICB9IGVsc2UgeworICAgICAgICAg ICAgJGNvbmZpZ3VyYXRpb25Qcm9kdWN0RGlyID0gIiRiYXNlUHJvZHVjdERpci8kY29uZmlndXJh dGlvbiI7CisgICAgICAgIH0KICAgICB9CiB9CiAK