217818 2020-10-16 05:43:43 -0700 sdpFmtLine should be missing from RTCRtpCodecCapability instead of being an empty string 2020-10-16 09:31:48 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf darin eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw webkit-bug-importer youennf oldest_to_newest 1698550 0 youennf 2020-10-16 05:43:43 -0700 sdpFmtLine should be missing from RTCRtpCodecCapability instead of being an empty string 1698551 1 youennf 2020-10-16 05:44:15 -0700 This makes https://webrtc.github.io/samples/src/content/peerconnection/change-codecs/ failing 1698552 2 411561 youennf 2020-10-16 05:45:49 -0700 Created attachment 411561 Patch 1698613 3 ews-feeder 2020-10-16 08:38:34 -0700 Committed r268592: <https://trac.webkit.org/changeset/268592> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411561. 1698614 4 webkit-bug-importer 2020-10-16 08:39:19 -0700 <rdar://problem/70379088> 1698640 5 411561 darin 2020-10-16 09:31:48 -0700 Comment on attachment 411561 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411561&action=review > Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:415 > + sdpFmtpLine = sdpFmtpLineBuilder.toString(); In future, for cases like this I think we might want to add a nullIfEmpty function that takes a String&& and returns a String. Seems a shame to add a local variable just for this transformation. Although that "llIf" sequence makes the function name ugly. 411561 2020-10-16 05:45:49 -0700 2020-10-16 08:38:34 -0700 Patch bug-217818-20201016144546.patch text/plain 4308 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4NTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWRiZWQzZmE0YzYxYjEw MGY3MzEyZTQ3MjMyOGFhMjIxNjIwY2RjMi4uZWQxMzg1YjQ3NDFiYTM1ZDVhODcxYTY5Y2E5YzVi NTJkNjljNTU4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTEwLTE2ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBzZHBGbXRMaW5lIHNob3Vs ZCBiZSBtaXNzaW5nIGZyb20gUlRDUnRwQ29kZWNDYXBhYmlsaXR5IGluc3RlYWQgb2YgYmVpbmcg YW4gZW1wdHkgc3RyaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMTc4MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBDb3ZlcmVkIGJ5IHVwZGF0ZWQgdGVzdC4KKworICAgICAgICAqIHBsYXRmb3JtL21l ZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQcm92aWRlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjp0b1JUQ1J0cENhcGFiaWxpdGllcyk6CisgICAgICAgIElmIGxpbmUgaXMgZW1wdHksIG1h a2Ugc3VyZSB0byByZXR1cm4gYSBudWxsIHN0cmluZyBpbnN0ZWFkLgorCiAyMDIwLTEwLTE2ICBZ b3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJSVEMgVlA5IERl Y29kZXIgc2hvdWxkIGJlIGFibGUgdG8gdXNlIFZUQgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1Byb3ZpZGVyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQ cm92aWRlci5jcHAKaW5kZXggNmMwZGJiMWUwYjJhMDhlNzE4NDY1Yzk0ZmI0YTdiYjBmMjk4NjM5 OC4uYzRmOWE5ZGIyODRmYzM4Njc0Y2E4ODVlOWEwMTE2NmUxODIzZjlhNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1By b3ZpZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3 ZWJydGMvTGliV2ViUlRDUHJvdmlkZXIuY3BwCkBAIC00MDQsMTMgKzQwNCwxNiBAQCBzdGF0aWMg aW5saW5lIFJUQ1J0cENhcGFiaWxpdGllcyB0b1JUQ1J0cENhcGFiaWxpdGllcyhjb25zdCB3ZWJy dGM6OlJ0cENhcGFiaWxpdAogCiAgICAgY2FwYWJpbGl0aWVzLmNvZGVjcy5yZXNlcnZlSW5pdGlh bENhcGFjaXR5KHJ0cENhcGFiaWxpdGllcy5jb2RlY3Muc2l6ZSgpKTsKICAgICBmb3IgKGF1dG8m IGNvZGVjIDogcnRwQ2FwYWJpbGl0aWVzLmNvZGVjcykgewotICAgICAgICBTdHJpbmdCdWlsZGVy IHNkcEZtdHBMaW5lOworICAgICAgICBTdHJpbmdCdWlsZGVyIHNkcEZtdHBMaW5lQnVpbGRlcjsK ICAgICAgICAgYm9vbCBoYXNQYXJhbWV0ZXIgPSBmYWxzZTsKICAgICAgICAgZm9yIChhdXRvJiBw YXJhbWV0ZXIgOiBjb2RlYy5wYXJhbWV0ZXJzKSB7Ci0gICAgICAgICAgICBzZHBGbXRwTGluZS5h cHBlbmQoaGFzUGFyYW1ldGVyID8gIjsiIDogIiIsIFN0cmluZ1ZpZXcocGFyYW1ldGVyLmZpcnN0 LmRhdGEoKSwgcGFyYW1ldGVyLmZpcnN0Lmxlbmd0aCgpKSwgJz0nLCBTdHJpbmdWaWV3KHBhcmFt ZXRlci5zZWNvbmQuZGF0YSgpLCBwYXJhbWV0ZXIuc2Vjb25kLmxlbmd0aCgpKSk7CisgICAgICAg ICAgICBzZHBGbXRwTGluZUJ1aWxkZXIuYXBwZW5kKGhhc1BhcmFtZXRlciA/ICI7IiA6ICIiLCBT dHJpbmdWaWV3KHBhcmFtZXRlci5maXJzdC5kYXRhKCksIHBhcmFtZXRlci5maXJzdC5sZW5ndGgo KSksICc9JywgU3RyaW5nVmlldyhwYXJhbWV0ZXIuc2Vjb25kLmRhdGEoKSwgcGFyYW1ldGVyLnNl Y29uZC5sZW5ndGgoKSkpOwogICAgICAgICAgICAgaGFzUGFyYW1ldGVyID0gdHJ1ZTsKICAgICAg ICAgfQotICAgICAgICBjYXBhYmlsaXRpZXMuY29kZWNzLnVuY2hlY2tlZEFwcGVuZChSVENSdHBD b2RlY0NhcGFiaWxpdHkgeyBmcm9tU3RkU3RyaW5nKGNvZGVjLm1pbWVfdHlwZSgpKSwgc3RhdGlj X2Nhc3Q8dWludDMyX3Q+KGNvZGVjLmNsb2NrX3JhdGUgPyAqY29kZWMuY2xvY2tfcmF0ZSA6IDAp LCB0b0NoYW5uZWxzKGNvZGVjLm51bV9jaGFubmVscyksIHNkcEZtdHBMaW5lLnRvU3RyaW5nKCkg fSk7CisgICAgICAgIFN0cmluZyBzZHBGbXRwTGluZTsKKyAgICAgICAgaWYgKHNkcEZtdHBMaW5l QnVpbGRlci5sZW5ndGgoKSkKKyAgICAgICAgICAgIHNkcEZtdHBMaW5lID0gc2RwRm10cExpbmVC dWlsZGVyLnRvU3RyaW5nKCk7CisgICAgICAgIGNhcGFiaWxpdGllcy5jb2RlY3MudW5jaGVja2Vk QXBwZW5kKFJUQ1J0cENvZGVjQ2FwYWJpbGl0eSB7IGZyb21TdGRTdHJpbmcoY29kZWMubWltZV90 eXBlKCkpLCBzdGF0aWNfY2FzdDx1aW50MzJfdD4oY29kZWMuY2xvY2tfcmF0ZSA/ICpjb2RlYy5j bG9ja19yYXRlIDogMCksIHRvQ2hhbm5lbHMoY29kZWMubnVtX2NoYW5uZWxzKSwgV1RGTW92ZShz ZHBGbXRwTGluZSkgfSk7CiAgICAgfQogCiAgICAgY2FwYWJpbGl0aWVzLmhlYWRlckV4dGVuc2lv bnMucmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShydHBDYXBhYmlsaXRpZXMuaGVhZGVyX2V4dGVuc2lv bnMuc2l6ZSgpKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwppbmRleCBlYTM2NDExOWIzYzk3NGRjOGUxNjJiZmU1OWQ2MDk3ZWQwMTVj NDU1Li44MTA0MDRhNzllNjYzNWJmZDM2N2M1MDViOWUwNzg3Yzk4Yjk1OWQ4IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTIgQEAKKzIwMjAtMTAtMTYgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29t PgorCisgICAgICAgIHNkcEZtdExpbmUgc2hvdWxkIGJlIG1pc3NpbmcgZnJvbSBSVENSdHBDb2Rl Y0NhcGFiaWxpdHkgaW5zdGVhZCBvZiBiZWluZyBhbiBlbXB0eSBzdHJpbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzgxOAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2VicnRjL3ZpZGVvLW11dGUt dnA4Lmh0bWw6CisKIDIwMjAtMTAtMTYgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29t PgogCiAgICAgICAgIFdlYlJUQyBWUDkgRGVjb2RlciBzaG91bGQgYmUgYWJsZSB0byB1c2UgVlRC CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93ZWJydGMvdmlkZW8tbXV0ZS12cDguaHRtbCBiL0xh eW91dFRlc3RzL3dlYnJ0Yy92aWRlby1tdXRlLXZwOC5odG1sCmluZGV4IDBiMTE1ZDUzMmQ0ZTRh YjA3NjlhNjQyZjcyNDRiYzVkYWMwN2VhYjUuLjRmYWRjZGE2YjkyMjk5MjRjODc5ODJmZDY1N2Q3 NjEyNTI0OTYwMDQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3dlYnJ0Yy92aWRlby1tdXRlLXZw OC5odG1sCisrKyBiL0xheW91dFRlc3RzL3dlYnJ0Yy92aWRlby1tdXRlLXZwOC5odG1sCkBAIC0y MCw3ICsyMCwxMiBAQCBwcm9taXNlX3Rlc3QoYXN5bmMgKHRlc3QpID0+IHsKICAgICAgICAgd2lu ZG93LmludGVybmFscy5jbGVhclBlZXJDb25uZWN0aW9uRmFjdG9yeSgpOwogCiAgICAgY29uc3Qg Y29kZWNzID0gUlRDUnRwU2VuZGVyLmdldENhcGFiaWxpdGllcygidmlkZW8iKS5jb2RlY3M7Ci0g ICAgYXNzZXJ0X3RydWUoY29kZWNzLnNvbWUoKGNvZGVjKSA9PiB7IHJldHVybiBjb2RlYy5taW1l VHlwZS5pbmRleE9mKCJWUDgiKSB9KSwgIlZQOCBpcyBsaXN0ZWQgYXMgYSBjb2RlYyIpOworICAg IGFzc2VydF90cnVlKGNvZGVjcy5zb21lKChjb2RlYykgPT4geyByZXR1cm4gY29kZWMubWltZVR5 cGUuaW5kZXhPZigiVlA4IikgPj0gMCB9KSwgIlZQOCBpcyBsaXN0ZWQgYXMgYSBjb2RlYyIpOwor CisgICAgY29kZWNzLmZvckVhY2goKGNvZGVjKSA9PiB7CisgICAgICAgaWYgKGNvZGVjLm1pbWVU eXBlLmluZGV4T2YoIlZQOCIpID49MCkKKyAgICAgICAgICAgYXNzZXJ0X2VxdWFscyhjb2RlYy5z ZHBGbXRwTGluZSwgdW5kZWZpbmVkLCAiVlA4IGNvZGVjLnNkcEZtdHBMaW5lIGlzIHVuZGVmaW5l ZCIpOworICAgIH0pOwogCiAgICAgY29uc3QgcGMgPSBuZXcgUlRDUGVlckNvbm5lY3Rpb24oKTsK ICAgICBwYy5hZGRUcmFuc2NlaXZlcigidmlkZW8iKTsK