217799 2020-10-15 18:08:12 -0700 [Flatpak SDK] flatpakutils.py reports "KeyError: 'gcc'" error if using with icecc and toolchains aren't generated yet 2020-10-17 01:17:20 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii pnormand pnormand webkit-bug-importer oldest_to_newest 1698416 0 fujii 2020-10-15 18:08:12 -0700 [Flatpak SDK] flatpakutils.py reports "KeyError: 'gcc'" error if using with icecc and toolchains aren't generated yet I'm using icecc. $ env | grep -i icecc CCACHE_PREFIX=icecc ICECC_SCHEDULER={my scheduler ip addr} build-webkit reports the following unfriendly error message: $ ./Tools/Scripts/build-webkit --gtk --release Building flatpak based environment Traceback (most recent call last): File "/home/fujii/webkit/gb/Tools/Scripts/webkit-flatpak", line 28, in <module> sys.exit(WebkitFlatpak.load_from_args().run()) File "/home/fujii/webkit/gb/Tools/flatpak/flatpakutils.py", line 897, in run return self.main() File "/home/fujii/webkit/gb/Tools/flatpak/flatpakutils.py", line 886, in main result = self.setup_dev_env() File "/home/fujii/webkit/gb/Tools/flatpak/flatpakutils.py", line 978, in setup_dev_env return self.run_in_sandbox(*self.user_command) File "/home/fujii/webkit/gb/Tools/flatpak/flatpakutils.py", line 822, in run_in_sandbox toolchain_path = self.icc_version[toolchain_name] KeyError: 'gcc' $ WebKitBuild/UserFlatpak/webkit_flatpak_config.json is not generated. Manually invoking Tools/Scripts/webkit-flatpak --regenerate-toolchains solves the issue. 1698498 1 411546 pnormand 2020-10-16 01:32:59 -0700 Created attachment 411546 Patch 1698731 2 411546 fujii 2020-10-16 13:38:45 -0700 Comment on attachment 411546 Patch Thank you. 1698926 3 ews-feeder 2020-10-17 01:16:17 -0700 Committed r268639: <https://trac.webkit.org/changeset/268639> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411546. 1698927 4 webkit-bug-importer 2020-10-17 01:17:20 -0700 <rdar://problem/70404732> 411546 2020-10-16 01:32:59 -0700 2020-10-17 01:16:17 -0700 Patch bug-217799-20201016013258.patch text/plain 1782 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4NTc1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmZjOWE5NGNiMzBjY2NiNWY1ODQ3NzdjOGZkNWVhMjM2 MTU2ZmQxZi4uYmI4NjY2NDBlMjNlOGJkZTg5ZTJiMTRmMzlmNDNkMWZkNDA0Y2FlMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIwLTEwLTE2ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbRmxhdHBhayBTREtdIGZsYXRwYWt1dGlscy5weSByZXBvcnRzICJLZXlFcnJv cjogJ2djYyciIGVycm9yIGlmIHVzaW5nIHdpdGggaWNlY2MgYW5kIHRvb2xjaGFpbnMgYXJlbid0 IGdlbmVyYXRlZCB5ZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIxNzc5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogZmxhdHBhay9mbGF0cGFrdXRpbHMucHk6CisgICAgICAgIChXZWJraXRGbGF0cGFr LnJ1bl9pbl9zYW5kYm94KTogR3JhY2VmdWxseSBleGl0IHdpdGggYW4gZXJyb3IgbWVzc2FnZSB3 aGVuIHRoZSBpY2VjYworICAgICAgICBjb25maWd1cmF0aW9uIGZhaWxlZCB0byBjb21wbGV0ZS4K KwogMjAyMC0xMC0xNSAgU2FtIFdlaW5pZyAgPHdlaW5pZ0BhcHBsZS5jb20+CiAKICAgICAgICAg QXR0ZW1wdCB0byBmaXggdGhlIGJ1aWxkLgpkaWZmIC0tZ2l0IGEvVG9vbHMvZmxhdHBhay9mbGF0 cGFrdXRpbHMucHkgYi9Ub29scy9mbGF0cGFrL2ZsYXRwYWt1dGlscy5weQppbmRleCBjMjgwODU2 MGNmN2JmMThiZjM0ZmRjNGI1NDM2YWRmZWI0NWNjNjc4Li4xMzFhNTM5OGFkYjQ4YzY5Nzg2Nzk3 ZTA4OTBlMWM1NzlmODM5ODJlIDEwMDY0NAotLS0gYS9Ub29scy9mbGF0cGFrL2ZsYXRwYWt1dGls cy5weQorKysgYi9Ub29scy9mbGF0cGFrL2ZsYXRwYWt1dGlscy5weQpAQCAtODE5LDcgKzgxOSwx MSBAQCBjbGFzcyBXZWJraXRGbGF0cGFrOgogICAgICAgICAgICAgbl9jb3JlcyA9IG11bHRpcHJv Y2Vzc2luZy5jcHVfY291bnQoKSAqIDMKICAgICAgICAgICAgIF9sb2cuZGVidWcoJ0ZvbGxvd2lu ZyBpY2VjcmVhbSByZWNvbW1lbmRhdGlvbiBmb3IgdGhlIG51bWJlciBvZiBjb3JlcyB0byB1c2U6 ICVkJyAlIG5fY29yZXMpCiAgICAgICAgICAgICB0b29sY2hhaW5fbmFtZSA9IG9zLmVudmlyb24u Z2V0KCJDQyIsICJnY2MiKQotICAgICAgICAgICAgdG9vbGNoYWluX3BhdGggPSBzZWxmLmljY192 ZXJzaW9uW3Rvb2xjaGFpbl9uYW1lXQorICAgICAgICAgICAgdHJ5OgorICAgICAgICAgICAgICAg IHRvb2xjaGFpbl9wYXRoID0gc2VsZi5pY2NfdmVyc2lvblt0b29sY2hhaW5fbmFtZV0KKyAgICAg ICAgICAgIGV4Y2VwdCBLZXlFcnJvcjoKKyAgICAgICAgICAgICAgICBDb25zb2xlLmVycm9yX21l c3NhZ2UoIlRvb2xjaGFpbnMgY29uZmlndXJhdGlvbiBub3QgZm91bmQuIFBsZWFzZSBydW4gd2Vi a2l0LWZsYXRwYWsgLXIiKQorICAgICAgICAgICAgICAgIHJldHVybiAxCiAgICAgICAgICAgICBp ZiBub3Qgb3MucGF0aC5pc2ZpbGUodG9vbGNoYWluX3BhdGgpOgogICAgICAgICAgICAgICAgIENv bnNvbGUuZXJyb3JfbWVzc2FnZSgiJXMgaXMgbm90IGEgdmFsaWQgSWNlQ0MgdG9vbGNoYWluLiBQ bGVhc2UgcnVuIHdlYmtpdC1mbGF0cGFrIC1yIiwgdG9vbGNoYWluX3BhdGgpCiAgICAgICAgICAg ICAgICAgcmV0dXJuIDEK