217791 2020-10-15 15:53:44 -0700 PDFPlugin.mm:2303:139: error: type 'SEL _Nullable' cannot be narrowed to 'bool' in initializer list [-Wc++11-narrowing] 2020-10-15 17:06:22 -0700 1 1 1 Unclassified WebKit PDF Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer beidson thorton webkit-bug-importer oldest_to_newest 1698328 0 ddkilzer 2020-10-15 15:53:44 -0700 Issue found by open source clang: In file included from WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource55-mm.mm:3: Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:2303:139: error: type 'SEL _Nullable' cannot be narrowed to 'bool' in initializer list [-Wc++11-narrowing] PDFContextMenuItem menuItem { String([item title]), !![item isEnabled], !![item isSeparatorItem], static_cast<int>([item state]), [item action], i }; ^~~~~~~~~~~~~ Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:2303:139: note: insert an explicit cast to silence this issue PDFContextMenuItem menuItem { String([item title]), !![item isEnabled], !![item isSeparatorItem], static_cast<int>([item state]), [item action], i }; ^~~~~~~~~~~~~ static_cast<bool>( ) <rdar://problem/70349804> 1698331 1 411502 ddkilzer 2020-10-15 15:56:49 -0700 Created attachment 411502 Patch v1 1698385 2 ews-feeder 2020-10-15 17:06:21 -0700 Committed r268562: <https://trac.webkit.org/changeset/268562> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411502. 411502 2020-10-15 15:56:49 -0700 2020-10-15 17:06:22 -0700 Patch v1 bug-217791-20201015160023.patch text/plain 1786 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4NDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZlNGY2NThjMzY0NWMxNzIx NDRiYWRlYzY5NjdkYTA5NWE1MGMxNGIuLmFiMDU0Yjc3ZWUzNTdlYjIxZTM1NzMzYjY0NDRkYjg5 ZWNiY2U3YzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMTAtMTUgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBQREZQbHVnaW4ubW06MjMwMzox Mzk6IGVycm9yOiB0eXBlICdTRUwgX051bGxhYmxlJyBjYW5ub3QgYmUgbmFycm93ZWQgdG8gJ2Jv b2wnIGluIGluaXRpYWxpemVyIGxpc3QgWy1XYysrMTEtbmFycm93aW5nXQorICAgICAgICA8aHR0 cHM6Ly93ZWJraXQub3JnL2IvMjE3NzkxPgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzAzNDk4 MDQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBX ZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5tbToKKyAgICAgICAgKFdlYktpdDo6UERG UGx1Z2luOjpoYW5kbGVDb250ZXh0TWVudUV2ZW50KToKKyAgICAgICAgLSBVc2UgYCEhYCB0byBj b252ZXJ0IHJlc3VsdCB0byBgYm9vbGAuCisKIDIwMjAtMTAtMTUgIERhdmlkIEtpbHplciAgPGRk a2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICB2MjogV2ViS2l0OjpYUENTZXJ2aWNlRXZlbnRI YW5kbGVyIGJsb2NrIHNob3VsZCBjYWxsIGV4aXQoKSBvbiB0aGUgbWFpbiB0aHJlYWQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4ubW0g Yi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1Z2luLm1tCmluZGV4 IGZiNjAyNmEwMGY3OWU1ZDIyZGQxYmNiZGMxNmE0OThhNWU0YjZkZTcuLmZkMjc3Y2JjNTEzMWI1 YjYyNmFmMmE5N2I0ZjUxNjdhOWJlMTM1YWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4ubW0KKysrIGIvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5tbQpAQCAtMjMwMCw3ICsyMzAwLDcgQEAgYm9v bCBQREZQbHVnaW46OmhhbmRsZUNvbnRleHRNZW51RXZlbnQoY29uc3QgV2ViTW91c2VFdmVudCYg ZXZlbnQpCiAgICAgICAgIGF1dG8gaXRlbSA9IFtuc01lbnUgaXRlbUF0SW5kZXg6aV07CiAgICAg ICAgIGlmIChbaXRlbSBzdWJtZW51XSkKICAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICBQ REZDb250ZXh0TWVudUl0ZW0gbWVudUl0ZW0geyBTdHJpbmcoW2l0ZW0gdGl0bGVdKSwgISFbaXRl bSBpc0VuYWJsZWRdLCAhIVtpdGVtIGlzU2VwYXJhdG9ySXRlbV0sIHN0YXRpY19jYXN0PGludD4o W2l0ZW0gc3RhdGVdKSwgW2l0ZW0gYWN0aW9uXSwgaSB9OworICAgICAgICBQREZDb250ZXh0TWVu dUl0ZW0gbWVudUl0ZW0geyBTdHJpbmcoW2l0ZW0gdGl0bGVdKSwgISFbaXRlbSBpc0VuYWJsZWRd LCAhIVtpdGVtIGlzU2VwYXJhdG9ySXRlbV0sIHN0YXRpY19jYXN0PGludD4oW2l0ZW0gc3RhdGVd KSwgISFbaXRlbSBhY3Rpb25dLCBpIH07CiAgICAgICAgIGl0ZW1zLmFwcGVuZChXVEZNb3ZlKG1l bnVJdGVtKSk7CiAgICAgfQogICAgIFBERkNvbnRleHRNZW51IGNvbnRleHRNZW51IHsgcG9pbnQs IFdURk1vdmUoaXRlbXMpIH07Cg==