217697 2020-10-14 01:30:24 -0700 REGRESSION: fast/canvas/webgl/context-attributes-alpha.html fails 2020-10-14 12:55:23 -0700 1 1 1 Unclassified WebKit WebGL WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 217212 217211 1 kkinnunen kkinnunen ap dino ews-watchlist graouts koivisto kondapallykalyan webkit-bug-importer oldest_to_newest 1697633 0 kkinnunen 2020-10-14 01:30:24 -0700 REGRESSION: fast/canvas/webgl/context-attributes-alpha.html fails after bug 217212 1697636 1 411306 kkinnunen 2020-10-14 01:46:08 -0700 Created attachment 411306 Patch 1697638 2 411306 koivisto 2020-10-14 02:00:04 -0700 Comment on attachment 411306 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411306&action=review > Source/WebCore/ChangeLog:10 > + WebGLLayer contentsOpaque. Neither the EWS nor the local testing Why is. that? 1697641 3 ews-feeder 2020-10-14 02:18:27 -0700 Committed r268446: <https://trac.webkit.org/changeset/268446> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411306. 1697642 4 webkit-bug-importer 2020-10-14 02:19:25 -0700 <rdar://problem/70284915> 1697646 5 kkinnunen 2020-10-14 02:36:42 -0700 >> + WebGLLayer contentsOpaque. Neither the EWS nor the local testing > Why is. that? It is unclear at this point, I'll investigate this more. The knowns: - I developed the patch on iMac with AMD card. I thought I ran the tests as supposed. - I noticed the regression on MacBook Pro with Intel/AMD, with automatic switching on - EWS runs Intel opus - Intel GPUs have bugs around IOSurfaces and their alpha channels. ANGLE tries to work around them. - The test and the expected.html both use the WebGL canvas alpha feature, which turned out to have the bug - The test should be run on Mac and expected to work - The -expected.html probably should not use the exact same code as what the test is testing, but it's somewhat tricky to alter the content in GPU-agnostic way The unknowns: - Did I run the tests locally? - Does Intel alpha bugs, ANGLE workarounds and the bug in question cancel each other out in EWS? - Does EWS run fast/canvas/webgl/context-attributes-alpha.html - If the bugs cancel each other out, why don't they cancel out with my MacBook Pro? Does it use the AMD part or are the drivers different or is there a bug in ANGLE workaround selection. I'll try to investigate the unknowns 1697835 6 ap 2020-10-14 12:48:48 -0700 To clarify, EWS is Mac Pros with AMD GPUs. 1697838 7 ap 2020-10-14 12:55:23 -0700 Bots that saw this failure were all newer AMD ones: iMac20,1 iMac19,1 MacBookPro15,3 MacBookPro16,1 411306 2020-10-14 01:46:08 -0700 2020-10-14 02:18:27 -0700 Patch bug-217697-20201014114606.patch text/plain 3913 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MzkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODU1YjY4NzY1YzA3MjJl YzM5ZmIxZTUzYjE2YTczMWQxNzBiM2M4My4uNTc5NDkzZjVjOGUxNGFkYWExMTg1MmQ0NjUxNThh NDAzYjBhMDYwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTEwLTE0ICBLaW1t byBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjog ZmFzdC9jYW52YXMvd2ViZ2wvY29udGV4dC1hdHRyaWJ1dGVzLWFscGhhLmh0bWwgZmFpbHMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzY5NworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBvcmlnaW5h bCB3b3JrIGluICJDb2NvYTogTWFrZSBXZWJHTExheWVyIG5vdCBkZXBlbmRlbnQgb24KKyAgICAg ICAgR3JhcGhpY3NDb250ZXh0R0xPcGVuR0wiIHdhcyBtaXNzaW5nIHRoZSBodW5rIHRvIGluaXRp YWxpemUKKyAgICAgICAgV2ViR0xMYXllciBjb250ZW50c09wYXF1ZS4gTmVpdGhlciB0aGUgRVdT IG5vciB0aGUgbG9jYWwgdGVzdGluZworICAgICAgICB1c2VkIHRoZSB0ZXN0IGNhc2UuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLCB0ZXN0ZWQgYnkKKyAgICAgICAgZmFzdC9jYW52YXMvd2ViZ2wv Y29udGV4dC1hdHRyaWJ1dGVzLWFscGhhLmh0bWwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9jb2NvYS9HcmFwaGljc0NvbnRleHRHTE9wZW5HTENvY29hLm1tOgorICAgICAgICAoV2Vi Q29yZTo6R3JhcGhpY3NDb250ZXh0R0xPcGVuR0w6OkdyYXBoaWNzQ29udGV4dEdMT3BlbkdMKToK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9XZWJHTExheWVyLmg6CisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvV2ViR0xMYXllci5tbToKKyAgICAgICAgKC1bV2Vi R0xMYXllciBpbml0V2l0aENsaWVudDpkZXZpY2VQaXhlbFJhdGlvOmNvbnRlbnRzT3BhcXVlOl0p OgorICAgICAgICAoLVtXZWJHTExheWVyIGluaXRXaXRoQ2xpZW50OmRldmljZVBpeGVsUmF0aW86 XSk6IERlbGV0ZWQuCisKIDIwMjAtMTAtMTMgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVy ZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBNYWtlIGdhbWVwYWRzIHZpc2libGUgYWZ0 ZXIgdGhlaXIgZmlyc3QgaW5wdXQgaXMgcmVjZWl2ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0dyYXBoaWNzQ29udGV4dEdMT3BlbkdMQ29jb2Eu bW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9HcmFwaGljc0NvbnRl eHRHTE9wZW5HTENvY29hLm1tCmluZGV4IGZmZTcwN2Q1ZDg4NWUxYjY0MTU3Mjg5ZmI4OTFjZGEy MWUzNjI0OTYuLjMyYWU1NWM5OTllMDE4NzU5MzdjZjk0OTRiYjQyYmQ1MjQ1YTJjNzkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0dyYXBoaWNzQ29u dGV4dEdMT3BlbkdMQ29jb2EubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY29jb2EvR3JhcGhpY3NDb250ZXh0R0xPcGVuR0xDb2NvYS5tbQpAQCAtMzM0LDcgKzMzNCw3 IEBAIEdyYXBoaWNzQ29udGV4dEdMT3BlbkdMOjpHcmFwaGljc0NvbnRleHRHTE9wZW5HTChHcmFw aGljc0NvbnRleHRHTEF0dHJpYnV0ZXMgYXR0CiAKICAgICAvLyBDcmVhdGUgdGhlIFdlYkdMTGF5 ZXIKICAgICBCRUdJTl9CTE9DS19PQkpDX0VYQ0VQVElPTlMKLSAgICAgICAgbV93ZWJHTExheWVy ID0gYWRvcHROUyhbW1dlYkdMTGF5ZXIgYWxsb2NdIGluaXRXaXRoQ2xpZW50OnRoaXMgZGV2aWNl UGl4ZWxSYXRpbzphdHRycy5kZXZpY2VQaXhlbFJhdGlvXSk7CisgICAgICAgIG1fd2ViR0xMYXll ciA9IGFkb3B0TlMoW1tXZWJHTExheWVyIGFsbG9jXSBpbml0V2l0aENsaWVudDp0aGlzIGRldmlj ZVBpeGVsUmF0aW86YXR0cnMuZGV2aWNlUGl4ZWxSYXRpbyBjb250ZW50c09wYXF1ZTohYXR0cnMu YWxwaGFdKTsKICNpZm5kZWYgTkRFQlVHCiAgICAgICAgIFttX3dlYkdMTGF5ZXIgc2V0TmFtZTpA IldlYkdMIExheWVyIl07CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NvY29hL1dlYkdMTGF5ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NvY29hL1dlYkdMTGF5ZXIuaAppbmRleCBkMmU0ZmNlYmJlNjU3NTliOTNmZTY5 MmFkNGMwZmEyZTFiMTYzMDBmLi4wMDNjYWEyOTMzYWU0NGQ2ZTUyYWFmZjg1NDkwMmFlNDY0YjM2 MTE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9X ZWJHTExheWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2Ev V2ViR0xMYXllci5oCkBAIC00OCw3ICs0OCw3IEBAIEFMTE9XX0RFUFJFQ0FURURfREVDTEFSQVRJ T05TX0JFR0lOCiAvLyB0aGUgZXhpc3RpbmcgYmluZGluZyBvYnRhaW5lZCB0aHJvdWdoIHRoZSBi dWZmZXIgcmVjeWNsZSBsb2dpYy4KIEBpbnRlcmZhY2UgV2ViR0xMYXllciA6IENBTGF5ZXIKIAot LSAoaWQpaW5pdFdpdGhDbGllbnQ6KE5ha2VkUHRyPFdlYkNvcmU6OldlYkdMTGF5ZXJDbGllbnQ+ KWNsaWVudCBkZXZpY2VQaXhlbFJhdGlvOihmbG9hdClkZXZpY2VQaXhlbFJhdGlvOworLSAoaWQp aW5pdFdpdGhDbGllbnQ6KE5ha2VkUHRyPFdlYkNvcmU6OldlYkdMTGF5ZXJDbGllbnQ+KWNsaWVu dCBkZXZpY2VQaXhlbFJhdGlvOihmbG9hdClkZXZpY2VQaXhlbFJhdGlvIGNvbnRlbnRzT3BhcXVl Oihib29sKWNvbnRlbnRzT3BhcXVlOwogCiAtIChDR0ltYWdlUmVmKWNvcHlJbWFnZVNuYXBzaG90 V2l0aENvbG9yU3BhY2U6KENHQ29sb3JTcGFjZVJlZiljb2xvclNwYWNlOwogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9XZWJHTExheWVyLm1tIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvV2ViR0xMYXllci5tbQppbmRl eCAwOWYwOWQ2OWFhMWIwODhhYzMxNGY2NWM2YTZjODUwNDQ4YmQ3MDI3Li4yOWYzNWMzZWFjZGU5 NTk1ZDRlODU3ZjhhNzU2ZjM2NmY2NDk3ZjI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9XZWJHTExheWVyLm1tCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL1dlYkdMTGF5ZXIubW0KQEAgLTQzLDExICs0MywxMiBA QAogICAgIEJPT0wgX3ByZXBhcmVkRm9yRGlzcGxheTsKIH0KIAotLSAoaWQpaW5pdFdpdGhDbGll bnQ6KE5ha2VkUHRyPFdlYkNvcmU6OldlYkdMTGF5ZXJDbGllbnQ+KWNsaWVudCBkZXZpY2VQaXhl bFJhdGlvOihmbG9hdClkZXZpY2VQaXhlbFJhdGlvCistIChpZClpbml0V2l0aENsaWVudDooTmFr ZWRQdHI8V2ViQ29yZTo6V2ViR0xMYXllckNsaWVudD4pY2xpZW50IGRldmljZVBpeGVsUmF0aW86 KGZsb2F0KWRldmljZVBpeGVsUmF0aW8gY29udGVudHNPcGFxdWU6KGJvb2wpY29udGVudHNPcGFx dWUKIHsKICAgICBfY2xpZW50ID0gY2xpZW50OwogICAgIHNlbGYgPSBbc3VwZXIgaW5pdF07CiAg ICAgc2VsZi50cmFuc2Zvcm0gPSBDQVRyYW5zZm9ybTNESWRlbnRpdHk7CisgICAgc2VsZi5jb250 ZW50c09wYXF1ZSA9IGNvbnRlbnRzT3BhcXVlOwogICAgIHNlbGYuY29udGVudHNTY2FsZSA9IGRl dmljZVBpeGVsUmF0aW87CiAgICAgcmV0dXJuIHNlbGY7CiB9Cg==