217684 2020-10-13 17:03:37 -0700 REGRESSION (r268384): ASSERTION FAILED: _startCount > 1 in -[WKMouseDeviceObserver stop] 2020-10-14 14:54:33 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=212580 InRadar P2 Normal --- 1 ryanhaddad hi hi thorton webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1697507 0 ryanhaddad 2020-10-13 17:03:37 -0700 Seeing the following assertion failure with 8 API tests on iOS Debug bots after https://trac.webkit.org/changeset/268384/webkit ASSERTION FAILED: _startCount > 1 /Volumes/Data/slave/ios-simulator-14-debug/build/Source/WebKit/UIProcess/ios/WKMouseDeviceObserver.mm(61) : -[WKMouseDeviceObserver stop] 1 0x104327f09 WTFCrash 2 0x10e73db2b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x10f7ded25 -[WKMouseDeviceObserver stop] 4 0x10f80ac33 WebKit::WebProcessProxy::platformDestroy() 5 0x10f615fe6 WebKit::WebProcessProxy::~WebProcessProxy() 6 0x10f616665 WebKit::WebProcessProxy::~WebProcessProxy() 7 0x10f6166ec WebKit::WebProcessProxy::~WebProcessProxy() 8 0x10f2b4ed4 WTF::ThreadSafeRefCounted<WebKit::WebProcessProxy, (WTF::DestructionThread)0>::deref() const::'lambda'()::operator()() const 9 0x10f2b4e6d WTF::ThreadSafeRefCounted<WebKit::WebProcessProxy, (WTF::DestructionThread)0>::deref() const 10 0x10f2b4e1e WebKit::WebProcessProxy::deref() 11 0x10f2b4def WTF::Ref<WebKit::WebProcessProxy, WTF::DumbPtrTraits<WebKit::WebProcessProxy> >::~Ref() 12 0x10f281845 WTF::Ref<WebKit::WebProcessProxy, WTF::DumbPtrTraits<WebKit::WebProcessProxy> >::~Ref() 13 0x10f62ad98 WebKit::WebPageProxy::close()::$_6::~$_6() 14 0x10f5bc205 WebKit::WebPageProxy::close()::$_6::~$_6() 15 0x10f65cfe5 WTF::Detail::CallableWrapper<WebKit::WebPageProxy::close()::$_6, void>::~CallableWrapper() 16 0x10f65ce45 WTF::Detail::CallableWrapper<WebKit::WebPageProxy::close()::$_6, void>::~CallableWrapper() 17 0x10f65ce6c WTF::Detail::CallableWrapper<WebKit::WebPageProxy::close()::$_6, void>::~CallableWrapper() 18 0x10433d63f std::__1::default_delete<WTF::Detail::CallableWrapperBase<void> >::operator()(WTF::Detail::CallableWrapperBase<void>*) const 19 0x10433d5bf std::__1::unique_ptr<WTF::Detail::CallableWrapperBase<void>, std::__1::default_delete<WTF::Detail::CallableWrapperBase<void> > >::reset(WTF::Detail::CallableWrapperBase<void>*) 20 0x10433d559 std::__1::unique_ptr<WTF::Detail::CallableWrapperBase<void>, std::__1::default_delete<WTF::Detail::CallableWrapperBase<void> > >::~unique_ptr() 21 0x10433d535 std::__1::unique_ptr<WTF::Detail::CallableWrapperBase<void>, std::__1::default_delete<WTF::Detail::CallableWrapperBase<void> > >::~unique_ptr() 22 0x10433d515 WTF::Function<void ()>::~Function() 23 0x10433c485 WTF::Function<void ()>::~Function() 24 0x1043d0f0e WTF::RunLoop::performWork() 25 0x1043d5641 WTF::RunLoop::performWork(void*) 26 0x136f63845 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 27 0x136f6373d __CFRunLoopDoSource0 28 0x136f62c1f __CFRunLoopDoSources0 29 0x136f5d3f7 __CFRunLoopRun 30 0x136f5cb9e CFRunLoopRunSpecific 31 0x1369b0e61 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] Child process terminated with signal 11: Segmentation fault SHOULD NEVER BE REACHED /Volumes/Data/slave/ios-simulator-14-debug/build/Source/WebKit/Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm(45) : virtual void WebKit::AuthenticationManager::initializeConnection(IPC::Connection *) https://build.webkit.org/builders/Apple-iOS-14-Simulator-Debug-WK2-Tests/builds/244/steps/run-api-tests/logs/stdio 1697508 1 webkit-bug-importer 2020-10-13 17:04:07 -0700 <rdar://problem/70272646> 1697527 2 411283 hi 2020-10-13 17:27:52 -0700 Created attachment 411283 Patch I'm not sure why/how this is happening, but the `ASSERT` isn't really necessary 1697567 3 411283 thorton 2020-10-13 17:53:30 -0700 Comment on attachment 411283 Patch You need to understand how you got here; a double-stop could mean you go to zero while having outstanding clients, so r- until you figure out how. 1697574 4 hi 2020-10-13 18:23:17 -0700 (In reply to Tim Horton from comment #3) > Comment on attachment 411283 [details] > Patch > > You need to understand how you got here; a double-stop could mean you go to zero while having outstanding clients, so r- until you figure out how. here's what I know so far: The log above indicates that these tests are failing: - WKWebView.EvaluateJavaScriptBlockCrash - WebProcessCache.ClearWhenEnteringCache - WKProcessPool.WarmInitialProcess - WKProcessPool.PrewarmedProcessCrash - WKWebView.LocalStorageClear - ProcessSwap.ClosePageAfterCrossSiteProvisionalLoad - WKNavigation.ProcessCrashDuringCallback - _WKDownload.CrashAfterDownloadDidFinishWhenDownloadProxyHoldsTheLastRefOnWebProcessPool None of these tests crash on my machine using an iOS simulator. There is only one place that `[WKMouseDeviceObserver stop]` is called, and that's inside `WebProcessProxy::platformDestroy` (private member function), which is called inside `WebProcessProxy::~WebProcessProxy`. `[WKMouseDeviceObserver start]` is called inside `WebProcessProxy::platformCreate` (private member function), which is called inside `WebProcessProxy::WebProcessProxy`, and inside `Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm` (all of which ran before any test crashed). I know that `WebProcessProxy::WebProcessProxy` and `WebProcessProxy::~WebProcessProxy` are not somehow being called more than once because there are other `ASSERT` in both that should trigger in that case. Even more confusingly, `WKStylusDeviceObserver` has the exact same logic in the exact same places as `WKMouseDeviceObserver` and yet its `ASSERT` is not being triggered. clearly there is something magical happening here :( I will try to reproduce this tonight by running the entire API test suite, but I wonder if it wouldn't be more prudent to just change `WKMouseDeviceObserver`/`WKStylusDeviceObserver` to add the listener as soon as the `sharedInstance` is created and remove `stop` (I only added it to try to be more efficient when there are no `WebProcessProxy`, but I think that that's likely very rare) instead of trying to chase down the cause of what should be impossible. I'll see what I find tonight. 1697592 5 411294 hi 2020-10-13 19:48:43 -0700 Created attachment 411294 Patch (In reply to Devin Rousso from comment #4) > clearly there is something magical happening here :( I have found the magic! It was past me being stupid 😬 It should be `_startCount >= 1` as it's totally possible for there to have been only one prior call to `-[WKMouseDeviceObserver start]`/`-[WKStylusDeviceObserver start]`. I tested this change locally and it passed all the API tests with no crashes. I think I'd still suggest the patch as I've written it as it's more permissive/forgiving (e.g. if someone _really_ wants to make sure the listener has stopped then they can call it without having to worry about a crash). If there is a preference/precedence for ensuring that things like this listener are not over-stopped then I can just adjust the `ASSERT`. 1697624 6 thorton 2020-10-13 23:48:13 -0700 (In reply to Devin Rousso from comment #5) > Created attachment 411294 [details] > Patch > > (In reply to Devin Rousso from comment #4) > > clearly there is something magical happening here :( > > I have found the magic! It was past me being stupid 😬 > > It should be `_startCount >= 1` as it's totally possible for there to have > been only one prior call to `-[WKMouseDeviceObserver > start]`/`-[WKStylusDeviceObserver start]`. > > I tested this change locally and it passed all the API tests with no crashes. > > I think I'd still suggest the patch as I've written it as it's more > permissive/forgiving (e.g. if someone _really_ wants to make sure the > listener has stopped then they can call it without having to worry about a > crash). This is very strange reasoning for exactly the reason I said the first time around (your "someone" who "really wants to make sure the listener has stopped" is screwing over someone /else/ who is using your global API). Counted APIs need to be /very strict/. > If there is a preference/precedence for ensuring that things like > this listener are not over-stopped then I can just adjust the `ASSERT`. Plz put the assert back. 1697789 7 411351 hi 2020-10-14 11:03:54 -0700 Created attachment 411351 Patch 1697848 8 ews-feeder 2020-10-14 13:27:47 -0700 Committed r268482: <https://trac.webkit.org/changeset/268482> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411351. 411283 2020-10-13 17:27:52 -0700 2020-10-13 19:48:43 -0700 Patch bug-217684-20201013172751.patch text/plain 2038 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZjlkNmZiYzU4MzI0OTBmN2RhYTIxN2JlNWRiYmU2NWZmNmRjMGNiYy4uMDkw ZGNlODgzNmE4MTE2ZmZiNmE3OTQ5ZDBkZWI5YzhjZTFlZDNlZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxOCBAQAorMjAyMC0xMC0xMyAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTiAocjI2ODM4NCk6IEFTU0VSVElPTiBGQUlMRUQ6IF9zdGFydENv dW50ID4gMSBpbiAtW1dLTW91c2VEZXZpY2VPYnNlcnZlciBzdG9wXQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3Njg0CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS83MDI3MjY0Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGUgYEFTU0VSVGAgaXNuJ3QgcmVhbGx5IG5lY2Vzc2FyeSwgYXMgd2UgY2Fu IHJldHVybiBpZiB0aGUgYF9zdGFydENvdW50YCBpcyBhbHJlYWR5IGAwYC4KKworICAgICAgICAq IFVJUHJvY2Vzcy9pb3MvV0tNb3VzZURldmljZU9ic2VydmVyLm1tOgorICAgICAgICAoLVtXS01v dXNlRGV2aWNlT2JzZXJ2ZXIgc3RvcF0pOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tTdHls dXNEZXZpY2VPYnNlcnZlci5tbToKKyAgICAgICAgKC1bV0tTdHlsdXNEZXZpY2VPYnNlcnZlciBz dG9wXSk6CisKIDIwMjAtMTAtMTIgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgog CiAgICAgICAgIENTUyAiYW55LXBvaW50ZXI6ZmluZSIgbWVkaWEgcXVlcnkgZmFsc2Ugb24gaVBh ZC9QZW5jaWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS01vdXNl RGV2aWNlT2JzZXJ2ZXIubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tNb3VzZURl dmljZU9ic2VydmVyLm1tCmluZGV4IGUzMTNlMGJkM2Q1OGE2NDY5YjVkNTRiZDJiZTZiNmM2OTYz OGZlYzUuLjJjNTc5YjBkMTE3OTZjODc2M2I3MDdiM2E2NDNiNzI5YjY4ZjgyZTkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS01vdXNlRGV2aWNlT2JzZXJ2ZXIubW0K KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLTW91c2VEZXZpY2VPYnNlcnZlci5t bQpAQCAtNTgsOCArNTgsNyBAQCAtICh2b2lkKXN0YXJ0CiAKIC0gKHZvaWQpc3RvcAogewotICAg IEFTU0VSVChfc3RhcnRDb3VudCA+IDEpOwotICAgIGlmICgtLV9zdGFydENvdW50KQorICAgIGlm ICghX3N0YXJ0Q291bnQgfHwgLS1fc3RhcnRDb3VudCkKICAgICAgICAgcmV0dXJuOwogCiAgICAg QVNTRVJUKF90b2tlbik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3Mv V0tTdHlsdXNEZXZpY2VPYnNlcnZlci5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9X S1N0eWx1c0RldmljZU9ic2VydmVyLm1tCmluZGV4IDJkOWE2ZGZmNWE1NTI5ZDIyMjRlYjcyMGZm ZDA2MDVmNjczYjNlMmYuLjJmNTdjMDg4Njk3MzRiMzBlMmIwMGE5MGFlODEwMTVjNDlhNjgwYzMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS1N0eWx1c0RldmljZU9i c2VydmVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS1N0eWx1c0Rldmlj ZU9ic2VydmVyLm1tCkBAIC04OCw4ICs4OCw3IEBAIC0gKHZvaWQpc3RhcnQKIAogLSAodm9pZClz dG9wCiB7Ci0gICAgQVNTRVJUKF9zdGFydENvdW50ID4gMSk7Ci0gICAgaWYgKC0tX3N0YXJ0Q291 bnQpCisgICAgaWYgKCFfc3RhcnRDb3VudCB8fCAtLV9zdGFydENvdW50KQogICAgICAgICByZXR1 cm47CiAKICAgICBbW1VJU2NyaWJibGVJbnRlcmFjdGlvbiBjbGFzc10gcmVtb3ZlT2JzZXJ2ZXI6 c2VsZiBmb3JLZXlQYXRoOkAiaXNQZW5jaWxJbnB1dEV4cGVjdGVkIl07Cg== 411294 2020-10-13 19:48:43 -0700 2020-10-14 11:03:52 -0700 Patch bug-217684.patch text/plain 2159 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZjlkNmZiYzU4MzI0OTBmN2RhYTIxN2JlNWRiYmU2NWZmNmRjMGNiYy4uMDkw ZGNlODgzNmE4MTE2ZmZiNmE3OTQ5ZDBkZWI5YzhjZTFlZDNlZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwyMCBAQAorMjAyMC0xMC0xMyAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTiAocjI2ODM4NCk6IEFTU0VSVElPTiBGQUlMRUQ6IF9zdGFydENv dW50ID4gMSBpbiAtW1dLTW91c2VEZXZpY2VPYnNlcnZlciBzdG9wXQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3Njg0CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS83MDI3MjY0Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGUgYEFTU0VSVGAgd2FzIGluY29ycmVjdCBpbiB0aGF0IGl0J3MgcG9zc2li bGUgZm9yIGBfc3RhcnRDb3VudGAgdG8gYmUgZXF1YWwgdG8gYDFgLiBJdAorICAgICAgICBpc24n dCByZWFsbHkgbmVjZXNzYXJ5IHRvIGJlZ2luIHdpdGggdGhvdWdoLCBhcyB3ZSBjYW4ganVzdCBy ZXR1cm4gaWYgdGhlIGBfc3RhcnRDb3VudGAgaXMKKyAgICAgICAgYWxyZWFkeSBgMGAuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLTW91c2VEZXZpY2VPYnNlcnZlci5tbToKKyAgICAgICAg KC1bV0tNb3VzZURldmljZU9ic2VydmVyIHN0b3BdKToKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9z L1dLU3R5bHVzRGV2aWNlT2JzZXJ2ZXIubW06CisgICAgICAgICgtW1dLU3R5bHVzRGV2aWNlT2Jz ZXJ2ZXIgc3RvcF0pOgorCiAyMDIwLTEwLTEyICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxl LmNvbT4KIAogICAgICAgICBDU1MgImFueS1wb2ludGVyOmZpbmUiIG1lZGlhIHF1ZXJ5IGZhbHNl IG9uIGlQYWQvUGVuY2lsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3Mv V0tNb3VzZURldmljZU9ic2VydmVyLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dL TW91c2VEZXZpY2VPYnNlcnZlci5tbQppbmRleCBlMzEzZTBiZDNkNThhNjQ2OWI1ZDU0YmQyYmU2 YjZjNjk2MzhmZWM1Li4yYzU3OWIwZDExNzk2Yzg3NjNiNzA3YjNhNjQzYjcyOWI2OGY4MmU5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tNb3VzZURldmljZU9ic2Vy dmVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS01vdXNlRGV2aWNlT2Jz ZXJ2ZXIubW0KQEAgLTU4LDggKzU4LDcgQEAgLSAodm9pZClzdGFydAogCiAtICh2b2lkKXN0b3AK IHsKLSAgICBBU1NFUlQoX3N0YXJ0Q291bnQgPiAxKTsKLSAgICBpZiAoLS1fc3RhcnRDb3VudCkK KyAgICBpZiAoIV9zdGFydENvdW50IHx8IC0tX3N0YXJ0Q291bnQpCiAgICAgICAgIHJldHVybjsK IAogICAgIEFTU0VSVChfdG9rZW4pOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvaW9zL1dLU3R5bHVzRGV2aWNlT2JzZXJ2ZXIubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9pb3MvV0tTdHlsdXNEZXZpY2VPYnNlcnZlci5tbQppbmRleCAyZDlhNmRmZjVhNTUyOWQyMjI0 ZWI3MjBmZmQwNjA1ZjY3M2IzZTJmLi4yZjU3YzA4ODY5NzM0YjMwZTJiMDBhOTBhZTgxMDE1YzQ5 YTY4MGMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tTdHlsdXNE ZXZpY2VPYnNlcnZlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tTdHls dXNEZXZpY2VPYnNlcnZlci5tbQpAQCAtODgsOCArODgsNyBAQCAtICh2b2lkKXN0YXJ0CiAKIC0g KHZvaWQpc3RvcAogewotICAgIEFTU0VSVChfc3RhcnRDb3VudCA+IDEpOwotICAgIGlmICgtLV9z dGFydENvdW50KQorICAgIGlmICghX3N0YXJ0Q291bnQgfHwgLS1fc3RhcnRDb3VudCkKICAgICAg ICAgcmV0dXJuOwogCiAgICAgW1tVSVNjcmliYmxlSW50ZXJhY3Rpb24gY2xhc3NdIHJlbW92ZU9i c2VydmVyOnNlbGYgZm9yS2V5UGF0aDpAImlzUGVuY2lsSW5wdXRFeHBlY3RlZCJdOwo= 411351 2020-10-14 11:03:54 -0700 2020-10-14 14:54:33 -0700 Patch bug-217684-20201014110353.patch text/plain 2156 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMmY1MTVjMTI2MGQ2ZjI0Y2ZkNzZiODg5NWVkYmQxNTllMTM1NzM2NC4uOTA3 ZTU1NjBhYzJlZTkxNzBiYTdhODAwNWZmNTUxMGM2MTRjNjNiNyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxOSBAQAorMjAyMC0xMC0xNCAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTiAocjI2ODM4NCk6IEFTU0VSVElPTiBGQUlMRUQ6IF9zdGFydENv dW50ID4gMSBpbiAtW1dLTW91c2VEZXZpY2VPYnNlcnZlciBzdG9wXQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3Njg0CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS83MDI3MjY0Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGUgYEFTU0VSVGAgd2FzIGluY29ycmVjdCBpbiB0aGF0IGl0J3MgcG9zc2li bGUgZm9yIGBfc3RhcnRDb3VudGAgdG8gYmUgZXF1YWwgdG8gYDFgLiBBbHNvCisgICAgICAgIGFk ZCBhIGNoZWNrIHRvIG1ha2Ugc3VyZSBgX3N0YXJ0Q291bnRgIGRvZXNuJ3Qgb3ZlcmZsb3cuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLTW91c2VEZXZpY2VPYnNlcnZlci5tbToKKyAgICAg ICAgKC1bV0tNb3VzZURldmljZU9ic2VydmVyIHN0b3BdKToKKyAgICAgICAgKiBVSVByb2Nlc3Mv aW9zL1dLU3R5bHVzRGV2aWNlT2JzZXJ2ZXIubW06CisgICAgICAgICgtW1dLU3R5bHVzRGV2aWNl T2JzZXJ2ZXIgc3RvcF0pOgorCiAyMDIwLTEwLTEzICBKdWxpYW4gR29uemFsZXogIDxqdWxpYW5f YV9nb256YWxlekBhcHBsZS5jb20+CiAKICAgICAgICAgTnVsbCBkZXJlZmVyZW5jZSBpbiBQREZQ bHVnaW46OnNuYXBzaG90KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lv cy9XS01vdXNlRGV2aWNlT2JzZXJ2ZXIubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3Mv V0tNb3VzZURldmljZU9ic2VydmVyLm1tCmluZGV4IGUzMTNlMGJkM2Q1OGE2NDY5YjVkNTRiZDJi ZTZiNmM2OTYzOGZlYzUuLjc0MDJlNTU0ZmI5Zjc0YzEwMzhkYzdlN2QxMjgxYTJjZmNlZmMxODcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS01vdXNlRGV2aWNlT2Jz ZXJ2ZXIubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLTW91c2VEZXZpY2VP YnNlcnZlci5tbQpAQCAtNTgsOCArNTgsOCBAQCAtICh2b2lkKXN0YXJ0CiAKIC0gKHZvaWQpc3Rv cAogewotICAgIEFTU0VSVChfc3RhcnRDb3VudCA+IDEpOwotICAgIGlmICgtLV9zdGFydENvdW50 KQorICAgIEFTU0VSVChfc3RhcnRDb3VudCk7CisgICAgaWYgKCFfc3RhcnRDb3VudCB8fCAtLV9z dGFydENvdW50KQogICAgICAgICByZXR1cm47CiAKICAgICBBU1NFUlQoX3Rva2VuKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS1N0eWx1c0RldmljZU9ic2VydmVy Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLU3R5bHVzRGV2aWNlT2JzZXJ2ZXIu bW0KaW5kZXggMmQ5YTZkZmY1YTU1MjlkMjIyNGViNzIwZmZkMDYwNWY2NzNiM2UyZi4uNzA2Nzk1 NmZiNTA4MjcwNjI5ZGRhYzYwZGZkOTIyZmU3ZTk2YTZiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL1dLU3R5bHVzRGV2aWNlT2JzZXJ2ZXIubW0KKysrIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLU3R5bHVzRGV2aWNlT2JzZXJ2ZXIubW0KQEAgLTg4LDgg Kzg4LDggQEAgLSAodm9pZClzdGFydAogCiAtICh2b2lkKXN0b3AKIHsKLSAgICBBU1NFUlQoX3N0 YXJ0Q291bnQgPiAxKTsKLSAgICBpZiAoLS1fc3RhcnRDb3VudCkKKyAgICBBU1NFUlQoX3N0YXJ0 Q291bnQpOworICAgIGlmICghX3N0YXJ0Q291bnQgfHwgLS1fc3RhcnRDb3VudCkKICAgICAgICAg cmV0dXJuOwogCiAgICAgW1tVSVNjcmliYmxlSW50ZXJhY3Rpb24gY2xhc3NdIHJlbW92ZU9ic2Vy dmVyOnNlbGYgZm9yS2V5UGF0aDpAImlzUGVuY2lsSW5wdXRFeHBlY3RlZCJdOwo=