<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>217674</bug_id>
          
          <creation_ts>2020-10-13 15:09:09 -0700</creation_ts>
          <short_desc>Simplify AudioNode::checkNumberOfChannelsForInput()</short_desc>
          <delta_ts>2020-10-13 15:47:36 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Audio</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>cdumez</cc>
    
    <cc>darin</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>ggaren</cc>
    
    <cc>glenn</cc>
    
    <cc>jer.noble</cc>
    
    <cc>philipj</cc>
    
    <cc>sergio</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1697431</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-10-13 15:09:09 -0700</bug_when>
    <thetext>Simplify AudioNode::checkNumberOfChannelsForInput().</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1697434</commentid>
    <comment_count>1</comment_count>
      <attachid>411265</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-10-13 15:11:03 -0700</bug_when>
    <thetext>Created attachment 411265
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1697442</commentid>
    <comment_count>2</comment_count>
      <attachid>411265</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2020-10-13 15:18:18 -0700</bug_when>
    <thetext>Comment on attachment 411265
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1697465</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-10-13 15:46:26 -0700</bug_when>
    <thetext>Committed r268426: &lt;https://trac.webkit.org/changeset/268426&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411265.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1697468</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-10-13 15:47:36 -0700</bug_when>
    <thetext>&lt;rdar://problem/70269898&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>411265</attachid>
            <date>2020-10-13 15:11:03 -0700</date>
            <delta_ts>2020-10-13 15:46:26 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-217674-20201013151102.patch</filename>
            <type>text/plain</type>
            <size>1824</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4NDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDFkOWE1NmUxNTMxZGUx
OWZlOWM2M2E4MzgwYmRlZjM0ODQ0MjlhYi4uMjUxYzVkODE2MzM2MjMwOWU3NDkzMDI4OTRiYmM4
MGY3MTA4NmUzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTEwLTEzICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2ltcGxpZnkgQXVkaW9Ob2Rl
OjpjaGVja051bWJlck9mQ2hhbm5lbHNGb3JJbnB1dCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTc2NzQKKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW1wbGlmeSBBdWRpb05vZGU6OmNoZWNrTnVtYmVy
T2ZDaGFubmVsc0ZvcklucHV0KCkgYnkgc2ltcGx5IGNhbGxpbmcKKyAgICAgICAgdXBkYXRlSW50
ZXJuYWxCdXMoKSBvbiB0aGUgaW5wdXQgaW4gcmVsZWFzZS4gV2Ugb25seSBpdGVyYXRlIG1faW5w
dXRzCisgICAgICAgIGluIGRlYnVnIHRvIG1ha2Ugc3VyZSB0aGlzIGlzIGFuIGlucHV0IGFzc29j
aWF0ZWQgd2l0aCB0aGlzIG5vZGUuCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL0F1ZGlv
Tm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb05vZGU6OmNoZWNrTnVtYmVyT2ZDaGFu
bmVsc0ZvcklucHV0KToKKwogMjAyMC0xMC0xMyAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5G
dWppaUBzb255LmNvbT4KIAogICAgICAgICBbV2luQ2Fpcm9dW01lZGlhRm91bmRhdGlvbl0gTWFu
eSB0ZXN0IGNhc2VzIGFyZSB0aW1pbmcgb3V0IGJ5IHdhaXRpbmcgZm9yIGV2ZW50cwpkaWZmIC0t
Z2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb05vZGUuY3BwIGIvU291
cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb05vZGUuY3BwCmluZGV4IDc0NjhlMzg0
MDJjMjIzOWU5ZTFhY2U1OTFlMmE4ODYzNzI2M2Q4NzQuLmQ1YTRlMzEyYTJmNzdhMWNiYWEwYjM5
Zjc3MGE2MGUzOTdhNzIzMWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vi
YXVkaW8vQXVkaW9Ob2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlv
L0F1ZGlvTm9kZS5jcHAKQEAgLTQ3OSwxNCArNDc5LDggQEAgdm9pZCBBdWRpb05vZGU6OmNoZWNr
TnVtYmVyT2ZDaGFubmVsc0ZvcklucHV0KEF1ZGlvTm9kZUlucHV0KiBpbnB1dCkKIHsKICAgICBB
U1NFUlQoY29udGV4dCgpLmlzQXVkaW9UaHJlYWQoKSAmJiBjb250ZXh0KCkuaXNHcmFwaE93bmVy
KCkpOwogCi0gICAgZm9yIChhdXRvJiBzYXZlZElucHV0IDogbV9pbnB1dHMpIHsKLSAgICAgICAg
aWYgKGlucHV0ID09IHNhdmVkSW5wdXQuZ2V0KCkpIHsKLSAgICAgICAgICAgIGlucHV0LT51cGRh
dGVJbnRlcm5hbEJ1cygpOwotICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICB9Ci0gICAgfQot
Ci0gICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgQVNTRVJUKG1faW5wdXRzLmZpbmRNYXRj
aGluZyhbJl0oYXV0byYgYXNzb2NpYXRlZElucHV0KSB7IHJldHVybiBhc3NvY2lhdGVkSW5wdXQu
Z2V0KCkgPT0gaW5wdXQ7IH0pICE9IG5vdEZvdW5kKTsKKyAgICBpbnB1dC0+dXBkYXRlSW50ZXJu
YWxCdXMoKTsKIH0KIAogYm9vbCBBdWRpb05vZGU6OnByb3BhZ2F0ZXNTaWxlbmNlKCkgY29uc3QK
</data>

          </attachment>
      

    </bug>

</bugzilla>