217656 2020-10-13 08:43:49 -0700 Allow legacy custom scheme registration on non-main threads 2020-10-13 13:10:47 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen beidson ggaren webkit-bug-importer oldest_to_newest 1697265 0 achristensen 2020-10-13 08:43:49 -0700 Allow legacy custom scheme registration on non-main threads 1697267 1 411221 achristensen 2020-10-13 08:45:41 -0700 Created attachment 411221 Patch 1697281 2 achristensen 2020-10-13 09:31:52 -0700 Note: we did something similar for WKURLSchemeTask in r247461 because people just want to do loading things on different threads. 1697313 3 ews-feeder 2020-10-13 11:42:50 -0700 Committed r268401: <https://trac.webkit.org/changeset/268401> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411221. 1697315 4 webkit-bug-importer 2020-10-13 11:43:23 -0700 <rdar://problem/70259314> 1697358 5 ggaren 2020-10-13 13:10:47 -0700 Should we log an error when this happens, so the developer becomes aware? 411221 2020-10-13 08:45:41 -0700 2020-10-13 11:42:51 -0700 Patch bug-217656-20201013084540.patch text/plain 2510 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjgzOTQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDIwLTEwLTEzICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWxsb3cgbGVnYWN5 IGN1c3RvbSBzY2hlbWUgcmVnaXN0cmF0aW9uIG9uIG5vbi1tYWluIHRocmVhZHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzY1NgorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNzAyMjgwMzY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgcjI2NzgwMiB3YXMgcXVpdGUgbmVjZXNzYXJ5LCBidXQgaXQgZXhw b3NlZCBhbiBpbnRlcm5hbCBjbGllbnQgY2FsbGluZyBvdXIgQVBJIG9uIGEgYmFja2dyb3VuZCB0 aHJlYWQsCisgICAgICAgIHdoaWNoIGNyYXNoZXMgbm93LiAgTWFrZSBpdCBub3QgY3Jhc2guICBU aGVyZSBpcyBhIHJhY2UgY29uZGl0aW9uIGluIHRoZWlyIHJlZ2lzdHJhdGlvbiwgYnV0IHRoZXJl IGFscmVhZHkgd2FzLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS0Jyb3dzaW5n Q29udGV4dENvbnRyb2xsZXIubW06CisgICAgICAgICgrW1dLQnJvd3NpbmdDb250ZXh0Q29udHJv bGxlciByZWdpc3RlclNjaGVtZUZvckN1c3RvbVByb3RvY29sOl0pOgorICAgICAgICAoK1tXS0Jy b3dzaW5nQ29udGV4dENvbnRyb2xsZXIgdW5yZWdpc3RlclNjaGVtZUZvckN1c3RvbVByb3RvY29s Ol0pOgorCiAyMDIwLTEwLTEzICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+ CiAKICAgICAgICAgQ29jb2E6IE1ha2UgV2ViR0xMYXllciBub3QgZGVwZW5kZW50IG9uICBHcmFw aGljc0NvbnRleHRHTE9wZW5HTApJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0Nv Y29hL1dLQnJvd3NpbmdDb250ZXh0Q29udHJvbGxlci5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVyLm1t CShyZXZpc2lvbiAyNjgzOTQpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVyLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMDIsMTIg KzEwMiwyNCBAQCAtICh2b2lkKWRlYWxsb2MKIAogKyAodm9pZClyZWdpc3RlclNjaGVtZUZvckN1 c3RvbVByb3RvY29sOihOU1N0cmluZyAqKXNjaGVtZQogewotICAgIFdlYktpdDo6V2ViUHJvY2Vz c1Bvb2w6OnJlZ2lzdGVyR2xvYmFsVVJMU2NoZW1lQXNIYXZpbmdDdXN0b21Qcm90b2NvbEhhbmRs ZXJzKHNjaGVtZSk7CisgICAgaWYgKFtOU1RocmVhZCBpc01haW5UaHJlYWRdKQorICAgICAgICBX ZWJLaXQ6OldlYlByb2Nlc3NQb29sOjpyZWdpc3Rlckdsb2JhbFVSTFNjaGVtZUFzSGF2aW5nQ3Vz dG9tUHJvdG9jb2xIYW5kbGVycyhzY2hlbWUpOworICAgIGVsc2UgeworICAgICAgICBkaXNwYXRj aF9hc3luYyhkaXNwYXRjaF9nZXRfbWFpbl9xdWV1ZSgpLCBtYWtlQmxvY2tQdHIoW3NjaGVtZSA9 IHJldGFpblB0cihzY2hlbWUpXSB7CisgICAgICAgICAgICBXZWJLaXQ6OldlYlByb2Nlc3NQb29s OjpyZWdpc3Rlckdsb2JhbFVSTFNjaGVtZUFzSGF2aW5nQ3VzdG9tUHJvdG9jb2xIYW5kbGVycyhz Y2hlbWUuZ2V0KCkpOworICAgICAgICB9KS5nZXQoKSk7CisgICAgfQogfQogCiArICh2b2lkKXVu cmVnaXN0ZXJTY2hlbWVGb3JDdXN0b21Qcm90b2NvbDooTlNTdHJpbmcgKilzY2hlbWUKIHsKLSAg ICBXZWJLaXQ6OldlYlByb2Nlc3NQb29sOjp1bnJlZ2lzdGVyR2xvYmFsVVJMU2NoZW1lQXNIYXZp bmdDdXN0b21Qcm90b2NvbEhhbmRsZXJzKHNjaGVtZSk7CisgICAgaWYgKFtOU1RocmVhZCBpc01h aW5UaHJlYWRdKQorICAgICAgICBXZWJLaXQ6OldlYlByb2Nlc3NQb29sOjp1bnJlZ2lzdGVyR2xv YmFsVVJMU2NoZW1lQXNIYXZpbmdDdXN0b21Qcm90b2NvbEhhbmRsZXJzKHNjaGVtZSk7CisgICAg ZWxzZSB7CisgICAgICAgIGRpc3BhdGNoX2FzeW5jKGRpc3BhdGNoX2dldF9tYWluX3F1ZXVlKCks IG1ha2VCbG9ja1B0cihbc2NoZW1lID0gcmV0YWluUHRyKHNjaGVtZSldIHsKKyAgICAgICAgICAg IFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6OnVucmVnaXN0ZXJHbG9iYWxVUkxTY2hlbWVBc0hhdmlu Z0N1c3RvbVByb3RvY29sSGFuZGxlcnMoc2NoZW1lLmdldCgpKTsKKyAgICAgICAgfSkuZ2V0KCkp OworICAgIH0KIH0KIAogLSAodm9pZClsb2FkUmVxdWVzdDooTlNVUkxSZXF1ZXN0ICopcmVxdWVz dAo=