217650 2020-10-12 20:35:35 -0700 REGRESSION(r268267) [webkitpy] Add missing deps for pytest when running webdriver tests 2020-10-16 16:51:58 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=217694 https://bugs.webkit.org/show_bug.cgi?id=217856 InRadar P2 Normal --- 1 lmoura lmoura bugs-noreply ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1697162 0 lmoura 2020-10-12 20:35:35 -0700 Sample trace from https://build.webkit.org/builders/GTK-Linux-64-bit-Release-WebDriver-Tests/builds/3122/steps/webdriver-test/logs/stdio: Using port gtk Test configuration: <, x86, release> Using display server xvfb Using driver at /app/webkit/WebKitBuild/Release/bin/WebKitWebDriver Browser: MiniBrowser Parsing expectations Traceback (most recent call last): File "/app/webkit/Tools/Scripts/run-webdriver-tests", line 85, in <module> runner.run(args) File "/app/webkit/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py", line 70, in run runner_tests = [runner.collect_tests(tests) for runner in self._runners] File "/app/webkit/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py", line 51, in collect_tests executor = WebDriverSeleniumExecutor(self._driver, self._env) File "/app/webkit/Tools/Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py", line 57, in __init__ do_delayed_imports() File "/app/webkit/Tools/Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py", line 35, in do_delayed_imports import webkitpy.webdriver_tests.pytest_runner as pytest_runner File "/app/webkit/Tools/Scripts/webkitpy/webdriver_tests/pytest_runner.py", line 32, in <module> import pytest File "/app/webkit/Tools/Scripts/libraries/autoinstalled/python-2/pytest.py", line 8, in <module> from _pytest.assertion import register_assert_rewrite File "/app/webkit/Tools/Scripts/libraries/autoinstalled/python-2/_pytest/assertion/__init__.py", line 13, in <module> from _pytest.assertion import rewrite File "/app/webkit/Tools/Scripts/libraries/autoinstalled/python-2/_pytest/assertion/rewrite.py", line 24, in <module> from _pytest.assertion import util File "/app/webkit/Tools/Scripts/libraries/autoinstalled/python-2/_pytest/assertion/util.py", line 11, in <module> import _pytest._code File "/app/webkit/Tools/Scripts/libraries/autoinstalled/python-2/_pytest/_code/__init__.py", line 7, in <module> from .code import Code # noqa File "/app/webkit/Tools/Scripts/libraries/autoinstalled/python-2/_pytest/_code/code.py", line 15, in <module> import pluggy File "/app/webkit/Tools/Scripts/libraries/autoinstalled/python-2/pluggy/__init__.py", line 16, in <module> from .manager import PluginManager, PluginValidationError File "/app/webkit/Tools/Scripts/libraries/autoinstalled/python-2/pluggy/manager.py", line 11, in <module> import importlib_metadata File "/app/webkit/Tools/Scripts/libraries/autoinstalled/python-2/importlib_metadata/__init__.py", line 16, in <module> from ._compat import ( File "/app/webkit/Tools/Scripts/libraries/autoinstalled/python-2/importlib_metadata/_compat.py", line 36, in <module> import pathlib2 as pathlib File "/app/webkit/Tools/Scripts/libraries/autoinstalled/python-2/pathlib2/__init__.py", line 52, in <module> from scandir import scandir as os_scandir ImportError: No module named scandir program finished with exit code 1 elapsedTime=2.347611 1697167 1 411195 lmoura 2020-10-12 20:47:42 -0700 Created attachment 411195 Patch Patch to avoid exceptions when running. Should the scandir autoinstall do some check for versioning? 1697271 2 jbedard 2020-10-13 09:07:46 -0700 (In reply to Lauro Moura from comment #1) > Created attachment 411195 [details] > Patch > > Patch to avoid exceptions when running. Should the scandir autoinstall do > some check for versioning? webkitpy tests would break if scandir couldn't be installed on Python 2, so we don't need to do any version checks here. 1697272 3 ews-feeder 2020-10-13 09:10:24 -0700 Committed r268395: <https://trac.webkit.org/changeset/268395> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411195. 1697273 4 webkit-bug-importer 2020-10-13 09:11:21 -0700 <rdar://problem/70254411> 411195 2020-10-12 20:47:42 -0700 2020-10-13 09:10:25 -0700 Patch bug-217650-20201013004741.patch text/plain 2610 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MzgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWZjZDU2MDFkMjc3ZjJjOTY5MTU5MGU1Mzk4ODAyYTYw NDcwNjU2OC4uNWRlMTdhMjU5YjkwZGVjMmFkZGZiMWFiMTgxODM2OTYwNjNiYzZkMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDIwLTEwLTEyICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04ocjI2ODI2NykgW3dlYmtpdHB5XSBBZGQgbWlzc2luZyBkZXBzIGZvciBw eXRlc3Qgd2hlbiBydW5uaW5nIHdlYmRyaXZlciB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE3NjUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgc2NhbmRpciAobmVlZGVkIGFzIG9zLnNjYW5kaXIg d2FzIGFkZGVkIG9ubHkgaW4gcHkgMy41KQorCisgICAgICAgIEFsc28gZml4ZWQgbW9yZV9pdGVy dG9vbHMgYXV0b2luc3RhbGwgZGVjbGFyYXRpb24gc28gdGhlIHBhY2thZ2UKKyAgICAgICAgbmFt ZSwgd2l0aCB1bmRlcnNjb3JlLCBpcyB0aGUgbmFtZSBvZiB0aGUgd2Via2l0Y29yZXB5IHBhY2th Z2UgYW5kIHRoZQorICAgICAgICBkYXNoIGlzIHVzZWQgZm9yIHRoZSBweXBpIHBhY2thZ2UgbmFt ZS4KKworICAgICAgICBXaXRoIHRoZXNlIGNoYW5nZXMgdGhlIHNjcmlwdCBkb2VzIG5vdCBlcnJv ciBhbnltb3JlLCBhbHRob3VnaCB0aGVyZQorICAgICAgICBzZWVtcyB0byBiZSBzb21lIGlzc3Vl cyB3aXRoIHRoZSBleGVjdXRvciB3aGVuIHJ1bm5pbmcgdGVzdHMuIFRoZXkKKyAgICAgICAgaGFw cGVuIHRvIG9ubHkgc3RhcnQgYW5kIHN0b3AgdGhlIHdlYnNlcnZlciBidXQgbm90IGFjdHVhbGx5 IGJlaW5nCisgICAgICAgIHJ1bi4gVG8gYmUgaW52ZXN0aWdhdGVkIGluIGEgc2VwYXJhdGUgYnVn LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9fX2luaXRfXy5weToKKwogMjAyMC0xMC0x MiAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgW3dlYmtp dGNvcmVweV0gQXR0ZW1wdCB0byB0ZXJtaW5hdGUgc3R1Y2sgcHJvY2Vzc2VzIGJlZm9yZSBraWxs aW5nIHRoZW0KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvX19pbml0X18ucHkg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L19faW5pdF9fLnB5CmluZGV4IDFmOWY1N2Y5MTFjMWYy NTNiMzI2M2MyNzZkMWFiZjk3NmU4YWM0NmEuLjNhNTJjZjFkNTliNGVlYWY5ZjUwOTQ5ZTE4ODUx NTQxNmY4OWJjMTMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvX19pbml0X18u cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9fX2luaXRfXy5weQpAQCAtMzcsNyArMzcs NyBAQCBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdjb250ZXh0bGliMicsIFZlcnNpb24o MCwgNiwgMCkpKQogQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgnY292ZXJhZ2UnLCBWZXJz aW9uKDUsIDIsIDEpKSkKIEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ2Z1bmNzaWdzJywg VmVyc2lvbigxLCAwLCAyKSkpCiBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdpbXBvcnRs aWJfbWV0YWRhdGEnLCBWZXJzaW9uKDEsIDcsIDApKSkKLUF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBh Y2thZ2UoJ21vcmUtaXRlcnRvb2xzJywgVmVyc2lvbig1LCAwLCAwKSkpCitBdXRvSW5zdGFsbC5y ZWdpc3RlcihQYWNrYWdlKCdtb3JlX2l0ZXJ0b29scycsIFZlcnNpb24oNSwgMCwgMCksIHB5cGlf bmFtZT0nbW9yZS1pdGVydG9vbHMnKSkKIEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ2dl bnNoaScsIFZlcnNpb24oMCwgNywgMyksIHB5cGlfbmFtZT0nR2Vuc2hpJykpCiBBdXRvSW5zdGFs bC5yZWdpc3RlcihQYWNrYWdlKCdodG1sNWxpYicsIFZlcnNpb24oMSwgMSkpKQogQXV0b0luc3Rh bGwucmVnaXN0ZXIoUGFja2FnZSgnbW96cHJvY2VzcycsIFZlcnNpb24oMSwgMiwgMCkpKQpAQCAt NDksNiArNDksNyBAQCBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdweScsIFZlcnNpb24o MSwgOSwgMCkpKQogQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgncHl0ZXN0LXRpbWVvdXQn LCBWZXJzaW9uKDEsIDQsIDIpKSkKIEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ3B5dGVz dCcsIFZlcnNpb24oNCwgNiwgMTEpKSkKIEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ3B5 Y29kZXN0eWxlJywgVmVyc2lvbigyLCA1LCAwKSkpCitBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNr YWdlKCdzY2FuZGlyJywgVmVyc2lvbigxLCAxMCwgMCkpKQogQXV0b0luc3RhbGwucmVnaXN0ZXIo UGFja2FnZSgnc2VsZW5pdW0nLCBWZXJzaW9uKDMsIDE0MSwgMCkpKQogQXV0b0luc3RhbGwucmVn aXN0ZXIoUGFja2FnZSgndG9tbCcsIFZlcnNpb24oMCwgMTAsIDEpKSkKIEF1dG9JbnN0YWxsLnJl Z2lzdGVyKFBhY2thZ2UoJ3djd2lkdGgnLCBWZXJzaW9uKDAsIDIsIDUpKSkK