217635 2020-10-12 14:39:39 -0700 Elements in Shadow DOM are wrongly marked as stale by the WebDriver 2020-10-22 09:01:46 -0700 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Minor --- 1 webkitbugzilla webkit-unassigned bburg cdumez rniwa webkit-bug-importer oldest_to_newest 1697037 0 webkitbugzilla 2020-10-12 14:39:39 -0700 Elements in Shadow DOM are wrongly marked as stale by WebDriver when issuing commands. For example, see the shadow_dom element click tests in WPT. 1697047 1 411160 webkitbugzilla 2020-10-12 14:53:29 -0700 Created attachment 411160 Patch 1697054 2 webkitbugzilla 2020-10-12 14:56:23 -0700 The above patch fixes the issue where elements are marked as stale when issuing additional commands with the element for WebDriver. In addition, I also fixed the focus script to work for elements in shadow DOM (as otherwise the WebDriver returns: "element not interactable: Element is not focusable.)" 1697181 3 411160 rniwa 2020-10-12 23:50:20 -0700 Comment on attachment 411160 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411160&action=review > Source/WebDriver/Session.cpp:2088 > + " var activeElement = doc.activeElement;" Please use let instead of var like the rest of the function. > Source/WebDriver/Session.cpp:2090 > + " var shadowRoot = activeElement.shadowRoot;" This will only work with open shadow roots. That's not right. > Source/WebDriver/Session.cpp:2098 > + " if (element != activeElement)" This will do that trick: element != element.getRootNode().activeElement 1697482 4 411275 webkitbugzilla 2020-10-13 16:01:03 -0700 Created attachment 411275 Patch 1697484 5 webkitbugzilla 2020-10-13 16:04:05 -0700 Really great suggestion! I think I made the changes that you wanted. Your suggestion also made me think that the initial focus check, that makes sure that you don't refocus the same element, wasn't exactly correct, so I also changed that. 1699447 6 webkit-bug-importer 2020-10-19 14:40:25 -0700 <rdar://problem/70456975> 1699454 7 411275 bburg 2020-10-19 14:57:10 -0700 Comment on attachment 411275 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411275&action=review r=me Please fix typos in the Changelog and I'll set cq+. > Source/WebDriver/ChangeLog:9 > + instead of document.contains which doesnt work for elements in Shadow DOM Nit: 'doesn't' Nit: ending period. > Source/WebKit/ChangeLog:9 > + instead of declaring them as not interactable Nit: ending period. 1700457 8 412045 webkitbugzilla 2020-10-21 16:33:01 -0700 Created attachment 412045 Patch 1700655 9 412045 bburg 2020-10-22 08:53:00 -0700 Comment on attachment 412045 Patch r=me 1700663 10 ews-feeder 2020-10-22 09:01:45 -0700 Committed r268867: <https://trac.webkit.org/changeset/268867> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412045. 411160 2020-10-12 14:53:29 -0700 2020-10-13 16:00:57 -0700 Patch bug-217635-20201013005313.patch text/plain 4070 webkitbugzilla U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViRHJpdmVy L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCmluZGV4IDcyY2MxNDMwMmQw Nzk1ODc4ZTVjOGUxYTlkZmRiMTk0OTNmZmVkOTMuLjExMGU4NzhhMGFhZTc3ZmNmNGE0NDYyOGJm MzVmYTU5NTY2N2YyMjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMTAt MTIgIE5pdHphbiBVemllbHkgIDxsaW5rZ29yb25AZ21haWwuY29tPgorCisgICAgICAgIEVsZW1l bnRzIGluIFNoYWRvdyBET00gYXJlIHdyb25nbHkgbWFya2VkIGFzIHN0YWxlIGJ5IHRoZSBXZWJE cml2ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx NzYzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENo YW5nZWQgc3RhbGUgY2hlY2tpbmcsIHRvIGNoZWNrIGlmIHRoZSByb290IG5vZGUgaXMgdGhlIHJv b3QKKyAgICAgICAgbm9kZSBpcyB0aGUgZG9jdW1lbnQgZWxlbWVudCwgaW5zdGVhZCBvZiBkb2N1 bWVudC5jb250YWlucyB3aGljaCBkb2VzbnQKKyAgICAgICAgd29yayBmb3IgZWxlbWVudHMgaW4g U2hhZG93IERPTQorCisgICAgICAgICogU2Vzc2lvbi5jcHA6CisgICAgICAgIChXZWJEcml2ZXI6 OlNlc3Npb246OmVsZW1lbnRTZW5kS2V5cyk6CisKIDIwMjAtMTAtMDIgIENhcmxvcyBHYXJjaWEg Q2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFdlYkRyaXZlcjogYWRkIHN1 cHBvcnQgZm9yIHNhbWUgc2l0ZSBjb29raWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDliMDIxYjY2N2UyOGYzYjNl OWRhNzcxY2ZhZDliYzJmYWU3YzQwMDEuLmFmM2E0NWRhOTM0ZjQ4YzQwZmQ4ZjEyYjBhOTUxZGJl YjkwMzEzOTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMTAtMTIgIE5pdHphbiBV emllbHkgIDxsaW5rZ29yb25AZ21haWwuY29tPgorCisgICAgICAgIEVsZW1lbnRzIGluIFNoYWRv dyBET00gYXJlIHdyb25nbHkgbWFya2VkIGFzIHN0YWxlIGJ5IHRoZSBXZWJEcml2ZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzYzNQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIHRoZSBmb2N1 cyBzY3JpcHQgdG8gd29yayBmb3IgZWxlbWVudHMgaW4gU2hhZG93IERPTQorICAgICAgICBpbnN0 ZWFkIG9mIGRlY2xhcmluZyB0aGVtIGFzIG5vdCBpbnRlcmFjdGFibGUKKworICAgICAgICAqIFdl YlByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvblByb3h5LmpzOgorICAgICAg ICAobGV0LkF1dG9tYXRpb25TZXNzaW9uUHJveHkucHJvdG90eXBlLl9jbGVhclN0YWxlTm9kZXMp OgorICAgICAgICAobGV0LkF1dG9tYXRpb25TZXNzaW9uUHJveHkpOgorCiAyMDIwLTEwLTEwICBT YW0gV2VpbmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgV2ViUHJlZmVyZW5j ZSBkZWZpbml0aW9ucyBmcm9tIHNoYXJlZCBjb25maWd1cmF0aW9uIGZpbGVzIGluIFdlYkNvcmUg KFBhcnQgMSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvU2Vzc2lvbi5jcHAgYi9Tb3Vy Y2UvV2ViRHJpdmVyL1Nlc3Npb24uY3BwCmluZGV4IDZjNWZiZGI3MDUxNTViMjAyN2NiN2IwMWVl ODkxOTQ3OWVkN2U1OTguLmE4ZjJiYjdmNzY1ZDhiMTQ4OGE5MDhlZWU5NWY1ZDIxOTM2ZTNhYzkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvU2Vzc2lvbi5jcHAKKysrIGIvU291cmNlL1dl YkRyaXZlci9TZXNzaW9uLmNwcApAQCAtMjA4NSw3ICsyMDg1LDE3IEBAIHZvaWQgU2Vzc2lvbjo6 ZWxlbWVudFNlbmRLZXlzKGNvbnN0IFN0cmluZyYgZWxlbWVudElELCBjb25zdCBTdHJpbmcmIHRl eHQsIEZ1bmN0CiAgICAgICAgICAgICAgICAgICAgICIgICAgbGV0IGlzVGV4dEVsZW1lbnQgPSB0 YWdOYW1lID09PSAnVEVYVEFSRUEnIHx8ICh0YWdOYW1lID09PSAnSU5QVVQnICYmIGVsZW1lbnQu dHlwZSA9PT0gJ3RleHQnKTsiCiAgICAgICAgICAgICAgICAgICAgICIgICAgaWYgKGlzVGV4dEVs ZW1lbnQgJiYgZWxlbWVudC5zZWxlY3Rpb25FbmQgPT0gMCkiCiAgICAgICAgICAgICAgICAgICAg ICIgICAgICAgIGVsZW1lbnQuc2V0U2VsZWN0aW9uUmFuZ2UoZWxlbWVudC52YWx1ZS5sZW5ndGgs IGVsZW1lbnQudmFsdWUubGVuZ3RoKTsiCi0gICAgICAgICAgICAgICAgICAgICIgICAgaWYgKGVs ZW1lbnQgIT0gZG9jLmFjdGl2ZUVsZW1lbnQpIgorICAgICAgICAgICAgICAgICAgICAiICAgIHZh ciBhY3RpdmVFbGVtZW50ID0gZG9jLmFjdGl2ZUVsZW1lbnQ7IgorICAgICAgICAgICAgICAgICAg ICAiICAgIGlmIChlbGVtZW50ICE9IGFjdGl2ZUVsZW1lbnQpIHsiCisgICAgICAgICAgICAgICAg ICAgICIgICAgICAgdmFyIHNoYWRvd1Jvb3QgPSBhY3RpdmVFbGVtZW50LnNoYWRvd1Jvb3Q7Igor ICAgICAgICAgICAgICAgICAgICAiICAgICAgIHdoaWxlIChzaGFkb3dSb290KSB7IgorICAgICAg ICAgICAgICAgICAgICAiICAgICAgICAgICBhY3RpdmVFbGVtZW50ID0gc2hhZG93Um9vdC5hY3Rp dmVFbGVtZW50OyIKKyAgICAgICAgICAgICAgICAgICAgIiAgICAgICAgICAgaWYgKGVsZW1lbnQg PT0gYWN0aXZlRWxlbWVudCkiCisgICAgICAgICAgICAgICAgICAgICIgICAgICAgICAgICAgICAg YnJlYWs7IgorICAgICAgICAgICAgICAgICAgICAiICAgICAgICAgICBzaGFkb3dSb290ID0gYWN0 aXZlRWxlbWVudC5zaGFkb3dSb290OyIKKyAgICAgICAgICAgICAgICAgICAgIiAgICAgICB9Igor ICAgICAgICAgICAgICAgICAgICAiICAgIH0iCisgICAgICAgICAgICAgICAgICAgICIgICAgaWYg KGVsZW1lbnQgIT0gYWN0aXZlRWxlbWVudCkiCiAgICAgICAgICAgICAgICAgICAgICIgICAgICAg IHRocm93IHtuYW1lOiAnRWxlbWVudE5vdEludGVyYWN0YWJsZScsIG1lc3NhZ2U6ICdFbGVtZW50 IGlzIG5vdCBmb2N1c2FibGUuJ307IgogICAgICAgICAgICAgICAgICAgICAifSI7CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25T ZXNzaW9uUHJveHkuanMgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvQXV0b21hdGlvbi9XZWJB dXRvbWF0aW9uU2Vzc2lvblByb3h5LmpzCmluZGV4IDFlZWQyMTk1ZjkxNDY1YjgzMmI4ZGVlMjY5 ZGYyNzg0NGMyZDAwODMuLjcyMTk3NTc0OTg3MjZmMDE5ODVlNjViODZhMjg5NTMzOTc5MmJiNmUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9t YXRpb25TZXNzaW9uUHJveHkuanMKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0F1dG9t YXRpb24vV2ViQXV0b21hdGlvblNlc3Npb25Qcm94eS5qcwpAQCAtMjUyLDcgKzI1Miw4IEBAIGxl dCBBdXRvbWF0aW9uU2Vzc2lvblByb3h5ID0gY2xhc3MgQXV0b21hdGlvblNlc3Npb25Qcm94eQog ICAgIF9jbGVhclN0YWxlTm9kZXMoKQogICAgIHsKICAgICAgICAgZm9yICh2YXIgW25vZGUsIGlk ZW50aWZpZXJdIG9mIHRoaXMuX25vZGVUb0lkTWFwKSB7Ci0gICAgICAgICAgICBpZiAoIWRvY3Vt ZW50LmNvbnRhaW5zKG5vZGUpKSB7CisgICAgICAgICAgICBjb25zdCByb290Tm9kZSA9IG5vZGUu Z2V0Um9vdE5vZGUoeyBjb21wb3NlZDogdHJ1ZSB9KTsKKyAgICAgICAgICAgIGlmIChyb290Tm9k ZSAhPT0gZG9jdW1lbnQpIHsKICAgICAgICAgICAgICAgICB0aGlzLl9ub2RlVG9JZE1hcC5kZWxl dGUobm9kZSk7CiAgICAgICAgICAgICAgICAgdGhpcy5faWRUb05vZGVNYXAuZGVsZXRlKGlkZW50 aWZpZXIpOwogICAgICAgICAgICAgfQo= 411275 2020-10-13 16:01:03 -0700 2020-10-21 16:32:55 -0700 Patch bug-217635-20201014020044.patch text/plain 4207 webkitbugzilla U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViRHJpdmVy L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCmluZGV4IDcyY2MxNDMwMmQw Nzk1ODc4ZTVjOGUxYTlkZmRiMTk0OTNmZmVkOTMuLjE3ODZlZDk2OGQ3OTlhNmNjY2I4YmM5NWYw NmY2NTBhYTQ3MDg5NjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMTAt MTIgIE5pdHphbiBVemllbHkgIDxsaW5rZ29yb25AZ21haWwuY29tPgorCisgICAgICAgIEVsZW1l bnRzIGluIFNoYWRvdyBET00gYXJlIHdyb25nbHkgbWFya2VkIGFzIHN0YWxlIGJ5IHRoZSBXZWJE cml2ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx NzYzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENo YW5nZWQgc3RhbGUgY2hlY2tpbmcsIHRvIGNoZWNrIGlmIHRoZSByb290IG5vZGUgaXMgdGhlIGRv Y3VtZW50IGVsZW1lbnQsIAorICAgICAgICBpbnN0ZWFkIG9mIGRvY3VtZW50LmNvbnRhaW5zIHdo aWNoIGRvZXNudCB3b3JrIGZvciBlbGVtZW50cyBpbiBTaGFkb3cgRE9NCisKKyAgICAgICAgKiBT ZXNzaW9uLmNwcDoKKyAgICAgICAgKFdlYkRyaXZlcjo6U2Vzc2lvbjo6ZWxlbWVudFNlbmRLZXlz KToKKwogMjAyMC0xMC0wMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5j b20+CiAKICAgICAgICAgV2ViRHJpdmVyOiBhZGQgc3VwcG9ydCBmb3Igc2FtZSBzaXRlIGNvb2tp ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9D aGFuZ2VMb2cKaW5kZXggOWIwMjFiNjY3ZTI4ZjNiM2U5ZGE3NzFjZmFkOWJjMmZhZTdjNDAwMS4u YWYzYTQ1ZGE5MzRmNDhjNDBmZDhmMTJiMGE5NTFkYmViOTAzMTM5OCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMC0xMC0xMiAgTml0emFuIFV6aWVseSAgPGxpbmtnb3JvbkBnbWFpbC5j b20+CisKKyAgICAgICAgRWxlbWVudHMgaW4gU2hhZG93IERPTSBhcmUgd3JvbmdseSBtYXJrZWQg YXMgc3RhbGUgYnkgdGhlIFdlYkRyaXZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjE3NjM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRml4ZWQgdGhlIGZvY3VzIHNjcmlwdCB0byB3b3JrIGZvciBlbGVt ZW50cyBpbiBTaGFkb3cgRE9NCisgICAgICAgIGluc3RlYWQgb2YgZGVjbGFyaW5nIHRoZW0gYXMg bm90IGludGVyYWN0YWJsZQorCisgICAgICAgICogV2ViUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1 dG9tYXRpb25TZXNzaW9uUHJveHkuanM6CisgICAgICAgIChsZXQuQXV0b21hdGlvblNlc3Npb25Q cm94eS5wcm90b3R5cGUuX2NsZWFyU3RhbGVOb2Rlcyk6CisgICAgICAgIChsZXQuQXV0b21hdGlv blNlc3Npb25Qcm94eSk6CisKIDIwMjAtMTAtMTAgIFNhbSBXZWluaWcgIDx3ZWluaWdAYXBwbGUu Y29tPgogCiAgICAgICAgIFVzZSBXZWJQcmVmZXJlbmNlIGRlZmluaXRpb25zIGZyb20gc2hhcmVk IGNvbmZpZ3VyYXRpb24gZmlsZXMgaW4gV2ViQ29yZSAoUGFydCAxKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkRyaXZlci9TZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJEcml2ZXIvU2Vzc2lvbi5jcHAK aW5kZXggNmM1ZmJkYjcwNTE1NWIyMDI3Y2I3YjAxZWU4OTE5NDc5ZWQ3ZTU5OC4uNTk0ODUyYmU4 MTg4NTZkZDY2NmVhNjUwNWY3MWM0MzFlNGJkYTBhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkRy aXZlci9TZXNzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViRHJpdmVyL1Nlc3Npb24uY3BwCkBAIC0y MDc2LDcgKzIwNzYsOCBAQCB2b2lkIFNlc3Npb246OmVsZW1lbnRTZW5kS2V5cyhjb25zdCBTdHJp bmcmIGVsZW1lbnRJRCwgY29uc3QgU3RyaW5nJiB0ZXh0LCBGdW5jdAogICAgICAgICAgICAgICAg ICAgICAiZnVuY3Rpb24gZm9jdXMoZWxlbWVudCkgeyIKICAgICAgICAgICAgICAgICAgICAgIiAg ICBsZXQgZG9jID0gZWxlbWVudC5vd25lckRvY3VtZW50IHx8IGVsZW1lbnQ7IgogICAgICAgICAg ICAgICAgICAgICAiICAgIGxldCBwcmV2QWN0aXZlRWxlbWVudCA9IGRvYy5hY3RpdmVFbGVtZW50 OyIKLSAgICAgICAgICAgICAgICAgICAgIiAgICBpZiAoZWxlbWVudCAhPSBwcmV2QWN0aXZlRWxl bWVudCAmJiBwcmV2QWN0aXZlRWxlbWVudCkiCisgICAgICAgICAgICAgICAgICAgICIgICAgbGV0 IGVsZW1lbnRSb290Tm9kZSA9IGVsZW1lbnQuZ2V0Um9vdE5vZGUoKTsiCisgICAgICAgICAgICAg ICAgICAgICIgICAgaWYgKGVsZW1lbnRSb290Tm9kZS5hY3RpdmVFbGVtZW50ICE9PSBlbGVtZW50 ICYmIHByZXZBY3RpdmVFbGVtZW50KSIKICAgICAgICAgICAgICAgICAgICAgIiAgICAgICAgcHJl dkFjdGl2ZUVsZW1lbnQuYmx1cigpOyIKICAgICAgICAgICAgICAgICAgICAgIiAgICBlbGVtZW50 LmZvY3VzKCk7IgogICAgICAgICAgICAgICAgICAgICAiICAgIGxldCB0YWdOYW1lID0gZWxlbWVu dC50YWdOYW1lLnRvVXBwZXJDYXNlKCk7IgpAQCAtMjA4NSw3ICsyMDg2LDcgQEAgdm9pZCBTZXNz aW9uOjplbGVtZW50U2VuZEtleXMoY29uc3QgU3RyaW5nJiBlbGVtZW50SUQsIGNvbnN0IFN0cmlu ZyYgdGV4dCwgRnVuY3QKICAgICAgICAgICAgICAgICAgICAgIiAgICBsZXQgaXNUZXh0RWxlbWVu dCA9IHRhZ05hbWUgPT09ICdURVhUQVJFQScgfHwgKHRhZ05hbWUgPT09ICdJTlBVVCcgJiYgZWxl bWVudC50eXBlID09PSAndGV4dCcpOyIKICAgICAgICAgICAgICAgICAgICAgIiAgICBpZiAoaXNU ZXh0RWxlbWVudCAmJiBlbGVtZW50LnNlbGVjdGlvbkVuZCA9PSAwKSIKICAgICAgICAgICAgICAg ICAgICAgIiAgICAgICAgZWxlbWVudC5zZXRTZWxlY3Rpb25SYW5nZShlbGVtZW50LnZhbHVlLmxl bmd0aCwgZWxlbWVudC52YWx1ZS5sZW5ndGgpOyIKLSAgICAgICAgICAgICAgICAgICAgIiAgICBp ZiAoZWxlbWVudCAhPSBkb2MuYWN0aXZlRWxlbWVudCkiCisgICAgICAgICAgICAgICAgICAgICIg ICAgaWYgKGVsZW1lbnRSb290Tm9kZS5hY3RpdmVFbGVtZW50ICE9PSBlbGVtZW50KSIKICAgICAg ICAgICAgICAgICAgICAgIiAgICAgICAgdGhyb3cge25hbWU6ICdFbGVtZW50Tm90SW50ZXJhY3Rh YmxlJywgbWVzc2FnZTogJ0VsZW1lbnQgaXMgbm90IGZvY3VzYWJsZS4nfTsiCiAgICAgICAgICAg ICAgICAgICAgICJ9IjsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0F1 dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb25Qcm94eS5qcyBiL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uUHJveHkuanMKaW5kZXggMWVl ZDIxOTVmOTE0NjViODMyYjhkZWUyNjlkZjI3ODQ0YzJkMDA4My4uNzIxOTc1NzQ5ODcyNmYwMTk4 NWU2NWI4NmEyODk1MzM5NzkyYmI2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb25Qcm94eS5qcworKysgYi9Tb3VyY2Uv V2ViS2l0L1dlYlByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvblByb3h5Lmpz CkBAIC0yNTIsNyArMjUyLDggQEAgbGV0IEF1dG9tYXRpb25TZXNzaW9uUHJveHkgPSBjbGFzcyBB dXRvbWF0aW9uU2Vzc2lvblByb3h5CiAgICAgX2NsZWFyU3RhbGVOb2RlcygpCiAgICAgewogICAg ICAgICBmb3IgKHZhciBbbm9kZSwgaWRlbnRpZmllcl0gb2YgdGhpcy5fbm9kZVRvSWRNYXApIHsK LSAgICAgICAgICAgIGlmICghZG9jdW1lbnQuY29udGFpbnMobm9kZSkpIHsKKyAgICAgICAgICAg IGNvbnN0IHJvb3ROb2RlID0gbm9kZS5nZXRSb290Tm9kZSh7IGNvbXBvc2VkOiB0cnVlIH0pOwor ICAgICAgICAgICAgaWYgKHJvb3ROb2RlICE9PSBkb2N1bWVudCkgewogICAgICAgICAgICAgICAg IHRoaXMuX25vZGVUb0lkTWFwLmRlbGV0ZShub2RlKTsKICAgICAgICAgICAgICAgICB0aGlzLl9p ZFRvTm9kZU1hcC5kZWxldGUoaWRlbnRpZmllcik7CiAgICAgICAgICAgICB9Cg== 412045 2020-10-21 16:33:01 -0700 2020-10-22 09:01:45 -0700 Patch bug-217635-20201022023256.patch text/plain 4210 webkitbugzilla U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViRHJpdmVy L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCmluZGV4IDcyY2MxNDMwMmQw Nzk1ODc4ZTVjOGUxYTlkZmRiMTk0OTNmZmVkOTMuLjNjZTYzZTIwZmUyODY3ZTM1YzgxZTdiYTlh NDVhZmZlMTNmODBjMGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMTAt MTIgIE5pdHphbiBVemllbHkgIDxsaW5rZ29yb25AZ21haWwuY29tPgorCisgICAgICAgIEVsZW1l bnRzIGluIFNoYWRvdyBET00gYXJlIHdyb25nbHkgbWFya2VkIGFzIHN0YWxlIGJ5IHRoZSBXZWJE cml2ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx NzYzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENo YW5nZWQgc3RhbGUgY2hlY2tpbmcsIHRvIGNoZWNrIGlmIHRoZSByb290IG5vZGUgaXMgdGhlIGRv Y3VtZW50IGVsZW1lbnQsIAorICAgICAgICBpbnN0ZWFkIG9mIGRvY3VtZW50LmNvbnRhaW5zIHdo aWNoIGRvZXNuJ3Qgd29yayBmb3IgZWxlbWVudHMgaW4gU2hhZG93IERPTS4KKworICAgICAgICAq IFNlc3Npb24uY3BwOgorICAgICAgICAoV2ViRHJpdmVyOjpTZXNzaW9uOjplbGVtZW50U2VuZEtl eXMpOgorCiAyMDIwLTEwLTAyICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KIAogICAgICAgICBXZWJEcml2ZXI6IGFkZCBzdXBwb3J0IGZvciBzYW1lIHNpdGUgY29v a2llcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0 L0NoYW5nZUxvZwppbmRleCA5YjAyMWI2NjdlMjhmM2IzZTlkYTc3MWNmYWQ5YmMyZmFlN2M0MDAx Li4yZTBmODE5OTQyMTJhZjNmZmI0YmQzZWExNWZhMTJkZjUyOTJiY2ViIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAt MSwzICsxLDE3IEBACisyMDIwLTEwLTEyICBOaXR6YW4gVXppZWx5ICA8bGlua2dvcm9uQGdtYWls LmNvbT4KKworICAgICAgICBFbGVtZW50cyBpbiBTaGFkb3cgRE9NIGFyZSB3cm9uZ2x5IG1hcmtl ZCBhcyBzdGFsZSBieSB0aGUgV2ViRHJpdmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTc2MzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXhlZCB0aGUgZm9jdXMgc2NyaXB0IHRvIHdvcmsgZm9yIGVs ZW1lbnRzIGluIFNoYWRvdyBET00KKyAgICAgICAgaW5zdGVhZCBvZiBkZWNsYXJpbmcgdGhlbSBh cyBub3QgaW50ZXJhY3RhYmxlLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9BdXRvbWF0aW9uL1dl YkF1dG9tYXRpb25TZXNzaW9uUHJveHkuanM6CisgICAgICAgIChsZXQuQXV0b21hdGlvblNlc3Np b25Qcm94eS5wcm90b3R5cGUuX2NsZWFyU3RhbGVOb2Rlcyk6CisgICAgICAgIChsZXQuQXV0b21h dGlvblNlc3Npb25Qcm94eSk6CisKIDIwMjAtMTAtMTAgIFNhbSBXZWluaWcgIDx3ZWluaWdAYXBw bGUuY29tPgogCiAgICAgICAgIFVzZSBXZWJQcmVmZXJlbmNlIGRlZmluaXRpb25zIGZyb20gc2hh cmVkIGNvbmZpZ3VyYXRpb24gZmlsZXMgaW4gV2ViQ29yZSAoUGFydCAxKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkRyaXZlci9TZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJEcml2ZXIvU2Vzc2lvbi5j cHAKaW5kZXggNmM1ZmJkYjcwNTE1NWIyMDI3Y2I3YjAxZWU4OTE5NDc5ZWQ3ZTU5OC4uNTk0ODUy YmU4MTg4NTZkZDY2NmVhNjUwNWY3MWM0MzFlNGJkYTBhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkRyaXZlci9TZXNzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViRHJpdmVyL1Nlc3Npb24uY3BwCkBA IC0yMDc2LDcgKzIwNzYsOCBAQCB2b2lkIFNlc3Npb246OmVsZW1lbnRTZW5kS2V5cyhjb25zdCBT dHJpbmcmIGVsZW1lbnRJRCwgY29uc3QgU3RyaW5nJiB0ZXh0LCBGdW5jdAogICAgICAgICAgICAg ICAgICAgICAiZnVuY3Rpb24gZm9jdXMoZWxlbWVudCkgeyIKICAgICAgICAgICAgICAgICAgICAg IiAgICBsZXQgZG9jID0gZWxlbWVudC5vd25lckRvY3VtZW50IHx8IGVsZW1lbnQ7IgogICAgICAg ICAgICAgICAgICAgICAiICAgIGxldCBwcmV2QWN0aXZlRWxlbWVudCA9IGRvYy5hY3RpdmVFbGVt ZW50OyIKLSAgICAgICAgICAgICAgICAgICAgIiAgICBpZiAoZWxlbWVudCAhPSBwcmV2QWN0aXZl RWxlbWVudCAmJiBwcmV2QWN0aXZlRWxlbWVudCkiCisgICAgICAgICAgICAgICAgICAgICIgICAg bGV0IGVsZW1lbnRSb290Tm9kZSA9IGVsZW1lbnQuZ2V0Um9vdE5vZGUoKTsiCisgICAgICAgICAg ICAgICAgICAgICIgICAgaWYgKGVsZW1lbnRSb290Tm9kZS5hY3RpdmVFbGVtZW50ICE9PSBlbGVt ZW50ICYmIHByZXZBY3RpdmVFbGVtZW50KSIKICAgICAgICAgICAgICAgICAgICAgIiAgICAgICAg cHJldkFjdGl2ZUVsZW1lbnQuYmx1cigpOyIKICAgICAgICAgICAgICAgICAgICAgIiAgICBlbGVt ZW50LmZvY3VzKCk7IgogICAgICAgICAgICAgICAgICAgICAiICAgIGxldCB0YWdOYW1lID0gZWxl bWVudC50YWdOYW1lLnRvVXBwZXJDYXNlKCk7IgpAQCAtMjA4NSw3ICsyMDg2LDcgQEAgdm9pZCBT ZXNzaW9uOjplbGVtZW50U2VuZEtleXMoY29uc3QgU3RyaW5nJiBlbGVtZW50SUQsIGNvbnN0IFN0 cmluZyYgdGV4dCwgRnVuY3QKICAgICAgICAgICAgICAgICAgICAgIiAgICBsZXQgaXNUZXh0RWxl bWVudCA9IHRhZ05hbWUgPT09ICdURVhUQVJFQScgfHwgKHRhZ05hbWUgPT09ICdJTlBVVCcgJiYg ZWxlbWVudC50eXBlID09PSAndGV4dCcpOyIKICAgICAgICAgICAgICAgICAgICAgIiAgICBpZiAo aXNUZXh0RWxlbWVudCAmJiBlbGVtZW50LnNlbGVjdGlvbkVuZCA9PSAwKSIKICAgICAgICAgICAg ICAgICAgICAgIiAgICAgICAgZWxlbWVudC5zZXRTZWxlY3Rpb25SYW5nZShlbGVtZW50LnZhbHVl Lmxlbmd0aCwgZWxlbWVudC52YWx1ZS5sZW5ndGgpOyIKLSAgICAgICAgICAgICAgICAgICAgIiAg ICBpZiAoZWxlbWVudCAhPSBkb2MuYWN0aXZlRWxlbWVudCkiCisgICAgICAgICAgICAgICAgICAg ICIgICAgaWYgKGVsZW1lbnRSb290Tm9kZS5hY3RpdmVFbGVtZW50ICE9PSBlbGVtZW50KSIKICAg ICAgICAgICAgICAgICAgICAgIiAgICAgICAgdGhyb3cge25hbWU6ICdFbGVtZW50Tm90SW50ZXJh Y3RhYmxlJywgbWVzc2FnZTogJ0VsZW1lbnQgaXMgbm90IGZvY3VzYWJsZS4nfTsiCiAgICAgICAg ICAgICAgICAgICAgICJ9IjsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNz L0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb25Qcm94eS5qcyBiL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uUHJveHkuanMKaW5kZXgg MWVlZDIxOTVmOTE0NjViODMyYjhkZWUyNjlkZjI3ODQ0YzJkMDA4My4uNzIxOTc1NzQ5ODcyNmYw MTk4NWU2NWI4NmEyODk1MzM5NzkyYmI2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb25Qcm94eS5qcworKysgYi9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvblByb3h5 LmpzCkBAIC0yNTIsNyArMjUyLDggQEAgbGV0IEF1dG9tYXRpb25TZXNzaW9uUHJveHkgPSBjbGFz cyBBdXRvbWF0aW9uU2Vzc2lvblByb3h5CiAgICAgX2NsZWFyU3RhbGVOb2RlcygpCiAgICAgewog ICAgICAgICBmb3IgKHZhciBbbm9kZSwgaWRlbnRpZmllcl0gb2YgdGhpcy5fbm9kZVRvSWRNYXAp IHsKLSAgICAgICAgICAgIGlmICghZG9jdW1lbnQuY29udGFpbnMobm9kZSkpIHsKKyAgICAgICAg ICAgIGNvbnN0IHJvb3ROb2RlID0gbm9kZS5nZXRSb290Tm9kZSh7IGNvbXBvc2VkOiB0cnVlIH0p OworICAgICAgICAgICAgaWYgKHJvb3ROb2RlICE9PSBkb2N1bWVudCkgewogICAgICAgICAgICAg ICAgIHRoaXMuX25vZGVUb0lkTWFwLmRlbGV0ZShub2RlKTsKICAgICAgICAgICAgICAgICB0aGlz Ll9pZFRvTm9kZU1hcC5kZWxldGUoaWRlbnRpZmllcik7CiAgICAgICAgICAgICB9Cg==