217633 2020-10-12 14:15:59 -0700 Clean up the API tests of CARingBuffer 2020-10-13 09:57:15 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 peng.liu6 peng.liu6 sam simon.fraser webkit-bug-importer oldest_to_newest 1697024 0 peng.liu6 2020-10-12 14:15:59 -0700 Clean up the API tests of CARingBuffer 1697025 1 411157 peng.liu6 2020-10-12 14:18:18 -0700 Created attachment 411157 Patch 1697045 2 411157 sam 2020-10-12 14:53:01 -0700 Comment on attachment 411157 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411157&action=review > Tools/TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp:28 > +#if PLATFORM(COCOA) Maybe HAVE(CORE_AUDIO) or HAVE(AUDIO_TOOLBOX) instead? 1697075 3 411157 peng.liu6 2020-10-12 15:25:11 -0700 Comment on attachment 411157 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411157&action=review >> Tools/TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp:28 >> +#if PLATFORM(COCOA) > > Maybe HAVE(CORE_AUDIO) or HAVE(AUDIO_TOOLBOX) instead? Yes, good point! Thanks! 1697090 4 411176 peng.liu6 2020-10-12 15:41:59 -0700 Created attachment 411176 Revise the patch according to Sam's comment 1697289 5 ews-feeder 2020-10-13 09:56:42 -0700 Committed r268397: <https://trac.webkit.org/changeset/268397> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411176. 1697290 6 webkit-bug-importer 2020-10-13 09:57:15 -0700 <rdar://problem/70256224> 411157 2020-10-12 14:18:18 -0700 2020-10-12 15:41:58 -0700 Patch bug-217633-20201012141817.patch text/plain 2535 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MzU1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzU4MzM5ZTgzZmY0ZTZhNzcyMDg0MDc4NzFkZDRkMGVi MjY0N2EzMC4uZDRmZWYzYzA0YTJkNTUwZWNiYjE0ZDE1OGNiNjkzZDI2ZTUzMTU3MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIwLTEwLTEyICBQZW5nIExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAg ICAgQ2xlYW4gdXAgdGhlIEFQSSB0ZXN0cyBvZiBDQVJpbmdCdWZmZXIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzYzMworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB1bnVzZWQgcHJpdmF0ZSBm dW5jdGlvbnMgYW5kIGVuYWJsZSB0aGUgdGVzdHMgZm9yIGlPUy4KKworICAgICAgICAqIFRlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9DQVJpbmdCdWZmZXIuY3BwOgorICAgICAgICAoVGVzdFdl YktpdEFQSTo6Q0FSaW5nQnVmZmVyVGVzdDo6YXVkaW9CdWZmZXJMaXN0U2l6ZUZvclN0cmVhbSk6 IERlbGV0ZWQuCisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpDQVJpbmdCdWZmZXJUZXN0Ojpjb25m aWd1cmVCdWZmZXJMaXN0Rm9yU3RyZWFtKTogRGVsZXRlZC4KKwogMjAyMC0xMC0xMiAgTHVtaW5n IFlpbiAgPGx1bWluZ195aW5AYXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10gV29ya2Fyb3Vu ZCBmb3IgTUFDX09TX1hfVkVSU0lPTl9NQUpPUiBpbmNvcnJlY3RseSBpbmNsdWRpbmcgbWlub3Ig dmVyc2lvbiB3aGVuIGJ1aWxkaW5nIApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJDb3JlL0NBUmluZ0J1ZmZlci5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYkNvcmUvQ0FSaW5nQnVmZmVyLmNwcAppbmRleCA4MWQ3YmEyOTFhZTlmNGFiN2NmMmU1Zjlh YWQ2MmM5NDI0MzUzNjcyLi5mNDdiZTRmZGRhYTBjNWIwMjE2NjdiYjA2YTU4NzYwYjNjODczMzli IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvQ0FSaW5nQnVm ZmVyLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvQ0FSaW5nQnVm ZmVyLmNwcApAQCAtMjUsNyArMjUsNyBAQAogCiAjaW5jbHVkZSAiY29uZmlnLmgiCiAKLSNpZiBQ TEFURk9STShNQUMpCisjaWYgUExBVEZPUk0oQ09DT0EpCiAKICNpbmNsdWRlICJUZXN0LmgiCiAj aW5jbHVkZSA8V2ViQ29yZS9DQVJpbmdCdWZmZXIuaD4KQEAgLTc2LDI2ICs3Niw2IEBAIHB1Ymxp YzoKICAgICBzaXplX3QgY2FwYWNpdHkoKSBjb25zdCB7IHJldHVybiBtX2NhcGFjaXR5OyB9CiAK IHByaXZhdGU6Ci0gICAgc2l6ZV90IGF1ZGlvQnVmZmVyTGlzdFNpemVGb3JTdHJlYW0oY29uc3Qg Q0FBdWRpb1N0cmVhbURlc2NyaXB0aW9uJiBmb3JtYXQpCi0gICAgewotICAgICAgICByZXR1cm4g b2Zmc2V0b2YoQXVkaW9CdWZmZXJMaXN0LCBtQnVmZmVycykgKyAoc2l6ZW9mKEF1ZGlvQnVmZmVy KSAqIHN0ZDo6bWF4PHVpbnQzMl90PigxLCBmb3JtYXQubnVtYmVyT2ZDaGFubmVsU3RyZWFtcygp KSk7Ci0gICAgfQotCi0gICAgdm9pZCBjb25maWd1cmVCdWZmZXJMaXN0Rm9yU3RyZWFtKEF1ZGlv QnVmZmVyTGlzdCYgYnVmZmVyTGlzdCwgY29uc3QgQ0FBdWRpb1N0cmVhbURlc2NyaXB0aW9uJiBm b3JtYXQsIHVpbnQ4X3QqIGJ1ZmZlckRhdGEsIHNpemVfdCBzYW1wbGVDb3VudCkKLSAgICB7Ci0g ICAgICAgIHNpemVfdCBidWZmZXJDb3VudCA9IGZvcm1hdC5udW1iZXJPZkNoYW5uZWxTdHJlYW1z KCk7Ci0gICAgICAgIHNpemVfdCBjaGFubmVsQ291bnQgPSBmb3JtYXQubnVtYmVyT2ZJbnRlcmxl YXZlZENoYW5uZWxzKCk7Ci0gICAgICAgIHNpemVfdCBieXRlc1BlckNoYW5uZWwgPSBzYW1wbGVD b3VudCAqIGZvcm1hdC5ieXRlc1BlckZyYW1lKCk7Ci0KLSAgICAgICAgYnVmZmVyTGlzdC5tTnVt YmVyQnVmZmVycyA9IGJ1ZmZlckNvdW50OwotICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBp IDwgYnVmZmVyQ291bnQ7ICsraSkgewotICAgICAgICAgICAgYnVmZmVyTGlzdC5tQnVmZmVyc1tp XS5tTnVtYmVyQ2hhbm5lbHMgPSBjaGFubmVsQ291bnQ7Ci0gICAgICAgICAgICBidWZmZXJMaXN0 Lm1CdWZmZXJzW2ldLm1EYXRhQnl0ZVNpemUgPSBieXRlc1BlckNoYW5uZWw7Ci0gICAgICAgICAg ICBidWZmZXJMaXN0Lm1CdWZmZXJzW2ldLm1EYXRhID0gYnVmZmVyRGF0YTsKLSAgICAgICAgICAg IGlmIChidWZmZXJEYXRhKQotICAgICAgICAgICAgICAgIGJ1ZmZlckRhdGEgPSBidWZmZXJEYXRh ICsgYnl0ZXNQZXJDaGFubmVsOwotICAgICAgICB9Ci0gICAgfQogCiAgICAgc3RkOjp1bmlxdWVf cHRyPEF1ZGlvQnVmZmVyTGlzdD4gbV9idWZmZXJMaXN0OwogICAgIHN0ZDo6dW5pcXVlX3B0cjxD QVJpbmdCdWZmZXI+IG1fcmluZ0J1ZmZlcjsK 411176 2020-10-12 15:41:59 -0700 2020-10-13 09:56:42 -0700 Revise the patch according to Sam's comment bug-217633-20201012154158.patch text/plain 2558 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MzU1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzU4MzM5ZTgzZmY0ZTZhNzcyMDg0MDc4NzFkZDRkMGVi MjY0N2EzMC4uZDRmZWYzYzA0YTJkNTUwZWNiYjE0ZDE1OGNiNjkzZDI2ZTUzMTU3MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIwLTEwLTEyICBQZW5nIExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAg ICAgQ2xlYW4gdXAgdGhlIEFQSSB0ZXN0cyBvZiBDQVJpbmdCdWZmZXIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzYzMworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB1bnVzZWQgcHJpdmF0ZSBm dW5jdGlvbnMgYW5kIGVuYWJsZSB0aGUgdGVzdHMgZm9yIGlPUy4KKworICAgICAgICAqIFRlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9DQVJpbmdCdWZmZXIuY3BwOgorICAgICAgICAoVGVzdFdl YktpdEFQSTo6Q0FSaW5nQnVmZmVyVGVzdDo6YXVkaW9CdWZmZXJMaXN0U2l6ZUZvclN0cmVhbSk6 IERlbGV0ZWQuCisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpDQVJpbmdCdWZmZXJUZXN0Ojpjb25m aWd1cmVCdWZmZXJMaXN0Rm9yU3RyZWFtKTogRGVsZXRlZC4KKwogMjAyMC0xMC0xMiAgTHVtaW5n IFlpbiAgPGx1bWluZ195aW5AYXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10gV29ya2Fyb3Vu ZCBmb3IgTUFDX09TX1hfVkVSU0lPTl9NQUpPUiBpbmNvcnJlY3RseSBpbmNsdWRpbmcgbWlub3Ig dmVyc2lvbiB3aGVuIGJ1aWxkaW5nIApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJDb3JlL0NBUmluZ0J1ZmZlci5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYkNvcmUvQ0FSaW5nQnVmZmVyLmNwcAppbmRleCA4MWQ3YmEyOTFhZTlmNGFiN2NmMmU1Zjlh YWQ2MmM5NDI0MzUzNjcyLi44YmJlYmY0ZTVhMjcyMzk5MWFlNGFkNGNhNjhiMjA3ZjY4NGFhN2Q5 IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvQ0FSaW5nQnVm ZmVyLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvQ0FSaW5nQnVm ZmVyLmNwcApAQCAtMjUsNyArMjUsNyBAQAogCiAjaW5jbHVkZSAiY29uZmlnLmgiCiAKLSNpZiBQ TEFURk9STShNQUMpCisjaWYgRU5BQkxFKFdFQl9BVURJTykgJiYgVVNFKE1FRElBVE9PTEJPWCkK IAogI2luY2x1ZGUgIlRlc3QuaCIKICNpbmNsdWRlIDxXZWJDb3JlL0NBUmluZ0J1ZmZlci5oPgpA QCAtNzYsMjYgKzc2LDYgQEAgcHVibGljOgogICAgIHNpemVfdCBjYXBhY2l0eSgpIGNvbnN0IHsg cmV0dXJuIG1fY2FwYWNpdHk7IH0KIAogcHJpdmF0ZToKLSAgICBzaXplX3QgYXVkaW9CdWZmZXJM aXN0U2l6ZUZvclN0cmVhbShjb25zdCBDQUF1ZGlvU3RyZWFtRGVzY3JpcHRpb24mIGZvcm1hdCkK LSAgICB7Ci0gICAgICAgIHJldHVybiBvZmZzZXRvZihBdWRpb0J1ZmZlckxpc3QsIG1CdWZmZXJz KSArIChzaXplb2YoQXVkaW9CdWZmZXIpICogc3RkOjptYXg8dWludDMyX3Q+KDEsIGZvcm1hdC5u dW1iZXJPZkNoYW5uZWxTdHJlYW1zKCkpKTsKLSAgICB9Ci0KLSAgICB2b2lkIGNvbmZpZ3VyZUJ1 ZmZlckxpc3RGb3JTdHJlYW0oQXVkaW9CdWZmZXJMaXN0JiBidWZmZXJMaXN0LCBjb25zdCBDQUF1 ZGlvU3RyZWFtRGVzY3JpcHRpb24mIGZvcm1hdCwgdWludDhfdCogYnVmZmVyRGF0YSwgc2l6ZV90 IHNhbXBsZUNvdW50KQotICAgIHsKLSAgICAgICAgc2l6ZV90IGJ1ZmZlckNvdW50ID0gZm9ybWF0 Lm51bWJlck9mQ2hhbm5lbFN0cmVhbXMoKTsKLSAgICAgICAgc2l6ZV90IGNoYW5uZWxDb3VudCA9 IGZvcm1hdC5udW1iZXJPZkludGVybGVhdmVkQ2hhbm5lbHMoKTsKLSAgICAgICAgc2l6ZV90IGJ5 dGVzUGVyQ2hhbm5lbCA9IHNhbXBsZUNvdW50ICogZm9ybWF0LmJ5dGVzUGVyRnJhbWUoKTsKLQot ICAgICAgICBidWZmZXJMaXN0Lm1OdW1iZXJCdWZmZXJzID0gYnVmZmVyQ291bnQ7Ci0gICAgICAg IGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBidWZmZXJDb3VudDsgKytpKSB7Ci0gICAgICAgICAg ICBidWZmZXJMaXN0Lm1CdWZmZXJzW2ldLm1OdW1iZXJDaGFubmVscyA9IGNoYW5uZWxDb3VudDsK LSAgICAgICAgICAgIGJ1ZmZlckxpc3QubUJ1ZmZlcnNbaV0ubURhdGFCeXRlU2l6ZSA9IGJ5dGVz UGVyQ2hhbm5lbDsKLSAgICAgICAgICAgIGJ1ZmZlckxpc3QubUJ1ZmZlcnNbaV0ubURhdGEgPSBi dWZmZXJEYXRhOwotICAgICAgICAgICAgaWYgKGJ1ZmZlckRhdGEpCi0gICAgICAgICAgICAgICAg YnVmZmVyRGF0YSA9IGJ1ZmZlckRhdGEgKyBieXRlc1BlckNoYW5uZWw7Ci0gICAgICAgIH0KLSAg ICB9CiAKICAgICBzdGQ6OnVuaXF1ZV9wdHI8QXVkaW9CdWZmZXJMaXN0PiBtX2J1ZmZlckxpc3Q7 CiAgICAgc3RkOjp1bmlxdWVfcHRyPENBUmluZ0J1ZmZlcj4gbV9yaW5nQnVmZmVyOwo=