21760 2008-10-20 15:44:48 -0700 Inspector autocompletion auto-completes incorrectly in some cases 2008-10-20 22:38:54 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Mac OS X 10.5 VERIFIED FIXED HasReduction P2 Normal --- 1 oliver timothy aroben timothy oldest_to_newest 96041 0 oliver 2008-10-20 15:44:48 -0700 Autocomplete in the inspector will suggest things that represent incorrect syntax, eg. foo[0] = "bar"; foo.-> autocompletes to foo.0 foo["\u03bb"] = "lamda"; foo.-> autocompletes to foo.λ foo["bar+4"] = "math"; foo.-> autocompletes to foo.bar+4 which does not have the desired effect. 96057 1 24536 timothy 2008-10-20 21:37:20 -0700 Created attachment 24536 Proposed patch 96059 2 timothy 2008-10-20 21:52:34 -0700 Landed in r37757. 24536 2008-10-20 21:37:20 -0700 2008-10-20 21:38:11 -0700 Proposed patch 0001--Make-auto-complete-only-suggest-properties-t.patch text/plain 3195 timothy RnJvbSBmYWU1YzcyMWVhZmIwY2FiMzRlNDQ4ZTY5NjUyYTNmM2RkMzUxYjliIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBNb24sIDIwIE9jdCAyMDA4IDIxOjM2OjI2IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gICAg ICAgICBNYWtlIGF1dG8tY29tcGxldGUgb25seSBzdWdnZXN0IHByb3BlcnRpZXMgdGhhdCBhcmUg dmFsaWQgc3ludGF4CiAgICAgICAgIHdoZW4gdXNpbmcgZG90LW5vdGF0aW9uLiBBbHNvIHdoZW4g Y29tcGxldGluZyBudW1lcmljIHByb3BlcnRpZXMsCiAgICAgICAgIHRoZSBxdW90ZXMgYXJlIG9t aXR0ZWQgaW5zaWRlIHRoZSBicmFja2V0cy4KCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxNzYwCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxNzYxCgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgoKICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZS5qczoKICAgICAgICAoV2Vi SW5zcGVjdG9yLkNvbnNvbGUucHJvdG90eXBlLmNvbXBsZXRpb25zKTogU2tpcCBwcm9wZXJ0aWVz IHRoYXQKICAgICAgICBhcmUgbm90IHZhbGlkIGlkZW50aWZpZXMgd2hlbiB1c2luZyBkb3Qtbm90 YXRpb24uIEFuZCBvbWl0IHRoZSBxdW90ZXMKICAgICAgICB3aGVuIGNvbXBsZXRpbmcgbnVtYmVy cyBpbiBicmFja2V0LW5vdGF0aW9uLgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgIHwgICAxNiArKysrKysrKysrKysrKysrCiBXZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvQ29uc29sZS5qcyB8ICAgMTMgKysrKysrKysrKystLQogMiBmaWxlcyBjaGFuZ2VkLCAy NyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hh bmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODE3OWMzNi4uOTA5YWUxMSAxMDA2NDQK LS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSAr MSwyMSBAQAogMjAwOC0xMC0yMCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+ CiAKKyAgICAgICAgTWFrZSBhdXRvLWNvbXBsZXRlIG9ubHkgc3VnZ2VzdCBwcm9wZXJ0aWVzIHRo YXQgYXJlIHZhbGlkIHN5bnRheAorICAgICAgICB3aGVuIHVzaW5nIGRvdC1ub3RhdGlvbi4gQWxz byB3aGVuIGNvbXBsZXRpbmcgbnVtZXJpYyBwcm9wZXJ0aWVzLAorICAgICAgICB0aGUgcXVvdGVz IGFyZSBvbWl0dGVkIGluc2lkZSB0aGUgYnJhY2tldHMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzYwCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTc2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlLmpz OgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGUucHJvdG90eXBlLmNvbXBsZXRpb25zKTog U2tpcCBwcm9wZXJ0aWVzIHRoYXQKKyAgICAgICAgYXJlIG5vdCB2YWxpZCBpZGVudGlmaWVzIHdo ZW4gdXNpbmcgZG90LW5vdGF0aW9uLiBBbmQgb21pdCB0aGUgcXVvdGVzCisgICAgICAgIHdoZW4g Y29tcGxldGluZyBudW1iZXJzIGluIGJyYWNrZXQtbm90YXRpb24uCisKKzIwMDgtMTAtMjAgIFRp bW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCiAgICAgICAgIEZpeGVzIHRoZSBQ cm9maWxlcyBwYW5lbCBpbiB0aGUgV2ViIEluc3BlY3Rvciwgd2hpY2ggd2FzIGJyb2tlbiBieQog ICAgICAgICB0aGUgSlNWYWx1ZSBiYXNlLWNsYXNzIGNoYW5nZXMuIEFsc28gcmVuYW1lcyBzb21l IGZ1bmN0aW9ucyBhbmQKICAgICAgICAgdmFyaWFibGVzIGluIEphdmFTY3JpcHRQcm9maWxlTm9k ZS5jcHAgdGhhdCB3aGVyZSB0aXRsZSBjYXNlLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0NvbnNvbGUuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29u c29sZS5qcwppbmRleCBlZWNmNWU0Li5lNGRlODhiIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvQ29uc29sZS5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvQ29uc29sZS5qcwpAQCAtMjg0LDEyICsyODQsMjEgQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGUu cHJvdG90eXBlID0gewogICAgICAgICB2YXIgcHJvcGVydGllcyA9IE9iamVjdC5zb3J0ZWRQcm9w ZXJ0aWVzKHJlc3VsdCk7CiAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgcHJvcGVydGllcy5s ZW5ndGg7ICsraSkgewogICAgICAgICAgICAgdmFyIHByb3BlcnR5ID0gcHJvcGVydGllc1tpXTsK LSAgICAgICAgICAgIGlmIChicmFja2V0Tm90YXRpb24pCi0gICAgICAgICAgICAgICAgcHJvcGVy dHkgPSBxdW90ZVVzZWQgKyBwcm9wZXJ0eS5lc2NhcGVDaGFyYWN0ZXJzKHF1b3RlVXNlZCArICJc XCIpICsgcXVvdGVVc2VkICsgIl0iOworCisgICAgICAgICAgICBpZiAoZG90Tm90YXRpb24gJiYg IS9eW2EtekEtWl8kXVthLXpBLVowLTlfJF0qJC8udGVzdChwcm9wZXJ0eSkpCisgICAgICAgICAg ICAgICAgY29udGludWU7CisKKyAgICAgICAgICAgIGlmIChicmFja2V0Tm90YXRpb24pIHsKKyAg ICAgICAgICAgICAgICBpZiAoIS9eWzAtOV0rJC8udGVzdChwcm9wZXJ0eSkpCisgICAgICAgICAg ICAgICAgICAgIHByb3BlcnR5ID0gcXVvdGVVc2VkICsgcHJvcGVydHkuZXNjYXBlQ2hhcmFjdGVy cyhxdW90ZVVzZWQgKyAiXFwiKSArIHF1b3RlVXNlZDsKKyAgICAgICAgICAgICAgICBwcm9wZXJ0 eSArPSAiXSI7CisgICAgICAgICAgICB9CisKICAgICAgICAgICAgIGlmIChwcm9wZXJ0eS5sZW5n dGggPCBwcmVmaXgubGVuZ3RoKQogICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAg ICAgaWYgKHByb3BlcnR5LmluZGV4T2YocHJlZml4KSAhPT0gMCkKICAgICAgICAgICAgICAgICBj b250aW51ZTsKKwogICAgICAgICAgICAgcmVzdWx0cy5wdXNoKHByb3BlcnR5KTsKICAgICAgICAg ICAgIGlmIChiZXN0TWF0Y2hPbmx5KQogICAgICAgICAgICAgICAgIGJyZWFrOwotLSAKMS42LjAu MgoK