217593 2020-10-11 17:04:27 -0700 Build failures and warning under Source/WebCore/layout/integration/ 2020-10-11 17:40:17 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro mcatanzaro webkit-bug-importer zalan oldest_to_newest 1696733 0 mcatanzaro 2020-10-11 17:04:27 -0700 Multiple issues here: In file included from ../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.h:28, from ../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp:27, from DerivedSources/WebCore/unified-sources/UnifiedSource-207b877e-5.cpp:6: ../../Source/WebCore/layout/integration/LayoutIntegrationLineIteratorLegacyPath.h:67:5: error: ‘RunIteratorLegacyPath’ does not name a type; did you mean ‘LineIteratorLegacyPath’? 67 | RunIteratorLegacyPath firstRun() const | ^~~~~~~~~~~~~~~~~~~~~ | LineIteratorLegacyPath ../../Source/WebCore/layout/integration/LayoutIntegrationLineIteratorLegacyPath.h:72:5: error: ‘RunIteratorLegacyPath’ does not name a type; did you mean ‘LineIteratorLegacyPath’? 72 | RunIteratorLegacyPath lastRun() const | ^~~~~~~~~~~~~~~~~~~~~ | LineIteratorLegacyPath ../../Source/WebCore/layout/integration/LayoutIntegrationLineIteratorLegacyPath.h:77:5: error: ‘RunIteratorLegacyPath’ does not name a type; did you mean ‘LineIteratorLegacyPath’? 77 | RunIteratorLegacyPath logicalStartRunWithNode() const | ^~~~~~~~~~~~~~~~~~~~~ | LineIteratorLegacyPath ../../Source/WebCore/layout/integration/LayoutIntegrationLineIteratorLegacyPath.h:84:5: error: ‘RunIteratorLegacyPath’ does not name a type; did you mean ‘LineIteratorLegacyPath’? 84 | RunIteratorLegacyPath logicalEndRunWithNode() const | ^~~~~~~~~~~~~~~~~~~~~ | LineIteratorLegacyPath In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-207b877e-5.cpp:6: ../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp:82:42: error: return type ‘class WebCore::LayoutIntegration::LineRunIterator’ is incomplete 82 | LineRunIterator LineIterator::firstRun() const | ^~~~~ ../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp: In member function ‘void WebCore::LayoutIntegration::LineIterator::firstRun() const’: ../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp:84:66: error: ‘RunIterator’ does not name a type; did you mean ‘LineIterator’? 84 | return WTF::switchOn(m_line.m_pathVariant, [](auto& path) -> RunIterator { | ^~~~~~~~~~~ | LineIterator ../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp: At global scope: ../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp:89:41: error: return type ‘class WebCore::LayoutIntegration::LineRunIterator’ is incomplete 89 | LineRunIterator LineIterator::lastRun() const | ^~~~~ ../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp: In member function ‘void WebCore::LayoutIntegration::LineIterator::lastRun() const’: ../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp:91:66: error: ‘RunIterator’ does not name a type; did you mean ‘LineIterator’? 91 | return WTF::switchOn(m_line.m_pathVariant, [](auto& path) -> RunIterator { | ^~~~~~~~~~~ | LineIterator ../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp: At global scope: ../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp:96:57: error: return type ‘class WebCore::LayoutIntegration::LineRunIterator’ is incomplete 96 | LineRunIterator LineIterator::logicalStartRunWithNode() const | ^~~~~ ../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp: In member function ‘void WebCore::LayoutIntegration::LineIterator::logicalStartRunWithNode() const’: ../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp:98:66: error: ‘RunIterator’ does not name a type; did you mean ‘LineIterator’? 98 | return WTF::switchOn(m_line.m_pathVariant, [](auto& path) -> RunIterator { | ^~~~~~~~~~~ | LineIterator ../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp: At global scope: ../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp:103:55: error: return type ‘class WebCore::LayoutIntegration::LineRunIterator’ is incomplete 103 | LineRunIterator LineIterator::logicalEndRunWithNode() const | ^~~~~ ../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp: In member function ‘void WebCore::LayoutIntegration::LineIterator::logicalEndRunWithNode() const’: ../../Source/WebCore/layout/integration/LayoutIntegrationLineIterator.cpp:105:66: error: ‘RunIterator’ does not name a type; did you mean ‘LineIterator’? 105 | return WTF::switchOn(m_line.m_pathVariant, [](auto& path) -> RunIterator { | ^~~~~~~~~~~ | LineIterator [2657/5201] Building CXX object Source/WebCore/CMakeFiles...es/WebCore/unified-sources/UnifiedSource-207b877e-6.cpp.o In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-207b877e-6.cpp:1: ../../Source/WebCore/layout/integration/LayoutIntegrationRunIterator.cpp:163:31: warning: ‘const WebCore::RenderBlockFlow* WebCore::LayoutIntegration::lineLayoutSystemFlowForRenderer(const WebCore::RenderObject&)’ defined but not used [-Wunused-function] 163 | static const RenderBlockFlow* lineLayoutSystemFlowForRenderer(const RenderObject& renderer) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1696735 1 411080 mcatanzaro 2020-10-11 17:07:53 -0700 Created attachment 411080 Patch 1696738 2 zalan 2020-10-11 17:10:08 -0700 thanks! 1696745 3 ews-feeder 2020-10-11 17:39:27 -0700 Committed r268329: <https://trac.webkit.org/changeset/268329> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411080. 1696746 4 webkit-bug-importer 2020-10-11 17:40:17 -0700 <rdar://problem/70188773> 411080 2020-10-11 17:07:53 -0700 2020-10-11 17:39:28 -0700 Patch bug-217593-20201011190752.patch text/plain 3286 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQ4NDkyMzBkMmJjNzJk OGFkNGY5NzkxNGViNWZhY2M3MTc3YTYyYy4uODhkMDQ0OTY1OWRhYjRhODMyMjBkMzc1ZWNhNWRk MWZjN2ExYTQ1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTEwLTExICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIEJ1aWxkIGZh aWx1cmVzIGFuZCB3YXJuaW5nIHVuZGVyIFNvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlv bi8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNzU5 MworCisgICAgICAgIFVucmV2aWV3ZWQsIGZpeCB0d28gYnVpbGQgZmFpbHVyZXMgY2F1c2VkIGJ5 IG1pc3NpbmcgI2luY2x1ZGVzLiAoRm9yd2FyZCBkZWNsYXJhdGlvbnMgYXJlCisgICAgICAgIG5v dCBlbm91Z2ggaGVyZSwgd2UgbmVlZCB0byAjaW5jbHVkZSB0aGUgbmVjZXNzYXJ5IGhlYWRlci4p CisKKyAgICAgICAgQWxzbywgZml4IGFuIHVudXNlZCBmdW5jdGlvbiB3YXJuaW5nIHdoZW4gTEZD IGlzIG5vdCBlbmFibGVkLgorCisgICAgICAgICogbGF5b3V0L2ludGVncmF0aW9uL0xheW91dElu dGVncmF0aW9uTGluZUl0ZXJhdG9yLmNwcDoKKyAgICAgICAgKiBsYXlvdXQvaW50ZWdyYXRpb24v TGF5b3V0SW50ZWdyYXRpb25MaW5lSXRlcmF0b3JMZWdhY3lQYXRoLmg6CisgICAgICAgICogbGF5 b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uUnVuSXRlcmF0b3IuY3BwOgorCiAyMDIw LTEwLTExICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CiAKICAgICAgICAgVmFyaW91cyB0 ZXN0LWNhc2VzIGZyb20gR2Vja28gYXNzZXJ0IHdpdGggQVNTRVJUSU9OIEZBSUxFRDogdGFnTmFt ZSA9PSBtbXVsdGlzY3JpcHRzVGFnIG9yIEFTU0VSVElPTiBGQUlMRUQ6IHRhZ05hbWUgPT0gbXJv b3RUYWcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9MYXlv dXRJbnRlZ3JhdGlvbkxpbmVJdGVyYXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50 ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25MaW5lSXRlcmF0b3IuY3BwCmluZGV4IDM5M2UyZTkw ODM2YzY3MDIxODM2NDU0YmU1NDc2NGI1OTQ1Yzk4YTMuLjgyZDIxMTI1MzgwZmJjMjAyYmM5MGIz Yjg3MmU4ZmVkZTc5MTU1NjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRl Z3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVJdGVyYXRvci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUl0ZXJhdG9yLmNw cApAQCAtMjcsNiArMjcsNyBAQAogI2luY2x1ZGUgIkxheW91dEludGVncmF0aW9uTGluZUl0ZXJh dG9yLmgiCiAKICNpbmNsdWRlICJMYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuaCIKKyNpbmNs dWRlICJMYXlvdXRJbnRlZ3JhdGlvblJ1bkl0ZXJhdG9yLmgiCiAKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIG5hbWVzcGFjZSBMYXlvdXRJbnRlZ3JhdGlvbiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25MaW5lSXRlcmF0b3JMZWdh Y3lQYXRoLmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdy YXRpb25MaW5lSXRlcmF0b3JMZWdhY3lQYXRoLmgKaW5kZXggNmM1NjllNzIyMmEzNDY0N2E1MWVk OWEzY2IyZmE2ZGU3ZWJkYjg4Zi4uYjBmMTZlM2YzMTA5ODIwZmIxMjBjODEwZmE1ZWY0ZmNmMWVh NGEzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91 dEludGVncmF0aW9uTGluZUl0ZXJhdG9yTGVnYWN5UGF0aC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVJdGVyYXRvckxlZ2FjeVBh dGguaApAQCAtMjYsNiArMjYsNyBAQAogI3ByYWdtYSBvbmNlCiAKICNpbmNsdWRlICJMYXlvdXRJ bnRlZ3JhdGlvbklubGluZUNvbnRlbnQuaCIKKyNpbmNsdWRlICJMYXlvdXRJbnRlZ3JhdGlvblJ1 bkl0ZXJhdG9yTGVnYWN5UGF0aC5oIgogI2luY2x1ZGUgIlJvb3RJbmxpbmVCb3guaCIKIAogbmFt ZXNwYWNlIFdlYkNvcmUgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVn cmF0aW9uL0xheW91dEludGVncmF0aW9uUnVuSXRlcmF0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUv bGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uUnVuSXRlcmF0b3IuY3BwCmluZGV4 IDM2MzQ0ZWNjZDkzN2QyZDk0NTRmOTQ5OWYzMDk2NWMwMjkyMTE2ZjYuLjlmZjEyZGUzMGNkN2Nk OWIyMzkwOWIwNTA5ODA5NzU4ZmQ4YWIzMDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvblJ1bkl0ZXJhdG9yLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25SdW5JdGVy YXRvci5jcHAKQEAgLTE2MCw2ICsxNjAsNyBAQCBMaW5lUnVuSXRlcmF0b3ImIExpbmVSdW5JdGVy YXRvcjo6dHJhdmVyc2VQcmV2aW91c09uTGluZUlnbm9yaW5nTGluZUJyZWFrKCkKICAgICByZXR1 cm4gKnRoaXM7CiB9CiAKKyNpZiBFTkFCTEUoTEFZT1VUX0ZPUk1BVFRJTkdfQ09OVEVYVCkKIHN0 YXRpYyBjb25zdCBSZW5kZXJCbG9ja0Zsb3cqIGxpbmVMYXlvdXRTeXN0ZW1GbG93Rm9yUmVuZGVy ZXIoY29uc3QgUmVuZGVyT2JqZWN0JiByZW5kZXJlcikKIHsKICAgICAvLyBJbiBjdXJyZW50bHkg c3VwcG9ydGVkIGNhc2VzIHRoZSByZW5kZXJlciBpcyBhbHdheXMgZGlyZWN0IGNoaWxkIG9mIHRo ZSBmbG93LgpAQCAtMTY3LDYgKzE2OCw3IEBAIHN0YXRpYyBjb25zdCBSZW5kZXJCbG9ja0Zsb3cq IGxpbmVMYXlvdXRTeXN0ZW1GbG93Rm9yUmVuZGVyZXIoY29uc3QgUmVuZGVyT2JqZWN0CiAgICAg ICAgIHJldHVybiBudWxscHRyOwogICAgIHJldHVybiBkb3duY2FzdDxSZW5kZXJCbG9ja0Zsb3c+ KHJlbmRlcmVyLnBhcmVudCgpKTsKIH0KKyNlbmRpZgogCiBUZXh0UnVuSXRlcmF0b3IgZmlyc3RU ZXh0UnVuRm9yKGNvbnN0IFJlbmRlclRleHQmIHRleHQpCiB7Cg==